Re: NAG - Please commit my patches before subversion switch
Martin, All three patches for Bug #31230 are now available. Please commit when you get a chance. Regards, Sean http://issues.apache.org/bugzilla/showattachment.cgi?attach_id=12838 http://issues.apache.org/bugzilla/showattachment.cgi?attach_id=12839 http://issues.apache.org/bugzilla/showattachment.cgi?attach_id=12888 Then I'd prefer to wait until we have all of the fixes before we apply the patches. The move to SVN shouldn't affect the application of the diffs using the patch utility, so I'm not in a hurry to apply them before the move. -- Martin Cooper - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: NAG - Please commit my patches before subversion switch
On Tue, 28 Sep 2004 11:50:10 -0400, Sean Schofield [EMAIL PROTECTED] wrote: As per Craig's suggestion, I will nag the committers to apply the patches I have submitted to Bug #31230. These patches fix 2 of 3 classes that were using deprecated code. The bug needs to remain open, however, because there is still one more class that needs to be fixed. Then I'd prefer to wait until we have all of the fixes before we apply the patches. The move to SVN shouldn't affect the application of the diffs using the patch utility, so I'm not in a hurry to apply them before the move. -- Martin Cooper Thanks, sean http://issues.apache.org/bugzilla/showattachment.cgi?attach_id=12838 http://issues.apache.org/bugzilla/showattachment.cgi?attach_id=12839 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: NAG - Please commit my patches before subversion switch
OK. I will try to come up with a patch for the third class and email the list when its done. Thanks for the response. sean Martin Cooper wrote: On Tue, 28 Sep 2004 11:50:10 -0400, Sean Schofield [EMAIL PROTECTED] wrote: As per Craig's suggestion, I will nag the committers to apply the patches I have submitted to Bug #31230. These patches fix 2 of 3 classes that were using deprecated code. The bug needs to remain open, however, because there is still one more class that needs to be fixed. Then I'd prefer to wait until we have all of the fixes before we apply the patches. The move to SVN shouldn't affect the application of the diffs using the patch utility, so I'm not in a hurry to apply them before the move. -- Martin Cooper Thanks, sean http://issues.apache.org/bugzilla/showattachment.cgi?attach_id=12838 http://issues.apache.org/bugzilla/showattachment.cgi?attach_id=12839 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: NAG - Please commit my patches before subversion switch
No, thank you for the patches! -- James Mitchell Software Engineer / Open Source Evangelist EdgeTech, Inc. 678.910.8017 AIM: jmitchtx - Original Message - From: Sean Schofield [EMAIL PROTECTED] To: Struts Developers List [EMAIL PROTECTED] Sent: Tuesday, September 28, 2004 12:53 PM Subject: Re: NAG - Please commit my patches before subversion switch OK. I will try to come up with a patch for the third class and email the list when its done. Thanks for the response. sean Martin Cooper wrote: On Tue, 28 Sep 2004 11:50:10 -0400, Sean Schofield [EMAIL PROTECTED] wrote: As per Craig's suggestion, I will nag the committers to apply the patches I have submitted to Bug #31230. These patches fix 2 of 3 classes that were using deprecated code. The bug needs to remain open, however, because there is still one more class that needs to be fixed. Then I'd prefer to wait until we have all of the fixes before we apply the patches. The move to SVN shouldn't affect the application of the diffs using the patch utility, so I'm not in a hurry to apply them before the move. -- Martin Cooper Thanks, sean http://issues.apache.org/bugzilla/showattachment.cgi?attach_id=12838 http://issues.apache.org/bugzilla/showattachment.cgi?attach_id=12839 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]