First commit is a FAILURE!
I tried to commit a fix for WW-2477, which would be my first. I didn't realize that Bamboo is running/building with java 6. Shortly after committing, the Bamboo builds failed on the unit test I committed with the fix. I apologize for that :( I went ahead and deleted the test (the actual fixes were trivial). I have to go out to eat, but when I get back, I'll re-write the test using java 6 and commit. I attached the patch that I attempted to commit to the JIRA (in case anyone wants to take a look and help me guess why it works in 1.5 but fails when run in 6.0). Again sorry! -Wes - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: First commit is a FAILURE!
On Sat, 2008-02-09 at 14:40 -0800, Martin Cooper wrote: > My guess is that it has nothing to do with the JDK version, but has to do > with the state of the classpath while the tests are being run. Your test > code does not handle the case in which your target URL is not found in the > classpath, and if that happened, it would result in an NPE on the line of > code that caused an NPE in Bamboo... > > -- > Martin Cooper When I tell maven to use a 6.x series JDK, I get an NPE in the same spot. I will fail a bit less miserably though if the file/path isn't found. But, I assumed that the TLD file will be there since Maven builds it. I didn't try it, but a .getResource() call might find the TLD file magically, if so, it would significantly decrease the size of the unit test. I have to show up to my surprise birthday party my wife doesn't think I know about in a little bit, so I'll get it taken care of tonight. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: First commit is a FAILURE!
On Feb 9, 2008 2:17 PM, Wes Wannemacher <[EMAIL PROTECTED]> wrote: > I tried to commit a fix for WW-2477, which would be my first. I didn't > realize that Bamboo is running/building with java 6. Shortly after > committing, the Bamboo builds failed on the unit test I committed with > the fix. I apologize for that :( > > I went ahead and deleted the test (the actual fixes were trivial). I > have to go out to eat, but when I get back, I'll re-write the test using > java 6 and commit. I attached the patch that I attempted to commit to > the JIRA (in case anyone wants to take a look and help me guess why it > works in 1.5 but fails when run in 6.0). My guess is that it has nothing to do with the JDK version, but has to do with the state of the classpath while the tests are being run. Your test code does not handle the case in which your target URL is not found in the classpath, and if that happened, it would result in an NPE on the line of code that caused an NPE in Bamboo... -- Martin Cooper > Again sorry! > > -Wes > > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > >
