[jira] [Updated] (SUBMARINE-498) [WEB] Add notebook module to workbench with Angular
[ https://issues.apache.org/jira/browse/SUBMARINE-498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wen-Chien,Ruan updated SUBMARINE-498: - Labels: pull-request-available (was: ) > [WEB] Add notebook module to workbench with Angular > --- > > Key: SUBMARINE-498 > URL: https://issues.apache.org/jira/browse/SUBMARINE-498 > Project: Apache Submarine > Issue Type: Sub-task > Components: Workbench >Reporter: Wen-Chien,Ruan >Assignee: Wen-Chien,Ruan >Priority: Major > Labels: pull-request-available > > Add notebook module to workbench with Angular. > 1.Import NzCodeEditorModule. > 2.Web fronted page about notebook and route. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[jira] [Updated] (SUBMARINE-504) Enable angular style check in github actions
[ https://issues.apache.org/jira/browse/SUBMARINE-504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SUBMARINE-504: - Labels: pull-request-available (was: ) > Enable angular style check in github actions > > > Key: SUBMARINE-504 > URL: https://issues.apache.org/jira/browse/SUBMARINE-504 > Project: Apache Submarine > Issue Type: Improvement > Components: Workbench >Reporter: Kevin Su >Assignee: Kevin Su >Priority: Minor > Labels: pull-request-available > Fix For: 0.4.0 > > > Enable angular style check in github actions > Fix code style in workbench-ng -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[jira] [Commented] (SUBMARINE-501) Remove the K8s submitter test task from travis
[ https://issues.apache.org/jira/browse/SUBMARINE-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110373#comment-17110373 ] Wanqiang Ji commented on SUBMARINE-501: --- [~danielthank] Thanks for your interest. If you need any help, you can ping me. > Remove the K8s submitter test task from travis > -- > > Key: SUBMARINE-501 > URL: https://issues.apache.org/jira/browse/SUBMARINE-501 > Project: Apache Submarine > Issue Type: Task > Components: CI/CD >Reporter: Wanqiang Ji >Assignee: Daniel Chin >Priority: Major > Labels: newbie++ > Fix For: 0.4.0 > > > Due to we had the integration test in travis system, so we can remove the K8s > submitter test task to save the test time. Because it takes a lot of time to > create the K8s cluster in docker. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[jira] [Resolved] (SUBMARINE-493) Integrating jupyter notebook into Submarine
[ https://issues.apache.org/jira/browse/SUBMARINE-493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Xun resolved SUBMARINE-493. --- Fix Version/s: 0.5.0 Resolution: Fixed Issue resolved by pull request 290 [https://github.com/apache/submarine/pull/290] > Integrating jupyter notebook into Submarine > --- > > Key: SUBMARINE-493 > URL: https://issues.apache.org/jira/browse/SUBMARINE-493 > Project: Apache Submarine > Issue Type: Sub-task > Components: Workbench Notebook >Reporter: Ryan Lo >Assignee: Ryan Lo >Priority: Major > Labels: pull-request-available > Fix For: 0.5.0 > > > 1. Integrating jupyter notebook into Submarine on KinD cluster (local/travis) > 2. Run jupyter notebook test -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[submarine] branch master updated: SUBMARINE-493. Integrating jupyter notebook into Submarine
This is an automated email from the ASF dual-hosted git repository. liuxun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/submarine.git The following commit(s) were added to refs/heads/master by this push: new 9c2cdf8 SUBMARINE-493. Integrating jupyter notebook into Submarine 9c2cdf8 is described below commit 9c2cdf83beaec7f3ad24066b3a83121ef0e0b370 Author: Ryan Lo AuthorDate: Mon May 18 09:52:35 2020 +0800 SUBMARINE-493. Integrating jupyter notebook into Submarine ### What is this PR for? Deploy jupyter notebook with submarine-server ### What type of PR is it? [Feature] ### Todos ### What is the Jira issue? [SUBMARINE-493](https://issues.apache.org/jira/browse/SUBMARINE-493) ### How should this be tested? [passed CI](https://travis-ci.org/github/lowc1012/submarine/builds/688019593) ### Screenshots (if appropriate) https://user-images.githubusercontent.com/52355146/82148056-a20baa80-9884-11ea-8c77-30fe8ed741dd.png";> ![screenshot2](https://user-images.githubusercontent.com/52355146/82148067-b64fa780-9884-11ea-9b8b-c434bd63bb01.png) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: Ryan Lo Closes #290 from lowc1012/SUBMARINE-493 and squashes the following commits: fdcba8d [Ryan Lo] SUBMARINE-493. Change the path of jupyter docker-images 2c027d4 [Ryan Lo] SUBMARINE-493. typo fixed 71dce2c [Ryan Lo] SUBMARINE-493. Integrating jupyter notebook into Submarine --- dev-support/docker-images/jupyter/Dockerfile | 83 ++ dev-support/docker-images/jupyter/build.sh | 33 + submarine-cloud/hack/deploy-submarine.sh | 6 ++ submarine-cloud/hack/integration-test.sh | 1 + submarine-cloud/hack/kind-cluster-build.sh | 3 + .../manifests/submarine-cluster/jupyter.yaml | 53 ++ .../submarine-cluster/submarine-server.yaml| 4 ++ 7 files changed, 183 insertions(+) diff --git a/dev-support/docker-images/jupyter/Dockerfile b/dev-support/docker-images/jupyter/Dockerfile new file mode 100644 index 000..69eb76e --- /dev/null +++ b/dev-support/docker-images/jupyter/Dockerfile @@ -0,0 +1,83 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +ARG BASE_IMAGE=tensorflow/tensorflow:2.1.0-py3-jupyter + +FROM $BASE_IMAGE + +ARG NB_USER="jovyan" +ARG NB_UID="1000" +ARG NB_PREFIX="/jupyter/" +ARG NB_PORT= + +USER root +ENV NB_USER $NB_USER +ENV NB_UID $NB_UID +ENV NB_GID $NB_GID +ENV NB_PREFIX $NB_PREFIX +ENV NB_PORT $NB_PORT + +ENV PATH=$HOME/.local/bin:$PATH +ENV HOME=/home/$NB_USER + +RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -yq --no-install-recommends \ +apt-transport-https \ +build-essential \ +curl \ +wget \ +vim \ +bzip2 \ +ca-certificates \ +sudo \ +locales \ +fonts-liberation \ +run-one \ +python3-pip \ +python3-dev \ +python3-setuptools && \ +apt-get clean && rm -rf /var/lib/apt/lists/* + +RUN echo "$LOG_TAG Set locale" && \ +echo "LC_ALL=en_US.UTF-8" >> /etc/environment && \ +echo "en_US.UTF-8 UTF-8" >> /etc/locale.gen && \ +echo "LANG=en_US.UTF-8" > /etc/locale.conf && \ +locale-gen en_US.UTF-8 + +ENV LANG=en_US.UTF-8 \ +LC_ALL=en_US.UTF-8 + +# Create NB_USER user with UID=1000 and in the 'users' group +RUN useradd -m -s /bin/bash -N -u $NB_UID $NB_USER && \ +chown -R ${NB_USER}:users /usr/local/bin && \ +mkdir -p $HOME && \ +chown -R ${NB_USER}:users ${HOME} + + +# Add Tini +ENV TINI_VERSION v0.19.0 +ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /tini +RUN mv /tini /usr/local/bin/tini && chmod +x /usr/local/bin/tini + +# Install python package +RUN pip uninstall -y enum34 +RUN pip3 --no-cache-dir install \ +jupyterhub \ +jupyterlab + +# Configure container startup +EXPOSE $NB_PORT +USER $NB_UID +ENTRYPOINT ["tini", "-g", "--"] +CMD ["sh","-c", "jupyter notebook --notebook-dir=/home/${NB_USER} --ip=0.0.0.0 --no-browser --allow-root --port=$
[submarine] branch master updated: Submarine-463. [WEB]Implement database connection in project page with Angular
This is an automated email from the ASF dual-hosted git repository. liuxun pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/submarine.git The following commit(s) were added to refs/heads/master by this push: new e5bcea3 Submarine-463. [WEB]Implement database connection in project page with Angular e5bcea3 is described below commit e5bcea382c74047e2503a4ba891eb19fed813b7c Author: chiajoukuo AuthorDate: Mon May 18 16:03:26 2020 +0800 Submarine-463. [WEB]Implement database connection in project page with Angular ### What is this PR for? Implement database connection in project page with Angular ### What type of PR is it? [Feature] ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/SUBMARINE-463 ### How should this be tested? https://travis-ci.org/github/apache/submarine/builds/688270358 ### Screenshots (if appropriate) ![workspaceIT](https://user-images.githubusercontent.com/45503025/82117636-e70be000-97a3-11ea-8a93-3c3383679d0b.gif) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Author: chiajoukuo Author: chiajoukuo <45503025+chiajou...@users.noreply.github.com> Closes #289 from chiajoukuo/SUBMARINE-463 and squashes the following commits: 765005d [chiajoukuo] remove comment 56c2cb8 [chiajoukuo] Update submarine-workbench/workbench-web-ng/src/app/services/project.service.ts a1313b6 [chiajoukuo] fix IT fd803a9 [chiajoukuo] fix IT 4fa2d4a [chiajoukuo] fix IT c13d532 [chiajoukuo] fix IT e826824 [chiajoukuo] fix IT abe4c86 [chiajoukuo] fix IT a343738 [chiajoukuo] SUBMARINE-463 f319ded [chiajoukuo] SUBMARINE-463 --- .../apache/submarine/integration/workspaceIT.java | 40 +- .../public-api.ts => interfaces/project.ts}| 25 -- .../src/app/interfaces/public-api.ts | 1 + .../new-project-page.component.html| 16 ++-- .../new-project-page/new-project-page.component.ts | 42 +- .../workspace/project/project.component.html | 7 +- .../workspace/project/project.component.ts | 85 + .../src/app/services/project.service.ts| 89 ++ .../src/app/services/public-api.ts | 1 + 9 files changed, 255 insertions(+), 51 deletions(-) diff --git a/submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/workspaceIT.java b/submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/workspaceIT.java index 73ce796..d18ad4d 100644 --- a/submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/workspaceIT.java +++ b/submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/workspaceIT.java @@ -20,6 +20,8 @@ package org.apache.submarine.integration; import org.apache.submarine.AbstractSubmarineIT; import org.apache.submarine.WebDriverManager; import org.apache.submarine.SubmarineITUtils; +import org.openqa.selenium.support.ui.ExpectedConditions; +import org.openqa.selenium.support.ui.WebDriverWait; import org.openqa.selenium.By; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -56,8 +58,28 @@ public class workspaceIT extends AbstractSubmarineIT { pollingWait(By.xpath("//span[contains(text(), \"Workspace\")]"), MAX_BROWSER_TIMEOUT_SEC).click(); Assert.assertEquals(driver.getCurrentUrl(), "http://localhost:8080/workbench/workspace";); +WebDriverWait wait = new WebDriverWait( driver, 60); + wait.until(ExpectedConditions.visibilityOfElementLocated(By.xpath("//li[contains(text(), \"Release\")]"))); + +//Test release part +pollingWait(By.xpath("//li[contains(text(), \"Release\")]"), MAX_BROWSER_TIMEOUT_SEC).click(); + Assert.assertEquals(pollingWait(By.xpath("//nz-table[@id='releaseTable']"), MAX_BROWSER_TIMEOUT_SEC).isDisplayed(), true); + +//Test training part +pollingWait(By.xpath("//li[contains(text(), \"Training\")]"), MAX_BROWSER_TIMEOUT_SEC).click(); +Assert.assertEquals(pollingWait(By.xpath("//div[@id='trainingDiv']"), MAX_BROWSER_TIMEOUT_SEC).isDisplayed(), true); + +//Test team part +pollingWait(By.xpath("//li[contains(text(), \"Team\")]"), MAX_BROWSER_TIMEOUT_SEC).click(); +Assert.assertEquals(pollingWait(By.xpath("//div[@id='teamDiv']"), MAX_BROWSER_TIMEOUT_SEC).isDisplayed(), true); + +// shared part +pollingWait(By.xpath("//li[contains(text(), \"Shared\")]"), MAX_BROWSER_TIMEOUT_SEC).click(); +Assert.assertEquals(pollingWait(By.xpath("//nz-table[@id='sharedTable']"), MAX_BROWSER_TIMEOUT_SEC).isDisplayed(), true); + //Test project part pollingWait(By.xpath("//li[contains(text(), \"Project\")]"), MAX_BROWSER_TIMEOUT_SEC).click(); + wait.until(ExpectedConditions.visibilityOfElementLocat
[jira] [Resolved] (SUBMARINE-463) [web]Implement database connection in project page with Angular
[ https://issues.apache.org/jira/browse/SUBMARINE-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liu Xun resolved SUBMARINE-463. --- Fix Version/s: (was: 0.4.0) 0.5.0 Resolution: Fixed Issue resolved by pull request 289 [https://github.com/apache/submarine/pull/289] > [web]Implement database connection in project page with Angular > --- > > Key: SUBMARINE-463 > URL: https://issues.apache.org/jira/browse/SUBMARINE-463 > Project: Apache Submarine > Issue Type: Sub-task > Components: Workbench Web >Reporter: Chia-Jou Kuo >Assignee: Chia-Jou Kuo >Priority: Major > Fix For: 0.5.0 > > > Implement database connection in project page with Angular. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[jira] [Commented] (SUBMARINE-499) Refactor job API to experiment API
[ https://issues.apache.org/jira/browse/SUBMARINE-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110426#comment-17110426 ] Wanqiang Ji commented on SUBMARINE-499: --- Good question, thanks [~sunilg]. At present we use the tf-operator which belongs to Kubeflow, it had encapsulate tensorboard. And I think we should move the "tensorboard" label to tensorflow spec. cc: [~wangda] > Refactor job API to experiment API > -- > > Key: SUBMARINE-499 > URL: https://issues.apache.org/jira/browse/SUBMARINE-499 > Project: Apache Submarine > Issue Type: New Feature > Components: Backend Server >Reporter: Zhankun Tang >Assignee: Wanqiang Ji >Priority: Major > Fix For: 0.4.0 > > > With Wangda's new design agreed, we're going to refactor job API spec to > experiment spec. > Refer > [https://docs.google.com/document/d/1T-NowARlz0EGrsMiAdUmA6af1b_G4bUPu-eKi7nvuk8/edit#] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org
[jira] [Commented] (SUBMARINE-499) Refactor job API to experiment API
[ https://issues.apache.org/jira/browse/SUBMARINE-499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17110471#comment-17110471 ] Wangda Tan commented on SUBMARINE-499: -- [~jiwq], [https://pytorch.org/tutorials/intermediate/tensorboard_tutorial.html] mentioned Tensorboard can be supported by PyTorch (officially). I think we should put this to at least PyTorch and Tensorflow spec. > Refactor job API to experiment API > -- > > Key: SUBMARINE-499 > URL: https://issues.apache.org/jira/browse/SUBMARINE-499 > Project: Apache Submarine > Issue Type: New Feature > Components: Backend Server >Reporter: Zhankun Tang >Assignee: Wanqiang Ji >Priority: Major > Fix For: 0.4.0 > > > With Wangda's new design agreed, we're going to refactor job API spec to > experiment spec. > Refer > [https://docs.google.com/document/d/1T-NowARlz0EGrsMiAdUmA6af1b_G4bUPu-eKi7nvuk8/edit#] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org For additional commands, e-mail: dev-h...@submarine.apache.org