[GitHub] [submarine] liuxunorg commented on a change in pull request #182: SUBMARINE-360. [WEB] Implement the frontend of sign-up page with Angular
liuxunorg commented on a change in pull request #182: SUBMARINE-360. [WEB]
Implement the frontend of sign-up page with Angular
URL: https://github.com/apache/submarine/pull/182#discussion_r377470297
##
File path:
submarine-test/e2e/src/test/java/org/apache/submarine/integration/sidebarIT.java
##
@@ -66,7 +68,13 @@ public void sidebarNavigation() throws Exception {
pollingWait(By.xpath("//span[contains(text(), \"Manager\")]"),
MAX_BROWSER_TIMEOUT_SEC).click();
pollingWait(By.xpath("//a[@href='/workbench/manager/user']"),
MAX_BROWSER_TIMEOUT_SEC).click();
SubmarineITUtils.sleep( 5000, true);
+
+// Lazy-loading
+ WebDriverWait wait = new WebDriverWait( driver, 15, 5000);
+ pollingWait(By.xpath("//a[@href='/workbench/manager/user']"),
MAX_BROWSER_TIMEOUT_SEC).click();
+
wait.until(ExpectedConditions.visibilityOfElementLocated(By.xpath("//span[@class='ant-breadcrumb-link
ng-star-inserted']")));
Review comment:
Wrong code indentation
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org
For additional commands, e-mail: dev-h...@submarine.apache.org
[GitHub] [submarine] liuxunorg commented on a change in pull request #182: SUBMARINE-360. [WEB] Implement the frontend of sign-up page with Angular
liuxunorg commented on a change in pull request #182: SUBMARINE-360. [WEB]
Implement the frontend of sign-up page with Angular
URL: https://github.com/apache/submarine/pull/182#discussion_r377469944
##
File path:
submarine-workbench/workbench-web-ng/src/app/pages/user/register/register.component.ts
##
@@ -18,14 +18,86 @@
*/
import { Component, OnInit } from '@angular/core';
+import { FormBuilder, FormControl, FormGroup, Validators } from
'@angular/forms';
+import { Router } from '@angular/router';
@Component({
selector: 'submarine-register',
templateUrl: './register.component.html',
styleUrls: ['./register.component.scss']
})
export class RegisterComponent implements OnInit {
- constructor() {}
+ validateForm: FormGroup;
+ // mock data: must be removed in the future
Review comment:
You can remind yourself by adding `TODO(kevin85421): must be removed in the
future`, all TODO will be displayed in the `TODO view` in IDEA.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
-
To unsubscribe, e-mail: dev-unsubscr...@submarine.apache.org
For additional commands, e-mail: dev-h...@submarine.apache.org
