Yasuhito FUTATSUKI wrote on Thu, 19 Sep 2019 06:41 +00:00:
> On 2019/09/19 8:21, Johan Corveleyn wrote:
> > On Wed, Sep 18, 2019 at 12:08 PM Branko Čibej <br...@apache.org> wrote:
> >> You do *not* need a definition of 'struct foo' in order to use a 'struct
> >> foo*' pointer. So, no, that's not the problem.
>
> Actually C4115 is only a warning.
>
> https://docs.microsoft.com/cpp/error-messages/compiler-warnings/compiler-warning-levels-1-and-4-c4115?view=vs-2019
>
> However, it seems we are treating it as an error by specifyinging build
> option in build/generator/templates/vcnet_vcxproj.ezt .
>
> (Is it related to https://bugs.python.org/issue25878, especially
> msg256496 ?)
>
That certainly sounds similar.
For comparison, on a toy example, I get a warning if I use a pointer to
an undeclared struct type:
[[[
% cat foo.c
void f(struct foo *);
% cc -c -Wall foo.c
foo.c:1:15: warning: declaration of 'struct foo' will not be visible outside of
this function [-Wvisibility]
void f(struct foo *);
^
1 warning generated.
%
]]]
That doesn't happen if the struct type has been declared:
[[[
% cat bar.c
struct bar;
void g(struct bar *);
% cc -c -Wall bar.c
%
]]]
I think that -Wvisibility warning is basically what that C4115 is about?
pytime.h doesn't declare 'struct timeval', neither directly nor via
an #include.
I haven't checked whether my build warns about -Wvisibility there.
> The FAIL on test_merge_peg3 is a newline style issue on reading file
> in raw mode, which is introduced by my patch.
> (https://svn.apache.org/viewvc/subversion/branches/swig-py3/subversion/bindings/swig/python/tests/client.py?view=annotate#l438)
>
> Rest of those errors and failures are in the tests that were added only
> to swig-py, and it seems most of the causes of them are confusion of
> paths in platform specific format and Subversion's canoical format,
> as the comment in SubversionClientTestCase.test_update4() says.
>
> (I'll try to fix those issues on check-swig-py later, hopefully
> next weekend.)
Thanks! No rush.
Cheers,
Daniel
