Re: Svn server images / appliances / packages

[Daniel Shahaf]

Branko Čibej wrote on Mon, 16 Dec 2019 15:33 +00:00:
> We should look into how, or if, other ASF projects publish their
> Dockerfiles. I'd much rather have an asf/ repository at docker.io than a
> subversion/ repository.

There's an official https://hub.docker.com/u/apache.

Re: svn commit: r1871916 - /subversion/trunk/subversion/svn/log-cmd.c

[Daniel Shahaf]

danie...@apache.org wrote on Mon, 23 Dec 2019 06:50 +00:00:
> 'svn log': Make the --quiet and --diff options not mutually exclusive.
> 
> +++ subversion/trunk/subversion/svn/log-cmd.c Mon Dec 23 06:50:26 2019
> @@ -733,10 +733,6 @@ svn_cl__log(apr_getopt_t *os,
> -  if (opt_state->quiet && opt_state->show_diff)
> -return svn_error_create(SVN_ERR_CL_ARG_PARSING_ERROR, NULL,
> -_("'quiet' and 'diff' options are "
> -  "mutually exclusive"));

If anyone knows of a reason to keep --quiet and --diff mutually
exclusive, please speak up.  (On users@ this change was determined to be
a good idea, but asking here, too, in case we missed something.)

Cheers,

Daniel

Re: "svn list -v" column alignment issue

[Daniel Shahaf]

Vincent Lefevre wrote on Mon, 23 Dec 2019 02:21 +00:00:
> On 2019-12-21 08:09:46 +, Daniel Shahaf wrote:
> > Vincent Lefevre wrote on Sat, Dec 21, 2019 at 00:09:09 +0100:
> > > There's something wrong with "svn list -v" column alignment when
> > > there are author names with more than 8 characters. For instance,
> > > with the gcc repository:
> > > 
> > > [...]
> > >  279442 jozeflDec 16 12:02 libgcc/
> > >  278886 jvdelisle  Dec 01 23:29 libgfortran/
> > > [...]
> > 
> > As implemented, the width is initially 8 but as soon as a longer name is 
> > seen,
> > subsequent lines will be aligned with that, up to a maximum length of 16.
> > 
> > Do you have a better algorithm to propose?
> 
> cache the maximum length name in the working-copy data.

Let's see.  We could cache the value in wc.db.  Running 'ls' or 'blame' [the
same considerations apply to both] would update the cache; running 'cleanup'
would purge it.

Two things are not immediately clear to me:

- This info is only needed by the cmdline client, not by other library users.
  This suggests the API should be generic.  A per-client cache, maybe?  There's
  already a svn_client_ctx_t::client_name so it's not unprecedented.

- What the cache keys should be.  wc.db is designed to be shared among multiple
  WC's, so presumably the cache should be per-wcroot or possibly per-repository?

>

Another idea: The WC caches the "last changed author" information.  When
initializing the display width, we could initialize it as though we'd already
encountered a line with the longest "last changed author" that's cached in wc.db
(possibly for a relevant subtree).

>

(To be clear, I'm just brainstorming; I'm not going to implement either of
these ideas.  Patches welcome.)

> Make the minimum width configurable,

Currently it is only configurable by changing the constant's value and
rebuilding…

Oh.  I missed it before, but passing -H increases the minimum width to 14.
That's not obvious from the --help output and variable names.

Re: "svn list -v" column alignment issue

[Vincent Lefevre]

On 2019-12-23 03:21:09 +0100, Vincent Lefevre wrote:
> On 2019-12-21 08:09:46 +, Daniel Shahaf wrote:
> > Vincent Lefevre wrote on Sat, Dec 21, 2019 at 00:09:09 +0100:
> > > There's something wrong with "svn list -v" column alignment when
> > > there are author names with more than 8 characters. For instance,
> > > with the gcc repository:
> > > 
> > > [...]
> > >  279442 jozeflDec 16 12:02 libgcc/
> > >  278886 jvdelisle  Dec 01 23:29 libgfortran/
> > > [...]
> > 
> > As implemented, the width is initially 8 but as soon as a longer name is 
> > seen,
> > subsequent lines will be aligned with that, up to a maximum length of 16.
> > 
> > Do you have a better algorithm to propose?
> 
> Make the minimum width configurable, or cache the maximum length name
> in the working-copy data.

Or wait for a fraction of second, say 0.1 s, after the first data
are available, and compute the width based on these initial data.
In most cases (e.g. when -R is not used), these data will actually
be complete, so that the output will be correct.

-- 
Vincent Lefèvre  - Web: 
100% accessible validated (X)HTML - Blog: 
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)

Re: "svn list -v" column alignment issue

[Vincent Lefevre]

On 2019-12-21 08:09:46 +, Daniel Shahaf wrote:
> Vincent Lefevre wrote on Sat, Dec 21, 2019 at 00:09:09 +0100:
> > There's something wrong with "svn list -v" column alignment when
> > there are author names with more than 8 characters. For instance,
> > with the gcc repository:
> > 
> > [...]
> >  279442 jozeflDec 16 12:02 libgcc/
> >  278886 jvdelisle  Dec 01 23:29 libgfortran/
> > [...]
> 
> As implemented, the width is initially 8 but as soon as a longer name is seen,
> subsequent lines will be aligned with that, up to a maximum length of 16.
> 
> Do you have a better algorithm to propose?

Make the minimum width configurable, or cache the maximum length name
in the working-copy data.

-- 
Vincent Lefèvre  - Web: 
100% accessible validated (X)HTML - Blog: 
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)