Re: Subversion 1.14.3 up for testing/signing

2023-12-21 Thread Daniel Sahlberg
Den fre 22 dec. 2023 kl 02:49 skrev Johan Corveleyn :

> On Tue, Dec 19, 2023 at 1:30 PM Johan Corveleyn  wrote:
> >
> > On Mon, Dec 18, 2023 at 11:13 PM Nathan Hartman
> >  wrote:
> > >
> > > On Sat, Dec 9, 2023 at 10:50 AM Nathan Hartman <
> hartmannat...@apache.org> wrote:
> > > >
> > > > The 1.14.3 release artifacts are now available for testing/signing.
> > > > Please get the tarballs from
> > > >   https://dist.apache.org/repos/dist/dev/subversion
> > > > and add your signatures there.
> > > >
> > > > Thanks!
> > >
> > >
> > > Hi all,
> > >
> > > Just to help plan ahead a little bit: Who else is planning to
> > > test/sign the 1.14.3 tarballs, and approximately how much time do you
> > > need?
> > >
> > > (If it's possible to be done with testing/signing toward the
> > > middle/end of this week, I will have a good opportunity to finish up
> > > the release work, but please let me know...)
> >
> > I still plan to go for it (on Windows 10). Not sure if middle of this
> > week (i.e. Wednesday night or so) is still realistic, but I'll try. No
> > guarantees though, so if you have enough sigs feel free to go ahead.
> >
> > I started with some initial steps last weekend, but got stranded along
> > the way. Basically I realized that OpenSSL 1.1.1 is totally EOL, and I
> > should really go for OpenSSL 3 now, which forces me to rebuild serf
> > and httpd (fortunately, others have already done work on serf 1.3.10
> > to make it work with OpenSSL 3, so I hope that will work out smoothly
> > -- as for httpd, that's always a big adventure on Windows). Oh and I'd
> > like the latest version of APR 1.7 as well, which includes a relevant
> > fix for Windows junctions / subst / something. So far, I've just
> > collected everything I need, but have not run a single buildscript
> > yet. To be continued ...
>
> Still working on it.
>
> Succesfully built zlib-1.3, openssl-3.0.12, apr-1.7.4, apr-util-1.6.3,
> httpd-2.4.58 (and pcre-8.45 and expat-2.2.9) and serf 1.3.10.
>
> Finally, did some tweaks to get gen_win_dependencies.py to run, but
> then ran into following error:
> [[[
> python gen-make.py --release
> --with-swig=C:\research\swigwin-4.1.1 --with-py3c=C:\research\py3c-1.4
> --with-junit=C:\research\svn\dev\deps64\src\junit-4.13.2\junit.jar
> --with-jdk="C:\Program Files\Java\jdk-21" --with-httpd=C:\Apache2.4.58
> --with-serf=C:\research\svn\dev\deps64\src\serf-1.3.10
> --with-openssl=C:\research\svn\dev\deps64\src\openssl-3.0.12
> --with-sqlite=C:\research\svn\dev\deps64\src\sqlite-amalgamation-3.44.2.0
> --with-zlib=C:\research\svn\dev\deps64\src\zlib-1.3
> --vsnet-version=2019 -t vcproj 2>&1 | tee log.gen-make
>
> C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:233:
> SyntaxWarning: invalid escape sequence '\.'
>   if val == '2002' or re.match('^7(\.\d+)?$', val):
>
> C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:238:
> SyntaxWarning: invalid escape sequence '\.'
>   elif val == '2003' or re.match('^8(\.\d+)?$', val):
>
> C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:243:
> SyntaxWarning: invalid escape sequence '\.'
>   elif val == '2005' or re.match('^9(\.\d+)?$', val):
>
> C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:248:
> SyntaxWarning: invalid escape sequence '\.'
>   elif val == '2008' or re.match('^10(\.\d+)?$', val):
>
> C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:283:
> SyntaxWarning: invalid escape sequence '\d'
>   elif re.match('^20\d+$', val):
>
> C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:290:
> SyntaxWarning: invalid escape sequence '\d'
>   elif re.match('^1\d+$', val):
> C:\research\svn\dev\subversion-1.14.3\build\transform_sql.py:53:
> SyntaxWarning: invalid escape sequence '\('
>   re_statement = re.compile('-- *STMT_([A-Z_0-9]+)( +\(([^\)]*)\))?')
> Generating for Visual Studio 2019
> ]]]
>
> That is using Python 3.12.1.
>
> When downgrading to Python 3.9 those errors are gone. Just wanted to
> let you guys know ...
>
> Then, regardless of the above error, when I start building with
> msbuild, I run into following error:
> [[[
>
> C:\research\svn\dev\deps64\src\sqlite-amalgamation-3.44.2.0\sqlite3.c(34597,42):
> error C4013: 'sqlite3PagerWalSystemErrno' undefined; assuming extern
> returning
>  int
> [C:\research\svn\dev\subversion-1.14.3\build\win32\vcnet-vcproj\libsvn_subr.vcxproj]
> ]]]
>

The declaration is guarded by:
#if defined(SQLITE_USE_SEH) && !defined(SQLITE_OMIT_WAL)

While the actual use seems to be guarded by
#ifdef SQLITE_USE_SEH

In our code we have
$ grep -r SQLITE_OMIT_WAL
subversion/libsvn_subr/sqlite3wrapper.c:#  define SQLITE_OMIT_WAL 1

I assume we trigger some bug in SQLite but I don't have time to dig into
the SQLite source code. It's not the first time we've hit errors with
OMIT_WAL


> I ran out of time for tonight, will continue tomorrow. If anybody
> knows what I

Re: Subversion 1.14.3 up for testing/signing

2023-12-21 Thread Daniel Sahlberg
Den fre 22 dec. 2023 kl 03:08 skrev Yasuhito FUTATSUKI :

> Hi,
>
> On 2023/12/22 10:49, Johan Corveleyn wrote:
> > On Tue, Dec 19, 2023 at 1:30 PM Johan Corveleyn 
> wrote:
> >>
> >> On Mon, Dec 18, 2023 at 11:13 PM Nathan Hartman
> >>  wrote:
> >>>
> >>> On Sat, Dec 9, 2023 at 10:50 AM Nathan Hartman <
> hartmannat...@apache.org> wrote:
> 
>  The 1.14.3 release artifacts are now available for testing/signing.
>  Please get the tarballs from
>    https://dist.apache.org/repos/dist/dev/subversion
>  and add your signatures there.
> 
>  Thanks!
> >>>
> >>>
> >>> Hi all,
> >>>
> >>> Just to help plan ahead a little bit: Who else is planning to
> >>> test/sign the 1.14.3 tarballs, and approximately how much time do you
> >>> need?
> >>>
> >>> (If it's possible to be done with testing/signing toward the
> >>> middle/end of this week, I will have a good opportunity to finish up
> >>> the release work, but please let me know...)
> >>
> >> I still plan to go for it (on Windows 10). Not sure if middle of this
> >> week (i.e. Wednesday night or so) is still realistic, but I'll try. No
> >> guarantees though, so if you have enough sigs feel free to go ahead.
> >>
> >> I started with some initial steps last weekend, but got stranded along
> >> the way. Basically I realized that OpenSSL 1.1.1 is totally EOL, and I
> >> should really go for OpenSSL 3 now, which forces me to rebuild serf
> >> and httpd (fortunately, others have already done work on serf 1.3.10
> >> to make it work with OpenSSL 3, so I hope that will work out smoothly
> >> -- as for httpd, that's always a big adventure on Windows). Oh and I'd
> >> like the latest version of APR 1.7 as well, which includes a relevant
> >> fix for Windows junctions / subst / something. So far, I've just
> >> collected everything I need, but have not run a single buildscript
> >> yet. To be continued ...
> >
> > Still working on it.
> >
> > Succesfully built zlib-1.3, openssl-3.0.12, apr-1.7.4, apr-util-1.6.3,
> > httpd-2.4.58 (and pcre-8.45 and expat-2.2.9) and serf 1.3.10.
> >
> > Finally, did some tweaks to get gen_win_dependencies.py to run, but
> > then ran into following error:
> > [[[
> > python gen-make.py --release
> > --with-swig=C:\research\swigwin-4.1.1 --with-py3c=C:\research\py3c-1.4
> > --with-junit=C:\research\svn\dev\deps64\src\junit-4.13.2\junit.jar
> > --with-jdk="C:\Program Files\Java\jdk-21" --with-httpd=C:\Apache2.4.58
> > --with-serf=C:\research\svn\dev\deps64\src\serf-1.3.10
> > --with-openssl=C:\research\svn\dev\deps64\src\openssl-3.0.12
> > --with-sqlite=C:\research\svn\dev\deps64\src\sqlite-amalgamation-3.44.2.0
> > --with-zlib=C:\research\svn\dev\deps64\src\zlib-1.3
> > --vsnet-version=2019 -t vcproj 2>&1 | tee log.gen-make
> >
> C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:233:
> > SyntaxWarning: invalid escape sequence '\.'
> >   if val == '2002' or re.match('^7(\.\d+)?$', val):
> >
> C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:238:
> > SyntaxWarning: invalid escape sequence '\.'
> >   elif val == '2003' or re.match('^8(\.\d+)?$', val):
> >
> C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:243:
> > SyntaxWarning: invalid escape sequence '\.'
> >   elif val == '2005' or re.match('^9(\.\d+)?$', val):
> >
> C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:248:
> > SyntaxWarning: invalid escape sequence '\.'
> >   elif val == '2008' or re.match('^10(\.\d+)?$', val):
> >
> C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:283:
> > SyntaxWarning: invalid escape sequence '\d'
> >   elif re.match('^20\d+$', val):
> >
> C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:290:
> > SyntaxWarning: invalid escape sequence '\d'
> >   elif re.match('^1\d+$', val):
> > C:\research\svn\dev\subversion-1.14.3\build\transform_sql.py:53:
> > SyntaxWarning: invalid escape sequence '\('
> >   re_statement = re.compile('-- *STMT_([A-Z_0-9]+)( +\(([^\)]*)\))?')
> > Generating for Visual Studio 2019
> > ]]]
> >
> > That is using Python 3.12.1.
> >
> > When downgrading to Python 3.9 those errors are gone. Just wanted to
> > let you guys know ...
>
> Should we backport r1912632?
>

Yes, it is probably a good idea to nominate it, but I don't think we need
to hold off the release for this. It is only a warning at the moment
(although it will be an error in a later Python release, see the relase
notes for Python 3.12).


> Cheers,
> --
> Yasuhito FUTATSUKI /
>

 Kind regards,
Daniel


Re: Subversion 1.14.3 up for testing/signing

2023-12-21 Thread Yasuhito FUTATSUKI
Hi,

On 2023/12/22 10:49, Johan Corveleyn wrote:
> On Tue, Dec 19, 2023 at 1:30 PM Johan Corveleyn  wrote:
>>
>> On Mon, Dec 18, 2023 at 11:13 PM Nathan Hartman
>>  wrote:
>>>
>>> On Sat, Dec 9, 2023 at 10:50 AM Nathan Hartman  
>>> wrote:

 The 1.14.3 release artifacts are now available for testing/signing.
 Please get the tarballs from
   https://dist.apache.org/repos/dist/dev/subversion
 and add your signatures there.

 Thanks!
>>>
>>>
>>> Hi all,
>>>
>>> Just to help plan ahead a little bit: Who else is planning to
>>> test/sign the 1.14.3 tarballs, and approximately how much time do you
>>> need?
>>>
>>> (If it's possible to be done with testing/signing toward the
>>> middle/end of this week, I will have a good opportunity to finish up
>>> the release work, but please let me know...)
>>
>> I still plan to go for it (on Windows 10). Not sure if middle of this
>> week (i.e. Wednesday night or so) is still realistic, but I'll try. No
>> guarantees though, so if you have enough sigs feel free to go ahead.
>>
>> I started with some initial steps last weekend, but got stranded along
>> the way. Basically I realized that OpenSSL 1.1.1 is totally EOL, and I
>> should really go for OpenSSL 3 now, which forces me to rebuild serf
>> and httpd (fortunately, others have already done work on serf 1.3.10
>> to make it work with OpenSSL 3, so I hope that will work out smoothly
>> -- as for httpd, that's always a big adventure on Windows). Oh and I'd
>> like the latest version of APR 1.7 as well, which includes a relevant
>> fix for Windows junctions / subst / something. So far, I've just
>> collected everything I need, but have not run a single buildscript
>> yet. To be continued ...
> 
> Still working on it.
> 
> Succesfully built zlib-1.3, openssl-3.0.12, apr-1.7.4, apr-util-1.6.3,
> httpd-2.4.58 (and pcre-8.45 and expat-2.2.9) and serf 1.3.10.
> 
> Finally, did some tweaks to get gen_win_dependencies.py to run, but
> then ran into following error:
> [[[
> python gen-make.py --release
> --with-swig=C:\research\swigwin-4.1.1 --with-py3c=C:\research\py3c-1.4
> --with-junit=C:\research\svn\dev\deps64\src\junit-4.13.2\junit.jar
> --with-jdk="C:\Program Files\Java\jdk-21" --with-httpd=C:\Apache2.4.58
> --with-serf=C:\research\svn\dev\deps64\src\serf-1.3.10
> --with-openssl=C:\research\svn\dev\deps64\src\openssl-3.0.12
> --with-sqlite=C:\research\svn\dev\deps64\src\sqlite-amalgamation-3.44.2.0
> --with-zlib=C:\research\svn\dev\deps64\src\zlib-1.3
> --vsnet-version=2019 -t vcproj 2>&1 | tee log.gen-make
> C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:233:
> SyntaxWarning: invalid escape sequence '\.'
>   if val == '2002' or re.match('^7(\.\d+)?$', val):
> C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:238:
> SyntaxWarning: invalid escape sequence '\.'
>   elif val == '2003' or re.match('^8(\.\d+)?$', val):
> C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:243:
> SyntaxWarning: invalid escape sequence '\.'
>   elif val == '2005' or re.match('^9(\.\d+)?$', val):
> C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:248:
> SyntaxWarning: invalid escape sequence '\.'
>   elif val == '2008' or re.match('^10(\.\d+)?$', val):
> C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:283:
> SyntaxWarning: invalid escape sequence '\d'
>   elif re.match('^20\d+$', val):
> C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:290:
> SyntaxWarning: invalid escape sequence '\d'
>   elif re.match('^1\d+$', val):
> C:\research\svn\dev\subversion-1.14.3\build\transform_sql.py:53:
> SyntaxWarning: invalid escape sequence '\('
>   re_statement = re.compile('-- *STMT_([A-Z_0-9]+)( +\(([^\)]*)\))?')
> Generating for Visual Studio 2019
> ]]]
> 
> That is using Python 3.12.1.
> 
> When downgrading to Python 3.9 those errors are gone. Just wanted to
> let you guys know ...

Should we backport r1912632?

Cheers,
-- 
Yasuhito FUTATSUKI /


Re: Subversion 1.14.3 up for testing/signing

2023-12-21 Thread Johan Corveleyn
On Tue, Dec 19, 2023 at 1:30 PM Johan Corveleyn  wrote:
>
> On Mon, Dec 18, 2023 at 11:13 PM Nathan Hartman
>  wrote:
> >
> > On Sat, Dec 9, 2023 at 10:50 AM Nathan Hartman  
> > wrote:
> > >
> > > The 1.14.3 release artifacts are now available for testing/signing.
> > > Please get the tarballs from
> > >   https://dist.apache.org/repos/dist/dev/subversion
> > > and add your signatures there.
> > >
> > > Thanks!
> >
> >
> > Hi all,
> >
> > Just to help plan ahead a little bit: Who else is planning to
> > test/sign the 1.14.3 tarballs, and approximately how much time do you
> > need?
> >
> > (If it's possible to be done with testing/signing toward the
> > middle/end of this week, I will have a good opportunity to finish up
> > the release work, but please let me know...)
>
> I still plan to go for it (on Windows 10). Not sure if middle of this
> week (i.e. Wednesday night or so) is still realistic, but I'll try. No
> guarantees though, so if you have enough sigs feel free to go ahead.
>
> I started with some initial steps last weekend, but got stranded along
> the way. Basically I realized that OpenSSL 1.1.1 is totally EOL, and I
> should really go for OpenSSL 3 now, which forces me to rebuild serf
> and httpd (fortunately, others have already done work on serf 1.3.10
> to make it work with OpenSSL 3, so I hope that will work out smoothly
> -- as for httpd, that's always a big adventure on Windows). Oh and I'd
> like the latest version of APR 1.7 as well, which includes a relevant
> fix for Windows junctions / subst / something. So far, I've just
> collected everything I need, but have not run a single buildscript
> yet. To be continued ...

Still working on it.

Succesfully built zlib-1.3, openssl-3.0.12, apr-1.7.4, apr-util-1.6.3,
httpd-2.4.58 (and pcre-8.45 and expat-2.2.9) and serf 1.3.10.

Finally, did some tweaks to get gen_win_dependencies.py to run, but
then ran into following error:
[[[
python gen-make.py --release
--with-swig=C:\research\swigwin-4.1.1 --with-py3c=C:\research\py3c-1.4
--with-junit=C:\research\svn\dev\deps64\src\junit-4.13.2\junit.jar
--with-jdk="C:\Program Files\Java\jdk-21" --with-httpd=C:\Apache2.4.58
--with-serf=C:\research\svn\dev\deps64\src\serf-1.3.10
--with-openssl=C:\research\svn\dev\deps64\src\openssl-3.0.12
--with-sqlite=C:\research\svn\dev\deps64\src\sqlite-amalgamation-3.44.2.0
--with-zlib=C:\research\svn\dev\deps64\src\zlib-1.3
--vsnet-version=2019 -t vcproj 2>&1 | tee log.gen-make
C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:233:
SyntaxWarning: invalid escape sequence '\.'
  if val == '2002' or re.match('^7(\.\d+)?$', val):
C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:238:
SyntaxWarning: invalid escape sequence '\.'
  elif val == '2003' or re.match('^8(\.\d+)?$', val):
C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:243:
SyntaxWarning: invalid escape sequence '\.'
  elif val == '2005' or re.match('^9(\.\d+)?$', val):
C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:248:
SyntaxWarning: invalid escape sequence '\.'
  elif val == '2008' or re.match('^10(\.\d+)?$', val):
C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:283:
SyntaxWarning: invalid escape sequence '\d'
  elif re.match('^20\d+$', val):
C:\research\svn\dev\subversion-1.14.3\build\generator\gen_win_dependencies.py:290:
SyntaxWarning: invalid escape sequence '\d'
  elif re.match('^1\d+$', val):
C:\research\svn\dev\subversion-1.14.3\build\transform_sql.py:53:
SyntaxWarning: invalid escape sequence '\('
  re_statement = re.compile('-- *STMT_([A-Z_0-9]+)( +\(([^\)]*)\))?')
Generating for Visual Studio 2019
]]]

That is using Python 3.12.1.

When downgrading to Python 3.9 those errors are gone. Just wanted to
let you guys know ...

Then, regardless of the above error, when I start building with
msbuild, I run into following error:
[[[
C:\research\svn\dev\deps64\src\sqlite-amalgamation-3.44.2.0\sqlite3.c(34597,42):
error C4013: 'sqlite3PagerWalSystemErrno' undefined; assuming extern
returning
 int 
[C:\research\svn\dev\subversion-1.14.3\build\win32\vcnet-vcproj\libsvn_subr.vcxproj]
]]]

I ran out of time for tonight, will continue tomorrow. If anybody
knows what I should do about the above error, let me know :-).
Otherwise I'll try downgrading sqlite to 3.41.2 (the version Evgeny
Kotkov used a couple of days ago).

-- 
Johan