Re: Pristines-on-demand: authz denied during textbase sync (#4888)

[Daniel Shahaf]

Julian Foad wrote on Wed, Apr 06, 2022 at 13:07:43 +0100:
> > Filed as issue #4888, https://subversion.apache.org/issue/4888
> 
> I have just been looking back over this issue. Clearly there is more to
> it than a quick fix. Summary, based on reviewing the email thread:
> 
> - FAIL: authz_tests.py 31 remove_access_after_commit
> 
> - Patched in : in "text base sync"
> phase, ignore auth error while fetching any text base; continue with
> trying to fetch the rest.
> 
> - While that change fixes that particular test case, it also seems to
> have regressed the failure mode of «svn cat iota@BASE» when iota is
> locally-modified and has no read access. On trunk that command displayed
> the base text; on this branch that command now errors out.
> 
> - We started thinking about what other failure modes could now occur
> because of failures (including unauthorised, redirect, and others) at
> the hydrate phase. This is somewhat open ended; we don't have a simple
> answer to how this all should be taken care of consistently.
> 
> I suggest:
> 
> - revert the patch I applied, as it's papering over the problem in an
> incomplete way and so possibly causes more confusion than it fixes.
> 
> - leave this issue open and come back to it later; it's an edge case not
> part of common work flows.

Shouldn't SVN-4888 be marked a blocker, though?  At least until we are
satisfied that the code as it stands is a solid base to implement an
answer to the "open ended" questions on at a later date?

It's also a regression, but as you say it's also an edge case, and these
two aspects may cancel each other out.

Cheers,

Daniel

Re: Pristines-on-demand: authz denied during textbase sync (#4888)

[Karl Fogel]

On 06 Apr 2022, Julian Foad wrote:

Evgeny Kotkov wrote:
- revert the patch I applied, as it's papering over the 
problem in an
incomplete way and so possibly causes more confusion than it 
fixes.


- leave this issue open and come back to it later; it's an 
edge case not

part of common work flows.


+1.


Thanks! Reverted that patch in r1899616.


+1 here too, post facto, FWIW!

Re: Pristines-on-demand: authz denied during textbase sync (#4888)

[Julian Foad]

Evgeny Kotkov wrote:
>> - revert the patch I applied, as it's papering over the problem in an
>> incomplete way and so possibly causes more confusion than it fixes.
>> 
>> - leave this issue open and come back to it later; it's an edge case not
>> part of common work flows.
> 
> +1.

Thanks! Reverted that patch in r1899616.

- Julian

Re: Pristines-on-demand: authz denied during textbase sync (#4888)

[Evgeny Kotkov]

Julian Foad  writes:

> I suggest:
>
> - revert the patch I applied, as it's papering over the problem in an
> incomplete way and so possibly causes more confusion than it fixes.
>
> - leave this issue open and come back to it later; it's an edge case not
> part of common work flows.

+1.


Regards,
Evgeny Kotkov

Re: Pristines-on-demand: authz denied during textbase sync (#4888)

[Julian Foad]

> Filed as issue #4888, https://subversion.apache.org/issue/4888

I have just been looking back over this issue. Clearly there is more to
it than a quick fix. Summary, based on reviewing the email thread:

- FAIL: authz_tests.py 31 remove_access_after_commit

- Patched in : in "text base sync"
phase, ignore auth error while fetching any text base; continue with
trying to fetch the rest.

- While that change fixes that particular test case, it also seems to
have regressed the failure mode of «svn cat iota@BASE» when iota is
locally-modified and has no read access. On trunk that command displayed
the base text; on this branch that command now errors out.

- We started thinking about what other failure modes could now occur
because of failures (including unauthorised, redirect, and others) at
the hydrate phase. This is somewhat open ended; we don't have a simple
answer to how this all should be taken care of consistently.

I suggest:

- revert the patch I applied, as it's papering over the problem in an
incomplete way and so possibly causes more confusion than it fixes.

- leave this issue open and come back to it later; it's an edge case not
part of common work flows.

Re: Pristines-on-demand: authz denied during textbase sync (#4888)

[Julian Foad]

Filed as issue #4888, https://subversion.apache.org/issue/4888

I will come back to it soonish.