Re: svn commit: r1232059 - in /subversion/trunk/contrib/server-side/mod_setlocale: ./ README mod_setlocale.c
On Mon, Jan 16, 2012 at 10:37 AM, wrote:
> Author: neels
> Date: Mon Jan 16 16:37:17 2012
> New Revision: 1232059
>
> URL: http://svn.apache.org/viewvc?rev=1232059&view=rev
> Log:
> Add mod_setlocale to contrib.
>
> * contrib/server-side/mod_setlocale/mod_setlocale.c,
> * contrib/server-side/mod_setlocale/README:
> New files.
>
> Patch by: danielsh (mod_setlocale.c), me (README file)
I am concerned about this (and followup) commits.
For the last several years, my understanding is that contrib/ has been
deprecated. We don't ship it with the release tarballs. We've even
been asking folks to move stuff out, where possible. The Subversion
project should not be a "hoster of {last,first} resort" when it comes
to Subversion-related code.
While I don't doubt the utility or quality of this code, contrib/ is
not the place for it to live.
-Hyrum
Re: svn commit: r1232059 - in /subversion/trunk/contrib/server-side/mod_setlocale: ./ README mod_setlocale.c
2012/1/17 Hyrum K Wright :
> On Mon, Jan 16, 2012 at 10:37 AM, wrote:
>> Author: neels
>> Date: Mon Jan 16 16:37:17 2012
>> New Revision: 1232059
>>
>> URL: http://svn.apache.org/viewvc?rev=1232059&view=rev
>> Log:
>> Add mod_setlocale to contrib.
>>
>> * contrib/server-side/mod_setlocale/mod_setlocale.c,
>> * contrib/server-side/mod_setlocale/README:
>> New files.
>>
>> Patch by: danielsh (mod_setlocale.c), me (README file)
>
> I am concerned about this (and followup) commits.
>
> For the last several years, my understanding is that contrib/ has been
> deprecated. We don't ship it with the release tarballs. We've even
> been asking folks to move stuff out, where possible. The Subversion
> project should not be a "hoster of {last,first} resort" when it comes
> to Subversion-related code.
>
> While I don't doubt the utility or quality of this code, contrib/ is
> not the place for it to live.
>
How can a generic HTTPD module that affect the whole HTTPD live in
subversion's contrib?
Quoting from its README:
[[[
17 * What:
18 mod_setlocale is a minimalistic httpd module that sets the locale for
*THE
19 ENTIRE* httpd process. This also sets the native encoding of mod_dav_svn
20 and in consequence eliminates all of above problems.
]]]
You are not calling it "mod_svn_setlocale" and that rings some bells for me.
Best regards,
Konstantin Kolinko
Re: svn commit: r1232059 - in /subversion/trunk/contrib/server-side/mod_setlocale: ./ README mod_setlocale.c
On 01/17/2012 02:59 AM, Konstantin Kolinko wrote: > 2012/1/17 Hyrum K Wright : >> While I don't doubt the utility or quality of this code, contrib/ is >> not the place for it to live. So what's the status of that "subversion-extras" project? Didn't gstein at some point reserve a space on google code or something? (can't find it) I mean, we could probably host it at elego.de or sf.net or anywhere, but it sure is practical to have one common place that everyone agrees to put svn-extras in, where all committers have access, etc. How about /repos/asf/svn-extras/ for that matter? We could just 'svn mv' contrib over there and be done with it ... ? > How can a generic HTTPD module that affect the whole HTTPD live in > subversion's contrib? admittedly, it certainly is a bit too generic; but to me, it is basically a hack by some svn devs trying to help svn users sort out a common problem with mod_dav_svn -- 'svn' mentioned thrice ;) The fact that mod_setlocale is as generic is more like a coincidence from my point of view. Then again, it isn't anywhere close to the best way to address this problem generically. So we just dropped it "anywhere". ~Neels signature.asc Description: OpenPGP digital signature
Re: svn commit: r1232059 - in /subversion/trunk/contrib/server-side/mod_setlocale: ./ README mod_setlocale.c
On Tue, Jan 17, 2012 at 5:45 AM, Neels J Hofmeyr wrote: > On 01/17/2012 02:59 AM, Konstantin Kolinko wrote: >> 2012/1/17 Hyrum K Wright : >>> While I don't doubt the utility or quality of this code, contrib/ is >>> not the place for it to live. > > So what's the status of that "subversion-extras" project? Didn't gstein at > some point reserve a space on google code or something? (can't find it) > > I mean, we could probably host it at elego.de or sf.net or anywhere, but it > sure is practical to have one common place that everyone agrees to put > svn-extras in, where all committers have access, etc. > > How about /repos/asf/svn-extras/ for that matter? We could just 'svn mv' > contrib over there and be done with it ... ? That path would be a top-level project at the ASF, so we probably couldn't do that. If anything, we could move contrib/ to ^/subversion/contrib, but that seems like just a hack. Even though there already exists stuff in contrib/, my main point with regards to this particular module is that we shouldn't be adding more to contrib/. Your suggestion to use apache-extras.org is a great one, and I'd invite interested parties to pursue development there. >> How can a generic HTTPD module that affect the whole HTTPD live in >> subversion's contrib? > > admittedly, it certainly is a bit too generic; but to me, it is basically a > hack by some svn devs trying to help svn users sort out a common problem > with mod_dav_svn -- 'svn' mentioned thrice ;) > > The fact that mod_setlocale is as generic is more like a coincidence from my > point of view. Then again, it isn't anywhere close to the best way to > address this problem generically. So we just dropped it "anywhere". Exactly. I don't object to the module, per se (indeed, I don't endorse it, either), but the Subversion tree in the ASF repo is not a generic apache module hosting service. :) -Hyrum -- uberSVN: Apache Subversion Made Easy http://www.uberSVN.com/
Re: svn commit: r1232059 - in /subversion/trunk/contrib/server-side/mod_setlocale: ./ README mod_setlocale.c
Hyrum K Wright wrote on Tue, Jan 17, 2012 at 08:13:40 -0600: > Exactly. I don't object to the module, per se (indeed, I don't > endorse it, either), but the Subversion tree in the ASF repo is not a > generic apache module hosting service. :) No; it's a place for the Subversion devs to maintain code in that is useful to Subversion users.
Re: svn commit: r1232059 - in /subversion/trunk/contrib/server-side/mod_setlocale: ./ README mod_setlocale.c
On 01/17/2012 09:16 AM, Daniel Shahaf wrote: > Hyrum K Wright wrote on Tue, Jan 17, 2012 at 08:13:40 -0600: >> Exactly. I don't object to the module, per se (indeed, I don't >> endorse it, either), but the Subversion tree in the ASF repo is not a >> generic apache module hosting service. :) > > No; it's a place for the Subversion devs to maintain code in that is > useful to Subversion users. That's never been quite the definition of our contrib/ area. Historically, anything useful to Subversion users that the Subversion devs were willing to collectively maintain (and that's the key phrase here) was placed into tools/; it was the stuff that we were *not* willing to maintain that got dumped into contrib/ for lack of a better place. We no longer lack a better place thanks to the Apache Extras project, so our contrib/ area should, at a minimum, be closed to further additions. And we should gradually seek to move stuff that currently lives there either into tools/ proper (where we will accept responsibility for maintenance) or into Extras projects. -- C. Michael Pilato CollabNet <> www.collab.net <> Distributed Development On Demand signature.asc Description: OpenPGP digital signature
Re: svn commit: r1232059 - in /subversion/trunk/contrib/server-side/mod_setlocale: ./ README mod_setlocale.c
On 01/17/2012 03:26 PM, C. Michael Pilato wrote: > That's never been quite the definition of our contrib/ area. Historically, > anything useful to Subversion users that the Subversion devs were willing to > collectively maintain (and that's the key phrase here) was placed into > tools/; so I swiftly created http://code.google.com/a/apache-extras.org/p/mod-setlocale/ (and then I swiftly wanted to svnrdump load the revs into it. Long story short, it's a hassle and in the end doesn't work because apache-extras.org isn't using 1.7 yet. Replayed it semi-manually.) So mod_setlocale is now on apache-extras.org. ~Neels signature.asc Description: OpenPGP digital signature
Re: svn commit: r1232059 - in /subversion/trunk/contrib/server-side/mod_setlocale: ./ README mod_setlocale.c
On Tue, Jan 17, 2012 at 10:40 AM, Neels J Hofmeyr wrote: > On 01/17/2012 03:26 PM, C. Michael Pilato wrote: >> That's never been quite the definition of our contrib/ area. Historically, >> anything useful to Subversion users that the Subversion devs were willing to >> collectively maintain (and that's the key phrase here) was placed into >> tools/; > > so I swiftly created > http://code.google.com/a/apache-extras.org/p/mod-setlocale/ > > (and then I swiftly wanted to svnrdump load the revs into it. > Long story short, it's a hassle and in the end doesn't work because > apache-extras.org isn't using 1.7 yet. Replayed it semi-manually.) > > So mod_setlocale is now on apache-extras.org. Thanks! -Hyrum -- uberSVN: Apache Subversion Made Easy http://www.uberSVN.com/
