Re: svn commit: r943609 - in /subversion/trunk/subversion: libsvn_wc/props.c tests/cmdline/special_tests.py

2010-05-12 Thread Daniel Shahaf 
Daniel Shahaf wrote on Wed, 12 May 2010 at 23:19 +0300:
 It only affects symlinks being added on Windows

And even then, what exactly is the effect?  What code exactly is going to 
bother noticing that the property's value is not *, given that we 
promise it to always be * whenever the property is present?  :-)

Daniel
(I've always wondered why symlinks are represented as

metadata = { 'svn:special' : '*' }
data = link $target

rather than as

metadata = { 'svn:special' : 'link' }
data = $target

.)

Re: svn commit: r943609 - in /subversion/trunk/subversion: libsvn_wc/props.c tests/cmdline/special_tests.py

2010-05-12 Thread Greg Stein 
On Wed, May 12, 2010 at 16:34, Daniel Shahaf d...@daniel.shahaf.name wrote:
 Daniel Shahaf wrote on Wed, 12 May 2010 at 23:19 +0300:
 It only affects symlinks being added on Windows

 And even then, what exactly is the effect?  What code exactly is going to
 bother noticing that the property's value is not *, given that we
 promise it to always be * whenever the property is present?  :-)

 Daniel
 (I've always wondered why symlinks are represented as

    metadata = { 'svn:special' : '*' }
    data = link $target

 rather than as

    metadata = { 'svn:special' : 'link' }
    data = $target

Don't get me started. It should have been svn:symlink = $target