Re: Should tarballs contain __pycache__ dirs?
On 2022/04/04 17:50, Julian Foad wrote: > Yasuhito FUTATSUKI wrote: >>> ./build/__pycache__ >>> ./build/generator/__pycache__ >>> ./build/generator/swig/__pycache__ >>> >>> Are they supposed to be present in the tarball? >> >> I don't think they are supposed. > > Agreed. > >> Those directries should be cleaned in fast-clean and clean-swig-py >> target in Makefile.in, like "*.pyc" files. >> >> Here is a patch against trunk, but can't be applied against 1.14.x. > > I haven't tested the patch but +1 in principle. I've committed a revised patch in r1903267 yesterday, and nominated it for backport to 1.14.x now. Cheers, -- Yasuhito FUTATSUKI
Re: Should tarballs contain __pycache__ dirs?
Yasuhito FUTATSUKI wrote: >> ./build/__pycache__ >> ./build/generator/__pycache__ >> ./build/generator/swig/__pycache__ >> >> Are they supposed to be present in the tarball? > > I don't think they are supposed. Agreed. > Those directries should be cleaned in fast-clean and clean-swig-py > target in Makefile.in, like "*.pyc" files. > > Here is a patch against trunk, but can't be applied against 1.14.x. I haven't tested the patch but +1 in principle. - Julian
Re: Should tarballs contain __pycache__ dirs?
(I sent this message only for Nathan halfway by accident, so I resent
for the list)
Hello,
On 2022/04/04 8:47, Nathan Hartman wrote:
> Tarballs for prior versions (e.g., 1.14.0, 1.14.1) contain these
> (empty) directories:
>
> ./build/__pycache__
> ./build/generator/__pycache__
> ./build/generator/swig/__pycache__
>
> Are they supposed to be present in the tarball?
I don't think they are supposed.
Those directries should be cleaned in fast-clean and clean-swig-py
target in Makefile.in, like "*.pyc" files.
Here is a patch against trunk, but can't be applied against 1.14.x.
Cheers,
--
Yasuhito FUTATSUKI Index: Makefile.in
===
--- Makefile.in (revision 1899544)
+++ Makefile.in (working copy)
@@ -460,6 +460,7 @@
$(abs_srcdir)/build
$(top_srcdir)/subversion/tests/cmdline/svntest; \
do \
test -e $$d || continue; \
+ find $$d -name "__pycache__" -exec rm -rf {} ';' -prune; \
find $$d -name "*.pyc" -exec rm {} ';'; \
done
@@ -969,6 +970,7 @@
for d in $(SWIG_PY_SRC_DIR) $(SWIG_PY_DIR); \
do \
test -e $$d || continue; \
+ find $$d -name "__pycache__" -exec rm -rf {} ';' -prune; \
find $$d -name "*.pyc" -exec rm {} ';'; \
done
Should tarballs contain __pycache__ dirs?
Tarballs for prior versions (e.g., 1.14.0, 1.14.1) contain these (empty) directories: ./build/__pycache__ ./build/generator/__pycache__ ./build/generator/swig/__pycache__ Are they supposed to be present in the tarball? Thanks, Nathan
