Re: svn commit: r1399582 - /subversion/trunk/subversion/libsvn_ra_serf/util_error.c

[Ivan Zhakov]

On Thu, Oct 18, 2012 at 3:31 PM,  s...@apache.org wrote:
 Author: stsp
 Date: Thu Oct 18 11:31:20 2012
 New Revision: 1399582

 URL: http://svn.apache.org/viewvc?rev=1399582view=rev
 Log:
 * subversion/libsvn_ra_serf/util_error.c: Include ra_serf.h which contains
prototypes for functions implemented in this file.

 Modified:
 subversion/trunk/subversion/libsvn_ra_serf/util_error.c

 Modified: subversion/trunk/subversion/libsvn_ra_serf/util_error.c
 URL: 
 http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/util_error.c?rev=1399582r1=1399581r2=1399582view=diff
 ==
 --- subversion/trunk/subversion/libsvn_ra_serf/util_error.c (original)
 +++ subversion/trunk/subversion/libsvn_ra_serf/util_error.c Thu Oct 18 
 11:31:20 2012
 @@ -25,6 +25,8 @@
  #include svn_utf.h
  #include private/svn_error_private.h

 +#include libsvn_ra_serf/ra_serf.h
 +
  /*
   * Undefine the helpers for creating errors.
   *
Hi Stefan.

Thanks for fixing this. Btw we use just ra_serf.h in other places.

-- 
Ivan Zhakov

Re: svn commit: r1399582 - /subversion/trunk/subversion/libsvn_ra_serf/util_error.c

[Julian Foad]

Ivan Zhakov wrote:

  Author: stsp
  Date: Thu Oct 18 11:31:20 2012
  New Revision: 1399582
 
  URL: http://svn.apache.org/viewvc?rev=1399582view=rev
  Log:
  * subversion/libsvn_ra_serf/util_error.c: Include ra_serf.h which contains
     prototypes for functions implemented in this file.
[...]
  +#include libsvn_ra_serf/ra_serf.h
  +

 Hi Stefan.
 
 Thanks for fixing this. Btw we use just ra_serf.h in other places.

Actually it does matter: the search path for includes contains the 'subversion' 
subdirectory of the *build tree* so this only works as written when building in 
the source tree.

When including a local header, just use its basename.

I fixed this (and the same problem with some includes in 
libsvn_wc/tree_conflict_editor.c) in r1399749.

- Julian