Re: svn commit: r1425778 - in /subversion/trunk: build.conf tools/dev/fsfs-access-map.c
On Wed, Dec 26, 2012 at 8:31 AM, Stefan Fuhrmann < stefanfuhrm...@alice-dsl.de> wrote: > On 12/26/2012 12:54 PM, Bert Huijben wrote: > > One of the build.conf changes applies to __ALL_TESTS__, not to libs. > (There is no such section). > > > I took that from the diff output "libs = __ALL__". > Corrected the log message now. > > > I’m not sure why we add tools that are not used by the test tools to the > __ALL_TESTS__ target? Do you intend to run it from the test suite. (On > which platforms?) > > > No. I don't expect that tool to be used in tests. > I only want to get it built. __ALL_TESTS__ seems > to be the target we use for this purpose already > (e.g. svn-rep-sharing-stats). > > Broken window? Maybe, we need a new "just > build it" target instead of misusing __ALL_TESTS__ > as the kitchen sink? > Possibly. It may also be useful to consider whether or not we should ship tools like this. (Though, I expect that packagers would probably them out into separate packages anyway, so maybe it's moot.)
Re: svn commit: r1425778 - in /subversion/trunk: build.conf tools/dev/fsfs-access-map.c
On 12/26/2012 12:54 PM, Bert Huijben wrote: One of the build.conf changes applies to __ALL_TESTS__, not to libs. (There is no such section). I took that from the diff output "libs = __ALL__". Corrected the log message now. I’m not sure why we add tools that are not used by the test tools to the __ALL_TESTS__ target? Do you intend to run it from the test suite. (On which platforms?) No. I don't expect that tool to be used in tests. I only want to get it built. __ALL_TESTS__ seems to be the target we use for this purpose already (e.g. svn-rep-sharing-stats). Broken window? Maybe, we need a new "just build it" target instead of misusing __ALL_TESTS__ as the kitchen sink? -- Stefan^2. *From:* stef...@apache.org <mailto:stef...@apache.org> *Sent:* December 25, 2012 11:22 PM *To:* comm...@subversion.apache.org <mailto:comm...@subversion.apache.org> *Subject:* svn commit: r1425778 - in /subversion/trunk: build.conf tools/dev/fsfs-access-map.c Author: stefan2 Date: Tue Dec 25 22:22:07 2012 New Revision: 1425778 URL: http://svn.apache.org/viewvc?rev=1425778&view=rev Log: A new developer tool: take an strace from some fsfs-based operation and create a read access heat map for it. The latter gets written as BMP file along with a few stats. This allows to visualize the efficiency (or lack thereof) of our FS usage. * build.conf (libs): add new dependency (fsfs-access-map): new tool * tools/dev/fsfs-access-map.c (): new tool Added: subversion/trunk/tools/dev/fsfs-access-map.c Modified: subversion/trunk/build.conf Modified: subversion/trunk/build.conf URL: http://svn.apache.org/viewvc/subversion/trunk/build.conf?rev=1425778&r1=1425777&r2=1425778&view=diff == --- subversion/trunk/build.conf (original) +++ subversion/trunk/build.conf Tue Dec 25 22:22:07 2012 @@ -1224,7 +1224,7 @@ libs = __ALL__ ra-local-test
