Re: [dev] [st] [PATCH] Allow mouse copy-paste for programs that claim mouse to themselves by holding shift

2014-02-13 Thread Roberto E. Vargas Caballero
> Is it the application's job or the terminal's to provide an escape
> mechanism for the mouse claiming? Can an application claim
> shift+mouseclicks?

I have a similar feeling (this is the reason why I asked about
opinions), because when you are in a X environment copy/paste is
supplied by the X server, and when you are in a kernel virtual
terminal it is supplied by gpm, so  I do not really understand why
the application has to deal with the mouse. And it is true, the
patch removes the possibility of setting shift-mouse binding, and
I do not like this point.

What terminals support this feature?

Regards,

-- 
Roberto E. Vargas Caballero



Re: [dev] [st] [PATCH] Allow mouse copy-paste for programs that claim mouse to themselves by holding shift

2014-02-13 Thread Raphaël Proust
On Thu, Feb 13, 2014 at 10:02 AM, Roberto E. Vargas Caballero
 wrote:
>> Classical example of when this is required is Midnight Commander - it have
>> useful mouse integration, but copy-pasting a filename or two is sometimes a
>> nice thing to be able to do. Some other terminal emulators achieve this by
>> not sending mouse events to the program whenever "Shift" is pressed, and
>> instead processing such events themselves. This patch does just this.
>
> If nobody complaints about this patch I will apply it the next week.

I'm wondering if anyone is using dvtm with mouse features enabled.
dvtm already provides a shift+mouse for X copy-paste[0].

Is it the application's job or the terminal's to provide an escape
mechanism for the mouse claiming? Can an application claim
shift+mouseclicks?


Cheers,
-- 
__
Raphaël Proust


[0] from the man page:
   Copy and Paste
  By default dvtm captures mouse events to provide  the
actions  listed  below.
  Unfortunately  this  interferes  with the standard X
copy and paste mechanism.
  To work around this you need to hold down Shift  while
selecting  or  pasting
  text.  Alternatively you can disable mouse support at
compile time, start dvtm
  with the -M flag or toggle mouse support during runtime
with Mod-M.



Re: [dev] [st] [PATCH] Allow mouse copy-paste for programs that claim mouse to themselves by holding shift

2014-02-13 Thread Roberto E. Vargas Caballero
> Classical example of when this is required is Midnight Commander - it have
> useful mouse integration, but copy-pasting a filename or two is sometimes a
> nice thing to be able to do. Some other terminal emulators achieve this by
> not sending mouse events to the program whenever "Shift" is pressed, and
> instead processing such events themselves. This patch does just this.

If nobody complaints about this patch I will apply it the next week.

Regards,
-- 
Roberto E. Vargas Caballero



Re: [dev] [surf] [PATCH] improve title change handling

2014-02-13 Thread Quentin Rameau
> I'm weary about ifdef statements and it doesn't look like this would
> handle future versions of webkit anyway.

Yes, I'm not fond either of defining use cases with preprocessor
statements, that's why I'm rather asking if we should keep the if
check (as it is only useful for outdated versions of webkitgtk), than
enforcing that #if >= version.
Btw that's not really an ifdef but rather a comparison of constants.

I'm not sure about what you mean by handling future versions of
webkit. Do you fear that they will remove the macro in future versions
?