Re: [dev] noice and NetBSD curses
Silvan Jegen wrote: > I thought that maybe one of the programs is linked against the > non-"...w" variant of the curses library (i. e. "libncurses" instead > of "libncursesw") but it turns out that NetBSD's curses library does > not have this separation at all. Interesting stuff. Some programs, like already mentioned vifm, have ugly installers that look specifically for ncurses and ncursesw, and pkgsrc has wrappers USE_CURSES and FAKE_NCURSES for them to use the system's curses. So, yeah, you don't need additional switches for wide characters. -- caóc
Re: [dev] [dwm] [PATCH] Do not draw bar if it is hidden
Laslo Hunhold wrote:
> Maybe we can layer this check out though and do a
>
> if (m->showbar) {
> drawbar(...)
> }
>
> What do you guys think?
+1
--
caóc
Re: [dev] noice and NetBSD curses
Silvan Jegen wrote: > I thought that maybe one of the programs is linked against the > non-"...w" variant of the curses library (i. e. "libncurses" instead > of "libncursesw") but it turns out that NetBSD's curses library does > not have this separation at all. Interesting stuff. It can handle wide characters -- https://github.com/NetBSD/src/blob/trunk/lib/libcurses/cchar.c > Not sure how to debug this further. Especially not without a working > NetBSD installation (and I am lazy...). You can grab the code here https://github.com/sabotage-linux/netbsd-curses and try to link noice against it. -- caóc
Re: [dev] noice and NetBSD curses
On Sun, Aug 5, 2018 at 4:56 PM, Cág wrote: > Silvan Jegen wrote: > >> I have the same locale set up (LANG=en_US.UTF-8) and on my (Linux) >> machine, both rover and noice (compiled from tip) show the "früh.mp3" >> filename correctly without me having to set LC_ALL=C. > > Keep in mind, this is NetBSD with its own curses library. It was > suggested that it's a bug somehow covered by ncurses. I thought that maybe one of the programs is linked against the non-"...w" variant of the curses library (i. e. "libncurses" instead of "libncursesw") but it turns out that NetBSD's curses library does not have this separation at all. Interesting stuff. >> What you could try is to check what setlocale() returns in both cases. >> There may be an error when setting up the locale in the noice case. > > If I simply printf setlocale() nothing strange appears: C for COLLATE, > and en_US.UTF-8 for everything else. The same is inside noice when > spawning a shell. So the locale doesn't seem to be an issue. Not sure how to debug this further. Especially not without a working NetBSD installation (and I am lazy...). Cheers, Silvan
Re: [dev] [dwm] [PATCH] Do not draw bar if it is hidden
On Tue, Aug 7, 2018 at 11:45 AM, Laslo Hunhold wrote:
> On Mon, 6 Aug 2018 16:42:19 +0300
> Alexander Krotov wrote:
>
> Dear Alexander,
>
>> With this patch the bar can at least be hidden before opening web
>> pages that cause Xft errors.
>
> I agree with the patch, but not because of the Xft bug. We should just
> not execute code that is unnecessary.
>
> Maybe we can layer this check out though and do a
>
> if (m->showbar) {
> drawbar(...)
> }
>
> What do you guys think?
I don't mind either way as long as we don't execute code that we don't need.
Only calling drawbar() when we actually want to show the bar would
make the intent clearer.
Cheers,
Silvan
Re: [dev] [dwm] [PATCH] Do not draw bar if it is hidden
On Mon, 6 Aug 2018 16:42:19 +0300
Alexander Krotov wrote:
Dear Alexander,
> With this patch the bar can at least be hidden before opening web
> pages that cause Xft errors.
I agree with the patch, but not because of the Xft bug. We should just
not execute code that is unnecessary.
Maybe we can layer this check out though and do a
if (m->showbar) {
drawbar(...)
}
What do you guys think?
With best regards
Laslo
--
Laslo Hunhold
Re: [dev] [dwm] [PATCH] Do not draw bar if it is hidden
Hi Alexander On Mon, Aug 6, 2018 at 3:42 PM, Alexander Krotov wrote: > With this patch the bar can at least be hidden before opening web pages > that cause Xft errors. Looks good to me! There is no reason to draw the bar if you don't want to show it. Cheers, Silvan
Re: [dev] [dwm] [PATCH] Do not draw bar if it is hidden
On Mon, 2018-08-06 at 19:01 +0200, Petr Šabata wrote: > On Mon, Aug 06, 2018 at 06:10:02PM +0200, Hiltjo Posthuma wrote: > > This is not a dwm issue. Please bother the Xft developers. > > While true, there's also no point in executing the code if the > bar is hidden. Completely second that. -- David
