Re: [dev] [st] monospace rendering gaps

2019-12-06 Thread Eric Pruitt
On Sat, Dec 07, 2019 at 03:50:09AM +, sylvain.bertr...@gmail.com wrote:
> I did fool around with your patch and the dejavu font: when I forced the
> pixel size I got those gaps. Not to mention the anti-aliasing seems to be
> involved.

I don't understand how it would be possible to have the gaps if you're
forcing the sizes. Could you post a screenshot? Also, are you certain
your changes are going into effect? You could test it by setting the
bounding boxes to something ridiculously small like 0.5 for ch/cwscale
or something like 6 pixels if you're using absolute values.

Eric



Re: [dev] [st] monospace rendering gaps

2019-12-06 Thread anigger

dunno what the issue may be but i use a
fairly default config.h so i doubt it's st

On 12/7/19 4:46 AM, sylvain.bertr...@gmail.com wrote:

On Fri, Dec 06, 2019 at 08:01:41PM +0200, anigger@national.shitposting.agency 
wrote:

but i use liberation mono.


I gave a shot at liberation mono and noto mono. Both have still issues at
various scales. The best rendering seems from liberation mono, my version of
noto is quite old though.

I am still ?





Re: [dev] [st] monospace rendering gaps

2019-12-06 Thread sylvain . bertrand
On Fri, Dec 06, 2019 at 08:01:41PM +0200, anigger@national.shitposting.agency 
wrote:
> but i use liberation mono.

I gave a shot at liberation mono and noto mono. Both have still issues at
various scales. The best rendering seems from liberation mono, my version of
noto is quite old though.

I am still ?

-- 
Sylvain



Re: [dev] [st] monospace rendering gaps

2019-12-06 Thread sylvain . bertrand
On Fri, Dec 06, 2019 at 10:55:27AM -0800, Eric Pruitt wrote:
> I've had this same problem since I upgraded to Debian 10. I believe this
> is due to changes in character bounding box sizes because you can fix
> this by adjusting cwscale and chscale. On my systems, I only have
> vertical gaps, and setting chscale to 0.94 removes them. I submitted a
> patch to the mailing list to allow both values to be specified using
> absolute values of pixels instead of multipliers
> (https://lists.suckless.org/hackers/1907/16943.html) so you can ensure
> bounding boxes were always the same size regardless of what the font
> library reports character dimensions to be, but it was not committed.

I did fool around with your patch and the dejavu font: when I forced the
pixel size I got those gaps. Not to mention the anti-aliasing seems to be
involved.

It looks like we are digging out freetype/ttf demons?

-- 
Sylvain



Re: [dev] [st] monospace rendering gaps

2019-12-06 Thread Eric Pruitt
On Thu, Dec 05, 2019 at 06:19:16PM +, sylvain.bertr...@gmail.com wrote:
> I know I am walking on eggs: it seems st monospace font rendering with 
> freetype
> (I use dejavu mono) has some vertical and/or horizontal gaps (whatever the
> rendering size).
>
> To illustrate, with lynx web browser:
> https://en.wikipedia.org/wiki/Box-drawing_character#Examples
>
> I don't know what is the bottom of this, anyone?

I've had this same problem since I upgraded to Debian 10. I believe this
is due to changes in character bounding box sizes because you can fix
this by adjusting cwscale and chscale. On my systems, I only have
vertical gaps, and setting chscale to 0.94 removes them. I submitted a
patch to the mailing list to allow both values to be specified using
absolute values of pixels instead of multipliers
(https://lists.suckless.org/hackers/1907/16943.html) so you can ensure
bounding boxes were always the same size regardless of what the font
library reports character dimensions to be, but it was not committed.

Eric



Re: [dev] [st] monospace rendering gaps

2019-12-06 Thread anigger

Could it be your fonts.conf (or similar)?

The box looks fine to me (+ - | :S).

I haven't noticed anything unusual
but i use liberation mono.

On 12/5/19 8:19 PM, sylvain.bertr...@gmail.com wrote:

Hi,

I know I am walking on eggs: it seems st monospace font rendering with freetype
(I use dejavu mono) has some vertical and/or horizontal gaps (whatever the
rendering size).

To illustrate, with lynx web browser:
https://en.wikipedia.org/wiki/Box-drawing_character#Examples
   
I don't know what is the bottom of this, anyone?