Re: [dev] dmenu tip build error

2012-01-25 Thread Carsten Mattner
On Wed, Jan 25, 2012 at 11:52 AM, Aragon Gouveia  wrote:
> On 01/25/12 12:26, Connor Lane Smith wrote:
>>
>> I think that patch is GNU-specific. The problem is that using
>> -D_POSIX_C_SOURCE=2 was breaking builds on FreeBSD
>
>
> FWIW, my update to FreeBSD's dmenu port patches those bits, so it's probably
> OK if you don't worry too much about it for FreeBSD. :)

It's preferable to have it build out of the box.
Should be easy to find a fix without relying on autoconf to check the function,
shouldn't it?



[dev] dmenu tip build error

2012-01-25 Thread Carsten Mattner
Hi,

it seems that the commit 484:0b6490d9a62b "remove _POSIX_C_SOURCE cflag"
broke the build on at least Fedora 16.

The following patch fixes it on Fedora 16. I haven't tested it on anything else.

diff -r 1659395e4de0 stest.c
--- a/stest.c   Thu Jan 19 22:52:17 2012 +
+++ b/stest.c   Wed Jan 25 10:39:21 2012 +0100
@@ -6,6 +6,7 @@
 #include 
 #include 
 #include 
+#include 

 #define FLAG(x)  (flag[(x)-'a'])