[dev] [dwm] pertag and struct Monitor issues
Hello, I've stumbled upon this while trying to add gaplessgrid layout to my dwm. In pertag patch, the struct Monitor is moved after the '#include "config.h"' line, so it will know about 'tags' variable I guess. But the nasty thing is, layout patches like gaplessgrid need to know Monitor when compiled. I've solved this by moving the whole Monitor struct to config.h, but that looks kind of stupid to me, but so far I don't know any other solution. We can't predecleare tags in dwm.c, for we don't know it's size yet. And so I run out of ideas. Is there any other way than moving this struct to config.h? Regards, Ted
Re: [dev] [dwm] pertag and struct Monitor issues
2009/9/29 Tadeusz Sośnierz : > And so I run out of ideas. Is there any > other way than moving this struct to config.h? I guess you can include gaplessgrid.h in dwm.c right after Monitor structure declaration. -- Sidney Amani
Re: [dev] [dwm] pertag and struct Monitor issues
2009/9/29 Tadeusz Sośnierz : > Hello, > I've stumbled upon this while trying to add gaplessgrid layout to my > dwm. In pertag patch, the struct Monitor is moved after the '#include > "config.h"' line, so it will know about 'tags' variable I guess. But > the nasty thing is, layout patches like gaplessgrid need to know > Monitor when compiled. I've solved this by moving the whole Monitor > struct to config.h, but that looks kind of stupid to me, but so far I > don't know any other solution. We can't predecleare tags in dwm.c, for > we don't know it's size yet. And so I run out of ideas. Is there any > other way than moving this struct to config.h? > Regards, > Ted Would it make sense to add a void *aux; to Monitor, that patches don't need to screw around with dwm.c? Kind regards, Anselm
Re: [dev] [dwm] pertag and struct Monitor issues
Hiho, > > But the nasty thing is, layout patches like gaplessgrid need to know > > Monitor when compiled. I thought the same, when writing nmaster+bstack, but then nsz has rewritten it in its current form, and it doesn't need to know Monitor. Look at http://dwm.suckless.org/patches/nmaster-sym.c The trick is to use an external array indexed by monitor. This might or might not do the trick for you. > Would it make sense to add a > > void *aux; > > to Monitor, that patches don't need to screw around with dwm.c? IMHO this would be really ugly and patches mucking up dwm.c would be preferable to this. Regards, Mate
Re: [dev] [dwm] pertag and struct Monitor issues
On Wed, Sep 30, 2009 at 9:37 AM, Mate Nagy wrote: >> Would it make sense to add a >> >> void *aux; >> >> to Monitor, that patches don't need to screw around with dwm.c? > IMHO this would be really ugly and patches mucking up dwm.c would be > preferable to this. > I agree, and it wouldn't work when mixing patches. -- Sidney Amani
