Re: [dev] [st] minor issue and scrollback patch

[Mitt Green]

Bryan Bennett wrote:


Unless I'm reading this improperly, the cursor's color would still
change because of the
if-block between line 3858 and ~3875.


Even if the colour changes, I can't see it.


It looks like you could simply
remove the if-statement
that Pickfire is mentioning entirely and structure it so that it
always uses the "if" case.


If I remove the block entirely, cursor disappears completely.

Re: [dev] [st] minor issue and scrollback patch

[Bryan Bennett]

Unless I'm reading this improperly, the cursor's color would still
change because of the
if-block between line 3858 and ~3875. It looks like you could simply
remove the if-statement
that Pickfire is mentioning entirely and structure it so that it
always uses the "if" case.

Re: [dev] [st] minor issue and scrollback patch

[Pickfire]

On Fri, Apr 08, 2016 at 10:26:38PM +0300, Mitt Green wrote:

Draco Metallium wrote:


Did you ever change config.def.h? By hand or maybe with another patch?


I did, by hand, after first clone from git. You know, there was no
config.h, so instead of copying config.def.h, I changed the latter.


If so, just add "#define histsize 2000" to it
(just after "static int borderpx..."), and compile.
Remember to remove config.h, or you will
have to add the line to it as well.


So, I put "#define ..." to both manually and now it's fine.
Thanks.

So, I wonder if cursor shape on inactive terminals could be changed,
'tis always an empty block [1].

[1]: http://imgur.com/IPQSa1O


I guess you could just remove `& WIN_FOCUSED` in st.c:

   if (xw.state & WIN_FOCUSED) {

--
_
< Do what you like, like what you do. >
-
   \   ^__^
\  (oo)\___
   (__)\   )\/\
   ||w |
   || ||

Re: [dev] [st] minor issue and scrollback patch

[Mitt Green]

Draco Metallium wrote:


Did you ever change config.def.h? By hand or maybe with another patch?


I did, by hand, after first clone from git. You know, there was no
config.h, so instead of copying config.def.h, I changed the latter.


If so, just add "#define histsize 2000" to it
(just after "static int borderpx..."), and compile.
Remember to remove config.h, or you will
have to add the line to it as well.


So, I put "#define ..." to both manually and now it's fine.
Thanks.

So, I wonder if cursor shape on inactive terminals could be changed,
'tis always an empty block [1].

[1]: http://imgur.com/IPQSa1O

Cheers,
Mitt

Re: [dev] [st] minor issue and scrollback patch

[Rodrigo S. Cañibano]

> 2) Trying to apply the patch [1] leads to:
> 
> patching file config.h
> HUNK #1 failed at 7

Did you ever change config.def.h? By hand or maybe with another patch?

If so, just add "#define histsize 2000" to it (just after "static int
borderpx..."), and compile. Remember to remove config.h, or you will
have to add the line to it as well.

[dev] [st] minor issue and scrollback patch

[Mitt Green]

Hi everyone,

1) In st I use underline as a cursor, but whatever cursor
I choose, on inactive window there is always an empty block.

2) Trying to apply the patch [1] leads to:

patching file config.h
HUNK #1 failed at 7

...
[I changed config.def.h to config.h,
but even if not, it doesn't change the result]
...

$ make CC=tcc
st.c:373: error: 'histsize' undeclared



config.[def].h.rej contains
+#define histsize 2000
on line 7.

No other errors.

[1]: http://st.suckless.org/patches/scrollback

Thanks,
Mitt