Re: [dev] Xft patch dwm 6.0
Because I'm a doofus : ) Damn that Xft documentation! If I only knew
XftColorAllocName existed, uhgg. Thanks David! I'm almost
certain from looking at that, that it will fix my problem. And yea I'm
aware of the XSetForegroundColor, : ) Thanks a bunch!
On Tue, May 15, 2012 at 9:34 PM, David Dufberg Töttrup da...@dufberg.sewrote:
On May 15 2012, Lee Fallat wrote:
There is one bug. For some reason, The colors for the font are affected by
the previous color 'parsed' by XAllocNamedColor. If someone could check
out
getcolor() and figure what is wrong, that'd be great. I'd really like to
make this patch *perfect* before throwing it up on suckless.
Don't know why you do the converting thingie. Why not use
XftColorAllocName?
Like this (untested, but similar works in a program I wrote):
XftColor getcolor(const char *colstr) {
XftColor color;
if(!XftColorAllocName(dpy, visual, cmap, colstr, color))
die(error, cannot allocate color '%s'\n, colstr);
return color;
}
Also you don't need to XSetForeground before XftDrawStringUtf8 in drawtext.
David
Re: [dev] Xft patch dwm 6.0
Nope, sorry David, it didn't work either. The same result occurs, just with less code : P Damn what a problem!
Re: [dev] Xft patch dwm 6.0
Here is the latest xft patch, works with tip, not sure about 6.0. It does work with the default config file though, so high hopes. : ) Changes: Changed drawtext, drawsquare, and getcolor to work with XftColors. Made it convert colors at the beginning to save resources later on instead of originally converting on the fly. No memory leaks (from what i know, thanks for your patch before Lars!) I think that's it. There is one bug. For some reason, The colors for the font are affected by the previous color 'parsed' by XAllocNamedColor. If someone could check out getcolor() and figure what is wrong, that'd be great. I'd really like to make this patch *perfect* before throwing it up on suckless. Thanks! dwm-6.0-tip-xft.diff Description: Binary data
Re: [dev] Xft patch dwm 6.0
Hey Lars, I guess I really should have uploaded a fixed version sooner as I too noticed this a week later I made this patch. It now works (from what I've seen) flawlessly with dwm-tip and I've gotten rid of the nasty XLFD format. I'll upload it tomorrow. Sorry for the hassle! It's my first time working with Xft/X in general. Guess that teaches me to do more rigorous testing before hand, eh? On Sun, May 13, 2012 at 6:18 PM, Lars L lars.lindqvist...@gmail.com wrote: On 30/03, Lee Fallat wrote: Alright, sorry for all the confusion. Here is the unified patch! Be sure to have dejavu font installed to experience the utf8ness ; ) Since I applied this patch a few days ago I've had Xorg grind to a halt several times, after slowly eating up all my ram Xorg ended up in an infinite SIGALRM loop using all available cpu cycles. Rudimentary testing seems to suggest that attached diff solves the problem. -- Lars
Re: [dev] Xft patch dwm 6.0
Would it just be better if I pushed my changes to the wiki?
[dev] Xft patch dwm 6.0
Hey, I have implemented Xft support into dwm 6.0 and I'd like to ask, how could I submit my patch for reviewing to you guys (if you even review)?
Re: [dev] Xft patch dwm 6.0
On 03/30/12 at 11:50am, Lee Fallat wrote: Hey, I have implemented Xft support into dwm 6.0 and I'd like to ask, how could I submit my patch for reviewing to you guys (if you even review)? Send an email to this list with an attachment or commit to the wiki. -- Hannes Blut pgpctVajhNM8I.pgp Description: PGP signature
Re: [dev] Xft patch dwm 6.0
On 30 March 2012 17:50, Lee Fallat ircsurfe...@gmail.com wrote: Hey, I have implemented Xft support into dwm 6.0 and I'd like to ask, how could I submit my patch for reviewing to you guys (if you even review)? Add it to the wiki. See http://suckless.org/wiki for details. Cheers, Anselm
Re: [dev] Xft patch dwm 6.0
Well I'm not sure how to put everything into one patch file, but here they are. dwm-6.0-xft.patch Description: Binary data dwm-6.0-xft-config-mk.patch Description: Binary data
Re: [dev] Xft patch dwm 6.0
On Fri, Mar 30, 2012 at 01:41:47PM -0400, Lee Fallat wrote: Well I'm not sure how to put everything into one patch file, but here they are. Generate a unified diff instead (diff -u), then you can just cat them together. Paul. -- Paul Hoffman nkui...@nkuitse.com
Re: [dev] Xft patch dwm 6.0
Alright, sorry for all the confusion. Here is the unified patch! Be sure to have dejavu font installed to experience the utf8ness ; ) dwm-6.0-xft.patch Description: Binary data
