Re: [dev] [surf] [PATCH] improve title change handling

[Quentin Rameau]

 I'm weary about ifdef statements and it doesn't look like this would
 handle future versions of webkit anyway.

Yes, I'm not fond either of defining use cases with preprocessor
statements, that's why I'm rather asking if we should keep the if
check (as it is only useful for outdated versions of webkitgtk), than
enforcing that #if = version.
Btw that's not really an ifdef but rather a comparison of constants.

I'm not sure about what you mean by handling future versions of
webkit. Do you fear that they will remove the macro in future versions
?

Re: [dev] [surf] [PATCH] improve title change handling

[Quentin Rameau]

Here is another patch, I'm not sure we should handle multiple versions
of webkitgtk. But as this bug is corrected in newer (recent, stable)
versions of webkitgtk, should we remove the needless workaround and
assume user has a valid version of webkitgtk ?


0001-Webkitgtk-1.11.5-fixes-anchor-title-handling.patch
Description: Binary data

Re: [dev] [surf] [PATCH] improve title change handling

[Carlos Torres]

I'm weary about ifdef statements and it doesn't look like this would
handle future versions of webkit anyway.

--Carlos

On 2/9/14, Quentin Rameau quinq...@gmail.com wrote:
 Here is another patch, I'm not sure we should handle multiple versions
 of webkitgtk. But as this bug is corrected in newer (recent, stable)
 versions of webkitgtk, should we remove the needless workaround and
 assume user has a valid version of webkitgtk ?