Superset Drill Time Range Filter

[Z0ltrix]

Hello superset devs,

we have a problem with our superset -> drill connection with time range filters.

When we filter a dashboard by time range (last week, month, etc.) i get an 

SYSTEM ERROR: ClassCastException: 
org.apache.drill.exec.expr.holders.NullableTimeStampHolder cannot be cast to 
org.apache.drill.exec.expr.holders.TimeStampHolder

from drill.

I dont want to talk here too much about the drill error because this is a topic 
for the drill project, but i think we could solve this also by adding something 
to db_engine_specs/drill.py

Superset sends the following to drill:

WHERE `startTime` >= '2022-02-14 00:00:00.00'
  AND `startTime` < '2022-02-21 00:00:00.00'
ORDER BY `startTime` DESC

Superset should send the following filter:
WHERE `startTime` >= TIMESTAMP '2022-02-14 00:00:00.00'
  AND `startTime` < TIMESTAMP '2022-02-21 00:00:00.00'
ORDER BY `startTime` DESC

My Question is, which classmethod of BaseEngineSpec must be overwritten and 
maybe you could give me a hint how i could do this.
If im aware what to do, i can create a PR for this.

Regards,
Christian

publickey - z0ltrix@pm.me - 0xF0E154C5.asc
Description: application/pgp-keys


signature.asc
Description: OpenPGP digital signature

Re: Superset Drill Time Range Filter

[Ville Brofeldt]

Hi Christian,

you should be able to change how dates/datetimes/timestamps are formatted for 
Drill connections here: 
https://github.com/apache/superset/blob/700829b74ae7093a3985b44a45376973a48eb1fe/superset/db_engine_specs/drill.py#L57-L67
 


However, it appears you’re not hitting either of those formatters, so there 
might actually be a bug that we need to look into. Please feel free to open up 
a bug ticket on GitHub so we can continue the discussion there.

Ville

> On 23. Feb 2022, at 11.49, Z0ltrix  wrote:
> 
> Hello superset devs,
> 
> we have a problem with our superset -> drill connection with time range 
> filters.
> 
> When we filter a dashboard by time range (last week, month, etc.) i get an 
> SYSTEM ERROR: ClassCastException: 
> org.apache.drill.exec.expr.holders.NullableTimeStampHolder cannot be cast to 
> org.apache.drill.exec.expr.holders.TimeStampHolder
> from drill.
> 
> I dont want to talk here too much about the drill error because this is a 
> topic for the drill project, but i think we could solve this also by adding 
> something to db_engine_specs/drill.py
> 
> Superset sends the following to drill:
> WHERE `startTime` >= '2022-02-14 00:00:00.00'
>   AND `startTime` < '2022-02-21 00:00:00.00'
> ORDER BY `startTime` DESC
> 
> Superset should send the following filter:
> WHERE `startTime` >= TIMESTAMP '2022-02-14 00:00:00.00'
>   AND `startTime` < TIMESTAMP '2022-02-21 00:00:00.00'
> ORDER BY `startTime` DESC
> 
> My Question is, which classmethod of BaseEngineSpec must be overwritten and 
> maybe you could give me a hint how i could do this.
> If im aware what to do, i can create a PR for this.
> 
> Regards,
> Christian
> 
> 

AW: Re: Superset Drill Time Range Filter

[Z0ltrix]

Done -> https://github.com/apache/superset/issues/18869 


--- Original Message ---

Ville Brofeldt  schrieb am Mittwoch, 23. Februar 
2022 um 11:01:

> Hi Christian,
> 

> you should be able to change how dates/datetimes/timestamps are formatted for 
> Drill connections here: 
> https://github.com/apache/superset/blob/700829b74ae7093a3985b44a45376973a48eb1fe/superset/db_engine_specs/drill.py#L57-L67
>  
> https://github.com/apache/superset/blob/700829b74ae7093a3985b44a45376973a48eb1fe/superset/db_engine_specs/drill.py#L57-L67
> 

> However, it appears you’re not hitting either of those formatters, so there 
> might actually be a bug that we need to look into. Please feel free to open 
> up a bug ticket on GitHub so we can continue the discussion there.
> 

> Ville
> 

> > On 23. Feb 2022, at 11.49, Z0ltrix z0lt...@pm.me.INVALID wrote:
> > 

> > Hello superset devs,
> > 

> > we have a problem with our superset -> drill connection with time range 
> > filters.
> > 

> > When we filter a dashboard by time range (last week, month, etc.) i get an
> > 

> > SYSTEM ERROR: ClassCastException: 
> > org.apache.drill.exec.expr.holders.NullableTimeStampHolder cannot be cast 
> > to org.apache.drill.exec.expr.holders.TimeStampHolder
> > 

> > from drill.
> > 

> > I dont want to talk here too much about the drill error because this is a 
> > topic for the drill project, but i think we could solve this also by adding 
> > something to db_engine_specs/drill.py
> > 

> > Superset sends the following to drill:
> > 

> > WHERE `startTime` >= '2022-02-14 00:00:00.00'
> > 

> > AND `startTime` < '2022-02-21 00:00:00.00'
> > 

> > ORDER BY `startTime` DESC
> > 

> > Superset should send the following filter:
> > 

> > WHERE `startTime` >= TIMESTAMP '2022-02-14 00:00:00.00'
> > 

> > AND `startTime` < TIMESTAMP '2022-02-21 00:00:00.00'
> > 

> > ORDER BY `startTime` DESC
> > 

> > My Question is, which classmethod of BaseEngineSpec must be overwritten and 
> > maybe you could give me a hint how i could do this.
> > 

> > If im aware what to do, i can create a PR for this.
> > 

> > Regards,
> > 

> > Christian
> > 

> > 

publickey - z0ltrix@pm.me - 0xF0E154C5.asc
Description: application/pgp-keys


signature.asc
Description: OpenPGP digital signature

[jira] [Created] (SUPERSET-16) Stalebot has stopped working on GitHub repo

[Ville Brofeldt (Jira)]

Ville Brofeldt created SUPERSET-16:
--

 Summary: Stalebot has stopped working on GitHub repo
 Key: SUPERSET-16
 URL: https://issues.apache.org/jira/browse/SUPERSET-16
 Project: Superset
  Issue Type: Task
Reporter: Ville Brofeldt


We've noticed that Stalebot has stopped marking stale issues/PRs as stale and 
closing old ones some time ago. This appears to have happened sometime in mid 
2021. I don't believe anyone has requested deactivation of it, and we would 
need to reactivate it. This is fairly critical, as we've done a fair bit of 
pruning and labelling on recent issues/PRs, but need to clean out the old ones.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

[RESULT][VOTE][SIP-74] Breaking Changes to include in Superset 2.0 -- and next steps

[Aaron Suddjian]

Hi everyone,

The vote for SIP-74 is now closed. The vote PASSED with a whopping 17
binding +1 votes, 0 non-binding, and 0 against.

Thank you all for your efforts and votes on this SIP!

*Next steps:*

We need to set up a protected GitHub branch lts-v1, then we can start
merging breaking changes on master. I have put together a kanban board to
track the 2.0 tasks from the SIP:
https://github.com/orgs/apache/projects/32/

Would someone who knows how to alter GitHub settings help with setting up
the lts-v1 branch, and then announce on the devlist and on Slack that we
intend to begin merging breaking changes on master? There is a task for
that in the project linked above. This branch will also need to behave like
a main branch in CI, but feel free to split that into a separate task if
desired.

-- 
Aaron Suddjian, Software Engineer at Preset

[jira] [Updated] (SUPERSET-16) Stalebot has stopped working on Superset GitHub repo

[Ville Brofeldt (Jira)]

 [ 
https://issues.apache.org/jira/browse/SUPERSET-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ville Brofeldt updated SUPERSET-16:
---
Summary: Stalebot has stopped working on Superset GitHub repo  (was: 
Stalebot has stopped working on GitHub repo)

> Stalebot has stopped working on Superset GitHub repo
> 
>
> Key: SUPERSET-16
> URL: https://issues.apache.org/jira/browse/SUPERSET-16
> Project: Superset
>  Issue Type: Task
>Reporter: Ville Brofeldt
>Priority: Critical
>
> We've noticed that Stalebot has stopped marking stale issues/PRs as stale and 
> closing old ones some time ago. This appears to have happened sometime in mid 
> 2021. I don't believe anyone has requested deactivation of it, and we would 
> need to reactivate it. This is fairly critical, as we've done a fair bit of 
> pruning and labelling on recent issues/PRs, but need to clean out the old 
> ones.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)