[GitHub] ManojKumarMaurya opened a new issue #4685: superset dashboard is blank

[GitBox]

ManojKumarMaurya opened a new issue #4685: superset dashboard is blank 
URL: https://github.com/apache/incubator-superset/issues/4685
 
 
   Make sure these boxes are checked before submitting your issue - thank you!
   
   
   
   
/home/ubuntu/code/superset/local/lib/python2.7/site-packages/flask_appbuilder/fields.py:152:
 UserWarning: allow_blank=True does not do anything for 
QuerySelectMultipleField.
 warnings.warn('allow_blank=True does not do anything for 
QuerySelectMultipleField.')
   
   
   - [x] I have checked the superset logs for python stack traces and included 
it here as text if any
   - [x] I have reproduced the issue with at least the latest released version 
of superset
   - [x] I have checked the issue tracker for the same issue and I haven't 
found one similar
   
   
   
   
   ### Superset version
   0.23.3
   
   ### Expected results
   superset should work 
   
   ### Actual results
   dashboard blank 
   
/home/ubuntu/code/superset/local/lib/python2.7/site-packages/flask_appbuilder/fields.py:152:
 UserWarning: allow_blank=True does not do anything for 
QuerySelectMultipleField.
 warnings.warn('allow_blank=True does not do anything for 
QuerySelectMultipleField.')
   
   
   ### Steps to reproduce
   
   
/home/ubuntu/code/superset/local/lib/python2.7/site-packages/flask_appbuilder/fields.py:152:
 UserWarning: allow_blank=True does not do anything for 
QuerySelectMultipleField.
 warnings.warn('allow_blank=True does not do anything for 
QuerySelectMultipleField.')
   
   
   https://user-images.githubusercontent.com/5546605/37859853-7f10e3f6-2f40-11e8-8443-5d047e774d43.png;>
   https://user-images.githubusercontent.com/5546605/37859854-7f4abf5e-2f40-11e8-960c-8d1473fd4198.png;>
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wffger commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2'

[GitBox]

wffger commented on issue #2217: Was unable to import superset Error: No module 
named 'pysqlite2'
URL: 
https://github.com/apache/incubator-superset/issues/2217#issuecomment-375840479
 
 
   > [root@devn ~]# cd /opt/python-env/Superset/  
   > [root@devn Superset]# source ./bin/activate
   > (Superset) [root@devn Superset]# pip -V
   > pip 9.0.3 from /opt/python-env/Superset/lib/python3.4/site-packages 
(python 3.4)
   > (Superset) [root@devn Superset]# python -V  
   > Python 3.4.8  
   > (Superset) [root@devn Superset]# pip show superset  
   > Name: superset  
   > Version: 0.23.3  
   > Summary: A interactive data visualization platform build on SqlAlchemy and 
druid.io  
   > Home-page: https://github.com/airbnb/superset  
   > Author: Maxime Beauchemin
   > Author-email: maximebeauche...@gmail.com
   > License: Apache License, Version 2.0
   > Location: /opt/python-env/Superset/lib/python3.4/site-packages
   > Requires: boto3, celery, colorama, cryptography, flask, flask-appbuilder, 
flask-cache, flask-migrate, flask-script, flask-sqlalchemy, flask-testing, 
flask-wtf, flower, future, python-geohash, humanize, gunicorn, idna, markdown, 
pandas, parsedatetime, pathlib2, polyline, pydruid, PyHive, python-dateutil, 
pyyaml, requests, simplejson, six, sqlalchemy, sqlalchemy-utils, sqlparse, 
thrift, thrift-sasl, unidecode, bleach


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wffger commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2'

[GitBox]

wffger commented on issue #2217: Was unable to import superset Error: No module 
named 'pysqlite2'
URL: 
https://github.com/apache/incubator-superset/issues/2217#issuecomment-375840479
 
 
   `[root@devn ~]# cd /opt/python-env/Superset/  
   [root@devn Superset]# source ./bin/activate
   (Superset) [root@devn Superset]# pip -V
   pip 9.0.3 from /opt/python-env/Superset/lib/python3.4/site-packages (python 
3.4)
   (Superset) [root@devn Superset]# python -V  
   Python 3.4.8  
   (Superset) [root@devn Superset]# pip show superset  
   Name: superset  
   Version: 0.23.3  
   Summary: A interactive data visualization platform build on SqlAlchemy and 
druid.io  
   Home-page: https://github.com/airbnb/superset  
   Author: Maxime Beauchemin
   Author-email: maximebeauche...@gmail.com
   License: Apache License, Version 2.0
   Location: /opt/python-env/Superset/lib/python3.4/site-packages
   Requires: boto3, celery, colorama, cryptography, flask, flask-appbuilder, 
flask-cache, flask-migrate, flask-script, flask-sqlalchemy, flask-testing, 
flask-wtf, flower, future, python-geohash, humanize, gunicorn, idna, markdown, 
pandas, parsedatetime, pathlib2, polyline, pydruid, PyHive, python-dateutil, 
pyyaml, requests, simplejson, six, sqlalchemy, sqlalchemy-utils, sqlparse, 
thrift, thrift-sasl, unidecode, bleach
   `


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wffger commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2'

[GitBox]

wffger commented on issue #2217: Was unable to import superset Error: No module 
named 'pysqlite2'
URL: 
https://github.com/apache/incubator-superset/issues/2217#issuecomment-375840479
 
 
   `[root@devn ~]# cd /opt/python-env/Superset/
   [root@devn Superset]# source ./bin/activate
   (Superset) [root@devn Superset]# 
   (Superset) [root@devn Superset]# 
   (Superset) [root@devn Superset]# 
   (Superset) [root@devn Superset]# 
   (Superset) [root@devn Superset]# pip -V
   pip 9.0.3 from /opt/python-env/Superset/lib/python3.4/site-packages (python 
3.4)
   (Superset) [root@devn Superset]# python -V  
   Python 3.4.8  
   (Superset) [root@devn Superset]# pip show superset  
   Name: superset  
   Version: 0.23.3  
   Summary: A interactive data visualization platform build on SqlAlchemy and 
druid.io  
   Home-page: https://github.com/airbnb/superset  
   Author: Maxime Beauchemin
   Author-email: maximebeauche...@gmail.com
   License: Apache License, Version 2.0
   Location: /opt/python-env/Superset/lib/python3.4/site-packages
   Requires: boto3, celery, colorama, cryptography, flask, flask-appbuilder, 
flask-cache, flask-migrate, flask-script, flask-sqlalchemy, flask-testing, 
flask-wtf, flower, future, python-geohash, humanize, gunicorn, idna, markdown, 
pandas, parsedatetime, pathlib2, polyline, pydruid, PyHive, python-dateutil, 
pyyaml, requests, simplejson, six, sqlalchemy, sqlalchemy-utils, sqlparse, 
thrift, thrift-sasl, unidecode, bleach
   `


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4684: Fix up the Lyft color scheme

[GitBox]

codecov-io commented on issue #4684: Fix up the Lyft color scheme
URL: 
https://github.com/apache/incubator-superset/pull/4684#issuecomment-375839789
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4684?src=pr=h1)
 Report
   > Merging 
[#4684](https://codecov.io/gh/apache/incubator-superset/pull/4684?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/9abc5c724ff878ca92edce3e074ce6a4d9ea60b9?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4684/graphs/tree.svg?src=pr=KsB0fHcx6l=650=150)](https://codecov.io/gh/apache/incubator-superset/pull/4684?src=pr=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #4684   +/-   ##
   ==
 Coverage71.4%   71.4%   
   ==
 Files 190 190   
 Lines   14935   14935   
 Branches 11021102   
   ==
 Hits10664   10664   
 Misses   42684268   
 Partials3   3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4684?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/assets/javascripts/modules/colors.js](https://codecov.io/gh/apache/incubator-superset/pull/4684/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL21vZHVsZXMvY29sb3JzLmpz)
 | `77.08% <ø> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4684?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4684?src=pr=footer).
 Last update 
[9abc5c7...ade5670](https://codecov.io/gh/apache/incubator-superset/pull/4684?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wffger commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2'

[GitBox]

wffger commented on issue #2217: Was unable to import superset Error: No module 
named 'pysqlite2'
URL: 
https://github.com/apache/incubator-superset/issues/2217#issuecomment-375840479
 
 
   `[root@devn ~]# cd /opt/python-env/Superset/
   [root@devn Superset]# source ./bin/activate
   (Superset) [root@devn Superset]# 
   (Superset) [root@devn Superset]# 
   (Superset) [root@devn Superset]# 
   (Superset) [root@devn Superset]# 
   (Superset) [root@devn Superset]# pip -V
   pip 9.0.3 from /opt/python-env/Superset/lib/python3.4/site-packages (python 
3.4)
   (Superset) [root@devn Superset]# python -V
   Python 3.4.8
   (Superset) [root@devn Superset]# pip show superset
   Name: superset
   Version: 0.23.3
   Summary: A interactive data visualization platform build on SqlAlchemy and 
druid.io
   Home-page: https://github.com/airbnb/superset
   Author: Maxime Beauchemin
   Author-email: maximebeauche...@gmail.com
   License: Apache License, Version 2.0
   Location: /opt/python-env/Superset/lib/python3.4/site-packages
   Requires: boto3, celery, colorama, cryptography, flask, flask-appbuilder, 
flask-cache, flask-migrate, flask-script, flask-sqlalchemy, flask-testing, 
flask-wtf, flower, future, python-geohash, humanize, gunicorn, idna, markdown, 
pandas, parsedatetime, pathlib2, polyline, pydruid, PyHive, python-dateutil, 
pyyaml, requests, simplejson, six, sqlalchemy, sqlalchemy-utils, sqlparse, 
thrift, thrift-sasl, unidecode, bleach
   `


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wffger commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2'

[GitBox]

wffger commented on issue #2217: Was unable to import superset Error: No module 
named 'pysqlite2'
URL: 
https://github.com/apache/incubator-superset/issues/2217#issuecomment-375840479
 
 
   `[root@devn ~]# cd /opt/python-env/Superset/
   [root@devn Superset]# source ./bin/activate
   (Superset) [root@devn Superset]# 
   (Superset) [root@devn Superset]# 
   (Superset) [root@devn Superset]# 
   (Superset) [root@devn Superset]# 
   (Superset) [root@devn Superset]# pip -V
   pip 9.0.3 from /opt/python-env/Superset/lib/python3.4/site-packages (python 
3.4)
   (Superset) [root@devn Superset]# python -V
   Python 3.4.8
   (Superset) [root@devn Superset]# pip show superset
   Name: superset
   Version: 0.23.3
   Summary: A interactive data visualization platform build on SqlAlchemy and 
druid.io
   Home-page: https://github.com/airbnb/superset
   Author: Maxime Beauchemin
   Author-email: maximebeauche...@gmail.com
   License: Apache License, Version 2.0
   Location: /opt/python-env/Superset/lib/python3.4/site-packages
   Requires: boto3, celery, colorama, cryptography, flask, flask-appbuilder, 
flask-cache, flask-migrate, flask-script, flask-sqlalchemy, flask-testing, 
flask-wtf, flower, future, python-geohash, humanize, gunicorn, idna, markdown, 
pandas, parsedatetime, pathlib2, polyline, pydruid, PyHive, python-dateutil, 
pyyaml, requests, simplejson, six, sqlalchemy, sqlalchemy-utils, sqlparse, 
thrift, thrift-sasl, unidecode, bleach
   
   `


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4684: Fix up the Lyft color scheme

[GitBox]

codecov-io commented on issue #4684: Fix up the Lyft color scheme
URL: 
https://github.com/apache/incubator-superset/pull/4684#issuecomment-375839789
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4684?src=pr=h1)
 Report
   > Merging 
[#4684](https://codecov.io/gh/apache/incubator-superset/pull/4684?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/9abc5c724ff878ca92edce3e074ce6a4d9ea60b9?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4684/graphs/tree.svg?src=pr=KsB0fHcx6l=650=150)](https://codecov.io/gh/apache/incubator-superset/pull/4684?src=pr=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #4684   +/-   ##
   ==
 Coverage71.4%   71.4%   
   ==
 Files 190 190   
 Lines   14935   14935   
 Branches 11021102   
   ==
 Hits10664   10664   
 Misses   42684268   
 Partials3   3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4684?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/assets/javascripts/modules/colors.js](https://codecov.io/gh/apache/incubator-superset/pull/4684/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL21vZHVsZXMvY29sb3JzLmpz)
 | `77.08% <ø> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4684?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4684?src=pr=footer).
 Last update 
[9abc5c7...e18ce5e](https://codecov.io/gh/apache/incubator-superset/pull/4684?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hughhhh commented on issue #4684: Fix up the Lyft color scheme

[GitBox]

hug commented on issue #4684: Fix up the Lyft color scheme
URL: 
https://github.com/apache/incubator-superset/pull/4684#issuecomment-375839337
 
 
   :ship:


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hughhhh commented on issue #4684: Fix up the Lyft color scheme

[GitBox]

hug commented on issue #4684: Fix up the Lyft color scheme
URL: 
https://github.com/apache/incubator-superset/pull/4684#issuecomment-375839337
 
 
   :ship:


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4680: [WiP] Hotkeys in SQL Lab

[GitBox]

codecov-io commented on issue #4680: [WiP] Hotkeys in SQL Lab
URL: 
https://github.com/apache/incubator-superset/pull/4680#issuecomment-375838321
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4680?src=pr=h1)
 Report
   > Merging 
[#4680](https://codecov.io/gh/apache/incubator-superset/pull/4680?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/76394d3f8f711c2754dbfdd0c6cf7deb6d3ef122?src=pr=desc)
 will **increase** coverage by `0.06%`.
   > The diff coverage is `87.5%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4680/graphs/tree.svg?src=pr=KsB0fHcx6l=650=150)](https://codecov.io/gh/apache/incubator-superset/pull/4680?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4680  +/-   ##
   ==
   + Coverage71.4%   71.46%   +0.06% 
   ==
 Files 190  191   +1 
 Lines   1493414956  +22 
 Branches 1102 1100   -2 
   ==
   + Hits1066310688  +25 
   + Misses   4268 4265   -3 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4680?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/assets/javascripts/components/Hotkeys.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4680/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NvbXBvbmVudHMvSG90a2V5cy5qc3g=)
 | `100% <100%> (ø)` | |
   | 
[superset/assets/javascripts/SqlLab/actions.js](https://codecov.io/gh/apache/incubator-superset/pull/4680/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9hY3Rpb25zLmpz)
 | `72.32% <100%> (ø)` | :arrow_up: |
   | 
[...javascripts/SqlLab/components/AceEditorWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4680/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIuanN4)
 | `76.47% <100%> (+1.47%)` | :arrow_up: |
   | 
[...assets/javascripts/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4680/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=)
 | `77.55% <63.63%> (+2.81%)` | :arrow_up: |
   | 
[superset/assets/javascripts/modules/colors.js](https://codecov.io/gh/apache/incubator-superset/pull/4680/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL21vZHVsZXMvY29sb3JzLmpz)
 | `77.08% <0%> (+0.48%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4680?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4680?src=pr=footer).
 Last update 
[76394d3...e8dcbf7](https://codecov.io/gh/apache/incubator-superset/pull/4680?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #4682: Add lyftColor to the game 

[GitBox]

mistercrunch closed pull request #4682: Add lyftColor to the game 
URL: https://github.com/apache/incubator-superset/pull/4682
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/backendSync.json b/superset/assets/backendSync.json
index 9e1ce4cd89..9145cc9817 100644
--- a/superset/assets/backendSync.json
+++ b/superset/assets/backendSync.json
@@ -2747,6 +2747,10 @@
 [
   "googleCategory20c",
   "googleCategory20c"
+],
+[
+  "lyftColors",
+  "lyftColors"
 ]
   ],
   "description": "The color scheme for rendering chart",
diff --git a/superset/assets/javascripts/modules/colors.js 
b/superset/assets/javascripts/modules/colors.js
index f2bba3b5a6..909a8bf0d8 100644
--- a/superset/assets/javascripts/modules/colors.js
+++ b/superset/assets/javascripts/modules/colors.js
@@ -27,6 +27,14 @@ export const bnbColors = [
   '#b37e00',
   '#988b4e',
 ];
+
+export const lyftColors = [
+  '#ff00bf', // pink
+  '#352384', // purple
+  '#333447', // carbon
+  '#f3f3f5', // silver
+];
+
 const d3Category10 = d3.scale.category10().range();
 const d3Category20 = d3.scale.category20().range();
 const d3Category20b = d3.scale.category20b().range();


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4683: Fix bug with sorting columns in group by using time shift

[GitBox]

codecov-io commented on issue #4683: Fix bug with sorting columns in group by 
using time shift
URL: 
https://github.com/apache/incubator-superset/pull/4683#issuecomment-375834201
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4683?src=pr=h1)
 Report
   > Merging 
[#4683](https://codecov.io/gh/apache/incubator-superset/pull/4683?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/00cab7e1073ba8d810b5dd323cb6fdb706ced537?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4683/graphs/tree.svg?width=650=KsB0fHcx6l=150=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4683?src=pr=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #4683   +/-   ##
   ==
 Coverage71.4%   71.4%   
   ==
 Files 190 190   
 Lines   14934   14934   
 Branches 11021102   
   ==
 Hits10663   10663   
 Misses   42684268   
 Partials3   3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4683?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4683/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5)
 | `79.62% <0%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4683?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4683?src=pr=footer).
 Last update 
[00cab7e...c94e995](https://codecov.io/gh/apache/incubator-superset/pull/4683?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] michellethomas opened a new pull request #4683: Fix bug with sorting columns in group by using time shift

[GitBox]

michellethomas opened a new pull request #4683: Fix bug with sorting columns in 
group by using time shift
URL: https://github.com/apache/incubator-superset/pull/4683
 
 
   Fixing the `'<' not supported between instances of 'str' and 'tuple'` issue 
with time shift group by line charts. 
   
   @john-bodley 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] timifasubaa commented on issue #4669: [sqllab] Using app context for processing Jinja template in async mode

[GitBox]

timifasubaa commented on issue #4669: [sqllab] Using app context for processing 
Jinja template in async mode
URL: 
https://github.com/apache/incubator-superset/pull/4669#issuecomment-375831481
 
 
   LGTM?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] timifasubaa commented on issue #4588: [sqllab] How can we make large Superset queries load faster?

[GitBox]

timifasubaa commented on issue #4588: [sqllab] How can we make large Superset 
queries load faster?
URL: 
https://github.com/apache/incubator-superset/issues/4588#issuecomment-375827342
 
 
   Some more ideas were shared at today's meeting. 
   One was having a separate flow for downloading query results as CSV. 
   Then for non csv, 
   
   Always limiting the query before sending to the db ( this should help reduce 
Presto load). The question here is that when the query is eventually run on a 
slice, it still runs the full query. Or do we want to limit that too?
   
   Another potentially separate idea is to respond early and display results on 
the frontend when the db has the first 1000 rows ready. (This can be known from 
the stats object returned from polling). THen rendering the rest when the user 
clicks to see all.
   
   We will have to have an opinion on how superset should run queries and 
communiate that clearly in the interface so users, for example don't think the 
first 1K rows is all the results there is. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] timifasubaa commented on issue #4588: [sqllab] How can we make large Superset queries load faster?

[GitBox]

timifasubaa commented on issue #4588: [sqllab] How can we make large Superset 
queries load faster?
URL: 
https://github.com/apache/incubator-superset/issues/4588#issuecomment-375827342
 
 
   Some more ideas were shared at today's meeting. 
   One was having a separate flow for downloading query results as CSV. 
   Otherwise, always limiting the query results ( this should help reduce 
Presto load). The question is that whe it is eventually run on a slice, it 
still runs the full query. 
   
   Third idea is to respond early to when 1000 rows have been generated. (This 
can be known from the stats object returned from polling) And send that to the 
frontend for rendering while the rest of it runs. 
   
   We will have to have an opinion on how superset should run queries and 
communiate that clearly in the interface so users, for example don't think the 
first 1K rows is all the results there is. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4682: Add lyftColor to the game 

[GitBox]

codecov-io commented on issue #4682: Add lyftColor to the game 
URL: 
https://github.com/apache/incubator-superset/pull/4682#issuecomment-375825134
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4682?src=pr=h1)
 Report
   > Merging 
[#4682](https://codecov.io/gh/apache/incubator-superset/pull/4682?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/00cab7e1073ba8d810b5dd323cb6fdb706ced537?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4682/graphs/tree.svg?src=pr=KsB0fHcx6l=650=150)](https://codecov.io/gh/apache/incubator-superset/pull/4682?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #4682  +/-   ##
   =
   + Coverage71.4%   71.4%   +<.01% 
   =
 Files 190 190  
 Lines   14934   14935   +1 
 Branches 11021102  
   =
   + Hits10663   10664   +1 
 Misses   42684268  
 Partials3   3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4682?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/assets/javascripts/modules/colors.js](https://codecov.io/gh/apache/incubator-superset/pull/4682/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL21vZHVsZXMvY29sb3JzLmpz)
 | `77.08% <100%> (+0.48%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4682?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4682?src=pr=footer).
 Last update 
[00cab7e...e80a502](https://codecov.io/gh/apache/incubator-superset/pull/4682?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4682: Add lyftColor to the game 

[GitBox]

codecov-io commented on issue #4682: Add lyftColor to the game 
URL: 
https://github.com/apache/incubator-superset/pull/4682#issuecomment-375825134
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4682?src=pr=h1)
 Report
   > Merging 
[#4682](https://codecov.io/gh/apache/incubator-superset/pull/4682?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/00cab7e1073ba8d810b5dd323cb6fdb706ced537?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4682/graphs/tree.svg?width=650=pr=KsB0fHcx6l=150)](https://codecov.io/gh/apache/incubator-superset/pull/4682?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #4682  +/-   ##
   =
   + Coverage71.4%   71.4%   +<.01% 
   =
 Files 190 190  
 Lines   14934   14935   +1 
 Branches 11021102  
   =
   + Hits10663   10664   +1 
 Misses   42684268  
 Partials3   3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4682?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/assets/javascripts/modules/colors.js](https://codecov.io/gh/apache/incubator-superset/pull/4682/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL21vZHVsZXMvY29sb3JzLmpz)
 | `77.08% <100%> (+0.48%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4682?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4682?src=pr=footer).
 Last update 
[00cab7e...e80a502](https://codecov.io/gh/apache/incubator-superset/pull/4682?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] betodealmeida commented on issue #4387: Time filter - remove infinity for end date

[GitBox]

betodealmeida commented on issue #4387: Time filter - remove infinity for end 
date
URL: 
https://github.com/apache/incubator-superset/issues/4387#issuecomment-375824524
 
 
   @vylc, I can't repro this — @mistercrunch, do you know if this was changed 
recently?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] john-bodley commented on issue #4552: [travis/tox] Restructuring configuration and testing

[GitBox]

john-bodley commented on issue #4552: [travis/tox] Restructuring configuration 
and testing
URL: 
https://github.com/apache/incubator-superset/pull/4552#issuecomment-375824124
 
 
   @mistercrunch @betodealmeida per the conservation regarding pinning earlier 
today what are your thoughts on this PR? Note beyond `requirements.txt` there's 
changes in configuration around testing (including unit tests), the `tox` test 
harness, and Travis CI. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] john-bodley commented on issue #4682: Add lyftColor to the game 

[GitBox]

john-bodley commented on issue #4682: Add lyftColor to the game 
URL: 
https://github.com/apache/incubator-superset/pull/4682#issuecomment-375823077
 
 
   LGTM 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hughhhh opened a new pull request #4682: Add lyftColor to the game 

[GitBox]

hug opened a new pull request #4682: Add lyftColor to the game 
URL: https://github.com/apache/incubator-superset/pull/4682
 
 
   Because the branding matters 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] michellethomas opened a new issue #4681: Time table viz sorting doesn't work with values equal to 0

[GitBox]

michellethomas opened a new issue #4681: Time table viz sorting doesn't work 
with values equal to 0
URL: https://github.com/apache/incubator-superset/issues/4681
 
 
   This has been a known issue for some time, but I wanted to keep track of 
this as a known bug. We are seeing an issue with sorting columns in reactable 
and I submitted an issue in reactable in Oct that no one has responded to. I 
mentioned this issue 
[here](https://github.com/apache/incubator-superset/issues/4649) when 
discussing which table components to use.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4678: Update documentation about yarn lock

[GitBox]

codecov-io commented on issue #4678: Update documentation about yarn lock
URL: 
https://github.com/apache/incubator-superset/pull/4678#issuecomment-375815860
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4678?src=pr=h1)
 Report
   > Merging 
[#4678](https://codecov.io/gh/apache/incubator-superset/pull/4678?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/76394d3f8f711c2754dbfdd0c6cf7deb6d3ef122?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4678/graphs/tree.svg?height=150=pr=KsB0fHcx6l=650)](https://codecov.io/gh/apache/incubator-superset/pull/4678?src=pr=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #4678   +/-   ##
   ==
 Coverage71.4%   71.4%   
   ==
 Files 190 190   
 Lines   14934   14934   
 Branches 11021102   
   ==
 Hits10663   10663   
 Misses   42684268   
 Partials3   3
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4678?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4678?src=pr=footer).
 Last update 
[76394d3...077862d](https://codecov.io/gh/apache/incubator-superset/pull/4678?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] john-bodley closed pull request #4679: add yarn lock info to contributing.md

[GitBox]

john-bodley closed pull request #4679: add yarn lock info to contributing.md
URL: https://github.com/apache/incubator-superset/pull/4679
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index b337dad4d8..7f7ff50ae6 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -259,6 +259,10 @@ superset runserver -d -p 8081
 npm run dev
 ```
 
+ Upgrading npm packages
+
+Should you add or upgrade a npm package, which involves changing 
`package.json`, you'll need to re-run `yarn install` and push the newly 
generated `yarn.lock` file so we get the reproducible build. More information 
at (https://yarnpkg.com/blog/2016/11/24/lockfiles-for-all/)
+
 ## Testing
 
 Before running python unit tests, please setup local testing environment:


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4679: add yarn lock info to contributing.md

[GitBox]

codecov-io commented on issue #4679: add yarn lock info to contributing.md
URL: 
https://github.com/apache/incubator-superset/pull/4679#issuecomment-375815118
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4679?src=pr=h1)
 Report
   > Merging 
[#4679](https://codecov.io/gh/apache/incubator-superset/pull/4679?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/76394d3f8f711c2754dbfdd0c6cf7deb6d3ef122?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4679/graphs/tree.svg?width=650=150=pr=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/4679?src=pr=tree)
   
   ```diff
   @@  Coverage Diff   @@
   ##   master   #4679   +/-   ##
   ==
 Coverage71.4%   71.4%   
   ==
 Files 190 190   
 Lines   14934   14934   
 Branches 11021102   
   ==
 Hits10663   10663   
 Misses   42684268   
 Partials3   3
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4679?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4679?src=pr=footer).
 Last update 
[76394d3...f90f341](https://codecov.io/gh/apache/incubator-superset/pull/4679?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hughhhh commented on issue #4680: [WiP] Hotkeys in SQL Lab

[GitBox]

hug commented on issue #4680: [WiP] Hotkeys in SQL Lab
URL: 
https://github.com/apache/incubator-superset/pull/4680#issuecomment-375813684
 
 
   @dubtran


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch opened a new pull request #4680: [WiP] Hotkeys in SQL Lab

[GitBox]

mistercrunch opened a new pull request #4680: [WiP] Hotkeys in SQL Lab
URL: https://github.com/apache/incubator-superset/pull/4680
 
 
   https://user-images.githubusercontent.com/487433/37855642-8878834c-2ead-11e8-97a0-9cc5fc8468ba.png;>
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] timifasubaa commented on issue #4245: build master branch failed

[GitBox]

timifasubaa commented on issue #4245: build master branch failed
URL: 
https://github.com/apache/incubator-superset/issues/4245#issuecomment-375812248
 
 
   If you're comfortable with Docker, you can try to see if this works for you 
: https://hub.docker.com/r/amancevice/superset/


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] jeffreythewang commented on issue #4299: Bump sqlalchemy to 1.2.2

[GitBox]

jeffreythewang commented on issue #4299: Bump sqlalchemy to 1.2.2
URL: 
https://github.com/apache/incubator-superset/pull/4299#issuecomment-375812162
 
 
   We're also having issues with the version bump related to the addition of 
the `get_table_comment` method as described 
[here](http://docs.sqlalchemy.org/en/latest/core/reflection.html#sqlalchemy.engine.reflection.Inspector.get_table_comment),
 as some postgresql-specific 
[logic](https://github.com/zzzeek/sqlalchemy/blob/master/lib/sqlalchemy/dialects/postgresql/base.py#L3004)
 is being inherited by other db engines.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] timifasubaa commented on issue #4245: build master branch failed

[GitBox]

timifasubaa commented on issue #4245: build master branch failed
URL: 
https://github.com/apache/incubator-superset/issues/4245#issuecomment-375812248
 
 
   If you're cmofortable with Docker, you can try to see if this works for you 
: https://hub.docker.com/r/amancevice/superset/


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] timifasubaa commented on issue #4348: Add yarn.lock for reproducible build (#4274)

[GitBox]

timifasubaa commented on issue #4348: Add yarn.lock for reproducible build 
(#4274)
URL: 
https://github.com/apache/incubator-superset/pull/4348#issuecomment-375810990
 
 
   Superseded by https://github.com/apache/incubator-superset/pull/4679 and 
https://github.com/apache/incubator-superset/pull/4674


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] timifasubaa commented on issue #4674: Add yarn.lock

[GitBox]

timifasubaa commented on issue #4674: Add yarn.lock
URL: 
https://github.com/apache/incubator-superset/pull/4674#issuecomment-375810612
 
 
   https://github.com/apache/incubator-superset/issues/4274


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] timifasubaa opened a new pull request #4679: add yarn lock info to contributing.md

[GitBox]

timifasubaa opened a new pull request #4679: add yarn lock info to 
contributing.md
URL: https://github.com/apache/incubator-superset/pull/4679
 
 
   This adds more info about updating the yarn lock as added in (#4674)
   
   @graceguo-supercat  @mistercrunch 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] timifasubaa opened a new pull request #4678: Update documentation about yarn lock

[GitBox]

timifasubaa opened a new pull request #4678: Update documentation about yarn 
lock
URL: https://github.com/apache/incubator-superset/pull/4678
 
 
   This adds more info about updating the yarn lock as added in 
(https://github.com/apache/incubator-superset/pull/4674)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] villebro commented on issue #3998: [SQLLab] Allow common table expressions (CTE), a.k.a. "with" statements

[GitBox]

villebro commented on issue #3998: [SQLLab] Allow common table expressions 
(CTE), a.k.a. "with" statements
URL: 
https://github.com/apache/incubator-superset/issues/3998#issuecomment-375807662
 
 
   I am unable to reproduce this bug. As we're currently using sqlparse==0.2.4, 
and CTEs were added in 0.2.0 (see 
https://github.com/andialbrecht/sqlparse/issues/227 and 
https://github.com/andialbrecht/sqlparse/commit/8f39d3367e8878e5f9a09b0166e3f0f73626e67d),
 this works in the current version of Superset.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] betodealmeida commented on a change in pull request #4654: Expose metrics to JS

[GitBox]

betodealmeida commented on a change in pull request #4654: Expose metrics to JS
URL: 
https://github.com/apache/incubator-superset/pull/4654#discussion_r176871595
 
 

 ##
 File path: superset/assets/javascripts/modules/sandbox.js
 ##
 @@ -22,6 +22,10 @@ export default function sandboxedEval(code, context, opts) {
   Object.keys(sandboxContext).forEach(function (key) {
 sandbox[key] = sandboxContext[key];
   });
-  vm.runInNewContext(codeToEval, sandbox, opts);
-  return sandbox[resultKey];
+  try {
+vm.runInNewContext(codeToEval, sandbox, opts);
+return sandbox[resultKey];
+  } catch (error) {
+return () => error;
 
 Review comment:
   The function `sandboxedEval` returns a function (either to mutate the data 
or generate the tooltip). I'm being consistent here, and returning this ensures 
that the error is displayed in the tooltip (see second screenshot).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] timifasubaa commented on issue #4674: Add yarn.lock

[GitBox]

timifasubaa commented on issue #4674: Add yarn.lock
URL: 
https://github.com/apache/incubator-superset/pull/4674#issuecomment-375801147
 
 
   @mistercrunch Sure. I'll be happy to add. The instructions would be 
something along the lines of updating the yarn.lock file whenever you add a new 
javascript dependency? Anything else you would want me to add? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] graceguo-supercat closed pull request #4639: forms: make csv import parse dates accepts a list of columns

[GitBox]

graceguo-supercat closed pull request #4639: forms: make csv import parse dates 
accepts a list of columns
URL: https://github.com/apache/incubator-superset/pull/4639
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/forms.py b/superset/forms.py
index eb8aba889a..e846d57ca9 100644
--- a/superset/forms.py
+++ b/superset/forms.py
@@ -10,7 +10,7 @@
 from flask_babel import lazy_gettext as _
 from flask_wtf.file import FileAllowed, FileField, FileRequired
 from wtforms import (
-BooleanField, IntegerField, SelectField, StringField)
+BooleanField, Field, IntegerField, SelectField, StringField)
 from wtforms.ext.sqlalchemy.fields import QuerySelectField
 from wtforms.validators import DataRequired, NumberRange, Optional
 
@@ -20,6 +20,32 @@
 config = app.config
 
 
+class CommaSeparatedListField(Field):
+widget = BS3TextFieldWidget()
+
+def _value(self):
+if self.data:
+return u', '.join(self.data)
+else:
+return u''
+
+def process_formdata(self, valuelist):
+if valuelist:
+self.data = [x.strip() for x in valuelist[0].split(',')]
+else:
+self.data = []
+
+
+def filter_not_empty_values(value):
+"""Returns a list of non empty values or None"""
+if not value:
+return None
+data = [x for x in value if x]
+if not data:
+return None
+return data
+
+
 class CsvToDatabaseForm(DynamicForm):
 # pylint: disable=E0211
 def all_db_items():
@@ -36,6 +62,7 @@ def all_db_items():
 validators=[
 FileRequired(), FileAllowed(['csv'], _('CSV Files Only!'))])
 con = QuerySelectField(
+_('Database'),
 query_factory=all_db_items,
 get_pk=lambda a: a.id, get_label=lambda a: a.database_name)
 sep = StringField(
@@ -99,9 +126,12 @@ def all_db_items():
 description=_(
 'Skip blank lines rather than interpreting them '
 'as NaN values.'))
-parse_dates = BooleanField(
+parse_dates = CommaSeparatedListField(
 _('Parse Dates'),
-description=_('Parse date values.'))
+description=_(
+'A comma separated list of columns that should be '
+'parsed as dates.'),
+filters=[filter_not_empty_values])
 infer_datetime_format = BooleanField(
 _('Infer Datetime Format'),
 description=_(
diff --git a/superset/views/core.py b/superset/views/core.py
index 723e8ccfb7..a080a4b8eb 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -339,7 +339,6 @@ def form_get(self, form):
 form.mangle_dupe_cols.data = True
 form.skipinitialspace.data = False
 form.skip_blank_lines.data = True
-form.parse_dates.data = True
 form.infer_datetime_format.data = True
 form.decimal.data = '.'
 form.if_exists.data = 'append'
diff --git a/tests/form_tests.py b/tests/form_tests.py
new file mode 100644
index 00..82178a213e
--- /dev/null
+++ b/tests/form_tests.py
@@ -0,0 +1,28 @@
+# -*- coding: utf-8 -*-
+from __future__ import absolute_import
+from __future__ import division
+from __future__ import print_function
+from __future__ import unicode_literals
+
+from tests.base_tests import SupersetTestCase
+from wtforms.form import Form
+
+from superset.forms import (
+CommaSeparatedListField, filter_not_empty_values)
+
+
+class FormTestCase(SupersetTestCase):
+
+def test_comma_separated_list_field(self):
+field = CommaSeparatedListField().bind(Form(), 'foo')
+field.process_formdata([u''])
+self.assertEqual(field.data, [u''])
+
+field.process_formdata(['a,comma,separated,list'])
+self.assertEqual(field.data, [u'a', u'comma', u'separated', u'list'])
+
+def test_filter_not_empty_values(self):
+self.assertEqual(filter_not_empty_values(None), None)
+self.assertEqual(filter_not_empty_values([]), None)
+self.assertEqual(filter_not_empty_values(['']), None)
+self.assertEqual(filter_not_empty_values(['hi']), ['hi'])


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] graceguo-supercat closed issue #4637: csv import "parse dates" should be more flexible

[GitBox]

graceguo-supercat closed issue #4637: csv import "parse dates" should be more 
flexible
URL: https://github.com/apache/incubator-superset/issues/4637
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4674: Add yarn.lock

[GitBox]

mistercrunch commented on issue #4674: Add yarn.lock
URL: 
https://github.com/apache/incubator-superset/pull/4674#issuecomment-375800212
 
 
   Do we need instructions on `CONTRIBUTING.md` related to this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4473: [Wip] Added DeckGL unit test

[GitBox]

codecov-io commented on issue #4473: [Wip] Added DeckGL unit test
URL: 
https://github.com/apache/incubator-superset/pull/4473#issuecomment-371748732
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=h1)
 Report
   > Merging 
[#4473](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/b24a6fd4b56d9a89ac1ce507f6f545c509306ceb?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4473/graphs/tree.svg?height=150=650=KsB0fHcx6l=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4473  +/-   ##
   ==
   + Coverage   71.37%   71.38%   +<.01% 
   ==
 Files 190  190  
 Lines   1491814918  
 Branches 1102 1102  
   ==
   + Hits1064810649   +1 
   + Misses   4267 4266   -1 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5)
 | `79.69% <0%> (+0.07%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=footer).
 Last update 
[b24a6fd...23c500e](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4473: [Wip] Added DeckGL unit test

[GitBox]

codecov-io commented on issue #4473: [Wip] Added DeckGL unit test
URL: 
https://github.com/apache/incubator-superset/pull/4473#issuecomment-371748732
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=h1)
 Report
   > Merging 
[#4473](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/b24a6fd4b56d9a89ac1ce507f6f545c509306ceb?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4473/graphs/tree.svg?token=KsB0fHcx6l=pr=650=150)](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4473  +/-   ##
   ==
   + Coverage   71.37%   71.38%   +<.01% 
   ==
 Files 190  190  
 Lines   1491814918  
 Branches 1102 1102  
   ==
   + Hits1064810649   +1 
   + Misses   4267 4266   -1 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5)
 | `79.69% <0%> (+0.07%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=footer).
 Last update 
[b24a6fd...23c500e](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] althorian commented on issue #1338: Cannot connect to MySQL view

[GitBox]

althorian commented on issue #1338: Cannot connect to MySQL view
URL: 
https://github.com/apache/incubator-superset/issues/1338#issuecomment-375793509
 
 
   I have the same issue, I am using mySQL and superset (0.23.2) connecting to 
the database with mysql+mysqldb. The tables I can see just fine but the view 
does not show up at the bottom of the database source page when I test the 
connection. In mySQL the user account for superset has been granted 'show view' 
and 'show databases'.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4473: [Wip] Added DeckGL unit test

[GitBox]

codecov-io commented on issue #4473: [Wip] Added DeckGL unit test
URL: 
https://github.com/apache/incubator-superset/pull/4473#issuecomment-371748732
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=h1)
 Report
   > Merging 
[#4473](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/b24a6fd4b56d9a89ac1ce507f6f545c509306ceb?src=pr=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4473/graphs/tree.svg?src=pr=KsB0fHcx6l=650=150)](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4473  +/-   ##
   ==
   + Coverage   71.37%   71.38%   +<.01% 
   ==
 Files 190  190  
 Lines   1491814918  
 Branches 1102 1102  
   ==
   + Hits1064810649   +1 
   + Misses   4267 4266   -1 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5)
 | `79.69% <0%> (+0.07%)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=footer).
 Last update 
[b24a6fd...23c500e](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] timifasubaa commented on issue #4639: forms: make csv import parse dates accepts a list of columns

[GitBox]

timifasubaa commented on issue #4639: forms: make csv import parse dates 
accepts a list of columns
URL: 
https://github.com/apache/incubator-superset/pull/4639#issuecomment-375764750
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #4676: Fix setup.py, comma makes download_url a tuple

[GitBox]

mistercrunch closed pull request #4676: Fix setup.py, comma makes download_url 
a tuple
URL: https://github.com/apache/incubator-superset/pull/4676
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/setup.py b/setup.py
index bdb0d5e42a..f8f785e721 100644
--- a/setup.py
+++ b/setup.py
@@ -104,7 +104,8 @@ def get_git_sha():
 author_email='maximebeauche...@gmail.com',
 url='https://github.com/apache/incubator-superset',
 download_url=(
-'https://github.com/apache/incubator-superset/tarball/' + 
version_string,
+'https://github.com'
+'/apache/incubator-superset/tarball/' + version_string
 ),
 classifiers=[
 'Programming Language :: Python :: 2.7',


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4676: Fix setup.py, comma makes download_url a tuple

[GitBox]

codecov-io commented on issue #4676: Fix setup.py, comma makes download_url a 
tuple
URL: 
https://github.com/apache/incubator-superset/pull/4676#issuecomment-375751529
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4676?src=pr=h1)
 Report
   > Merging 
[#4676](https://codecov.io/gh/apache/incubator-superset/pull/4676?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/73f7f817d30f960f16611f01ac8daee52ad92830?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4676/graphs/tree.svg?width=650=150=pr=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/4676?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4676   +/-   ##
   ===
 Coverage   71.37%   71.37%   
   ===
 Files 190  190   
 Lines   1491814918   
 Branches 1102 1102   
   ===
 Hits1064810648   
 Misses   4267 4267   
 Partials33
   ```
   
   
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4676?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4676?src=pr=footer).
 Last update 
[73f7f81...b753477](https://codecov.io/gh/apache/incubator-superset/pull/4676?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] williaster closed pull request #4626: [dashboard-builder] add top-level tabs + undo-redo

[GitBox]

williaster closed pull request #4626: [dashboard-builder] add top-level tabs + 
undo-redo
URL: https://github.com/apache/incubator-superset/pull/4626
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] williaster commented on issue #4626: [dashboard-builder] add top-level tabs + undo-redo

[GitBox]

williaster commented on issue #4626: [dashboard-builder] add top-level tabs + 
undo-redo
URL: 
https://github.com/apache/incubator-superset/pull/4626#issuecomment-375749838
 
 
   going to merge.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on issue #4677: get column values for filters not working with clickhouse datasource

[GitBox]

xrmx commented on issue #4677: get column values for filters not working with 
clickhouse datasource
URL: 
https://github.com/apache/incubator-superset/issues/4677#issuecomment-375749330
 
 
   Looks like an issue in sqlalchemy_clickhouse more than in superset


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] baoxiao opened a new issue #4677: get column values for filters not working with clickhouse datasource

[GitBox]

baoxiao opened a new issue #4677: get column values for filters not working 
with clickhouse datasource
URL: https://github.com/apache/incubator-superset/issues/4677
 
 
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [X ] I have checked the superset logs for python stacktraces and included 
it here as text if any
   - [ x] I have reproduced the issue with at least the latest released version 
of superset
   - [ X] I have checked the issue tracker for the same issue and I haven't 
found one similar
   
   
   ### Superset version
   0.23.3
   
   ### Expected results
   the filter result dropdown box should show the distint values of the column 
   ### Actual results
   
   
   ### Steps to reproduce
   It just stuck there, no result show up.  On the server side get error:
   
   2018-03-23 12:46:10,563:ERROR:root:Code: 62, e.displayText() = 
DB::Exception: Syntax error: failed at position 52 (line 1, col 52): AS 
record_country
   FROM record_innodb.mtrack_record_201108
LIMIT 1 FORMAT TabSeparatedWithNamesAndTypes. Expected one of: 
PREWHERE, WHERE, Comma, ORDER BY, SETTINGS, INTO OUTFILE, FORMAT, FROM, GROUP 
BY, WITH, HAVING, UNION ALL, token, LIMIT, e.what() = DB::Exception
   Traceback (most recent call last):
 File 
"/home/centos/venv/lib/python2.7/site-packages/superset/views/base.py", line 
65, in wraps
   return f(self, *args, **kwargs)
 File 
"/home/centos/venv/lib/python2.7/site-packages/flask_appbuilder/security/decorators.py",
 line 52, in wraps
   return f(self, *args, **kwargs)
 File 
"/home/centos/venv/lib/python2.7/site-packages/superset/views/core.py", line 
1300, in filter
   config.get('FILTER_SELECT_ROW_LIMIT', 1),
 File 
"/home/centos/venv/lib/python2.7/site-packages/superset/connectors/sqla/models.py",
 line 395, in values_for_column
   df = pd.read_sql_query(sql=sql, con=engine)
 File "/home/centos/venv/lib/python2.7/site-packages/pandas/io/sql.py", 
line 332, in read_sql_query
   parse_dates=parse_dates, chunksize=chunksize)
 File "/home/centos/venv/lib/python2.7/site-packages/pandas/io/sql.py", 
line 1092, in read_query
   result = self.execute(*args)
 File "/home/centos/venv/lib/python2.7/site-packages/pandas/io/sql.py", 
line 983, in execute
   return self.connectable.execute(*args, **kwargs)
 File 
"/home/centos/venv/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 
2075, in execute
   return connection.execute(statement, *multiparams, **params)
 File 
"/home/centos/venv/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 
942, in execute
   return self._execute_text(object, multiparams, params)
 File 
"/home/centos/venv/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 
1104, in _execute_text
   statement, parameters
 File 
"/home/centos/venv/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 
1200, in _execute_context
   context)
 File 
"/home/centos/venv/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 
1416, in _handle_dbapi_exception
   util.reraise(*exc_info)
 File 
"/home/centos/venv/lib/python2.7/site-packages/sqlalchemy/engine/base.py", line 
1193, in _execute_context
   context)
 File 
"/home/centos/venv/lib/python2.7/site-packages/sqlalchemy/engine/default.py", 
line 507, in do_execute
   cursor.execute(statement, parameters)
 File 
"/home/centos/venv/lib/python2.7/site-packages/sqlalchemy_clickhouse/connector.py",
 line 209, in execute
   self._process_response(response)
 File 
"/home/centos/venv/lib/python2.7/site-packages/sqlalchemy_clickhouse/connector.py",
 line 340, in _process_response
   for r in response:
 File 
"/home/centos/venv/lib/python2.7/site-packages/infi/clickhouse_orm/database.py",
 line 162, in select
   r = self._send(query, settings, True)
 File 
"/home/centos/venv/lib/python2.7/site-packages/sqlalchemy_clickhouse/connector.py",
 line 102, in _send
   raise Exception(r.text)
   Exception: Code: 62, e.displayText() = DB::Exception: Syntax error: failed 
at position 52 (line 1, col 52): AS record_country
   FROM record_innodb.mtrack_record_201108
LIMIT 1 FORMAT TabSeparatedWithNamesAndTypes. Expected one of: 
PREWHERE, WHERE, Comma, ORDER BY, SETTINGS, INTO OUTFILE, FORMAT, FROM, GROUP 
BY, WITH, HAVING, UNION ALL, token, LIMIT, e.what() = DB::Exception
   
   when run ngrep to trace the packet, find superset send the below query to 
clickhouse,it seems like postgresql syntax, it cause error on clickhouse
   SELECT DISTINCT ON (record_country) record_country AS record_country FROM
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:

[GitHub] codecov-io commented on issue #4552: [travis/tox] Restructuring configuration and testing

[GitBox]

codecov-io commented on issue #4552: [travis/tox] Restructuring configuration 
and testing
URL: 
https://github.com/apache/incubator-superset/pull/4552#issuecomment-371021034
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=h1)
 Report
   > Merging 
[#4552](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/73f7f817d30f960f16611f01ac8daee52ad92830?src=pr=desc)
 will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4552/graphs/tree.svg?width=650=150=KsB0fHcx6l=pr)](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree)
   
   ```diff
   @@   Coverage Diff   @@
   ##   master#4552   +/-   ##
   ===
 Coverage   71.37%   71.37%   
   ===
 Files 190  190   
 Lines   1491814918   
 Branches 1102 1102   
   ===
 Hits1064810648   
 Misses   4267 4267   
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4552/diff?src=pr=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
 | `92.24% <0%> (ø)` | :arrow_up: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=footer).
 Last update 
[73f7f81...cbbf647](https://codecov.io/gh/apache/incubator-superset/pull/4552?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] john-bodley commented on issue #4676: Fix setup.py, comma makes download_url a tuple

[GitBox]

john-bodley commented on issue #4676: Fix setup.py, comma makes download_url a 
tuple
URL: 
https://github.com/apache/incubator-superset/pull/4676#issuecomment-375737637
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] john-bodley commented on issue #4565: Move access permissions methods to security manager

[GitBox]

john-bodley commented on issue #4565: Move access permissions methods to 
security manager
URL: 
https://github.com/apache/incubator-superset/pull/4565#issuecomment-375736987
 
 
   @mistercrunch the thinking was that the default security manager is still 
tightly coupled with FAB concepts (views/menus) which correspond to security 
related to the app UI and API. These concepts are irrelevant from a data 
security perspective and thus the reason for two security managers.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch opened a new pull request #4676: Fix setup.py, comma makes download_url a tuple

[GitBox]

mistercrunch opened a new pull request #4676: Fix setup.py, comma makes 
download_url a tuple
URL: https://github.com/apache/incubator-superset/pull/4676
 
 
   @john-bodley 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] amishyn commented on issue #4613: Uncaught TypeError: Cannot read property 'map' of null

[GitBox]

amishyn commented on issue #4613: Uncaught TypeError: Cannot read property 
'map' of null
URL: 
https://github.com/apache/incubator-superset/issues/4613#issuecomment-375717120
 
 
   Having the same issue, curious how did you fix it ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #4666: Sessions still active on Datasource

[GitBox]

mistercrunch commented on issue #4666: Sessions still active on Datasource
URL: 
https://github.com/apache/incubator-superset/issues/4666#issuecomment-375702579
 
 
   This is the PR you want 
https://github.com/apache/incubator-superset/pull/4251 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2'

[GitBox]

mistercrunch commented on issue #2217: Was unable to import superset Error: No 
module named 'pysqlite2'
URL: 
https://github.com/apache/incubator-superset/issues/2217#issuecomment-375701194
 
 
   Related:
   https://github.com/jupyterhub/jupyterhub/issues/464
   
   Looks like you need sqlite os C bindings as in `sqlite-devel` depending on 
your OS. What OS are you on?
   
   BTW 0.15.4 is super old.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wffger commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2'

[GitBox]

wffger commented on issue #2217: Was unable to import superset Error: No module 
named 'pysqlite2'
URL: 
https://github.com/apache/incubator-superset/issues/2217#issuecomment-375696910
 
 
   `pip install pysqlite3 `
   
   > Collecting pysqlite3 
   >   Downloading 
https://pypi.tuna.tsinghua.edu.cn/packages/0a/5d/e5c0b27142c554dbbefd7bac061cb26a57297794762089759852bc23b76c/pysqlite3-0.1.0.tar.gz
   > Installing collected packages: pysqlite3
   >   Running setup.py install for pysqlite3 ... done
   > Successfully installed pysqlite3 
   
   I still get the same prompt:  Was unable to import superset Error: No module 
named 'pysqlite2'


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] wffger commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2'

[GitBox]

wffger commented on issue #2217: Was unable to import superset Error: No module 
named 'pysqlite2'
URL: 
https://github.com/apache/incubator-superset/issues/2217#issuecomment-375696910
 
 
   `pip install pysqlite3
   Collecting pysqlite3
 Downloading 
https://pypi.tuna.tsinghua.edu.cn/packages/0a/5d/e5c0b27142c554dbbefd7bac061cb26a57297794762089759852bc23b76c/pysqlite3-0.1.0.tar.gz
   Installing collected packages: pysqlite3
 Running setup.py install for pysqlite3 ... done
   Successfully installed pysqlite3
   `
   I still get the same prompt:  Was unable to import superset Error: No module 
named 'pysqlite2'


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables

[GitBox]

shyam2794 commented on issue #3416: Add ability to color cells on Pivot Tables
URL: 
https://github.com/apache/incubator-superset/issues/3416#issuecomment-375690621
 
 
   @xiaohanyu @WangXueminGit I tried to implement the PR by myself and it works 
fine for the pivot visualization and it looks awesome . But you have stated on 
top of this thread that you have this feature implemented for both the table 
and pivot . How to implement this feature on plain table ? I am struck with the 
changes that needs to be done on table.js .
   
Can you share the code for plain table . It will be of great help . 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] AmineTay commented on issue #4666: Sessions still active on Datasource

[GitBox]

AmineTay commented on issue #4666: Sessions still active on Datasource
URL: 
https://github.com/apache/incubator-superset/issues/4666#issuecomment-375602966
 
 
   Hello,
   We also do analytics query using external database on which we have active 
session which is problematic for us. 
   And our version is 0.18.5
   Do you think if do an update of superset we will resolve the issue ? 
   
   Regards.
   
   Regards


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4639: forms: make csv import parse dates accepts a list of columns

[GitBox]

codecov-io commented on issue #4639: forms: make csv import parse dates accepts 
a list of columns
URL: 
https://github.com/apache/incubator-superset/pull/4639#issuecomment-374022137
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4639?src=pr=h1)
 Report
   > Merging 
[#4639](https://codecov.io/gh/apache/incubator-superset/pull/4639?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/73f7f817d30f960f16611f01ac8daee52ad92830?src=pr=desc)
 will **increase** coverage by `0.02%`.
   > The diff coverage is `94.44%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4639/graphs/tree.svg?width=650=pr=KsB0fHcx6l=150)](https://codecov.io/gh/apache/incubator-superset/pull/4639?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ##   master   #4639  +/-   ##
   =
   + Coverage   71.37%   71.4%   +0.02% 
   =
 Files 190 190  
 Lines   14918   14934  +16 
 Branches 11021102  
   =
   + Hits10648   10663  +15 
   - Misses   42674268   +1 
 Partials3   3
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4639?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4639/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==)
 | `71.19% <ø> (-0.03%)` | :arrow_down: |
   | 
[superset/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/4639/diff?src=pr=tree#diff-c3VwZXJzZXQvZm9ybXMucHk=)
 | `98.11% <94.44%> (-1.89%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4639?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4639?src=pr=footer).
 Last update 
[73f7f81...8ae10bd](https://codecov.io/gh/apache/incubator-superset/pull/4639?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] deatheyes opened a new issue #4675: Need proper way to display date time with time zone for epoch_s and epoch_ms

[GitBox]

deatheyes opened a new issue #4675: Need proper way to display date time with 
time zone for epoch_s and epoch_ms
URL: https://github.com/apache/incubator-superset/issues/4675
 
 
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [*] I have checked the superset logs for python stacktraces and included 
it here as text if any
   - [*] I have reproduced the issue with at least the latest released version 
of superset
   - [*] I have checked the issue tracker for the same issue and I haven't 
found one similar
   
   
   ### Superset version
   0.23.2
   
   ### Expected results
   display date time according to selected time zone
   
   ### Actual results
   there is no way to parse date time with specified time zone
   
   It is ugly to process time zone in the sql
   
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on issue #4639: forms: make csv import parse dates accepts a list of columns

[GitBox]

xrmx commented on issue #4639: forms: make csv import parse dates accepts a 
list of columns
URL: 
https://github.com/apache/incubator-superset/pull/4639#issuecomment-375589780
 
 
   @timifasubaa any chance you can take a look at this? I'll show this in a 
talk about superset tomorrow and I'd like that this or something equivalent 
will reach mainline. Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] riteshemigo commented on issue #2907: Superset very slow when FAB DB hosted on separate server

[GitBox]

riteshemigo commented on issue #2907: Superset very slow when FAB DB hosted on 
separate server
URL: 
https://github.com/apache/incubator-superset/issues/2907#issuecomment-375567411
 
 
   @BobSaintClare Did you find any permanent resolution for this. I am also 
facing the same issue.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4473: [Wip] Added DeckGL unit test

[GitBox]

codecov-io commented on issue #4473: [Wip] Added DeckGL unit test
URL: 
https://github.com/apache/incubator-superset/pull/4473#issuecomment-371748732
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=h1)
 Report
   > Merging 
[#4473](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/b512da8002dc0dc7f6a1f5eb983606118f484d32?src=pr=desc)
 will **increase** coverage by `0.21%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4473/graphs/tree.svg?width=650=pr=KsB0fHcx6l=150)](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4473  +/-   ##
   ==
   + Coverage   71.17%   71.38%   +0.21% 
   ==
 Files 187  190   +3 
 Lines   1480914918 +109 
 Branches 1085 1102  +17 
   ==
   + Hits1054010649 +109 
 Misses   4266 4266  
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[...cripts/explore/components/controls/TextControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC5qc3g=)
 | `45.45% <0%> (-1.43%)` | :arrow_down: |
   | 
[...ipts/explore/components/ControlPanelsContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLmpzeA==)
 | `86.95% <0%> (-0.93%)` | :arrow_down: |
   | 
[superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=)
 | `86.52% <0%> (-0.8%)` | :arrow_down: |
   | 
[superset/assets/javascripts/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NoYXJ0L0NoYXJ0LmpzeA==)
 | `64.95% <0%> (-0.56%)` | :arrow_down: |
   | 
[...javascripts/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4)
 | `92.45% <0%> (-0.55%)` | :arrow_down: |
   | 
[...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==)
 | `37.77% <0%> (-0.4%)` | :arrow_down: |
   | 
[superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5)
 | `51.89% <0%> (-0.36%)` | :arrow_down: |
   | 
[superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=)
 | `87.96% <0%> (-0.16%)` | :arrow_down: |
   | 
[superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==)
 | `74.21% <0%> (-0.13%)` | :arrow_down: |
   | 
[superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=)
 | `76.35% <0%> (-0.01%)` | :arrow_down: |
   | ... and [16 
more](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=footer).
 Last update 
[b512da8...90f2c20](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hughhhh commented on a change in pull request #4663: [Request For Comments][Explore] Streamlined metric definitions for SQLA and Druid

[GitBox]

hug commented on a change in pull request #4663: [Request For 
Comments][Explore] Streamlined metric definitions for SQLA and Druid
URL: 
https://github.com/apache/incubator-superset/pull/4663#discussion_r176654238
 
 

 ##
 File path: superset/connectors/sqla/models.py
 ##
 @@ -436,6 +436,25 @@ def get_from_clause(self, template_processor=None, 
db_engine_spec=None):
 return TextAsFrom(sa.text(from_sql), []).alias('expr_qry')
 return self.get_sqla_table()
 
+def adhoc_metric_to_sa(self, metric):
+column_name = metric.get('column').get('column_name')
+aggregate = metric.get('aggregate')
+label = metric.get('label')
+if aggregate == 'COUNT_DISTINCT':
 
 Review comment:
   nit: I would make this a `dict()` mapping for instance:
   ```
   aggregate_dict = {
'SUM' : sa.func.COUNT(column(column_name))
...
   }
   sa_metric = aggregate_dict.get(aggregate)
   ```
   
   I think this is much cleaner and would allow others to add more metrics 
easily later.
   
   PS: This is so dope! i can't wait till this lands so we can had some geo 
functions!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4473: [Wip] Added DeckGL unit test

[GitBox]

codecov-io commented on issue #4473: [Wip] Added DeckGL unit test
URL: 
https://github.com/apache/incubator-superset/pull/4473#issuecomment-371748732
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=h1)
 Report
   > Merging 
[#4473](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/b512da8002dc0dc7f6a1f5eb983606118f484d32?src=pr=desc)
 will **increase** coverage by `0.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4473/graphs/tree.svg?token=KsB0fHcx6l=pr=150=650)](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4473  +/-   ##
   ==
   + Coverage   71.17%   71.18%   +0.01% 
   ==
 Files 187  190   +3 
 Lines   1480914918 +109 
 Branches 1085 1102  +17 
   ==
   + Hits1054010620  +80 
   - Misses   4266 4295  +29 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5)
 | `49.72% <0%> (-2.53%)` | :arrow_down: |
   | 
[superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5)
 | `95% <0%> (-2.5%)` | :arrow_down: |
   | 
[...cripts/explore/components/controls/TextControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC5qc3g=)
 | `45.45% <0%> (-1.43%)` | :arrow_down: |
   | 
[superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=)
 | `86.87% <0%> (-1.26%)` | :arrow_down: |
   | 
[superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=)
 | `86.33% <0%> (-0.98%)` | :arrow_down: |
   | 
[...ipts/explore/components/ControlPanelsContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLmpzeA==)
 | `86.95% <0%> (-0.93%)` | :arrow_down: |
   | 
[superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==)
 | `77.07% <0%> (-0.74%)` | :arrow_down: |
   | 
[superset/assets/javascripts/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2NoYXJ0L0NoYXJ0LmpzeA==)
 | `64.95% <0%> (-0.56%)` | :arrow_down: |
   | 
[...javascripts/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4)
 | `92.45% <0%> (-0.55%)` | :arrow_down: |
   | 
[...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==)
 | `37.77% <0%> (-0.4%)` | :arrow_down: |
   | ... and [16 
more](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=footer).
 Last update 
[b512da8...90f2c20](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hughhhh commented on a change in pull request #4663: [Request For Comments][Explore] Streamlined metric definitions for SQLA and Druid

[GitBox]

hug commented on a change in pull request #4663: [Request For 
Comments][Explore] Streamlined metric definitions for SQLA and Druid
URL: 
https://github.com/apache/incubator-superset/pull/4663#discussion_r176654238
 
 

 ##
 File path: superset/connectors/sqla/models.py
 ##
 @@ -436,6 +436,25 @@ def get_from_clause(self, template_processor=None, 
db_engine_spec=None):
 return TextAsFrom(sa.text(from_sql), []).alias('expr_qry')
 return self.get_sqla_table()
 
+def adhoc_metric_to_sa(self, metric):
+column_name = metric.get('column').get('column_name')
+aggregate = metric.get('aggregate')
+label = metric.get('label')
+if aggregate == 'COUNT_DISTINCT':
 
 Review comment:
   nit: I would make this a `dict()` mapping for instance:
   ```
   aggregate_dict = {
'SUM' : sa.func.COUNT(column(column_name))
...
   }
   sa_metric = aggregate_dict.get(aggregate)
   ```
   
   I think this is much cleaner and would allow others to add more metrics 
later.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] napjon commented on issue #4635: [superset 0.23.2] bug no default charts position in dashboard, dashboard is empty

[GitBox]

napjon commented on issue #4635: [superset 0.23.2] bug no default charts 
position in dashboard, dashboard is empty
URL: 
https://github.com/apache/incubator-superset/issues/4635#issuecomment-375565317
 
 
   >Sorry as we're ironing out our release process. Part of the Apache process 
will force us to come up with steady solid releases. It probably won't make you 
feel better but I spent much more than 4 hours working on trying to come up 
with solid releases lately :(
   
   No need to apologize! Bug happens. Probably a good principle to sort through 
GitHub issues after spending 1 hour debugging cryptic bug.
   
   Thank you for your hard work on creating such an immensely useful tool. Been 
using it to speed up all of my report/summary.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] codecov-io commented on issue #4673: Add context to templates / respect slice timeout

[GitBox]

codecov-io commented on issue #4673: Add context to templates / respect slice 
timeout
URL: 
https://github.com/apache/incubator-superset/pull/4673#issuecomment-375558796
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4673?src=pr=h1)
 Report
   > Merging 
[#4673](https://codecov.io/gh/apache/incubator-superset/pull/4673?src=pr=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-superset/commit/b9965230df9940ca4387f9ac75fab90ed1a9c40a?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `50%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-superset/pull/4673/graphs/tree.svg?src=pr=650=KsB0fHcx6l=150)](https://codecov.io/gh/apache/incubator-superset/pull/4673?src=pr=tree)
   
   ```diff
   @@Coverage Diff @@
   ##   master#4673  +/-   ##
   ==
   - Coverage   71.37%   71.37%   -0.01% 
   ==
 Files 190  190  
 Lines   1491814920   +2 
 Branches 1102 1102  
   ==
   + Hits1064810649   +1 
   - Misses   4267 4268   +1 
 Partials33
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-superset/pull/4673?src=pr=tree)
 | Coverage Δ | |
   |---|---|---|
   | 
[superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4673/diff?src=pr=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==)
 | `77.91% <ø> (ø)` | :arrow_up: |
   | 
[superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4673/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5)
 | `79.57% <50%> (-0.05%)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4673?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4673?src=pr=footer).
 Last update 
[b996523...ef95564](https://codecov.io/gh/apache/incubator-superset/pull/4673?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] daoready commented on issue #4673: Add context to templates / respect slice timeout

[GitBox]

daoready commented on issue #4673: Add context to templates / respect slice 
timeout
URL: 
https://github.com/apache/incubator-superset/pull/4673#issuecomment-375556326
 
 
   I do not know Python, for me it is quite difficult to add tests, sorry about 
that


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] graceguo-supercat closed pull request #4630: [Bug fix] Fixed/Refactored annotation layer code so that non-timeseries annotations are applied based on the updated chart object after adding all

[GitBox]

graceguo-supercat closed pull request #4630: [Bug fix] Fixed/Refactored 
annotation layer code so that non-timeseries annotations are applied based on 
the updated chart object after adding all data
URL: https://github.com/apache/incubator-superset/pull/4630
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/visualizations/nvd3_vis.js 
b/superset/assets/visualizations/nvd3_vis.js
index 7cfb1c3320..9ce02bd031 100644
--- a/superset/assets/visualizations/nvd3_vis.js
+++ b/superset/assets/visualizations/nvd3_vis.js
@@ -533,6 +533,28 @@ function nvd3Vis(slice, payload) {
 chart.yAxis.axisLabel(fd.y_axis_label).axisLabelDistance(distance);
   }
 
+  const annotationLayers = (slice.formData.annotation_layers || 
[]).filter(x => x.show);
+  if (isTimeSeries && annotationLayers && slice.annotationData) {
+// Time series annotations add additional data
+const timeSeriesAnnotations = annotationLayers
+  .filter(a => a.annotationType === 
AnnotationTypes.TIME_SERIES).reduce((bushel, a) =>
+bushel.concat((slice.annotationData[a.name] || []).map((series) => {
+  if (!series) {
+return {};
+  }
+  const key = Array.isArray(series.key) ?
+`${a.name}, ${series.key.join(', ')}` : a.name;
+  return {
+...series,
+key,
+color: a.color,
+strokeWidth: a.width,
+classed: `${a.opacity} ${a.style}`,
+  };
+})), []);
+data.push(...timeSeriesAnnotations);
+  }
+
   // render chart
   svg
   .datum(data)
@@ -544,8 +566,7 @@ function nvd3Vis(slice, payload) {
   // on scroll, hide tooltips. throttle to only 4x/second.
   $(window).scroll(throttle(hideTooltips, 250));
 
-  const annotationLayers = (slice.formData.annotation_layers || 
[]).filter(x => x.show);
-
+  // The below code should be run AFTER rendering because chart is updated 
in call()
   if (isTimeSeries && annotationLayers) {
 // Formula annotations
 const formulas = annotationLayers.filter(a => a.annotationType === 
AnnotationTypes.FORMULA)
@@ -620,7 +641,7 @@ function nvd3Vis(slice, payload) {
   '' + body.join(', ') + '';
   });
 
-if (slice.annotationData && Object.keys(slice.annotationData).length) {
+if (slice.annotationData) {
   // Event annotations
   annotationLayers.filter(x => (
 x.annotationType === AnnotationTypes.EVENT &&
@@ -674,7 +695,6 @@ function nvd3Vis(slice, payload) {
 }
   });
 
-
   // Interval annotations
   annotationLayers.filter(x => (
 x.annotationType === AnnotationTypes.INTERVAL &&
@@ -737,33 +757,8 @@ function nvd3Vis(slice, payload) {
 .call(tip);
 }
   });
-
-  // Time series annotations
-  const timeSeriesAnnotations = annotationLayers
-.filter(a => a.annotationType === 
AnnotationTypes.TIME_SERIES).reduce((bushel, a) =>
-  bushel.concat((slice.annotationData[a.name] || []).map((series) 
=> {
-if (!series) {
-  return {};
-}
-const key = Array.isArray(series.key) ?
-  `${a.name}, ${series.key.join(', ')}` : a.name;
-return {
-  ...series,
-  key,
-  color: a.color,
-  strokeWidth: a.width,
-  classed: `${a.opacity} ${a.style}`,
-};
-  })), []);
-  data.push(...timeSeriesAnnotations);
 }
   }
-
-  // rerender chart
-  svg.datum(data)
-.attr('height', height)
-.attr('width', width)
-.call(chart);
 }
 return chart;
   };


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hughhhh commented on issue #4643: Added option to add fill to area line charts

[GitBox]

hug commented on issue #4643: Added option to add fill to area line charts
URL: 
https://github.com/apache/incubator-superset/pull/4643#issuecomment-375553809
 
 
   Setting the `fillOpacity` chart doesn't effect the color. Its weird because 
the api allows it to set this value but it doesn't change it in the view. I'll 
keep debugging might be a good op to contribute back to nvd3 :p
   
   
![line_area_opacity](https://user-images.githubusercontent.com/27827808/37814127-9b40c404-2e25-11e8-89d6-505f8e0375b2.gif)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hughhhh commented on issue #4643: Added option to add fill to area line charts

[GitBox]

hug commented on issue #4643: Added option to add fill to area line charts
URL: 
https://github.com/apache/incubator-superset/pull/4643#issuecomment-375553809
 
 
   Setting the `fillOpacity` chart doesn't effect the color. Its weird because 
the api allows it to set this value but it doesn't change it in the view.
   
   
![line_area_opacity](https://user-images.githubusercontent.com/27827808/37814127-9b40c404-2e25-11e8-89d6-505f8e0375b2.gif)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hughhhh commented on issue #4643: Added option to add fill to area line charts

[GitBox]

hug commented on issue #4643: Added option to add fill to area line charts
URL: 
https://github.com/apache/incubator-superset/pull/4643#issuecomment-375553809
 
 
   Setting the `fillOpacity` chart doesn't effect the color. Its weird because 
the api allows it to set this value but it doesn't change it in the view.
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] hughhhh commented on issue #4643: Added option to add fill to area line charts

[GitBox]

hug commented on issue #4643: Added option to add fill to area line charts
URL: 
https://github.com/apache/incubator-superset/pull/4643#issuecomment-375553809
 
 
   Setting the `fillOpacity` chart doesn't effect the color. Its weird because 
the api allows it to set this value but it doesn't change it in the view.
   
   
![line_area](https://user-images.githubusercontent.com/27827808/37813941-c59681ae-2e24-11e8-8333-859cacc99e1f.gif)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services