[GitHub] codecov-io commented on issue #4688: Added DeckGL Test
codecov-io commented on issue #4688: Added DeckGL Test URL: https://github.com/apache/incubator-superset/pull/4688#issuecomment-375946477 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4688?src=pr=h1) Report > Merging [#4688](https://codecov.io/gh/apache/incubator-superset/pull/4688?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9abc5c724ff878ca92edce3e074ce6a4d9ea60b9?src=pr=desc) will **increase** coverage by `0.08%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4688?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4688 +/- ## == + Coverage71.4% 71.48% +0.08% == Files 190 190 Lines 1493514935 Branches 1102 1102 == + Hits1066410676 +12 + Misses 4268 4256 -12 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4688?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4688/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `80.46% <0%> (+0.84%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4688?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4688?src=pr=footer). Last update [9abc5c7...de05959](https://codecov.io/gh/apache/incubator-superset/pull/4688?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4473: Added DeckGL Unit Test
codecov-io commented on issue #4473: Added DeckGL Unit Test URL: https://github.com/apache/incubator-superset/pull/4473#issuecomment-371748732 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=h1) Report > Merging [#4473](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9abc5c724ff878ca92edce3e074ce6a4d9ea60b9?src=pr=desc) will **increase** coverage by `0.08%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4473 +/- ## == + Coverage71.4% 71.48% +0.08% == Files 190 190 Lines 1493514935 Branches 1102 1102 == + Hits1066410676 +12 + Misses 4268 4256 -12 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `80.46% <0%> (+0.84%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=footer). Last update [9abc5c7...dd0468e](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hughhhh commented on issue #4473: Added DeckGL Unit Test
hug commented on issue #4473: Added DeckGL Unit Test URL: https://github.com/apache/incubator-superset/pull/4473#issuecomment-375945990 #4473 Moving... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hughhhh commented on issue #4473: Added DeckGL Unit Test
hug commented on issue #4473: Added DeckGL Unit Test URL: https://github.com/apache/incubator-superset/pull/4473#issuecomment-375945990 #4688 Moving... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hughhhh closed pull request #4473: Added DeckGL Unit Test
hug closed pull request #4473: Added DeckGL Unit Test
URL: https://github.com/apache/incubator-superset/pull/4473
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/tests/viz_tests.py b/tests/viz_tests.py
index 6822837e28..e0fdcd4094 100644
--- a/tests/viz_tests.py
+++ b/tests/viz_tests.py
@@ -15,6 +15,7 @@
class BaseVizTestCase(unittest.TestCase):
+
def test_constructor_exception_no_datasource(self):
form_data = {}
datasource = None
@@ -634,3 +635,109 @@ def test_rose_vis_get_data(self):
],
}
self.assertEqual(expected, res)
+
+
+class BaseDeckGLVizTestCase(unittest.TestCase):
+
+def test_get_metrics(self):
+form_data = {'size': 'large'}
+datasource = {'type': 'table'}
+test_viz_deckgl = viz.BaseDeckGLViz(datasource, form_data)
+result = test_viz_deckgl.get_metrics()
+assert result == [form_data.get('size')]
+
+form_data = {}
+test_viz_deckgl = viz.BaseDeckGLViz(datasource, form_data)
+result = test_viz_deckgl.get_metrics()
+assert result == []
+
+def test_scatterviz_get_metrics(self):
+form_data = {'size': 'large'}
+datasource = {'type': 'table'}
+
+form_data = {}
+test_viz_deckgl = viz.DeckScatterViz(datasource, form_data)
+test_viz_deckgl.point_radius_fixed = {'type': 'metric', 'value': 'int'}
+result = test_viz_deckgl.get_metrics()
+assert result == ['int']
+
+form_data = {}
+test_viz_deckgl = viz.DeckScatterViz(datasource, form_data)
+test_viz_deckgl.point_radius_fixed = {}
+result = test_viz_deckgl.get_metrics()
+assert result is None
+
+def test_get_js_columns(self):
+form_data = {'js_columns': ['a', 'b']}
+datasource = {'type': 'table'}
+mock_d = {
+'a': 'dummy1',
+'b': 'dummy2',
+'c': 'dummy3',
+}
+test_viz_deckgl = viz.BaseDeckGLViz(datasource, form_data)
+result = test_viz_deckgl.get_js_columns(mock_d)
+
+assert result == {'a': 'dummy1', 'b': 'dummy2'}
+
+def test_get_properties(self):
+mock_d = {}
+form_data = {'size': 'large'}
+datasource = {'type': 'table'}
+test_viz_deckgl = viz.BaseDeckGLViz(datasource, form_data)
+
+with self.assertRaises(NotImplementedError) as context:
+test_viz_deckgl.get_properties(mock_d)
+
+self.assertTrue('' in str(context.exception))
+
+def test_process_spatial_query_obj(self):
+form_data = {}
+datasource = {'type': 'table'}
+mock_key = 'spatial_key'
+mock_gb = []
+test_viz_deckgl = viz.BaseDeckGLViz(datasource, form_data)
+# result = test_viz_deckgl.process_spatial_query_obj(mock_key, mock_gb)
+
+with self.assertRaises(ValueError) as context:
+test_viz_deckgl.process_spatial_query_obj(mock_key, mock_gb)
+
+self.assertTrue('Bad spatial key' in str(context.exception))
+
+test_form_data = {
+'latlong_key': {
+'type': 'latlong',
+'lonCol': 'lon',
+'latCol': 'lat',
+},
+'delimited_key': {
+'type': 'delimited',
+'lonlatCol': 'lonlat',
+},
+'geohash_key': {
+'type': 'geohash',
+'geohashCol': 'geo',
+},
+}
+
+datasource = {'type': 'table'}
+expected_results = {
+'latlong_key': ['lon', 'lat'],
+'delimited_key': ['lonlat'],
+'geohash_key': ['geo'],
+}
+for mock_key in ['latlong_key', 'delimited_key', 'geohash_key']:
+mock_gb = []
+test_viz_deckgl = viz.BaseDeckGLViz(datasource, test_form_data)
+test_viz_deckgl.process_spatial_query_obj(mock_key, mock_gb)
+assert expected_results.get(mock_key) == mock_gb
+
+def test_geojson_query_obj(self):
+form_data = {'geojson': 'a'}
+datasource = {'type': 'table'}
+test_viz_deckgl = viz.DeckGeoJson(datasource, form_data)
+results = test_viz_deckgl.query_obj()
+
+assert results['metrics'] == []
+assert results['groupby'] == []
+assert results['columns'] == ['a']
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] hughhhh opened a new pull request #4688: Added DeckGL Test
hug opened a new pull request #4688: Added DeckGL Test URL: https://github.com/apache/incubator-superset/pull/4688 Here are a few test I've added for DeckGL. Wanted to get some early feedback before doing another set. @mistercrunch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hughhhh commented on issue #4473: Added DeckGL Unit Test
hug commented on issue #4473: Added DeckGL Unit Test URL: https://github.com/apache/incubator-superset/pull/4473#issuecomment-375931165 @mistercrunch Can you take look? I have another set of test coming, but wanted to get feedback on this set before moving on. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4473: [Wip] Added DeckGL unit test
codecov-io commented on issue #4473: [Wip] Added DeckGL unit test URL: https://github.com/apache/incubator-superset/pull/4473#issuecomment-371748732 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=h1) Report > Merging [#4473](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b24a6fd4b56d9a89ac1ce507f6f545c509306ceb?src=pr=desc) will **increase** coverage by `0.07%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4473 +/- ## == + Coverage 71.37% 71.44% +0.07% == Files 190 190 Lines 1491814935 +17 Branches 1102 1102 == + Hits1064810671 +23 + Misses 4267 4261 -6 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvZm9ybXMucHk=) | `98.11% <0%> (-1.89%)` | :arrow_down: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.19% <0%> (-0.03%)` | :arrow_down: | | [superset/assets/javascripts/modules/colors.js](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL21vZHVsZXMvY29sb3JzLmpz) | `77.08% <0%> (+0.48%)` | :arrow_up: | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4473/diff?src=pr=tree#diff-c3VwZXJzZXQvdml6LnB5) | `80.11% <0%> (+0.49%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=footer). Last update [b24a6fd...210b8d1](https://codecov.io/gh/apache/incubator-superset/pull/4473?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shashanksingh commented on issue #4685: superset dashboard is blank
shashanksingh commented on issue #4685: superset dashboard is blank URL: https://github.com/apache/incubator-superset/issues/4685#issuecomment-375915526 @xrmx @ManojKumarMaurya nevermind got it https://github.com/apache/incubator-superset/issues/4642 , we have to use the new Release candiate build for this to solve (0.24.0rc1) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] shashanksingh commented on issue #4685: superset dashboard is blank
shashanksingh commented on issue #4685: superset dashboard is blank URL: https://github.com/apache/incubator-superset/issues/4685#issuecomment-375915408 @xrmx I am facing the same issue, can you please point us to right P.R.. Would be really helpfull. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4687: i18n(es_es)
codecov-io commented on issue #4687: i18n(es_es) URL: https://github.com/apache/incubator-superset/pull/4687#issuecomment-375914980 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4687?src=pr=h1) Report > Merging [#4687](https://codecov.io/gh/apache/incubator-superset/pull/4687?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9abc5c724ff878ca92edce3e074ce6a4d9ea60b9?src=pr=desc) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/incubator-superset/pull/4687?src=pr=tree) ```diff @@ Coverage Diff @@ ## master #4687 +/- ## == Coverage71.4% 71.4% == Files 190 190 Lines 14935 14935 Branches 11021102 == Hits10664 10664 Misses 42684268 Partials3 3 ``` -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4687?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4687?src=pr=footer). Last update [9abc5c7...2692483](https://codecov.io/gh/apache/incubator-superset/pull/4687?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] joebordes opened a new pull request #4687: i18n(es_es)
joebordes opened a new pull request #4687: i18n(es_es) URL: https://github.com/apache/incubator-superset/pull/4687 first stab at Spanish translation This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] BobSaintClare commented on issue #2907: Superset very slow when FAB DB hosted on separate server
BobSaintClare commented on issue #2907: Superset very slow when FAB DB hosted on separate server URL: https://github.com/apache/incubator-superset/issues/2907#issuecomment-375905504 I haven't... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hughhhh commented on issue #4684: Fix up the Lyft color scheme
hug commented on issue #4684: Fix up the Lyft color scheme URL: https://github.com/apache/incubator-superset/pull/4684#issuecomment-375905241 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] villebro commented on issue #3998: [SQLLab] Allow common table expressions (CTE), a.k.a. "with" statements
villebro commented on issue #3998: [SQLLab] Allow common table expressions (CTE), a.k.a. "with" statements URL: https://github.com/apache/incubator-superset/issues/3998#issuecomment-375807662 I am unable to reproduce this bug. As we're currently using sqlparse==0.2.4, and CTEs were added in 0.2.0 (see https://github.com/andialbrecht/sqlparse/issues/227 and https://github.com/andialbrecht/sqlparse/commit/8f39d3367e8878e5f9a09b0166e3f0f73626e67d), this works in the current version of Superset. Please let me know if I am missing something, otherwise I propose closing this issue. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] villebro commented on issue #4686: Preprocess SQL Lab query prior to checking syntax
villebro commented on issue #4686: Preprocess SQL Lab query prior to checking syntax URL: https://github.com/apache/incubator-superset/pull/4686#issuecomment-375876288 Testing for this would require calling sql_lab.execute_query(), as the error arises when syntax checking happens prior to calling the template processor. Currently there doesn't seem to be a unit test for this function. If the maintainers see the need for one for this specific case, I can add one. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ManojKumarMaurya commented on issue #4685: superset dashboard is blank
ManojKumarMaurya commented on issue #4685: superset dashboard is blank URL: https://github.com/apache/incubator-superset/issues/4685#issuecomment-375887054 how can I get the fix issue really helpful if any suggestion This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4686: Preprocess SQL Lab query prior to checking syntax
codecov-io commented on issue #4686: Preprocess SQL Lab query prior to checking syntax URL: https://github.com/apache/incubator-superset/pull/4686#issuecomment-375877670 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4686?src=pr=h1) Report > Merging [#4686](https://codecov.io/gh/apache/incubator-superset/pull/4686?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/9abc5c724ff878ca92edce3e074ce6a4d9ea60b9?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `55.55%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4686?src=pr=tree) ```diff @@Coverage Diff@@ ## master #4686 +/- ## = + Coverage71.4% 71.4% +<.01% = Files 190 190 Lines 14935 14934 -1 Branches 11021102 = Hits10664 10664 + Misses 42684267 -1 Partials3 3 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4686?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4686/diff?src=pr=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `74.6% <55.55%> (+0.39%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4686?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4686?src=pr=footer). Last update [9abc5c7...43a614b](https://codecov.io/gh/apache/incubator-superset/pull/4686?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] villebro commented on issue #4686: Preprocess SQL Lab query prior to checking syntax
villebro commented on issue #4686: Preprocess SQL Lab query prior to checking syntax URL: https://github.com/apache/incubator-superset/pull/4686#issuecomment-375876288 There doesn't seem to be any tests for sql_lab.execute_query(). If the maintainers see the need for one for this specific case, I can add one. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] villebro opened a new pull request #4686: Preprocess SQL Lab query prior to checking syntax
villebro opened a new pull request #4686: Preprocess SQL Lab query prior to checking syntax URL: https://github.com/apache/incubator-superset/pull/4686 Syntax checking doesn't work if jinja templates haven't been prerendered. Also remove unreachable return statement. Fixes #4288. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] wffger commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2'
wffger commented on issue #2217: Was unable to import superset Error: No module named 'pysqlite2' URL: https://github.com/apache/incubator-superset/issues/2217#issuecomment-375862457 Reinstall Python, remember use `sudo make && sudo make altinstall`. After that, I can go ahead. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #4299: Bump sqlalchemy to 1.2.2
xrmx commented on issue #4299: Bump sqlalchemy to 1.2.2 URL: https://github.com/apache/incubator-superset/pull/4299#issuecomment-375853660 @jeffreythewang care to open an issue? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #4639: forms: make csv import parse dates accepts a list of columns
xrmx commented on issue #4639: forms: make csv import parse dates accepts a list of columns URL: https://github.com/apache/incubator-superset/pull/4639#issuecomment-375853578 Thanks @timifasubaa @graceguo-supercat ! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] villebro commented on issue #4288: Query starting with jinja2 statement is rejected because "it's not a select"
villebro commented on issue #4288: Query starting with jinja2 statement is rejected because "it's not a select" URL: https://github.com/apache/incubator-superset/issues/4288#issuecomment-375851685 Implementing this change seems pretty straight forward, but seems to require some additional refactoring to be able to implement a decent test case. Will take a stab at this in the coming days. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
