[GitHub] claycrosby closed issue #4177: New Map Not Showing in List
claycrosby closed issue #4177: New Map Not Showing in List URL: https://github.com/apache/incubator-superset/issues/4177 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] claycrosby opened a new issue #4743: New Feature: Dynamic Filtering Based on User
claycrosby opened a new issue #4743: New Feature: Dynamic Filtering Based on User URL: https://github.com/apache/incubator-superset/issues/4743 It would be great if we could configure Superset to apply dynamic filters to a dashboard based on the user/role. I'm thinking about having a way for a single dashboard record that is automatically filtered based on who's viewing it - if a user should only see data for one province, department, country, etc. (basically a dimension), an admin could assign that dimension as an auto-filter in their user / user role. This prevents an admin from having to build one pre-filtered version of the dashboard per view (which could be very numerous), and doesn't open up the risk of a user viewing data from an unauthorized area. Currently, the only restrictions like this are around individual metrics (too granular) and data sources (too broad). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jcoelho-pt commented on issue #4501: No columns imported from table from MSSQL-DB
jcoelho-pt commented on issue #4501: No columns imported from table from MSSQL-DB URL: https://github.com/apache/incubator-superset/issues/4501#issuecomment-378163776 Hello Sebastian. Were you hable to fix it? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jcoelho-pt commented on issue #4501: No columns imported from table from MSSQL-DB
jcoelho-pt commented on issue #4501: No columns imported from table from MSSQL-DB URL: https://github.com/apache/incubator-superset/issues/4501#issuecomment-378163776 Hello @sebastianwindeck. Were you hable to fix it? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #4743: New Feature: Dynamic Filtering Based on User
xrmx commented on issue #4743: New Feature: Dynamic Filtering Based on User URL: https://github.com/apache/incubator-superset/issues/4743#issuecomment-378165040 I think we already have an issue filed for this This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mansitamboli opened a new issue #4744: how to create calculation field in superset?
mansitamboli opened a new issue #4744: how to create calculation field in superset? URL: https://github.com/apache/incubator-superset/issues/4744 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and included it here as text if any - [ ] I have reproduced the issue with at least the latest released version of superset - [ ] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version ### Expected results ### Actual results ### Steps to reproduce This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sebastianwindeck commented on issue #4501: No columns imported from table from MSSQL-DB
sebastianwindeck commented on issue #4501: No columns imported from table from MSSQL-DB URL: https://github.com/apache/incubator-superset/issues/4501#issuecomment-378192784 Hey @jcoelho-pt, the fix for me to solve the Unicode issue was the shipping to superset from Py2 to Py3. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] claycrosby commented on issue #4743: New Feature: Dynamic Filtering Based on User
claycrosby commented on issue #4743: New Feature: Dynamic Filtering Based on User URL: https://github.com/apache/incubator-superset/issues/4743#issuecomment-378199949 OK, I wasn't able to find it when searching. If I find it I'll merge This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] SpyderRivera commented on issue #4626: [dashboard-builder] add top-level tabs + undo-redo
SpyderRivera commented on issue #4626: [dashboard-builder] add top-level tabs + undo-redo URL: https://github.com/apache/incubator-superset/pull/4626#issuecomment-378261581 What is the timeline for merging the dashboard-builder branch into master? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lprashant-94 commented on a change in pull request #4728: [sql_lab]Disabled run query button if sql query editor is empty
lprashant-94 commented on a change in pull request #4728: [sql_lab]Disabled run
query button if sql query editor is empty
URL:
https://github.com/apache/incubator-superset/pull/4728#discussion_r178873137
##
File path:
superset/assets/javascripts/SqlLab/components/RunQueryActionButton.jsx
##
@@ -43,6 +44,7 @@ export default function RunQueryActionButton(props) {
onClick={() => props.runQuery(true)}
key="run-async-btn"
tooltip={t('Run query asynchronously')}
+ disabled={!props.sql.trim()}
Review comment:
I have made changes, please review :+1:
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] williaster commented on issue #4626: [dashboard-builder] add top-level tabs + undo-redo
williaster commented on issue #4626: [dashboard-builder] add top-level tabs + undo-redo URL: https://github.com/apache/incubator-superset/pull/4626#issuecomment-378347567 @SpyderRivera likely another 4 weeks or so/early May, mostly because of the migration and testing needed. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] feng-tao opened a new pull request #4745: [bugfix] Fix the arguement order for security function
feng-tao opened a new pull request #4745: [bugfix] Fix the arguement order for security function URL: https://github.com/apache/incubator-superset/pull/4745 Minor bug fix: the perm and view_menu seems to be in the wrong order. cc @mistercrunch This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4736: [Explore] Adding custom expressions to adhoc metrics
codecov-io commented on issue #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#issuecomment-377995539 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=h1) Report > Merging [#4736](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f6fe11f76e0c890184ac37b25e1a4baf30bc94d1?src=pr&el=desc) will **increase** coverage by `0.04%`. > The diff coverage is `80%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#4736 +/- ## == + Coverage 72.38% 72.42% +0.04% == Files 205 205 Lines 1537415463 +89 Branches 1182 1205 +23 == + Hits1112811199 +71 - Misses 4243 4261 +18 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...ripts/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `94.11% <ø> (+5.22%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `76.18% <0%> (-1.12%)` | :arrow_down: | | [...s/javascripts/explore/propTypes/adhocMetricType.js](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvcHJvcFR5cGVzL2FkaG9jTWV0cmljVHlwZS5qcw==) | `100% <100%> (ø)` | :arrow_up: | | [...javascripts/SqlLab/components/AceEditorWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIuanN4) | `76.05% <100%> (ø)` | :arrow_up: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `88.07% <100%> (+0.02%)` | :arrow_up: | | [...pts/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `78.62% <100%> (-0.3%)` | :arrow_down: | | [superset/assets/javascripts/explore/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29uc3RhbnRzLmpz) | `100% <100%> (ø)` | :arrow_up: | | [...ipts/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `80.85% <82.35%> (-2.49%)` | :arrow_down: | | [superset/assets/javascripts/explore/AdhocMetric.js](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvQWRob2NNZXRyaWMuanM=) | `94.91% <93.18%> (-5.09%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=footer). Last update [f6fe11f...fe895c5](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4736: [Explore] Adding custom expressions to adhoc metrics
codecov-io commented on issue #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#issuecomment-377995539 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=h1) Report > Merging [#4736](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f6fe11f76e0c890184ac37b25e1a4baf30bc94d1?src=pr&el=desc) will **increase** coverage by `0.04%`. > The diff coverage is `80%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#4736 +/- ## == + Coverage 72.38% 72.42% +0.04% == Files 205 205 Lines 1537415463 +89 Branches 1182 1205 +23 == + Hits1112811199 +71 - Misses 4243 4261 +18 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...ripts/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `94.11% <ø> (+5.22%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `76.18% <0%> (-1.12%)` | :arrow_down: | | [...s/javascripts/explore/propTypes/adhocMetricType.js](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvcHJvcFR5cGVzL2FkaG9jTWV0cmljVHlwZS5qcw==) | `100% <100%> (ø)` | :arrow_up: | | [...pts/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `78.62% <100%> (-0.3%)` | :arrow_down: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `88.07% <100%> (+0.02%)` | :arrow_up: | | [superset/assets/javascripts/explore/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29uc3RhbnRzLmpz) | `100% <100%> (ø)` | :arrow_up: | | [...javascripts/SqlLab/components/AceEditorWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIuanN4) | `76.05% <100%> (ø)` | :arrow_up: | | [...ipts/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `80.85% <82.35%> (-2.49%)` | :arrow_down: | | [superset/assets/javascripts/explore/AdhocMetric.js](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvQWRob2NNZXRyaWMuanM=) | `94.91% <93.18%> (-5.09%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=footer). Last update [f6fe11f...fe895c5](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabeLoins commented on issue #4736: [Explore] Adding custom expressions to adhoc metrics
GabeLoins commented on issue #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#issuecomment-378399490 Updated based on comments from team at Airbnb- a) now the smart defaults in the simple tab will only be inferred when the simple tab can entirely describe the advanced sql expression. if not, the simple tabs defaults will be blank. b) the window can be resized if you want more working space in the advanced sql editor view heres a gif describing both features:  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4745: [bugfix] Fix the arguement order for security function
codecov-io commented on issue #4745: [bugfix] Fix the arguement order for security function URL: https://github.com/apache/incubator-superset/pull/4745#issuecomment-378399800 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4745?src=pr&el=h1) Report > Merging [#4745](https://codecov.io/gh/apache/incubator-superset/pull/4745?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f6fe11f76e0c890184ac37b25e1a4baf30bc94d1?src=pr&el=desc) will **not change** coverage. > The diff coverage is `0%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4745?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master#4745 +/- ## === Coverage 72.38% 72.38% === Files 205 205 Lines 1537415374 Branches 1182 1182 === Hits1112811128 Misses 4243 4243 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4745?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/security.py](https://codecov.io/gh/apache/incubator-superset/pull/4745/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkucHk=) | `74.21% <0%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4745?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4745?src=pr&el=footer). Last update [f6fe11f...a75d56e](https://codecov.io/gh/apache/incubator-superset/pull/4745?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #4745: [bugfix] Fix the arguement order for security function
xrmx commented on issue #4745: [bugfix] Fix the arguement order for security function URL: https://github.com/apache/incubator-superset/pull/4745#issuecomment-378400964 Opportunity to add a test? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on issue #4736: [Explore] Adding custom expressions to adhoc metrics
williaster commented on issue #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#issuecomment-378402807 @GabeLoins can we get a design pass on this before merging? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] williaster commented on issue #4736: [Explore] Adding custom expressions to adhoc metrics
williaster commented on issue #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#issuecomment-378402807 @GabeLoins can we get a design pass on this before merging? I'm mostly concerned about the size of the tabs and the strange offset once you resize the popover container This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] feng-tao commented on a change in pull request #4565: [security] Refactor security code into SupersetSecurityManager
feng-tao commented on a change in pull request #4565: [security] Refactor
security code into SupersetSecurityManager
URL:
https://github.com/apache/incubator-superset/pull/4565#discussion_r178966310
##
File path: superset/security.py
##
@@ -77,177 +78,282 @@
])
-def merge_perm(sm, permission_name, view_menu_name):
-# Implementation copied from sm.find_permission_view_menu.
-# TODO: use sm.find_permission_view_menu once issue
-# https://github.com/airbnb/superset/issues/1944 is resolved.
-permission = sm.find_permission(permission_name)
-view_menu = sm.find_view_menu(view_menu_name)
-pv = None
-if permission and view_menu:
-pv = sm.get_session.query(sm.permissionview_model).filter_by(
-permission=permission, view_menu=view_menu).first()
-if not pv and permission_name and view_menu_name:
-sm.add_permission_view_menu(permission_name, view_menu_name)
-
-
-def is_user_defined_permission(perm):
-return perm.permission.name in OBJECT_SPEC_PERMISSIONS
-
-
-def get_or_create_main_db():
-logging.info('Creating database reference')
-dbobj = (
-db.session.query(models.Database)
-.filter_by(database_name='main')
-.first()
-)
-if not dbobj:
-dbobj = models.Database(database_name='main')
-dbobj.set_sqlalchemy_uri(conf.get('SQLALCHEMY_DATABASE_URI'))
-dbobj.expose_in_sqllab = True
-dbobj.allow_run_sync = True
-db.session.add(dbobj)
-db.session.commit()
-return dbobj
-
-
-def is_admin_only(pvm):
-# not readonly operations on read only model views allowed only for admins
-if (pvm.view_menu.name in READ_ONLY_MODEL_VIEWS and
-pvm.permission.name not in READ_ONLY_PERMISSION):
-return True
-return (
-pvm.view_menu.name in ADMIN_ONLY_VIEW_MENUS or
-pvm.permission.name in ADMIN_ONLY_PERMISSIONS
-)
-
-
-def is_alpha_only(pvm):
-if (pvm.view_menu.name in GAMMA_READ_ONLY_MODEL_VIEWS and
-pvm.permission.name not in READ_ONLY_PERMISSION):
-return True
-return (
-pvm.view_menu.name in ALPHA_ONLY_VIEW_MENUS or
-pvm.permission.name in ALPHA_ONLY_PERMISSIONS
-)
-
-
-def is_admin_pvm(pvm):
-return not is_user_defined_permission(pvm)
-
-
-def is_alpha_pvm(pvm):
-return not (is_user_defined_permission(pvm) or is_admin_only(pvm))
-
-
-def is_gamma_pvm(pvm):
-return not (is_user_defined_permission(pvm) or is_admin_only(pvm) or
-is_alpha_only(pvm))
-
-
-def is_sql_lab_pvm(pvm):
-return pvm.view_menu.name in {'SQL Lab'} or pvm.permission.name in {
-'can_sql_json', 'can_csv', 'can_search_queries',
-}
-
-
-def is_granter_pvm(pvm):
-return pvm.permission.name in {
-'can_override_role_permissions', 'can_approve',
-}
-
-
-def set_role(role_name, pvm_check):
-logging.info('Syncing {} perms'.format(role_name))
-sesh = sm.get_session()
-pvms = sesh.query(ab_models.PermissionView).all()
-pvms = [p for p in pvms if p.permission and p.view_menu]
-role = sm.add_role(role_name)
-role_pvms = [p for p in pvms if pvm_check(p)]
-role.permissions = role_pvms
-sesh.merge(role)
-sesh.commit()
-
-
-def create_custom_permissions():
-# Global perms
-merge_perm(sm, 'all_datasource_access', 'all_datasource_access')
-merge_perm(sm, 'all_database_access', 'all_database_access')
-
-
-def create_missing_perms():
-"""Creates missing perms for datasources, schemas and metrics"""
-
-logging.info(
-'Fetching a set of all perms to lookup which ones are missing')
-all_pvs = set()
-for pv in sm.get_session.query(sm.permissionview_model).all():
-if pv.permission and pv.view_menu:
-all_pvs.add((pv.permission.name, pv.view_menu.name))
-
-def merge_pv(view_menu, perm):
-"""Create permission view menu only if it doesn't exist"""
-if view_menu and perm and (view_menu, perm) not in all_pvs:
-merge_perm(sm, view_menu, perm)
-
-logging.info('Creating missing datasource permissions.')
-datasources = ConnectorRegistry.get_all_datasources(db.session)
-for datasource in datasources:
-merge_pv('datasource_access', datasource.get_perm())
-merge_pv('schema_access', datasource.schema_perm)
-
-logging.info('Creating missing database permissions.')
-databases = db.session.query(models.Database).all()
-for database in databases:
-merge_pv('database_access', database.perm)
-
-logging.info('Creating missing metrics permissions')
-metrics = []
-for datasource_class in ConnectorRegistry.sources.values():
-metrics += list(db.session.query(datasource_class.metric_class).all())
-
-for metric in metrics:
-if metric.is_restricted:
-merge_pv('metric_access', metric.perm)
-
-
-def clean_perms():
-"""FAB leaves faulty permissions that need to be cleaned up"""
-logg
[GitHub] mistercrunch commented on issue #4745: [bugfix] Fix the arguement order for security function
mistercrunch commented on issue #4745: [bugfix] Fix the arguement order for security function URL: https://github.com/apache/incubator-superset/pull/4745#issuecomment-378405318 I'm wondering if the perms are reversed here somehow, which would make this a backward incompatible change... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] feng-tao commented on issue #4745: [bugfix] Fix the arguement order for security function
feng-tao commented on issue #4745: [bugfix] Fix the arguement order for security function URL: https://github.com/apache/incubator-superset/pull/4745#issuecomment-378409674 @xrmx, I could add a test if it is an issue. I hope I am not misunderstand the code... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] feng-tao opened a new pull request #4745: [bugfix] Fix the arguement order for security function
feng-tao opened a new pull request #4745: [bugfix] Fix the arguement order for security function URL: https://github.com/apache/incubator-superset/pull/4745 Minor bug fix: the perm and view_menu seems to be in the wrong order. cc @mistercrunch @hug This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] feng-tao closed pull request #4745: [bugfix] Fix the arguement order for security function
feng-tao closed pull request #4745: [bugfix] Fix the arguement order for
security function
URL: https://github.com/apache/incubator-superset/pull/4745
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/security.py b/superset/security.py
index e342b034d9..90a26fd1f8 100644
--- a/superset/security.py
+++ b/superset/security.py
@@ -211,7 +211,7 @@ def accessible_by_user(self, database, datasource_names,
schema=None):
full_names = {d.full_name for d in user_datasources}
return [d for d in datasource_names if d in full_names]
-def merge_perm(self, permission_name, view_menu_name):
+def merge_perm(self, view_menu_name, permission_name):
# Implementation copied from sm.find_permission_view_menu.
# TODO: use sm.find_permission_view_menu once issue
# https://github.com/airbnb/superset/issues/1944 is resolved.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mistercrunch opened a new pull request #4746: Filtering out SQLLab views out of table list view by default
mistercrunch opened a new pull request #4746: Filtering out SQLLab views out of table list view by default URL: https://github.com/apache/incubator-superset/pull/4746 This adds a `is_sqllab_view` flag in the "tables" table, and makes the filters those out in the Tables list view. The filter showing on top may be a bit confusing, but certainly less than seeing lots of user generated views. It fixes this: https://user-images.githubusercontent.com/487433/38277601-d74c2034-374d-11e8-812b-5b0f2b14afdc.png";> The default link to "Tables" is a bit confusing as we show the filter by default. I tried other options like using FAB's `base_filters` but it prevents the SQL Lab view from being edited / visible in any way. https://user-images.githubusercontent.com/487433/38277614-e6f393dc-374d-11e8-9147-05f0a7a05222.png";> This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch closed pull request #4728: [sql_lab]Disabled run query button if sql query editor is empty
mistercrunch closed pull request #4728: [sql_lab]Disabled run query button if
sql query editor is empty
URL: https://github.com/apache/incubator-superset/pull/4728
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/superset/assets/javascripts/SqlLab/components/RunQueryActionButton.jsx
b/superset/assets/javascripts/SqlLab/components/RunQueryActionButton.jsx
index 6ad5cc4123..dd1d8b0250 100644
--- a/superset/assets/javascripts/SqlLab/components/RunQueryActionButton.jsx
+++ b/superset/assets/javascripts/SqlLab/components/RunQueryActionButton.jsx
@@ -10,9 +10,11 @@ const propTypes = {
runQuery: PropTypes.func.isRequired,
selectedText: PropTypes.string,
stopQuery: PropTypes.func.isRequired,
+ sql: PropTypes.string.isRequired,
};
const defaultProps = {
allowAsync: false,
+ sql: '',
};
export default function RunQueryActionButton(props) {
@@ -32,6 +34,7 @@ export default function RunQueryActionButton(props) {
onClick={() => props.runQuery(false)}
key="run-btn"
tooltip={t('Run query synchronously')}
+ disabled={!props.sql.trim()}
>
{runBtnText}
@@ -43,6 +46,7 @@ export default function RunQueryActionButton(props) {
onClick={() => props.runQuery(true)}
key="run-async-btn"
tooltip={t('Run query asynchronously')}
+ disabled={!props.sql.trim()}
>
{runBtnText}
diff --git a/superset/assets/javascripts/SqlLab/components/SqlEditor.jsx
b/superset/assets/javascripts/SqlLab/components/SqlEditor.jsx
index 04f1fd19ae..b3093f3d42 100644
--- a/superset/assets/javascripts/SqlLab/components/SqlEditor.jsx
+++ b/superset/assets/javascripts/SqlLab/components/SqlEditor.jsx
@@ -215,6 +215,7 @@ class SqlEditor extends React.PureComponent {
runQuery={this.runQuery}
selectedText={qe.selectedText}
stopQuery={this.stopQuery}
+sql={this.state.sql}
/>
diff --git
a/superset/assets/spec/javascripts/explore/components/RunQueryActionButton_spec.jsx
b/superset/assets/spec/javascripts/explore/components/RunQueryActionButton_spec.jsx
index c78d1c75c4..141e471d00 100644
---
a/superset/assets/spec/javascripts/explore/components/RunQueryActionButton_spec.jsx
+++
b/superset/assets/spec/javascripts/explore/components/RunQueryActionButton_spec.jsx
@@ -16,6 +16,7 @@ describe('RunQueryActionButton', () => {
runQuery: () => {}, // eslint-disable-line
selectedText: null,
stopQuery: () => {}, // eslint-disable-line
+sql: '',
};
beforeEach(() => {
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] codecov-io commented on issue #4742: [sql lab] preserve schema through visualize flow
codecov-io commented on issue #4742: [sql lab] preserve schema through visualize flow URL: https://github.com/apache/incubator-superset/pull/4742#issuecomment-378416836 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4742?src=pr&el=h1) Report > Merging [#4742](https://codecov.io/gh/apache/incubator-superset/pull/4742?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f6fe11f76e0c890184ac37b25e1a4baf30bc94d1?src=pr&el=desc) will **increase** coverage by `0.2%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4742?src=pr&el=tree) ```diff @@Coverage Diff@@ ## master#4742 +/- ## = + Coverage 72.38% 72.58% +0.2% = Files 205 205 Lines 1537415376 +2 Branches 1182 1183 +1 = + Hits1112811161 +33 + Misses 4243 4212 -31 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4742?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...sets/javascripts/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4742/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `69.15% <ø> (ø)` | :arrow_up: | | [...s/javascripts/SqlLab/components/VisualizeModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4742/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1Zpc3VhbGl6ZU1vZGFsLmpzeA==) | `99.24% <100%> (ø)` | :arrow_up: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4742/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.48% <100%> (+2.33%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4742?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4742?src=pr&el=footer). Last update [f6fe11f...f86208e](https://codecov.io/gh/apache/incubator-superset/pull/4742?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4702: RFC: add logger that logs into browser console
codecov-io commented on issue #4702: RFC: add logger that logs into browser console URL: https://github.com/apache/incubator-superset/pull/4702#issuecomment-377009683 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4702?src=pr&el=h1) Report > Merging [#4702](https://codecov.io/gh/apache/incubator-superset/pull/4702?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f6fe11f76e0c890184ac37b25e1a4baf30bc94d1?src=pr&el=desc) will **decrease** coverage by `0.06%`. > The diff coverage is `29.16%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4702?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#4702 +/- ## == - Coverage 72.38% 72.32% -0.07% == Files 205 205 Lines 1537415394 +20 Branches 1182 1182 == + Hits1112811133 +5 - Misses 4243 4258 +15 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4702?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4702/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.15% <100%> (ø)` | :arrow_up: | | [superset/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/4702/diff?src=pr&el=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=) | `72.32% <100%> (+0.24%)` | :arrow_up: | | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/4702/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `44.06% <19.04%> (-2.77%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4702?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4702?src=pr&el=footer). Last update [f6fe11f...436d3e8](https://codecov.io/gh/apache/incubator-superset/pull/4702?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] feng-tao commented on issue #4745: [bugfix] Fix the arguement order for security function
feng-tao commented on issue #4745: [bugfix] Fix the arguement order for security function URL: https://github.com/apache/incubator-superset/pull/4745#issuecomment-378422294 @xrmx , @mistercrunch , @hug actually is it get_perm(https://github.com/apache/incubator-superset/blob/master/superset/connectors/druid/models.py#L512) actually is get_view_menu? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] feng-tao commented on issue #4745: [bugfix] Fix the arguement order for security function
feng-tao commented on issue #4745: [bugfix] Fix the arguement order for security function URL: https://github.com/apache/incubator-superset/pull/4745#issuecomment-378422294 @xrmx , @mistercrunch , @hug actually is it get_perm(https://github.com/apache/incubator-superset/blob/master/superset/connectors/druid/models.py#L512) actually get_view_menu? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] feng-tao commented on issue #4745: [bugfix] Fix the arguement order for security function
feng-tao commented on issue #4745: [bugfix] Fix the arguement order for security function URL: https://github.com/apache/incubator-superset/pull/4745#issuecomment-378422294 @xrmx , @mistercrunch , @hug actually is it get_perm(https://github.com/apache/incubator-superset/blob/master/superset/connectors/druid/models.py#L512) actually get_view_menu? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4746: Filtering out SQLLab views out of table list view by default
codecov-io commented on issue #4746: Filtering out SQLLab views out of table list view by default URL: https://github.com/apache/incubator-superset/pull/4746#issuecomment-378426925 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4746?src=pr&el=h1) Report > Merging [#4746](https://codecov.io/gh/apache/incubator-superset/pull/4746?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f6fe11f76e0c890184ac37b25e1a4baf30bc94d1?src=pr&el=desc) will **increase** coverage by `0.01%`. > The diff coverage is `93.33%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4746?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#4746 +/- ## == + Coverage 72.38% 72.39% +0.01% == Files 205 205 Lines 1537415385 +11 Branches 1182 1182 == + Hits1112811138 +10 - Misses 4243 4244 +1 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4746?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4746/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.09% <0%> (-0.06%)` | :arrow_down: | | [.../assets/javascripts/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4746/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `89.28% <100%> (+0.39%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4746/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `77.43% <100%> (+0.14%)` | :arrow_up: | | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/4746/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `71.84% <100%> (+0.27%)` | :arrow_up: | | [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/4746/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `89.74% <100%> (+0.85%)` | :arrow_up: | | [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4746/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `91.11% <100%> (+0.13%)` | :arrow_up: | | [...assets/javascripts/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4746/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `77.88% <0%> (ø)` | :arrow_up: | | [...scripts/SqlLab/components/RunQueryActionButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4746/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLmpzeA==) | `88% <0%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4746?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4746?src=pr&el=footer). Last update [f6fe11f...d1e8757](https://codecov.io/gh/apache/incubator-superset/pull/4746?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] abowden-spotx opened a new pull request #4747: [WiP] Download Dashboards as PDF
abowden-spotx opened a new pull request #4747: [WiP] Download Dashboards as PDF URL: https://github.com/apache/incubator-superset/pull/4747 Working on being able to download a dashboard or slice as a PDF so visualizations can easily be shared/emailed/etc. Still working on authentication (currently, the pdf created will show an image of the access denied and login screen), passing the correct dashboard to be downloaded, and checks on the system so the file can be saved to an appropriate folder. Any feedback is greatly appreciated! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabeLoins commented on issue #4736: [Explore] Adding custom expressions to adhoc metrics
GabeLoins commented on issue #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#issuecomment-378429603 @williaster good points. Adjusted tab widths and made it so the resize doesn't affect the arrow positioning. both features are demoed here:  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vylc opened a new issue #4748: [P00 - Line Chart] Time grain/time range changes not rendering correctly
vylc opened a new issue #4748: [P00 - Line Chart] Time grain/time range changes not rendering correctly URL: https://github.com/apache/incubator-superset/issues/4748 Make sure these boxes are checked before submitting your issue - thank you! - [ x] I have checked the superset logs for python stacktraces and included it here as text if any - [ x] I have reproduced the issue with at least the latest released version of superset - [ x] I have checked the issue tracker for the same issue and I haven't found one similar Data in the time range selected in the slider/filter doesn't fill up the entire chart. See screenshot https://user-images.githubusercontent.com/33429480/38280574-082eb254-375b-11e8-8310-5e3502eaa130.png";> This is affecting dashboards as well. instead of the chart resizing to zoom into the range that is being shown/filtered for, it just truncates to the range Another example: https://superset.lyft.net/superset/dashboard/80/?preselect_filters=%7B%22524%22%3A%7B%22__from%22%3A%2228%20days%20ago%22%2C%22__to%22%3A%2221%20days%20ago%22%2C%22__time_grain%22%3A%22hour%22%2C%22region%22%3A%5B%22BKN%22%5D%7D%2C%22525%22%3A%7B%22__from%22%3A%2228%20days%20ago%22%2C%22__to%22%3A%2221%20days%20ago%22%2C%22__granularity%22%3A%221%20hour%22%7D%7D ### Superset version ### Expected results ### Actual results ### Steps to reproduce This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vylc opened a new issue #4749: [P00 Line Chart] Time shift doesn't work with Group By dimension
vylc opened a new issue #4749: [P00 Line Chart] Time shift doesn't work with Group By dimension URL: https://github.com/apache/incubator-superset/issues/4749 Chart renders fine as is, however, when you apply a 7 day time shift, it throws an errors. Notable is that when Group by is removed, the time shift works fine http://superset-prod.lyft.net/superset/explore/?r=230 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and included it here as text if any - [ ] I have reproduced the issue with at least the latest released version of superset - [ ] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version ### Expected results ### Actual results ### Steps to reproduce This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4736: [Explore] Adding custom expressions to adhoc metrics
mistercrunch commented on issue #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#issuecomment-378431398 It's no biggy to me but tabs are usually used to organize heavy amounts of content, we probably could get away without using them at all. What about using the `PopoverSection` component?  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4736: [Explore] Adding custom expressions to adhoc metrics
codecov-io commented on issue #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#issuecomment-377995539 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=h1) Report > Merging [#4736](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7a497e2f6b9681c19954fc848b27f94856ab9089?src=pr&el=desc) will **increase** coverage by `0.03%`. > The diff coverage is `78.99%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#4736 +/- ## == + Coverage 72.38% 72.41% +0.03% == Files 205 205 Lines 1537415467 +93 Branches 1182 1205 +23 == + Hits1112811201 +73 - Misses 4243 4263 +20 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...ripts/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `94.11% <ø> (+5.22%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `76.18% <0%> (-1.12%)` | :arrow_down: | | [...s/javascripts/explore/propTypes/adhocMetricType.js](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvcHJvcFR5cGVzL2FkaG9jTWV0cmljVHlwZS5qcw==) | `100% <100%> (ø)` | :arrow_up: | | [superset/assets/javascripts/explore/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29uc3RhbnRzLmpz) | `100% <100%> (ø)` | :arrow_up: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `88.07% <100%> (+0.02%)` | :arrow_up: | | [...javascripts/SqlLab/components/AceEditorWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIuanN4) | `76.05% <100%> (ø)` | :arrow_up: | | [...pts/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `78.62% <100%> (-0.3%)` | :arrow_down: | | [...vascripts/explore/components/AdhocMetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY09wdGlvbi5qc3g=) | `91.3% <66.66%> (-3.7%)` | :arrow_down: | | [...ipts/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `80% <80.76%> (-3.34%)` | :arrow_down: | | [superset/assets/javascripts/explore/AdhocMetric.js](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvQWRob2NNZXRyaWMuanM=) | `94.91% <93.18%> (-5.09%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=footer). Last update [7a497e2...772e676](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: u
[GitHub] codecov-io commented on issue #4736: [Explore] Adding custom expressions to adhoc metrics
codecov-io commented on issue #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#issuecomment-377995539 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=h1) Report > Merging [#4736](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7a497e2f6b9681c19954fc848b27f94856ab9089?src=pr&el=desc) will **increase** coverage by `0.03%`. > The diff coverage is `78.99%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#4736 +/- ## == + Coverage 72.38% 72.41% +0.03% == Files 205 205 Lines 1537415467 +93 Branches 1182 1205 +23 == + Hits1112811201 +73 - Misses 4243 4263 +20 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...ripts/explore/components/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9NZXRyaWNEZWZpbml0aW9uVmFsdWUuanN4) | `94.11% <ø> (+5.22%)` | :arrow_up: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `76.18% <0%> (-1.12%)` | :arrow_down: | | [...javascripts/SqlLab/components/AceEditorWrapper.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIuanN4) | `76.05% <100%> (ø)` | :arrow_up: | | [superset/assets/javascripts/explore/constants.js](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29uc3RhbnRzLmpz) | `100% <100%> (ø)` | :arrow_up: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `88.07% <100%> (+0.02%)` | :arrow_up: | | [...s/javascripts/explore/propTypes/adhocMetricType.js](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvcHJvcFR5cGVzL2FkaG9jTWV0cmljVHlwZS5qcw==) | `100% <100%> (ø)` | :arrow_up: | | [...pts/explore/components/controls/MetricsControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNzQ29udHJvbC5qc3g=) | `78.62% <100%> (-0.3%)` | :arrow_down: | | [...vascripts/explore/components/AdhocMetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY09wdGlvbi5qc3g=) | `91.3% <66.66%> (-3.7%)` | :arrow_down: | | [...ipts/explore/components/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY01ldHJpY0VkaXRQb3BvdmVyLmpzeA==) | `80% <80.76%> (-3.34%)` | :arrow_down: | | [superset/assets/javascripts/explore/AdhocMetric.js](https://codecov.io/gh/apache/incubator-superset/pull/4736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvQWRob2NNZXRyaWMuanM=) | `94.91% <93.18%> (-5.09%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=footer). Last update [7a497e2...772e676](https://codecov.io/gh/apache/incubator-superset/pull/4736?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: u
[GitHub] vylc commented on issue #4107: [sql lab] data results view truncates integers at 16 digits
vylc commented on issue #4107: [sql lab] data results view truncates integers at 16 digits URL: https://github.com/apache/incubator-superset/issues/4107#issuecomment-378432039 @mistercrunch @hug with more and more ppl using SQL Lab, can we get this pushed? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vylc opened a new issue #4750: [Explore View] Time Shift column names do not carry over from Verbose Name
vylc opened a new issue #4750: [Explore View] Time Shift column names do not carry over from Verbose Name URL: https://github.com/apache/incubator-superset/issues/4750 When employing time shift, the time period comparison column names do not carry over from Verbose Name. Instead you get the verbose name for the current time period and then for the time comparison period line, it shows the original name of the column in a different color JIRA: DPTOOLS-462 Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and included it here as text if any - [ ] I have reproduced the issue with at least the latest released version of superset - [ ] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version ### Expected results ### Actual results ### Steps to reproduce This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vylc opened a new issue #4751: [P00 - Dashboard] Chart whitespace customization
vylc opened a new issue #4751: [P00 - Dashboard] Chart whitespace customization URL: https://github.com/apache/incubator-superset/issues/4751 There is too much whitespace on the line charts - this is mainly driven by how the X-axis diagonally shows values (see image) Currently, only able to shorten the vertical space of the x-axis which really only cuts off the text (also not helpful) Options: (1) Allow for text wrapping, vertical, horizontal (as well as diagonal) placing of x-axis text (2) Allow for option to not have values in x-axis to show up, relying completely on tooltip Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and included it here as text if any - [ ] I have reproduced the issue with at least the latest released version of superset - [ ] I have checked the issue tracker for the same issue and I haven't found one similar JIRA - DPTOOLS 448 ### Superset version ### Expected results ### Actual results ### Steps to reproduce This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] vylc opened a new issue #4752: [Calendar Heatmap] Improvements to make this usable
vylc opened a new issue #4752: [Calendar Heatmap] Improvements to make this
usable
URL: https://github.com/apache/incubator-superset/issues/4752
Calendar heatmap is a powerful visualization to show trends by week, hour,
day, etc., but it is currently not very useful.
Improvements:
(1) Add legend to show grain of calendar. For example, if x-axis is day and
y-axis is hour, show actual date values as well as hours
(2) Show actual metric value in box or as a tooltip when hovering over box
(3) Current heatmap is fixed and is determined by time range. Stretch to fit
size of available space.
Particularly around hourly cuts by day, trends are hard to spot when hours
wrap and start a new column
(4) Ability to define spectrum colors & grain
(a)Preset colors (orange/blue, red/green, should also be color blind safe -
will add in options shortly
(b)Color picker to choose custom colors for range
(c) Choose how many buckets to show. Current widget is defaulted at 5 (this
is okay, doesn't need to change)
Make sure these boxes are checked before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included
it here as text if any
- [ ] I have reproduced the issue with at least the latest released version
of superset
- [ ] I have checked the issue tracker for the same issue and I haven't
found one similar
### Superset version
{"GIT_SHA": "", "version": "0.24.0rc1"}
### Expected results
### Actual results
### Steps to reproduce
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] vylc opened a new issue #4753: [Annotation] Overlaid annotation layer doesn't come over with same time grain
vylc opened a new issue #4753: [Annotation] Overlaid annotation layer doesn't come over with same time grain URL: https://github.com/apache/incubator-superset/issues/4753 On a line chart, when adding an Time Series as an annotation, annotation time series comes over as a different time granularity. Time range comes over fine. Make sure these boxes are checked before submitting your issue - thank you! - [ ] I have checked the superset logs for python stacktraces and included it here as text if any - [ ] I have reproduced the issue with at least the latest released version of superset - [ ] I have checked the issue tracker for the same issue and I haven't found one similar ### Superset version ### Expected results ### Actual results ### Steps to reproduce This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch opened a new pull request #4754: [deck_multi] fixing issues with deck_multi
mistercrunch opened a new pull request #4754: [deck_multi] fixing issues with deck_multi URL: https://github.com/apache/incubator-superset/pull/4754 * bumped deck.gl related libs * add missing header to the multi-chart selector control * filtering out other `deck_multi` charts from the chart selector control * fix bug around removing charts from control would not remove them from the visualization This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] GabeLoins commented on issue #4736: [Explore] Adding custom expressions to adhoc metrics
GabeLoins commented on issue #4736: [Explore] Adding custom expressions to adhoc metrics URL: https://github.com/apache/incubator-superset/pull/4736#issuecomment-378444952 @mistercrunch yeah I definitely considered that as well when working on it. The big motivator for going with tabs is that the metric definitions could easily hit 4-5 lines if someone was defining a case/if statment. I wanted to give the Ace editor a good amount of space by default so that would be possible. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4754: [deck_multi] fixing issues with deck_multi
codecov-io commented on issue #4754: [deck_multi] fixing issues with deck_multi URL: https://github.com/apache/incubator-superset/pull/4754#issuecomment-378447046 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4754?src=pr&el=h1) Report > Merging [#4754](https://codecov.io/gh/apache/incubator-superset/pull/4754?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7a497e2f6b9681c19954fc848b27f94856ab9089?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `33.33%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4754?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#4754 +/- ## == - Coverage 72.38% 72.37% -0.01% == Files 205 205 Lines 1537415376 +2 Branches 1182 1182 == + Hits1112811129 +1 - Misses 4243 4244 +1 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4754?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4754/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `39.25% <ø> (ø)` | :arrow_up: | | [...explore/components/controls/SelectAsyncControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4754/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RBc3luY0NvbnRyb2wuanN4) | `63.15% <33.33%> (-1.55%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4754?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4754?src=pr&el=footer). Last update [7a497e2...cbc75cf](https://codecov.io/gh/apache/incubator-superset/pull/4754?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4754: [deck_multi] fixing issues with deck_multi
codecov-io commented on issue #4754: [deck_multi] fixing issues with deck_multi URL: https://github.com/apache/incubator-superset/pull/4754#issuecomment-378447046 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4754?src=pr&el=h1) Report > Merging [#4754](https://codecov.io/gh/apache/incubator-superset/pull/4754?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/7a497e2f6b9681c19954fc848b27f94856ab9089?src=pr&el=desc) will **decrease** coverage by `<.01%`. > The diff coverage is `33.33%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4754?src=pr&el=tree) ```diff @@Coverage Diff @@ ## master#4754 +/- ## == - Coverage 72.38% 72.37% -0.01% == Files 205 205 Lines 1537415376 +2 Branches 1182 1182 == + Hits1112811129 +1 - Misses 4243 4244 +1 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4754?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...set/assets/javascripts/explore/stores/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4754/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvc3RvcmVzL2NvbnRyb2xzLmpzeA==) | `39.25% <ø> (ø)` | :arrow_up: | | [...explore/components/controls/SelectAsyncControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4754/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RBc3luY0NvbnRyb2wuanN4) | `63.15% <33.33%> (-1.55%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4754?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4754?src=pr&el=footer). Last update [7a497e2...cbc75cf](https://codecov.io/gh/apache/incubator-superset/pull/4754?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] betodealmeida opened a new pull request #4755: Pass granularity from backend to frontend as ISO duration
betodealmeida opened a new pull request #4755: Pass granularity from backend to frontend as ISO duration URL: https://github.com/apache/incubator-superset/pull/4755 Currently the backend will pass the granularity as a string that is engine dependent, e.g, "30 seconds". I changed the backend so that an ISO 8601 duration is passed instead. This allows the frontend to handle the granularity better, eg, for the play slider. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hughhhh commented on issue #4107: [P00 - sql lab] data results view truncates integers at 16 digits
hug commented on issue #4107: [P00 - sql lab] data results view truncates integers at 16 digits URL: https://github.com/apache/incubator-superset/issues/4107#issuecomment-378481680 Yea i'll rope it in This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hughhhh commented on issue #4107: [P00 - sql lab] data results view truncates integers at 16 digits
hug commented on issue #4107: [P00 - sql lab] data results view truncates integers at 16 digits URL: https://github.com/apache/incubator-superset/issues/4107#issuecomment-378481680 Yea i'll rope in @fabianmenges changes into staging This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hughhhh commented on issue #4107: [P00 - sql lab] data results view truncates integers at 16 digits
hug commented on issue #4107: [P00 - sql lab] data results view truncates integers at 16 digits URL: https://github.com/apache/incubator-superset/issues/4107#issuecomment-378481680 Yea i'll rope in @fabianmenges changes into staging for us This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
