Re: Protecting "release--.*" branches

2019-03-24 Thread Maxime Beauchemin
I don't think we need a [DISCUSS] + [VOTE] thread for this subtopic
(protecting release branches).  This shouldn't be controversial:
collaborative branches should be protected. Apache INFRA isn't very fast,
so I thought I'd get this going. I think this should make sense regardless
of how SIP-12 evolves.

Happy to revert if needed.

Max

On Sun, Mar 24, 2019 at 9:30 PM Maxime Beauchemin <
maximebeauche...@gmail.com> wrote:

> Yes sorry I got confused as I had noticed `release--0.31` and assumed
> SIP-12 said `release--`.
>
> I altered the Jira to `release.*`
>
> On Sun, Mar 24, 2019 at 11:01 AM David Smith 
> wrote:
>
>> Hi John, yes I saw it said "if / is troublesome we suggest using a two
>> hyphens (--) instead."  For personal branches it makes sense to let users
>> decide how to name their branches, but for "official" and/or protected
>> branches like release, support, hotfix, etc, I think it makes sense to
>> strictly specify the format of those, and I think it makes sense to have
>> them  be something idiomatic like "[prefix]/".
>>
>> My main suggestion was that maybe this should be nailed down before we
>> start getting other folks to change repo settings. What if for now we
>> change the request to protect "release.*" ? That unblocks the short-term
>> desire to lock what we have, but gives some flexibility w.r.t to the exact
>> pattern we land on.
>>
>> Max? ^^
>>
>> Dave
>>
>>
>> On Sun, Mar 24, 2019 at 9:01 AM John Bodley > .invalid>
>> wrote:
>>
>> > Hey Dave,
>> >
>> > The branch naming convention was discussed in SIP-12
>> > . The
>> suggestion
>> > was either using '/' or '--' as the delimiter between a prefix and
>> suffix.
>> >
>> > -John
>> >
>> > On Sat, Mar 23, 2019 at 9:41 AM David Smith 
>> > wrote:
>> >
>> > > I think the discussion was around what our ability was to configure
>> this,
>> > > but I think actually submitting the request would be "downstream" of
>> > > documenting and voting on a release process and branch mechanics.
>> Should
>> > > we hold off on this?
>> > >
>> > > I think details need to be hammered out and voted on. An example, why
>> are
>> > > we using two hyphens? Can we be more "normal" and just use either
>> > > release-.* or release/.*? These decisions are going to have
>> implications
>> > > that the project is stuck with (ability to use tools that the rest of
>> the
>> > > world uses, etc), so it might be good to actually document and vote
>> on a
>> > > carefully-considered process/plan before asking the admins to
>> configure
>> > the
>> > > repos.
>> > >
>> > > Just my two cents.
>> > >
>> > > Dave
>> > >
>> > >
>> > > On Sat, Mar 23, 2019 at 9:14 AM Maxime Beauchemin <
>> > > maximebeauche...@gmail.com> wrote:
>> > >
>> > > > Hi all,
>> > > >
>> > > > As discussed, here's the request to protect release branches:
>> > > > https://issues.apache.org/jira/browse/INFRA-18082
>> > > >
>> > > > Max
>> > > >
>> > >
>> >
>>
>


Re: Protecting "release--.*" branches

2019-03-24 Thread Maxime Beauchemin
Yes sorry I got confused as I had noticed `release--0.31` and assumed
SIP-12 said `release--`.

I altered the Jira to `release.*`

On Sun, Mar 24, 2019 at 11:01 AM David Smith  wrote:

> Hi John, yes I saw it said "if / is troublesome we suggest using a two
> hyphens (--) instead."  For personal branches it makes sense to let users
> decide how to name their branches, but for "official" and/or protected
> branches like release, support, hotfix, etc, I think it makes sense to
> strictly specify the format of those, and I think it makes sense to have
> them  be something idiomatic like "[prefix]/".
>
> My main suggestion was that maybe this should be nailed down before we
> start getting other folks to change repo settings. What if for now we
> change the request to protect "release.*" ? That unblocks the short-term
> desire to lock what we have, but gives some flexibility w.r.t to the exact
> pattern we land on.
>
> Max? ^^
>
> Dave
>
>
> On Sun, Mar 24, 2019 at 9:01 AM John Bodley  .invalid>
> wrote:
>
> > Hey Dave,
> >
> > The branch naming convention was discussed in SIP-12
> > . The
> suggestion
> > was either using '/' or '--' as the delimiter between a prefix and
> suffix.
> >
> > -John
> >
> > On Sat, Mar 23, 2019 at 9:41 AM David Smith 
> > wrote:
> >
> > > I think the discussion was around what our ability was to configure
> this,
> > > but I think actually submitting the request would be "downstream" of
> > > documenting and voting on a release process and branch mechanics.
> Should
> > > we hold off on this?
> > >
> > > I think details need to be hammered out and voted on. An example, why
> are
> > > we using two hyphens? Can we be more "normal" and just use either
> > > release-.* or release/.*? These decisions are going to have
> implications
> > > that the project is stuck with (ability to use tools that the rest of
> the
> > > world uses, etc), so it might be good to actually document and vote on
> a
> > > carefully-considered process/plan before asking the admins to configure
> > the
> > > repos.
> > >
> > > Just my two cents.
> > >
> > > Dave
> > >
> > >
> > > On Sat, Mar 23, 2019 at 9:14 AM Maxime Beauchemin <
> > > maximebeauche...@gmail.com> wrote:
> > >
> > > > Hi all,
> > > >
> > > > As discussed, here's the request to protect release branches:
> > > > https://issues.apache.org/jira/browse/INFRA-18082
> > > >
> > > > Max
> > > >
> > >
> >
>


Re: Protecting "release--.*" branches

2019-03-24 Thread David Smith
Hi John, yes I saw it said "if / is troublesome we suggest using a two
hyphens (--) instead."  For personal branches it makes sense to let users
decide how to name their branches, but for "official" and/or protected
branches like release, support, hotfix, etc, I think it makes sense to
strictly specify the format of those, and I think it makes sense to have
them  be something idiomatic like "[prefix]/".

My main suggestion was that maybe this should be nailed down before we
start getting other folks to change repo settings. What if for now we
change the request to protect "release.*" ? That unblocks the short-term
desire to lock what we have, but gives some flexibility w.r.t to the exact
pattern we land on.

Max? ^^

Dave


On Sun, Mar 24, 2019 at 9:01 AM John Bodley 
wrote:

> Hey Dave,
>
> The branch naming convention was discussed in SIP-12
> . The suggestion
> was either using '/' or '--' as the delimiter between a prefix and suffix.
>
> -John
>
> On Sat, Mar 23, 2019 at 9:41 AM David Smith 
> wrote:
>
> > I think the discussion was around what our ability was to configure this,
> > but I think actually submitting the request would be "downstream" of
> > documenting and voting on a release process and branch mechanics.  Should
> > we hold off on this?
> >
> > I think details need to be hammered out and voted on. An example, why are
> > we using two hyphens? Can we be more "normal" and just use either
> > release-.* or release/.*? These decisions are going to have implications
> > that the project is stuck with (ability to use tools that the rest of the
> > world uses, etc), so it might be good to actually document and vote on a
> > carefully-considered process/plan before asking the admins to configure
> the
> > repos.
> >
> > Just my two cents.
> >
> > Dave
> >
> >
> > On Sat, Mar 23, 2019 at 9:14 AM Maxime Beauchemin <
> > maximebeauche...@gmail.com> wrote:
> >
> > > Hi all,
> > >
> > > As discussed, here's the request to protect release branches:
> > > https://issues.apache.org/jira/browse/INFRA-18082
> > >
> > > Max
> > >
> >
>


Re: Protecting "release--.*" branches

2019-03-24 Thread John Bodley
Hey Dave,

The branch naming convention was discussed in SIP-12
. The suggestion
was either using '/' or '--' as the delimiter between a prefix and suffix.

-John

On Sat, Mar 23, 2019 at 9:41 AM David Smith  wrote:

> I think the discussion was around what our ability was to configure this,
> but I think actually submitting the request would be "downstream" of
> documenting and voting on a release process and branch mechanics.  Should
> we hold off on this?
>
> I think details need to be hammered out and voted on. An example, why are
> we using two hyphens? Can we be more "normal" and just use either
> release-.* or release/.*? These decisions are going to have implications
> that the project is stuck with (ability to use tools that the rest of the
> world uses, etc), so it might be good to actually document and vote on a
> carefully-considered process/plan before asking the admins to configure the
> repos.
>
> Just my two cents.
>
> Dave
>
>
> On Sat, Mar 23, 2019 at 9:14 AM Maxime Beauchemin <
> maximebeauche...@gmail.com> wrote:
>
> > Hi all,
> >
> > As discussed, here's the request to protect release branches:
> > https://issues.apache.org/jira/browse/INFRA-18082
> >
> > Max
> >
>