Re: [VOTE] Release Apache Superset (incubating) 0.37.0 based on Superset 0.37.0rc2

[John Bodley]

+1 (binding)

On Thu, Jul 16, 2020 at 10:57 AM Erik Ritter 
wrote:

> +1 binding
>
> Erik
>
> On Thu, Jul 16, 2020 at 3:02 AM Ville Brofeldt  >
> wrote:
>
> > Hello Superset Community,
> >
> > This is a call for the vote to release Apache Superset
> > (incubating) version 0.37.0.
> >
> > The release candidate:
> > https://dist.apache.org/repos/dist/dev/incubator/superset/0.37.0rc2/
> >
> > Git tag for the release:
> > https://github.com/apache/incubator-superset/tree/0.37.0rc2
> >
> > The Change Log for the release:
> > https://github.com/apache/incubator-superset/blob/0.37.0rc2/CHANGELOG.md
> >
> > The Updating instructions for the release:
> > https://github.com/apache/incubator-superset/blob/0.37.0rc2/UPDATING.md
> >
> > public keys are available at:
> >
> > https://www.apache.org/dist/incubator/superset/KEYS
> >
> > The vote will be open for at least 72 hours or until the necessary number
> > of votes are reached.
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks,
> > The Apache Superset (Incubating) Team
>

Re: [VOTE] Release Apache Superset (incubating) 0.37.0 based on Superset 0.37.0rc1

[John Bodley]

+1 (binding)

On Sat, Jul 11, 2020 at 1:53 AM Ville Brofeldt 
wrote:

> Hello Superset Community,
>
> This is a call for the vote to release Apache Superset
> (incubating) version 0.37.0.
>
> The release candidate:
> https://dist.apache.org/repos/dist/dev/incubator/superset/0.37.0rc1/
>
> Git tag for the release:
> https://github.com/apache/incubator-superset/tree/0.37.0rc1
>
> The Change Log for the release:
> https://github.com/apache/incubator-superset/blob/0.37.0rc1/CHANGELOG.md
>
> public keys are available at:
>
> https://www.apache.org/dist/incubator/superset/KEYS
>
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
>
> Please vote accordingly:
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> Thanks,
> The Apache Superset (Incubating) Team

[DISCUSS] Proposal for improved UX for dashboard filter eligibility

[John Bodley]

Hi,

I was wondering whether people could review [SIP-45] Proposal for improved
UX for dashboard filter eligibility
 which proposes
an update to dashboard filters to ensure that they can only be enabled on
eligible charts, i.e., those where the filters relate to the underlying
chart datasource.

Thanks
-John

Re: [DISCUSS] SIP-35 Proposal for Improving Superset’s Python Code Organization

[John Bodley]

+1 (non-binding)

On Mon, Feb 24, 2020 at 4:54 PM Craig Rueda  wrote:

> +1 binding
> 
> From: Rob DiCiuccio 
> Sent: Monday, February 24, 2020 4:45 PM
> To: dev@superset.incubator.apache.org 
> Subject: Re: [DISCUSS] SIP-35 Proposal for Improving Superset’s Python
> Code Organization
>
> Note that this is a *new vote* for SIP-35, now that discussions are largely
> finished, and should replace the previous vote.
>
> +1 (non-binding)
>
> On Mon, Feb 24, 2020 at 4:39 PM Craig Rueda  wrote:
>
> > Please discuss & subscribe here:
> >
> > https://github.com/apache/incubator-superset/issues/9077
> >
>
>
> --
>
> *Rob DiCiuccio*
> Director of Engineering
> Preset | https://preset.io
>

Re: [VOTE] [SIP-35] Proposal for Improving Superset’s Python Code Organization

[John Bodley]

+1 (non-binding) for refactoring/reorganizing the code.
-1 (non-binding) for the execution/approach as I sense this topic is
still actively being discussed in the SIP.

> On Feb 14, 2020, at 10:53 PM, Ville Brofeldt  
> wrote:
>
> +1 binding (I will add my comments to the associated issue)
>
> Ville
>
>
>> On Fri, Feb 14, 2020, 13:14 daniel gaspar  wrote:
>>
>> Hello Superset Community,
>>
>> This is a call to vote for SIP-35 Proposal for Improving Superset’s Python
>> Code Organization.
>>
>> Further details here:
>> https://github.com/apache/incubator-superset/issues/9077
>>
>> The vote will be open for at least 1 Week or until the necessary number of
>> votes are reached.
>>
>> Please vote accordingly:
>>
>> [ ] +1 approve
>> [ ] +0 no opinion
>> [ ] -1 disapprove with the reason
>>
>> Thanks,
>> Daniel Gaspar
>>

Re: [VOTE] [SIP-36] Proposal for standardizing use of TypeScript

[John Bodley]

+1 (non-binding)

On Mon, Feb 10, 2020 at 5:35 PM Evan Rusackas  wrote:

> +1 (non-binding)
>
> Evan Rusackas
> Preset, Inc.
> On Feb 10, 2020, 5:14 PM -0800, Erik Ritter ,
> wrote:
> > Superset Community,
> >
> > This is a call to vote for SIP-36: Proposal for standardizing use of
> > TypeScript.
> >
> > Further details here:
> > https://github.com/apache/incubator-superset/issues/9101
> >
> > The vote will be open for at least 1 Week or until the necessary number
> of
> > votes are reached.
> >
> > Please vote accordingly:
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > Thanks!
> > Erik
>

[jira] [Commented] (SUPERSET-11) Remove unnecessary parens in druid/models.py

[John Bodley (Jira)]

[ 
https://issues.apache.org/jira/browse/SUPERSET-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951221#comment-16951221
 ] 

John Bodley commented on SUPERSET-11:
-

Note that pylint should identify these issues. Currently we have numerous 
warnings disabled either in `.pylintrc` or at the fie level.

> Remove unnecessary parens in druid/models.py
> 
>
> Key: SUPERSET-11
> URL: https://issues.apache.org/jira/browse/SUPERSET-11
> Project: Superset
>  Issue Type: Improvement
>Reporter: Jakob Homan
>Priority: Trivial
>  Labels: newbie
>
> Line: 425
> {code:python:title=druids.model/py}
> @property
> def perm(self) -> Optional[str]:
> return (
> ("{parent_name}.[{obj.metric_name}](id:{obj.id})").format(
> obj=self, parent_name=self.datasource.full_name
> )
> if self.datasource
> else None
> )
> {code}
> The parens around the string are not necessary and add visual confusion to 
> the other parens in the statement.  They should be removed and format 
> directly called on the string.
> *Note:* This is a newbie ticket designed as a starter task for a new 
> contributor.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[VOTE] SIP-15/15A Proposal for Transparent and Consistent Time Intervals

[John Bodley]

Hi,

I would like to call a vote on SIP-15/15A:

   - https://github.com/apache/incubator-superset/issues/6360
   - https://github.com/apache/incubator-superset/issues/7656

These are proposals for transparent and consistent time intervals across
the Druid REST API and SQLAlchemy connectors. Note though the logic is
quite simple the changes required are somewhat involved and include a
method for transitioning between the current and proposed solutions.

If anyone has any hesitation, questions, or concerns about the logic please
comment on the relevant SIPs.

Thanks
-John

Re: Issue 5791 - Need feedback

[John Bodley]

I’ve added some comments to your PR. It’s probably best to
discuss/iterate on the memoized issue in the PR.

> On May 21, 2019, at 12:58 AM, Gianluca Ciccarelli 
>  wrote:
>
> Hi all,
>
> I’d appreciate feedback on my PR (at 
> https://github.com/apache/incubator-superset/pull/7403/).
>
> I’m almost done addressing the 5 errors found by lgtm.com 
> (https://lgtm.com/projects/g/apache/incubator-superset/alerts/?mode=list=error).
>  I’m only having problems understanding how to fix the alert about memoized 
> (called "Mutation of descriptor in __get__ or __set__ method.”).
>
> Any suggestion is more than welcome!
>
> Gianluca Ciccarelli
> Data Engineer @ Bolt

Re: Superset production setup

[John Bodley]

Hi Matthew,

In answer to your questions (from Airbnb's perspective):

   1. Regarding a production environment it's probably highly dependent on
   your use case. At a minimum I would suggest having at least 3 web-servers
   (we use Gunicorn ) and 3 Celery workers for
   redundancy. We use Datadog for monitoring/alerting which has helped us
   track load and scale accordingly. We use Kubernetes for deployment which
   includes some elasticity, though currently we're running 3 web-servers and
   5+ Celery workers. The later may be overkill though we're trying to debug
   an ongoing QueuePool issue.
   2. We use AWS to house Redis, Superset, Celery, etc. which all run from
   the same region
   

   .
   3. Our servers run on 4 cores with 10 GB of memory. Note we haven't
   optimized this configuration.
   4. We have low thousands of weekly active users for Superset and SQL
   Lab.

-John




On Mon, May 20, 2019 at 12:24 AM Matthew Mutee  wrote:

> Hi dev,
>
> We have been testing superset for the last couple of months and now want to
> set it up in production. Could you please share what sort of resourcing
> considerations you have made for  your superset installation.
>
> I am interested in:
>
>1. Number of servers used for load balancing.
>2. Placement of  applications; redis, superset, celelery, nginx etc.
>3. Actual resources in the servers; memory, cores etc
>4. The average users accessing superset per day.
>
> Thanks :-)
>
> Regards,
> Matthew M.
>

Re: [VOTE] Hosting questions / answers on StackOverFlow

[John Bodley]

+1

> On Apr 23, 2019, at 7:02 PM, Jeff Feng  wrote:
>
> +1
>
> On Tue, Apr 23, 2019 at 6:19 PM Chris Williams
>  wrote:
>
>> +1
>>
>> Chris
>>
>> Data Visualization
>> San Francisco
>>
>>
>> On Tue, Apr 23, 2019 at 6:03 PM Abhishek Sharma <
>> abhioncbr.apa...@gmail.com>
>> wrote:
>>
>>> +1
>>>
>>> On Tue, Apr 23, 2019 at 8:49 PM Kan Ouivirach 
>>> wrote:
>>>
 +1

 On Wed, Apr 24, 2019 at 7:47 AM Michelle Thomas
  wrote:

> +1
>
> On Tue, Apr 23, 2019 at 5:42 PM Krist Wongsuphasawat <
> krist.wo...@gmail.com>
> wrote:
>
>> Hi Superset Community,
>>
>> Per the previous thread "[DISCUSS] Best place for questions /
>>> answers",
>> there is a proposal to
>>
>>   - Host Superset Q (questions such as "How do I do something in
>>   Superset?") on StackOverFlow instead of github issues.
>>   - New questions on other channels (github/slack/etc.) will not
>> be
>>   answered and the authors will be notified to ask on
>> StackOverFlow
>> instead.
>>   - Only keep bug reports, feature requests and project
>> maintenance
> issues
>>   on github. Old FAQs can be copied over to StackOverFlow. (Will
>>> need
>>   volunteers for this.)
>>
>> I would like to call for a VOTE to migrate to StackOverFlow.
>> Please +1 if you support this decision, 0 for no comment or -1 if
>> you
>> disagree.
>>
>> This poll will end on Friday April 26th, 11:59pm Pacific time.
>>
>> Best regards,
>>
>> Krist
>>
>> --
>>
>> *Krist Wongsuphasawat*
>> http://kristw.yellowpigz.com
>>
>

>>>
>>

Re: Latest release of Superset has no flower dependency.

[John Bodley]

Hi,

Per the update

since
0.31.0 Celery flower is optional and thus you will need to manually install
it in your environment. We've marked a number of non-required packages as
optional.

-John

On Mon, Apr 22, 2019 at 4:19 PM Abhishek Sharma 
wrote:

> Hi,
>
> Thanks for releasing a new version of Superset.
> While using the latest version of Superset, I realized flower dependency is
> not there. It is a good package for monitoring Celery. Is it dropped
> purposely?
>
> Also, please add me as a contributor for Superset Jira. My Jira id is
> *abhioncbr*
>
> Thanks
> Abhishek
>

Re: [VOTE] Release Superset 0.31.0 based on Superset 0.31.0 RC18

[John Bodley]

+1

On Sun, Apr 14, 2019 at 9:18 AM Krist Wongsuphasawat 
wrote:

> +1 exciting!
>
> Best regards,
>
> Krist
>
> --
>
> Krist Wongsuphasawat
> http://kristw.yellowpigz.com
> On Apr 14, 2019, 06:24 -0700, Jeff Feng ,
> wrote:
> > +1 Binding
> >
> > On Sun, Apr 14, 2019 at 6:20 AM Bolke de Bruin 
> wrote:
> >
> > > +1, non-binding
> > >
> > > I checked:
> > >
> > > * SHA512
> > > * Signature of the release, can use some improvement but the key
> checks out
> > > here (https://people.apache.org/keys/committer/):
> > >
> > > gpg: Signature made Tue Mar 19 07:35:24 2019 CET
> > > gpg: using RSA key BB990B01715969F648C7A65472DC479A3011B01B
> > > gpg: Good signature from "Maxime Beauchemin <
> maximebeauche...@gmail.com>"
> > > [unknown]
> > > gpg: WARNING: This key is not certified with a trusted signature!
> > > gpg: There is no indication that the signature belongs to the
> > > owner.
> > > Primary key fingerprint: BB99 0B01 7159 69F6 48C7 A654 72DC 479A 3011
> B01B
> > >
> > > * NOTICE present
> > > * LICENSE present
> > > * DISCLAIMER present
> > > * INSTALL.txt present (did not check build)
> > > * ran apache-rat
> > >
> > > Good luck at the incubator!
> > >
> > > (O and the vote is open for a minimum of 48h I believe :-) ).
> > >
> > > B.
> > >
> > >
> > >
> > > On 14 April 2019 at 00:24:11, Jeff Feng (jeff.f...@airbnb.com.invalid)
> > > wrote:
> > >
> > > ++ this is very exciting. Thank you Max!
> > >
> > > On Sat, Apr 13, 2019 at 3:19 PM Bolke de Bruin 
> wrote:
> > >
> > > > Great stuff Max! Good to see this happening!
> > > >
> > > > - Maybe good to note that only the vote of committers counts as a
> binding
> > > > vote and that it's good practice to make that clear when voting?
> > > >
> > > > I'll verify the release tomorrow.
> > > >
> > > > B.
> > > >
> > > > Sent from my iPhone
> > > >
> > > > > On 13 Apr 2019, at 23:56, Maxime Beauchemin <
> > > maximebeauche...@gmail.com>
> > >
> > > > wrote:
> > > > >
> > > > > Dear all,
> > > > >
> > > > > The source release 0.31.0 RC18 for Apache Superset is baked and
> > > available
> > > > > at:
> > > > > https://dist.apache.org/repos/dist/dev/incubator/superset/, public
> > > > > keys are available
> > > > > at
> https://dist.apache.org/repos/dist/release/incubator/superset/KEYS
> > > > >
> > > > > This is the first ASF release candidate of Superset (!)* We're
> still
> > > > > ironing out our release process, so please bear with us and help
> if you
> > > > can*.
> > > > > Note that we understand that starting at "RC18" is confusing, but
> > > > > constitute an outlier as we handoff from the old process to the new
> > > one.
> > > > > From this point onwards, we intend on using a linear sequence that
> maps
> > > > > one-to-one with Apache-submitted release candidates. The term
> release
> > > > > candidate and label RC should be exclusive to the proper
> > > Apache-compliant
> > > > > release process moving forward.
> > > > >
> > > > > Also note that I decided to use the label `0.31.0rc18` (pypi
> compliant)
> > > > > instead of a semver compliant `0.31.0-rc.18` which Pypi and
> Python's
> > > > > PEP-440 won't allow. This being a Python project, we use Python's
> > > > standards.
> > > > >
> > > > > As I went along, I documented the process in RELEASING.md in the
> repo,
> > > > > latest edits here
> > > > > https://github.com/apache/incubator-superset/pull/7296/files
> > > > >
> > > > > For context, the `0.31` release branch was cut at SHA 1fece0d2f,
> that
> > > was
> > > > > merged on master on Jan 22nd. From that common ancestor, the
> following
> > > > list
> > > > > of commit was added as cherry-picks. The SHAs in the list bellow
> > > > reference
> > > > > the cherries on the release branch, PR number are available to get
> more
> > > > > details.
> > > > >
> > > > > c43d0fd3 [sqlparse] Fixing table name extraction for ill-defined
> query
> > > > > (#7029)
> > > > > b64a452a [sql lab] improve table name detection in free form SQL
> > > (#6793)
> > > > > 2357c4aa Adding custom control overrides (#6956)
> > > > > 9dd7e84a [sql-parse] Fixing LIMIT exceptions (#6963)
> > > > > 5d8dd142 [csv-upload] Fixing message encoding (#6971)
> > > > > f454dedd [main] Disable resetting main DB attributes (#6845)
> > > > > e967b268 [sqla] Fixing order-by for non-inner-joins (#6862)
> > > > > a5d9a4e0 Adding template_params to datasource editor for sqla
> tables
> > > > (#6869)
> > > > > 6b895413 [datasource] Ensuring consistent behavior of datasource
> > > > > editing/saving. (#7037)
> > > > > 8ef2789f Adding warning message for sqllab save query (#7028)
> > > > > 0ebdb564 fix inaccurate data calculation with adata rolling and
> > > > > contribution (#7035)
> > > > > b3af6a26 [fix] explore chart from dashboard missed slice title
> (#7046)
> > > > > c54b067c [db-engine-spec] Aligning Hive/Presto partition logic
> (#7007)
> > > > > bd65942e Changing time table viz to pass formatTime a date (#7020)
> > > > > 50accda9 [fix] Cursor jumping when editing chart and 

Re: [DISCUSS] Best place for questions / answers

[John Bodley]

Hi,

I’m supportive of using Stack Overflow for Q It’s more 
discoverable/searchable than email and Slack, encourages community involvement, 
and helps to mitigate repeated questions.

-John

> On Apr 3, 2019, at 8:52 AM, Maxime Beauchemin  
> wrote:
> 
> In this issue https://github.com/apache/incubator-superset/issues/7160
> about sorting / closing our PRs and Github issues, there's a subtopic about
> how to handle questions.
> 
> It'd be nice to separate the channels for:
> * announcements / conversations / votes / design reviews / [DISCUSS] (ASF
> mailing list!)
> * issues / bugs / SIPs (Github!)
> * questions / answers ()
> 
> StackOverflow has proven to be a great place for this, it supports voting /
> bubbling up top answers, has unbeatable SEO, versioning of answers,
> supports rich content (code snippets, screenshots, ...), and gamifies the
> whole process.
> 
> What's the ASF recommended place for Q/A? Provided a consensus + winning
> vote, could we just direct people to StackOverflow?
> 
> Max

Re: Protecting "release--.*" branches

[John Bodley]

Hey Dave,

The branch naming convention was discussed in SIP-12
. The suggestion
was either using '/' or '--' as the delimiter between a prefix and suffix.

-John

On Sat, Mar 23, 2019 at 9:41 AM David Smith  wrote:

> I think the discussion was around what our ability was to configure this,
> but I think actually submitting the request would be "downstream" of
> documenting and voting on a release process and branch mechanics.  Should
> we hold off on this?
>
> I think details need to be hammered out and voted on. An example, why are
> we using two hyphens? Can we be more "normal" and just use either
> release-.* or release/.*? These decisions are going to have implications
> that the project is stuck with (ability to use tools that the rest of the
> world uses, etc), so it might be good to actually document and vote on a
> carefully-considered process/plan before asking the admins to configure the
> repos.
>
> Just my two cents.
>
> Dave
>
>
> On Sat, Mar 23, 2019 at 9:14 AM Maxime Beauchemin <
> maximebeauche...@gmail.com> wrote:
>
> > Hi all,
> >
> > As discussed, here's the request to protect release branches:
> > https://issues.apache.org/jira/browse/INFRA-18082
> >
> > Max
> >
>

[VOTE] SIP-12 Proposal for Branch Management and Release Process

[John Bodley]

Hi,

I would like to call a vote on [SIP-12] Proposal for Branch Management and
Release Process .

Thanks
-John

Re: [Vote] SIP-13: Proposal for Code Review Process

[John Bodley]

+1

> On Nov 8, 2018, at 3:05 PM, Grace Guo  wrote:
>
> +1
>
> - Grace
>
>
>> On Nov 8, 2018, at 10:59 AM, Krist Wongsuphasawat  
>> wrote:
>>
>> Hi dev@superset,
>>
>> I would like to call a vote on *SIP-13: Proposal for Code Review Process*.
>>
>> The proposal details and discussion can be found here.
>> https://github.com/apache/incubator-superset/issues/6132
>> One small modification from the original proposal is I have dropped the
>> stale branch check.
>>
>> Best regards,
>>
>> Krist
>

Re: [SIP-0] Vote

[John Bodley]

+1

On Wed, Oct 24, 2018 at 2:02 PM Krist Wongsuphasawat 
wrote:

> +1
>
> On Wed, Oct 24, 2018 at 1:59 PM Beto Dealmeida 
> wrote:
>
> > Hi, all.
> >
> > I would like to call a vote on SIP-0, "Superset Improvement Proposals":
> >
> > https://github.com/apache/incubator-superset/issues/5602
> >
> > Beto
> >
> >
>
> --
>
> *Krist Wongsuphasawat, PhD*
> http://kristw.yellowpigz.com
>

[SIP-12] Proposal for Branch Management and Release Process

[John Bodley]

https://github.com/apache/incubator-superset/issues/6131

Re: [VOTE] Deprecate support for Python <3.6

[John Bodley]

+1

> On Sep 20, 2018, at 9:51 PM, Maxime Beauchemin  
> wrote:
> 
> Since Superset is a product, and not a library, people have the luxury to
> pick which version of Python they desire when setting up Superset.
> 
> Supporting 2.7 has been a burden and we have to look into the future.
> 
> Arguments for this:
> * take advantage of py2.7...py3.6 features
>   * type annotations
>   * async / await
>   * fstrings syntactic sugar
>   * a decade of improvements listed here:
> https://docs.python.org/3/whatsnew/index.html
> * less Superset bugs related to version incompatibilities
> * free up slots in the build matrix
> * faster
> * maintained beyond 2020
> 
> Cons:
> * People living in the past will have to update their deploy scripts now
> instead of a year from now
> 
> -
> if you "-1" please state your reasons!

Re: Superset default tables

[John Bodley]

Hi,

I'm uncertain whether you're trying to upgrade an existing deployment or
installing a new deployment, but Superset needs it's own database (which is
specified in the SQLAlchemy URI). If you're creating a new deployment you
should follow these

instructions, which creates the necessary database tables and populate them
with the Flask App Builder (FAB) security permissions as well as the
example dataset. If you're simply upgrading to a newer version you should
follow these 
instructions.

-John

On Tue, May 15, 2018 at 10:48 AM, arindos.ext...@gmail.com <
arindos.ext...@gmail.com> wrote:

> I am attempting to deploy superset 0.24.0 with my MySQL server set in the
> ‘SQLALCHEMY_DATABASE_URI’ field. The issue I run into is superset attempts
> to create a ‘logs’ table on my database, on which I already have a table
> named logs so a create conflict occurs and superset fails to start. What
> other tables are setup by default by Superset? Can I change the name of
> them in a startup config? Is there an easy way around this problem I face?
>