[GitHub] Mogball closed pull request #3668: [Explore] Altered Slice Tag

[git]

Mogball closed pull request #3668: [Explore] Altered Slice Tag
URL: https://github.com/apache/incubator-superset/pull/3668
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/javascripts/components/AlteredSliceTag.jsx 
b/superset/assets/javascripts/components/AlteredSliceTag.jsx
new file mode 100644
index 00..eb24424e8d
--- /dev/null
+++ b/superset/assets/javascripts/components/AlteredSliceTag.jsx
@@ -0,0 +1,145 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+import { Table, Tr, Td, Thead, Th } from 'reactable';
+import { isEqual, isEmpty } from 'underscore';
+
+import TooltipWrapper from './TooltipWrapper';
+import { controls } from '../explore/stores/controls';
+import ModalTrigger from './ModalTrigger';
+import { t } from '../locales';
+
+const propTypes = {
+  origFormData: PropTypes.object.isRequired,
+  currentFormData: PropTypes.object.isRequired,
+};
+
+export default class AlteredSliceTag extends React.Component {
+
+  constructor(props) {
+super(props);
+const diffs = this.getDiffs(props);
+this.state = { diffs, hasDiffs: !isEmpty(diffs) };
+  }
+
+  componentWillReceiveProps(newProps) {
+// Update differences if need be
+if (isEqual(this.props, newProps)) {
+  return;
+}
+const diffs = this.getDiffs(newProps);
+this.setState({ diffs, hasDiffs: !isEmpty(diffs) });
+  }
+
+  getDiffs(props) {
+// Returns all properties that differ in the
+// current form data and the saved form data
+const ofd = props.origFormData;
+const cfd = props.currentFormData;
+const fdKeys = Object.keys(cfd);
+const diffs = {};
+for (const fdKey of fdKeys) {
+  // Ignore values that are undefined/nonexisting in either
+  if (!ofd[fdKey] && !cfd[fdKey]) {
+continue;
+  }
+  if (!isEqual(ofd[fdKey], cfd[fdKey])) {
+diffs[fdKey] = { before: ofd[fdKey], after: cfd[fdKey] };
+  }
+}
+return diffs;
+  }
+
+  formatValue(value, key) {
+// Format display value based on the control type
+// or the value type
+if (value === undefined) {
+  return 'N/A';
+} else if (value === null) {
+  return 'null';
+} else if (controls[key] && controls[key].type === 'FilterControl') {
+  if (!value.length) {
+return '[]';
+  }
+  return value.map((v) => {
+const filterVal = v.val.constructor === Array ? `[${v.val.join(', 
')}]` : v.val;
+return `${v.col} ${v.op} ${filterVal}`;
+  }).join(', ');
+} else if (controls[key] && controls[key].type === 'BoundsControl') {
+  return `Min: ${value[0]}, Max: ${value[1]}`;
+} else if (controls[key] && controls[key].type === 'CollectionControl') {
+  return value.map(v => JSON.stringify(v)).join(', ');
+} else if (typeof value === 'boolean') {
+  return value ? 'true' : 'false';
+} else if (value.constructor === Array) {
+  return value.length ? value.join(', ') : '[]';
+} else if (typeof value === 'string' || typeof value === 'number') {
+  return value;
+}
+return JSON.stringify(value);
+  }
+
+  renderRows() {
+const diffs = this.state.diffs;
+const rows = [];
+for (const key in diffs) {
+  rows.push(
+
+  
+  {this.formatValue(diffs[key].before, key)}
+  {this.formatValue(diffs[key].after, key)}
+,
+  );
+}
+return rows;
+  }
+
+  renderModalBody() {
+return (
+  
+
+  Control
+  Before
+  After
+
+{this.renderRows()}
+  
+);
+  }
+
+  renderTriggerNode() {
+return (
+  
+
+  {t('Altered')}
+
+  
+);
+  }
+
+  render() {
+// Return nothing if there are no differences
+if (!this.state.hasDiffs) {
+  return null;
+}
+// Render the label-warning 'Altered' tag which the user may
+// click to open a modal containing a table summarizing the
+// differences in the slice
+return (
+  
+);
+  }
+}
+
+AlteredSliceTag.propTypes = propTypes;
diff --git a/superset/assets/javascripts/explore/components/ChartContainer.jsx 
b/superset/assets/javascripts/explore/components/ChartContainer.jsx
index f3c660adf6..f74a263af7 100644
--- a/superset/assets/javascripts/explore/components/ChartContainer.jsx
+++ b/superset/assets/javascripts/explore/components/ChartContainer.jsx
@@ -8,6 +8,7 @@ import visMap from '../../

[GitHub] coveralls commented on issue #3492: PandasConnector

[git]

coveralls commented on issue #3492: PandasConnector
URL: 
https://github.com/apache/incubator-superset/pull/3492#issuecomment-337253705
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13755061/badge)](https://coveralls.io/builds/13755061)
   
   Coverage increased (+1.3%) to 71.412% when pulling 
**bb78be855a81c683bf47bb2ee073a8cbe9042954 on kimetrica:3302-pandas-connctor** 
into **ef59b6b6508d29588931755d22023b845ced8712 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] gauravbansal2000 commented on issue #1003: Multiple Y-Axes for Line Chart

[git]

gauravbansal2000 commented on issue #1003: Multiple Y-Axes for Line Chart
URL: 
https://github.com/apache/incubator-superset/issues/1003#issuecomment-337235527
 
 
   Ok so i tried using dual line axis. And it only supports two metrics one on 
1st y axis and 2nd on 2nd y axis. is there any easy way to add three metrics?  
since nvd3's multichart supports multiple metrics some on y1 and some on y2.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3683: [cleanup] removing print() artefacts

[git]

coveralls commented on issue #3683: [cleanup] removing print() artefacts
URL: 
https://github.com/apache/incubator-superset/pull/3683#issuecomment-337107162
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13747469/badge)](https://coveralls.io/builds/13747469)
   
   Coverage decreased (-0.01%) to 70.384% when pulling 
**24c25853671614f5572bbece45e30a80bc4086f3 on mistercrunch:fix_print** into 
**08f09b47615937337f232bd39361632564a15f81 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3683: [cleanup] removing print() artefacts

[git]

coveralls commented on issue #3683: [cleanup] removing print() artefacts
URL: 
https://github.com/apache/incubator-superset/pull/3683#issuecomment-337107163
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13747469/badge)](https://coveralls.io/builds/13747469)
   
   Coverage decreased (-0.01%) to 70.384% when pulling 
**24c25853671614f5572bbece45e30a80bc4086f3 on mistercrunch:fix_print** into 
**08f09b47615937337f232bd39361632564a15f81 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3683: [cleanup] removing print() artefacts

[git]

coveralls commented on issue #3683: [cleanup] removing print() artefacts
URL: 
https://github.com/apache/incubator-superset/pull/3683#issuecomment-337107161
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13747469/badge)](https://coveralls.io/builds/13747469)
   
   Coverage decreased (-0.01%) to 70.384% when pulling 
**24c25853671614f5572bbece45e30a80bc4086f3 on mistercrunch:fix_print** into 
**08f09b47615937337f232bd39361632564a15f81 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #3667: Update 20171013

[git]

mistercrunch commented on issue #3667: Update 20171013
URL: 
https://github.com/apache/incubator-superset/pull/3667#issuecomment-337107114
 
 
   Heard of "attribution"?!
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SeanPreusse commented on issue #3673: Sorting slices alphabetically results in 500 - Internal Server Error

[git]

SeanPreusse commented on issue #3673: Sorting slices alphabetically results in 
500 - Internal Server Error
URL: 
https://github.com/apache/incubator-superset/issues/3673#issuecomment-336692755
 
 
   version **20.4.** 
   ```
   **Stacktrace**
  Traceback (most recent call last):
 File 
"/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask/app.py",
 line 1982, in wsgi_app
   response = self.full_dispatch_request()
 File 
"/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask/app.py",
 line 1614, in full_dispatch_request
   rv = self.handle_user_exception(e)
 File 
"/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask/app.py",
 line 1517, in handle_user_exception
   reraise(exc_type, exc_value, tb)
 File 
"/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask/app.py",
 line 1612, in full_dispatch_request
   rv = self.dispatch_request()
 File 
"/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask/app.py",
 line 1598, in dispatch_request
   return self.view_functions[rule.endpoint](**req.view_args)
 File 
"/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask_appbuilder/security/decorators.py",
 line 26, in wraps
   return f(self, *args, **kwargs)
 File 
"/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask_appbuilder/views.py",
 line 475, in list
   widgets = self._list()
 File 
"/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask_appbuilder/baseviews.py",
 line 877, in _list
   page_size=page_size)
 File 
"/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask_appbuilder/baseviews.py",
 line 791, in _get_list_widget
   count, lst = self.datamodel.query(joined_filters, order_column, 
order_direction, page=page, page_size=page_size)
 File 
"/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask_appbuilder/models/sqla/interface.py",
 line 109, in query
   order_direction=order_direction)
 File 
"/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask_appbuilder/models/sqla/interface.py",
 line 71, in _get_base_query
   query = query.order_by(self._get_attr(order_column).asc())
   AttributeError: 'property' object has no attribute 'asc'
   ```
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #3586: [Feature] Percentage columns in Table Viz

[git]

mistercrunch closed pull request #3586: [Feature] Percentage columns in Table 
Viz
URL: https://github.com/apache/incubator-superset/pull/3586
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #3652: Authentication: Enable user impersonation for Superset to HiveServer2 using hive.server2.proxy.user (a.fernandez)

[git]

mistercrunch closed pull request #3652: Authentication: Enable user 
impersonation for Superset to HiveServer2 using hive.server2.proxy.user 
(a.fernandez)
URL: https://github.com/apache/incubator-superset/pull/3652
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch opened a new pull request #3683: [cleanup] removing print() artefacts

[git]

mistercrunch opened a new pull request #3683: [cleanup] removing print() 
artefacts
URL: https://github.com/apache/incubator-superset/pull/3683
 
 
   maybe related to: https://github.com/apache/incubator-superset/issues/3681
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Jeeva-Ganesan closed issue #3682: Parameter issue in MYSQL query

[git]

Jeeva-Ganesan closed issue #3682: Parameter issue in MYSQL query
URL: https://github.com/apache/incubator-superset/issues/3682
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Jeeva-Ganesan commented on issue #3682: Parameter issue in MYSQL query

[git]

Jeeva-Ganesan commented on issue #3682: Parameter issue in MYSQL query
URL: 
https://github.com/apache/incubator-superset/issues/3682#issuecomment-337088304
 
 
   All good. Thanks.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #3682: Parameter issue in MYSQL query

[git]

mistercrunch commented on issue #3682: Parameter issue in MYSQL query
URL: 
https://github.com/apache/incubator-superset/issues/3682#issuecomment-337082903
 
 
   We  recommend using the `mysqlclient` lib and just `mysql://` connection 
strings. If you need to use another driver (mysqlconnector?) then you may need 
to touch the code up a bit.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #3380: Add ability to custom order bars on a bar chart

[git]

mistercrunch commented on issue #3380: Add ability to custom order bars on a 
bar chart
URL: 
https://github.com/apache/incubator-superset/issues/3380#issuecomment-337080396
 
 
   Let's leave `3.` out of scope of this specific task.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3676: [New Viz] Nightingale Rose Chart

[git]

coveralls commented on issue #3676: [New Viz] Nightingale Rose Chart
URL: 
https://github.com/apache/incubator-superset/pull/3676#issuecomment-337080199
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13745867/badge)](https://coveralls.io/builds/13745867)
   
   Coverage increased (+0.8%) to 71.147% when pulling 
**aa9d96b17f05bdb2e63e933d0af7e2165c866de1 on 
Mogball:mogball/feature/rose_chart** into 
**2a89c90e0bfd74ad2bf88f7da080c58a02a9b33b on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3676: [New Viz] Nightingale Rose Chart

[git]

coveralls commented on issue #3676: [New Viz] Nightingale Rose Chart
URL: 
https://github.com/apache/incubator-superset/pull/3676#issuecomment-337080196
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13745867/badge)](https://coveralls.io/builds/13745867)
   
   Coverage increased (+0.8%) to 71.147% when pulling 
**aa9d96b17f05bdb2e63e933d0af7e2165c866de1 on 
Mogball:mogball/feature/rose_chart** into 
**2a89c90e0bfd74ad2bf88f7da080c58a02a9b33b on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3676: [New Viz] Nightingale Rose Chart

[git]

coveralls commented on issue #3676: [New Viz] Nightingale Rose Chart
URL: 
https://github.com/apache/incubator-superset/pull/3676#issuecomment-337080198
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13745867/badge)](https://coveralls.io/builds/13745867)
   
   Coverage increased (+0.8%) to 71.147% when pulling 
**aa9d96b17f05bdb2e63e933d0af7e2165c866de1 on 
Mogball:mogball/feature/rose_chart** into 
**2a89c90e0bfd74ad2bf88f7da080c58a02a9b33b on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3676: [New Viz] Nightingale Rose Chart

[git]

coveralls commented on issue #3676: [New Viz] Nightingale Rose Chart
URL: 
https://github.com/apache/incubator-superset/pull/3676#issuecomment-337080197
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13745867/badge)](https://coveralls.io/builds/13745867)
   
   Coverage increased (+0.8%) to 71.147% when pulling 
**aa9d96b17f05bdb2e63e933d0af7e2165c866de1 on 
Mogball:mogball/feature/rose_chart** into 
**2a89c90e0bfd74ad2bf88f7da080c58a02a9b33b on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #3664: [minor] fix padding in Time Table

[git]

mistercrunch closed pull request #3664: [minor] fix padding in Time Table
URL: https://github.com/apache/incubator-superset/pull/3664
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #3668: [Explore] Altered Slice Tag

[git]

mistercrunch commented on a change in pull request #3668: [Explore] Altered 
Slice Tag
URL: 
https://github.com/apache/incubator-superset/pull/3668#discussion_r144999151
 
 

 ##
 File path: superset/assets/javascripts/components/AlteredSliceTag.jsx
 ##
 @@ -0,0 +1,102 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+import { Table, Tr, Td, Thead, Th } from 'reactable';
+import TooltipWrapper from './TooltipWrapper';
+import { controls } from '../explore/stores/controls';
+import ModalTrigger from './ModalTrigger';
+import { t } from '../locales';
+
+export default class AlteredSliceTag extends React.Component {
+
+  formatValue(value, key) {
+// Format display value based on the control type
+// or the value type
+if (value === undefined) {
+  return 'N/A';
+} else if (value === null) {
+  return 'null';
+} else if (controls[key] && controls[key].type === 'FilterControl') {
+  if (!value.length) {
+return '[]';
+  }
+  return value.map((v) => {
+const filterVal = v.val.constructor === Array ? `[${v.val.join(', 
')}]` : v.val;
+return `${v.col} ${v.op} ${filterVal}`;
+  }).join(', ');
+} else if (controls[key] && controls[key].type === 'BoundsControl') {
+  return `Min: ${value[0]}, Max: ${value[1]}`;
+} else if (controls[key] && controls[key].type === 'CollectionControl') {
+  return value.map(v => JSON.stringify(v)).join(', ');
+} else if (typeof value === 'boolean') {
+  return value ? 'true' : 'false';
+} else if (value.constructor === Array) {
+  return value.length ? value.join(', ') : '[]';
+} else if (value.constructor === Object) {
+  return JSON.stringify(value);
+}
+return value;
+  }
+
+  renderRows() {
+const altered = this.props.altered;
+const rows = [];
+for (const key in altered) {
+  rows.push(
+
+  
+  {this.formatValue(altered[key].before, key)}
+  {this.formatValue(altered[key].after, key)}
+,
+  );
+}
+return rows;
+  }
+
+  renderModalBody() {
+return (
+  
+
+  Control
+  Before
+  After
+
+{this.renderRows()}
+  
+);
+  }
+
+  renderTriggerNode() {
+return (
+  
+
+  {t('Altered')}
+
+  
+);
+  }
+
+  render() {
+// Render the label-warning 'Altered' tag which the user may
+// click to open a modal containing a table summarizing the
+// differences in the slice
+return (
+  
+);
+  }
+}
+
+AlteredSliceTag.propTypes = {
 
 Review comment:
   Also what about if the component received `origFormData` and 
`currentFormData` instead, and the logic to check the differences can live in 
this component here.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #3668: [Explore] Altered Slice Tag

[git]

mistercrunch commented on a change in pull request #3668: [Explore] Altered 
Slice Tag
URL: 
https://github.com/apache/incubator-superset/pull/3668#discussion_r144998596
 
 

 ##
 File path: superset/assets/javascripts/components/AlteredSliceTag.jsx
 ##
 @@ -0,0 +1,102 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+import { Table, Tr, Td, Thead, Th } from 'reactable';
+import TooltipWrapper from './TooltipWrapper';
+import { controls } from '../explore/stores/controls';
+import ModalTrigger from './ModalTrigger';
+import { t } from '../locales';
+
+export default class AlteredSliceTag extends React.Component {
+
+  formatValue(value, key) {
+// Format display value based on the control type
+// or the value type
+if (value === undefined) {
+  return 'N/A';
+} else if (value === null) {
+  return 'null';
+} else if (controls[key] && controls[key].type === 'FilterControl') {
+  if (!value.length) {
+return '[]';
+  }
+  return value.map((v) => {
+const filterVal = v.val.constructor === Array ? `[${v.val.join(', 
')}]` : v.val;
+return `${v.col} ${v.op} ${filterVal}`;
+  }).join(', ');
+} else if (controls[key] && controls[key].type === 'BoundsControl') {
+  return `Min: ${value[0]}, Max: ${value[1]}`;
+} else if (controls[key] && controls[key].type === 'CollectionControl') {
+  return value.map(v => JSON.stringify(v)).join(', ');
+} else if (typeof value === 'boolean') {
+  return value ? 'true' : 'false';
+} else if (value.constructor === Array) {
+  return value.length ? value.join(', ') : '[]';
+} else if (value.constructor === Object) {
+  return JSON.stringify(value);
+}
+return value;
+  }
+
+  renderRows() {
+const altered = this.props.altered;
+const rows = [];
+for (const key in altered) {
+  rows.push(
+
+  
+  {this.formatValue(altered[key].before, key)}
+  {this.formatValue(altered[key].after, key)}
+,
+  );
+}
+return rows;
+  }
+
+  renderModalBody() {
+return (
+  
+
+  Control
+  Before
+  After
+
+{this.renderRows()}
+  
+);
+  }
+
+  renderTriggerNode() {
+return (
+  
+
+  {t('Altered')}
+
+  
+);
+  }
+
+  render() {
+// Render the label-warning 'Altered' tag which the user may
+// click to open a modal containing a table summarizing the
+// differences in the slice
+return (
+      
+);
+  }
+}
+
+AlteredSliceTag.propTypes = {
 
 Review comment:
   Please put `propTypes` at the top of the file as in most other modules
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #3668: [Explore] Altered Slice Tag

[git]

mistercrunch commented on a change in pull request #3668: [Explore] Altered 
Slice Tag
URL: 
https://github.com/apache/incubator-superset/pull/3668#discussion_r144999350
 
 

 ##
 File path: superset/assets/javascripts/components/AlteredSliceTag.jsx
 ##
 @@ -0,0 +1,102 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+import { Table, Tr, Td, Thead, Th } from 'reactable';
+import TooltipWrapper from './TooltipWrapper';
+import { controls } from '../explore/stores/controls';
+import ModalTrigger from './ModalTrigger';
+import { t } from '../locales';
+
+export default class AlteredSliceTag extends React.Component {
+
+  formatValue(value, key) {
+// Format display value based on the control type
+// or the value type
+if (value === undefined) {
+  return 'N/A';
+} else if (value === null) {
+  return 'null';
+} else if (controls[key] && controls[key].type === 'FilterControl') {
+  if (!value.length) {
+return '[]';
+  }
+  return value.map((v) => {
+const filterVal = v.val.constructor === Array ? `[${v.val.join(', 
')}]` : v.val;
+return `${v.col} ${v.op} ${filterVal}`;
+  }).join(', ');
+} else if (controls[key] && controls[key].type === 'BoundsControl') {
+  return `Min: ${value[0]}, Max: ${value[1]}`;
+} else if (controls[key] && controls[key].type === 'CollectionControl') {
+  return value.map(v => JSON.stringify(v)).join(', ');
+} else if (typeof value === 'boolean') {
+  return value ? 'true' : 'false';
+} else if (value.constructor === Array) {
+  return value.length ? value.join(', ') : '[]';
+} else if (value.constructor === Object) {
+  return JSON.stringify(value);
+}
+return value;
 
 Review comment:
   I'm thinking the catchall could be a `JSON.stringify` though I'm not 100 
sure of the implications. There's a guarantee that controls' values are always 
serializable since they make it through the redux store.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #3668: [Explore] Altered Slice Tag

[git]

mistercrunch commented on a change in pull request #3668: [Explore] Altered 
Slice Tag
URL: 
https://github.com/apache/incubator-superset/pull/3668#discussion_r144998156
 
 

 ##
 File path: superset/assets/javascripts/explore/components/ChartContainer.jsx
 ##
 @@ -145,6 +146,25 @@ class ChartContainer extends React.PureComponent {
 };
   }
 
+  isAltered() {
 
 Review comment:
   What about using a deep equality function like 
http://underscorejs.org/#isEqual instead? 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #3668: [Explore] Altered Slice Tag

[git]

mistercrunch commented on a change in pull request #3668: [Explore] Altered 
Slice Tag
URL: 
https://github.com/apache/incubator-superset/pull/3668#discussion_r144999022
 
 

 ##
 File path: superset/assets/javascripts/explore/components/ChartContainer.jsx
 ##
 @@ -145,6 +146,25 @@ class ChartContainer extends React.PureComponent {
 };
   }
 
+  isAltered() {
+// Returns all properties that differ in the
+// current form data and the base form data
+const fd = this.props.formData || {};
+const bfd = (this.props.slice && this.props.slice.form_data) || {};
+const fdKeys = new Set(Object.keys(fd).concat(Object.keys(bfd)));
+const differing = {};
+for (const fdKey of fdKeys) {
+  // Ignore values that are undefined/nonexisting in either
+  if (!fd[fdKey] && !bfd[fdKey]) {
+continue;
+  }
+  if (JSON.stringify(fd[fdKey]) !== JSON.stringify(bfd[fdKey])) {
+differing[fdKey] = { before: bfd[fdKey], after: fd[fdKey] };
+  }
+}
+return differing;
 
 Review comment:
   I'd expect a `isSomething` method to return a bool by naming conventions, 
rename the function to something like `getDiffs`.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on a change in pull request #3668: [Explore] Altered Slice Tag

[git]

mistercrunch commented on a change in pull request #3668: [Explore] Altered 
Slice Tag
URL: 
https://github.com/apache/incubator-superset/pull/3668#discussion_r144999785
 
 

 ##
 File path: superset/assets/javascripts/explore/components/ChartContainer.jsx
 ##
 @@ -145,6 +146,25 @@ class ChartContainer extends React.PureComponent {
 };
   }
 
+  isAltered() {
+// Returns all properties that differ in the
+// current form data and the base form data
+const fd = this.props.formData || {};
+const bfd = (this.props.slice && this.props.slice.form_data) || {};
 
 Review comment:
   Here you may want to use the `currentFormData` as the driver of which keys 
should exist. `slice.form_data` may have unused / deprecated keys that don't 
affect how the slice is rendered...
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Jeeva-Ganesan opened a new issue #3682: Parameter issue in MYSQL query

[git]

Jeeva-Ganesan opened a new issue #3682: Parameter issue in MYSQL query
URL: https://github.com/apache/incubator-superset/issues/3682
 
 
   Hi, I just installed superset and tried to connect to my mysql datasource.  
This is the error I was keep getting
   
   ```
   ERROR:root:execute() got an unexpected keyword argument 'args'
   Traceback (most recent call last):
 File 
"/Users/jeeva/anaconda/lib/python2.7/site-packages/superset/sql_lab.py", line 
179, in execute_sql
   **db_engine_spec.cursor_execute_kwargs)
   TypeError: execute() got an unexpected keyword argument 'args'
   ```
   
   Here is what i am using to connect to the source - its a mysql connector 
driver.
   
   `mysql+mysqlconnector://root:XX@127.0.0.1:3306/databasename`
   
   This line is what causing this issue,
   
   
https://github.com/apache/incubator-superset/blob/d0b5b449b281022d497f2079f83b103602c7077c/superset/sql_lab.py#L178
   
   After I commented this line and changed it to 
   
   #cursor.execute(query.executed_sql,
   #   **db_engine_spec.cursor_execute_kwargs)
   cursor.execute(query.executed_sql)
   
   It worked, posting it here for two reason, one is to share if anyone is 
facing the same issue and searching for the reason, second one is to know, is 
there anything wrong with my approach, do I have to install different mysql 
driver or something?
   
   Thanks.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #3678: [Tests] Unit tests for OptionDescription

[git]

mistercrunch closed pull request #3678: [Tests] Unit tests for OptionDescription
URL: https://github.com/apache/incubator-superset/pull/3678
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #3679: Avoid dividing by zero for sparkline in time table viz

[git]

mistercrunch closed pull request #3679: Avoid dividing by zero for sparkline in 
time table viz
URL: https://github.com/apache/incubator-superset/pull/3679
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #3680: Sqllab error troubleshooting

[git]

mistercrunch closed pull request #3680: Sqllab  error troubleshooting
URL: https://github.com/apache/incubator-superset/pull/3680
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] VincentLa14 opened a new issue #3681: OSError: [Errno 5] Input/output error

[git]

VincentLa14 opened a new issue #3681: OSError: [Errno 5] Input/output error
URL: https://github.com/apache/incubator-superset/issues/3681
 
 
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [x ] I have checked the superset logs for python stacktraces and included 
it here as text if any
   - [ x] I have reproduced the issue with at least the latest released version 
of superset
   - [x ] I have checked the issue tracker for the same issue and I haven't 
found one similar
   
   
   ### Superset version
   superset-0.20.4
   
   ### Expected results
   Default dashboards to display
   
   ### Actual results
   I get "[Errno 5] Input/output error" on all slices. For example, see 
attachment
   https://user-images.githubusercontent.com/14893645/31638738-0c60f720-b28a-11e7-954e-d90b8c6504b2.png";>
   
   
   
   
   ### Steps to reproduce
   Ran steps to install `superset` here: 
https://superset.incubator.apache.org/installation.html
   
   When I go into the slice, the stacktrace I get is
   ```
   Traceback (most recent call last):
 File 
"/Users/VincentLa/venv/superset-demo/lib/python3.5/site-packages/superset/viz.py",
 line 273, in get_payload
   try:
 File 
"/Users/VincentLa/venv/superset-demo/lib/python3.5/site-packages/superset/viz.py",
 line 97, in get_df
   self.results = self.datasource.query(query_obj)
 File 
"/Users/VincentLa/venv/superset-demo/lib/python3.5/site-packages/superset/connectors/sqla/models.py",
 line 563, in query
   sql = self.get_query_str(query_obj)
 File 
"/Users/VincentLa/venv/superset-demo/lib/python3.5/site-packages/superset/connectors/sqla/models.py",
 line 324, in get_query_str
   qry = self.get_sqla_query(**query_obj)
 File 
"/Users/VincentLa/venv/superset-demo/lib/python3.5/site-packages/superset/connectors/sqla/models.py",
 line 520, in get_sqla_query
   print('-='*20)
   OSError: [Errno 5] Input/output error
   ```
   
   See the following screenshot from "Birth in France by department in 2016"
   
   https://user-images.githubusercontent.com/14893645/31638779-3da4a3fe-b28a-11e7-93c8-68785d0f62fe.png";>
   
   
   
 
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3680: Sqllab error troubleshooting

[git]

coveralls commented on issue #3680: Sqllab  error troubleshooting
URL: 
https://github.com/apache/incubator-superset/pull/3680#issuecomment-337065116
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13744772/badge)](https://coveralls.io/builds/13744772)
   
   Coverage increased (+0.01%) to 70.396% when pulling 
**0770bc1c0ea97a2becb6d2f792bba1460bad5646 on 
timifasubaa:sqllab--error-troubleshooting** into 
**d0b5b449b281022d497f2079f83b103602c7077c on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] timifasubaa opened a new pull request #3680: Sqllab error troubleshooting

[git]

timifasubaa opened a new pull request #3680: Sqllab  error troubleshooting
URL: https://github.com/apache/incubator-superset/pull/3680
 
 
   This PR allows a link to common superset errors and their resolutions to be 
added to the bottom of error messages. This should help get users unblocked 
quicker. 
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] afernandez commented on issue #3652: Authentication: Enable user impersonation for Superset to HiveServer2 using hive.server2.proxy.user (a.fernandez)

[git]

afernandez commented on issue #3652: Authentication: Enable user impersonation 
for Superset to HiveServer2 using hive.server2.proxy.user (a.fernandez)
URL: 
https://github.com/apache/incubator-superset/pull/3652#issuecomment-337059942
 
 
   @mistercrunch would you be able to re-review these changes? Does the 
decrease in coveralls mean I need to add unit tests?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3678: [Tests] Unit tests for OptionDescription

[git]

coveralls commented on issue #3678: [Tests] Unit tests for OptionDescription
URL: 
https://github.com/apache/incubator-superset/pull/3678#issuecomment-337043882
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13743288/badge)](https://coveralls.io/builds/13743288)
   
   Coverage remained the same at 70.384% when pulling 
**2b3d0df0b9030f996dfde8233d0646d6f98bd19b on 
Mogball:mogball/feature/option_description_tests** into 
**d0b5b449b281022d497f2079f83b103602c7077c on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3679: Avoid dividing by zero for sparkline in time table viz

[git]

coveralls commented on issue #3679: Avoid dividing by zero for sparkline in 
time table viz
URL: 
https://github.com/apache/incubator-superset/pull/3679#issuecomment-337043884
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13743221/badge)](https://coveralls.io/builds/13743221)
   
   Coverage remained the same at 70.384% when pulling 
**fb407b47840792b12d525ac12d304c93515b6522 on 
michellethomas:time_table_viz_null_values** into 
**d0b5b449b281022d497f2079f83b103602c7077c on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3678: [Tests] Unit tests for OptionDescription

[git]

coveralls commented on issue #3678: [Tests] Unit tests for OptionDescription
URL: 
https://github.com/apache/incubator-superset/pull/3678#issuecomment-337043673
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13743264/badge)](https://coveralls.io/builds/13743264)
   
   Coverage decreased (-0.04%) to 70.341% when pulling 
**2b3d0df0b9030f996dfde8233d0646d6f98bd19b on 
Mogball:mogball/feature/option_description_tests** into 
**d0b5b449b281022d497f2079f83b103602c7077c on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] michellethomas opened a new pull request #3679: Avoid dividing by zero for sparkline in time table viz

[git]

michellethomas opened a new pull request #3679: Avoid dividing by zero for 
sparkline in time table viz
URL: https://github.com/apache/incubator-superset/pull/3679
 
 
   When calculating ratios to add to the sparkline, we should not be dividing 
by zero or null values. Instead I'm passing a null value to sparkData. This 
will result in a blank space in the sparkline. This matches how the line chart 
handles dividing by zero or null.
   
   
![image](https://user-images.githubusercontent.com/817955/31634479-97a8ccac-b278-11e7-9d5b-f6ab2b197e81.png)
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3678: [Tests] Unit tests for OptionDescription

[git]

coveralls commented on issue #3678: [Tests] Unit tests for OptionDescription
URL: 
https://github.com/apache/incubator-superset/pull/3678#issuecomment-337035104
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13742873/badge)](https://coveralls.io/builds/13742873)
   
   Coverage decreased (-0.04%) to 70.341% when pulling 
**99339838c989ee6c387ca2f8daa0f325c5c1845c on 
Mogball:mogball/feature/option_description_tests** into 
**d0b5b449b281022d497f2079f83b103602c7077c on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Mogball opened a new pull request #3678: [Tests] Unit tests for OptionDescription

[git]

Mogball opened a new pull request #3678: [Tests] Unit tests for 
OptionDescription
URL: https://github.com/apache/incubator-superset/pull/3678
 
 
   Adds unit tests missing for the `OptionDescription` component added in 
https://github.com/apache/incubator-superset/pull/3642
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3586: [Feature] Percentage columns in Table Viz

[git]

coveralls commented on issue #3586: [Feature] Percentage columns in Table Viz
URL: 
https://github.com/apache/incubator-superset/pull/3586#issuecomment-337028176
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13742515/badge)](https://coveralls.io/builds/13742515)
   
   Coverage increased (+0.4%) to 70.767% when pulling 
**5ec109ff93a6ac6cc8552f5874af85106488c5b8 on 
Mogball:mogball/feature/table_percent_columns** into 
**d0b5b449b281022d497f2079f83b103602c7077c on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3586: [Feature] Percentage columns in Table Viz

[git]

coveralls commented on issue #3586: [Feature] Percentage columns in Table Viz
URL: 
https://github.com/apache/incubator-superset/pull/3586#issuecomment-337028174
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13742515/badge)](https://coveralls.io/builds/13742515)
   
   Coverage increased (+0.4%) to 70.767% when pulling 
**5ec109ff93a6ac6cc8552f5874af85106488c5b8 on 
Mogball:mogball/feature/table_percent_columns** into 
**d0b5b449b281022d497f2079f83b103602c7077c on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3586: [Feature] Percentage columns in Table Viz

[git]

coveralls commented on issue #3586: [Feature] Percentage columns in Table Viz
URL: 
https://github.com/apache/incubator-superset/pull/3586#issuecomment-337028175
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13742515/badge)](https://coveralls.io/builds/13742515)
   
   Coverage increased (+0.4%) to 70.767% when pulling 
**5ec109ff93a6ac6cc8552f5874af85106488c5b8 on 
Mogball:mogball/feature/table_percent_columns** into 
**d0b5b449b281022d497f2079f83b103602c7077c on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on issue #3674: Minor feature request: additional Histogram display options

[git]

xrmx commented on issue #3674: Minor feature request: additional Histogram 
display options
URL: 
https://github.com/apache/incubator-superset/issues/3674#issuecomment-337026458
 
 
PR welcome as usual :)
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] timifasubaa commented on issue #3673: Sorting slices alphabetically results in 500 - Internal Server Error

[git]

timifasubaa commented on issue #3673: Sorting slices alphabetically results in 
500 - Internal Server Error
URL: 
https://github.com/apache/incubator-superset/issues/3673#issuecomment-337023421
 
 
   related: https://github.com/dpgaspar/Flask-AppBuilder/issues/610
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3586: [Feature] Percentage columns in Table Viz

[git]

coveralls commented on issue #3586: [Feature] Percentage columns in Table Viz
URL: 
https://github.com/apache/incubator-superset/pull/3586#issuecomment-337017472
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13741889/badge)](https://coveralls.io/builds/13741889)
   
   Coverage increased (+0.3%) to 70.696% when pulling 
**342e61cb36f31ca0be19f3283c54d815e80dc41c on 
Mogball:mogball/feature/table_percent_columns** into 
**d0b5b449b281022d497f2079f83b103602c7077c on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3586: [Feature] Percentage columns in Table Viz

[git]

coveralls commented on issue #3586: [Feature] Percentage columns in Table Viz
URL: 
https://github.com/apache/incubator-superset/pull/3586#issuecomment-337013651
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13741757/badge)](https://coveralls.io/builds/13741757)
   
   Coverage increased (+0.4%) to 70.767% when pulling 
**342e61cb36f31ca0be19f3283c54d815e80dc41c on 
Mogball:mogball/feature/table_percent_columns** into 
**d0b5b449b281022d497f2079f83b103602c7077c on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3676: [New Viz] Nightingale Rose Chart

[git]

coveralls commented on issue #3676: [New Viz] Nightingale Rose Chart
URL: 
https://github.com/apache/incubator-superset/pull/3676#issuecomment-337012187
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13741746/badge)](https://coveralls.io/builds/13741746)
   
   Coverage increased (+0.8%) to 71.135% when pulling 
**4b7789f204055518bac067dd23e3b5b558ab8669 on 
Mogball:mogball/feature/rose_chart** into 
**d0b5b449b281022d497f2079f83b103602c7077c on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rumbin commented on issue #3674: Minor feature request: additional Histogram display options

[git]

rumbin commented on issue #3674: Minor feature request: additional Histogram 
display options
URL: 
https://github.com/apache/incubator-superset/issues/3674#issuecomment-336969522
 
 
   I'd extend the list with:
   * d3 formatting of axes; currently very low x-valuesbare just shown as 0
   * optional normalization (area or max value)
   * optional log scale on y-axis
   * grouping, simultaneous plotting of the groups: either stacked or 
translucent
   * an interactive legend for the grouped series
   * clipping along x-axis, i.e., moving outliers to boundary bins within more 
narrow limits; this can be done using pandas' clip method
   
   OK, I agree that this is not what a minor request should contain. However, I 
wanted to point out which parts could be improved in my eyes, just in case 
someone gave some love to this visualization.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] panjiyar123 commented on issue #3570: Request for- Correlation Matrix Graph based Visualization

[git]

panjiyar123 commented on issue #3570: Request for- Correlation Matrix Graph 
based Visualization
URL: 
https://github.com/apache/incubator-superset/issues/3570#issuecomment-336964033
 
 
   Any help on this?? Appreciate your time for looking for this feature request.
   
   Regards,
   Lalan
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] timifasubaa commented on issue #3662: Set logging level to debug for DummyStatsLogger

[git]

timifasubaa commented on issue #3662: Set logging level to debug for 
DummyStatsLogger
URL: 
https://github.com/apache/incubator-superset/pull/3662#issuecomment-336954611
 
 
   lgtm
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] michellethomas commented on issue #3664: [minor] fix padding in Time Table

[git]

michellethomas commented on issue #3664: [minor] fix padding in Time Table
URL: 
https://github.com/apache/incubator-superset/pull/3664#issuecomment-336951718
 
 
   lgtm
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] baocaiwang closed issue #3677: The Dashboard's chart can't export to other document(Excel, PDF ....)

[git]

baocaiwang closed issue #3677: The Dashboard's chart can't export to other 
document(Excel, PDF )
URL: https://github.com/apache/incubator-superset/issues/3677
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on issue #3677: The Dashboard's chart can't export to other document(Excel, PDF ....)

[git]

xrmx commented on issue #3677: The Dashboard's chart can't export to other 
document(Excel, PDF )
URL: 
https://github.com/apache/incubator-superset/issues/3677#issuecomment-336830971
 
 
   Dup of #2995 please close
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] baocaiwang opened a new issue #3677: The Dashboard's chart can't export to other document(Excel, PDF ....)

[git]

baocaiwang opened a new issue #3677: The Dashboard's chart can't export to 
other document(Excel, PDF )
URL: https://github.com/apache/incubator-superset/issues/3677
 
 
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [ ] I have checked the superset logs for python stacktraces and included 
it here as text if any
   - [ ] I have reproduced the issue with at least the latest released version 
of superset
   - [ ] I have checked the issue tracker for the same issue and I haven't 
found one similar
   
   
   ### Superset version
   0.20.4
   
   ### Expected results
   the charts in Dashboard can export into Excel or PDF document
   
   ### Actual results
   I can't find the way to complete this function
   
   ### Steps to reproduce
   
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed pull request #3653: Add a ColorPickerControl

[git]

mistercrunch closed pull request #3653: Add a ColorPickerControl
URL: https://github.com/apache/incubator-superset/pull/3653
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch commented on issue #3675: How can I change the visualization? Changes are not displayed in the browser.

[git]

mistercrunch commented on issue #3675: How can I change the visualization? 
Changes are not displayed in the browser.
URL: 
https://github.com/apache/incubator-superset/issues/3675#issuecomment-336791891
 
 
   `npm run dev` will watch the files for modifications and re-compile as you 
edit
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] mistercrunch closed issue #3675: How can I change the visualization? Changes are not displayed in the browser.

[git]

mistercrunch closed issue #3675: How can I change the visualization? Changes 
are not displayed in the browser.
URL: https://github.com/apache/incubator-superset/issues/3675
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Oxystin commented on issue #3675: How can I change the visualization? Changes are not displayed in the browser.

[git]

Oxystin commented on issue #3675: How can I change the visualization? Changes 
are not displayed in the browser.
URL: 
https://github.com/apache/incubator-superset/issues/3675#issuecomment-336751380
 
 
   @xrmx thank you for the tip! It worked for me!
   Tell me, this procedure must be run after each edit of the sources?
   It is long enough. How then to debug your code?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Oxystin commented on issue #3675: How can I change the visualization? Changes are not displayed in the browser.

[git]

Oxystin commented on issue #3675: How can I change the visualization? Changes 
are not displayed in the browser.
URL: 
https://github.com/apache/incubator-superset/issues/3675#issuecomment-336749920
 
 
   @xrmx act according to instructions. Throws the error:
   
   root@ubuntu:/superset/superset/assets# yarn
   yarn install v1.2.1
   warning You are using Node "4.2.6" which is not supported and may encounter 
bugs or unexpected behavior. Yarn supports the following semver range: "^4.8.0 
|| ^5.7.0 || ^6.2.2 || ^8.0.0"
   info No lockfile found.
   [1/4] Resolving packages...
   warning brfs > static-module > through2 > xtend > object-keys@0.4.0:
   warning react-map-gl > mapbox-gl > point-geometry@0.0.0: This module has 
moved: please install @mapbox/point-geometry instead
   warning react-map-gl > mapbox-gl > vt-pbf > point-geometry@0.0.0: This 
module has moved: please install @mapbox/point-geometry instead
   warning react-map-gl > mapbox-gl > vector-tile@1.3.0: This module has moved: 
please install @mapbox/vector-tile instead
   warning react-map-gl > mapbox-gl > vt-pbf > vector-tile@1.3.0: This module 
has moved: please install @mapbox/vector-tile instead
   warning react-map-gl > mapbox-gl > geojson-rewind > geojson-area@0.1.0: This 
module is now under the @mapbox namespace: install @mapbox/geojson-area instead
   warning github-changes > parse-link-header > xtend > object-keys@0.2.0: 
Please update to the latest object-keys
   warning github-changes > github-commit-stream > request > node-uuid@1.4.8: 
Use uuid module instead
   [2/4] Fetching packages...
   **error mapbox-gl@0.38.0: The engine "node" is incompatible with this 
module. Expected version ">=6.4.0".**
   **error Found incompatible module**
   
   root@ubuntu:/superset/superset/assets# yarn run build
   yarn run v1.2.1
   warning You are using Node "4.2.6" which is not supported and may encounter 
bugs or unexpected behavior. Yarn supports the following semver range: "^4.8.0 
|| ^5.7.0 || ^6.2.2 || ^8.0.0"
   $ NODE_ENV=production webpack --colors --progress
   **error Couldn't find the binary NODE_ENV=production webpack --colors 
--progress**
   
   Tell me, this procedure must be run after each edit of the sources?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] everglory99 commented on issue #3524: Cannot created temp table in redshift DB

[git]

everglory99 commented on issue #3524: Cannot created temp table in redshift DB
URL: 
https://github.com/apache/incubator-superset/issues/3524#issuecomment-336750250
 
 
   I also observed this issue. After looking deeper into the problem, I 
realized that the problem is not that the ```temp table``` can't be created in 
SQL lab and actually the message ```The query returned no data``` is normal. 
However the real problem is that the created temp table can't be used in the 
successive queries. For example if I run the following query blocks in SQL lab
   ```SQL
   -- query block 1
   -- dummy table is just a copy of customer table
   create temp table dummy
   as
   (
   select user_id
   from customer
   )
   ;
   
   -- query block 2
   select * from dummy 
   ``` 
   I will get the expected result. However if I first run query block 1 and 
then query block 2, I will receive error message indicating table ```dummy``` 
does't exist. From Redshift temp table 
[documentation](http://docs.aws.amazon.com/redshift/latest/dg/r_CREATE_TABLE_NEW.html):
   > ...creates a temporary table that is visible only within the current 
session. The table is automatically dropped at the end of the session in which 
it is created
   
   I am starting to wonder how SQL lab handles "session". Does each SQL lab run 
re-connect to the database (start a new session) or it uses the same connection 
throughout the time when user is still logged in?  For most of the use cases, I 
think it is more convenient to enable SQL lab user to first create a temp table 
and then use it afterwards. Is it possible to achieve this? Thanks very much 
for the help! 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Oxystin commented on issue #3675: How can I change the visualization? Changes are not displayed in the browser.

[git]

Oxystin commented on issue #3675: How can I change the visualization? Changes 
are not displayed in the browser.
URL: 
https://github.com/apache/incubator-superset/issues/3675#issuecomment-336749920
 
 
   @xrmx act according to instructions. Throws the error:
   
   root@ubuntu:/superset/superset/assets# yarn
   yarn install v1.2.1
   warning You are using Node "4.2.6" which is not supported and may encounter 
bugs or unexpected behavior. Yarn supports the following semver range: "^4.8.0 
|| ^5.7.0 || ^6.2.2 || ^8.0.0"
   info No lockfile found.
   [1/4] Resolving packages...
   warning brfs > static-module > through2 > xtend > object-keys@0.4.0:
   warning react-map-gl > mapbox-gl > point-geometry@0.0.0: This module has 
moved: please install @mapbox/point-geometry instead
   warning react-map-gl > mapbox-gl > vt-pbf > point-geometry@0.0.0: This 
module has moved: please install @mapbox/point-geometry instead
   warning react-map-gl > mapbox-gl > vector-tile@1.3.0: This module has moved: 
please install @mapbox/vector-tile instead
   warning react-map-gl > mapbox-gl > vt-pbf > vector-tile@1.3.0: This module 
has moved: please install @mapbox/vector-tile instead
   warning react-map-gl > mapbox-gl > geojson-rewind > geojson-area@0.1.0: This 
module is now under the @mapbox namespace: install @mapbox/geojson-area instead
   warning github-changes > parse-link-header > xtend > object-keys@0.2.0: 
Please update to the latest object-keys
   warning github-changes > github-commit-stream > request > node-uuid@1.4.8: 
Use uuid module instead
   [2/4] Fetching packages...
   **error mapbox-gl@0.38.0: The engine "node" is incompatible with this 
module. Expected version ">=6.4.0".**
   **error Found incompatible module**
   
   root@ubuntu:/superset/superset/assets# yarn run build
   yarn run v1.2.1
   warning You are using Node "4.2.6" which is not supported and may encounter 
bugs or unexpected behavior. Yarn supports the following semver range: "^4.8.0 
|| ^5.7.0 || ^6.2.2 || ^8.0.0"
   $ NODE_ENV=production webpack --colors --progress
   **error Couldn't find the binary NODE_ENV=production webpack --colors 
--progress**
   
   Tell me, this procedure must be run after each edit of the sources?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Oxystin commented on issue #3675: How can I change the visualization? Changes are not displayed in the browser.

[git]

Oxystin commented on issue #3675: How can I change the visualization? Changes 
are not displayed in the browser.
URL: 
https://github.com/apache/incubator-superset/issues/3675#issuecomment-336746619
 
 
   @xrmx Hello. Thanks for the reply. The documentation I have read. 
Unfortunately I'm not advanced user to understand. I need to change only the 
angle of the label graphics. This can be done by removing a couple of lines in 
the source. I thought it can be done quickly. It turned out that it is more 
difficult. I'll try to understand.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Oxystin commented on issue #3675: How can I change the visualization? Changes are not displayed in the browser.

[git]

Oxystin commented on issue #3675: How can I change the visualization? Changes 
are not displayed in the browser.
URL: 
https://github.com/apache/incubator-superset/issues/3675#issuecomment-336737431
 
 
   @xrmx Hello. Thanks for the reply. The documentation I have read. 
Unfortunately I'm not advanced user to understand. I need to change only the 
angle of the label graphics. This can be done by removing a couple of lines in 
the source. I thought it can be done quickly. It turned out that it is more 
difficult. I'll try to understand. 
   
   Do you find it difficult to write a procedure or give a link? I can enter 
these commands in a Docker container? Sorry for the stupid questions.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Oxystin commented on issue #3675: How can I change the visualization? Changes are not displayed in the browser.

[git]

Oxystin commented on issue #3675: How can I change the visualization? Changes 
are not displayed in the browser.
URL: 
https://github.com/apache/incubator-superset/issues/3675#issuecomment-336737431
 
 
   @xrmx Hello. Thanks for the reply. The documentation I have read. 
Unfortunately I'm not advanced user to understand. I need to change only the 
angle of the label graphics. This can be done by removing a couple of lines in 
the source. I thought it can be done quickly. It turned out that it is more 
difficult. I'll try to understand. 
   
   Do you find it difficult to write a procedure or give a link? I can enter 
these commands in a Docker container? Sorry for the stupid questions.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3676: [WiP] Nightingale Rose Chart

[git]

coveralls commented on issue #3676: [WiP] Nightingale Rose Chart
URL: 
https://github.com/apache/incubator-superset/pull/3676#issuecomment-336736865
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13725767/badge)](https://coveralls.io/builds/13725767)
   
   Coverage decreased (-0.1%) to 70.267% when pulling 
**d3c0baa70cede7533d1a3723601e605647f77fe0 on 
Mogball:mogball/feature/rose_chart** into 
**bad6938d1a65453b94f7bfe4e9936e6e066b0775 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Mogball opened a new pull request #3676: [WiP] Nightingale Rose Chart

[git]

Mogball opened a new pull request #3676: [WiP] Nightingale Rose Chart
URL: https://github.com/apache/incubator-superset/pull/3676
 
 
   ![rose GIF](https://media.giphy.com/media/3ov9jZrDzwVi5HkPrW/source.gif)
   
   todo:
   - fix label overlapping
   - unit tests
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on issue #3675: How can I change the visualization? Changes are not displayed in the browser.

[git]

xrmx commented on issue #3675: How can I change the visualization? Changes are 
not displayed in the browser.
URL: 
https://github.com/apache/incubator-superset/issues/3675#issuecomment-336732783
 
 
   We're in 2017 where the frontend is built. You have to modify the source and 
then rebuild the whole thing. Next time looking at the documentation may save 
you two days of suffering  
https://superset.incubator.apache.org/installation.html#making-your-own-build
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] eddy-geek commented on issue #2868: Feature: Filter Box using TextInput #2867

[git]

eddy-geek commented on issue #2868: Feature: Filter Box using TextInput #2867
URL: 
https://github.com/apache/incubator-superset/pull/2868#issuecomment-336700650
 
 
   Is something missing to merge this, beside fixing the conflict issues? I am 
working on the rebase here: 
https://github.com/apache/incubator-superset/compare/master...eddy-geek:filter_input_box
   
   I'm also having the issue with big tables where the  SQL query times 
out...
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Oxystin opened a new issue #3675: ??? ???????? ????????????? ????????? ?? ???????????? ? ????????.

[git]

Oxystin opened a new issue #3675: ???  ? ? ?? 
 ? . 
URL: https://github.com/apache/incubator-superset/issues/3675
 
 
   Developers please help. I have been suffering for two days. I need to change 
the visualization of some graphs. Superset installed via Docker. I am modifying 
the container for the files _nvd3_vis.js_ and _chord.jsx_. But my changes are 
not displayed in the browser. There is a feeling that the * .js (x) files are 
cached. I reset the cache in browsers, restarted the container and even deleted 
the file nvd3_viz.js. This did not help me. Everything works without changes. 
Tell me what you need to do to see the changes, after editing the files in the 
folder ... / superset / assets / visualizations /?
   
   And tell me the development environment, in which it will be convenient to 
debug the project?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] eddy-geek commented on issue #2868: Feature: Filter Box using TextInput #2867

[git]

eddy-geek commented on issue #2868: Feature: Filter Box using TextInput #2867
URL: 
https://github.com/apache/incubator-superset/pull/2868#issuecomment-336700650
 
 
   Is something missing to merge this, beside fixing the conflict issues?
   
   I'm also having the issue with big tables where the  SQL query times 
out...
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SeanPreusse commented on issue #3672: URL link to parent or blank does not work within Markup or Separator widget

[git]

SeanPreusse commented on issue #3672: URL link to parent or blank does not work 
within Markup or Separator widget
URL: 
https://github.com/apache/incubator-superset/issues/3672#issuecomment-336693403
 
 
   Version .20.4
   
   Sorry for not being clear. Not sure if the markup slices are intended for 
this, but it would be great to create a landing page and use the 'markup' 
slices to navigate to key dashboards. Users can still use the dashboard main 
page, but the landing page can have other helpful information such as 
image/icons and a description of the dashboard a user would navigate to.
   
   1. Create new slice with visualisation type 'Markup'.
   2. Add title, image and url to link to another dashboard, description.
   'Link Text'
   3. Create dashboard with 'markup' widgets navigating to key dashboards
   4. When you click on the link, nothing happens.
   
![image](https://user-images.githubusercontent.com/15626895/31582852-7c78e726-b1da-11e7-8d32-de7075624e51.png)
   
   
   
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SeanPreusse commented on issue #3673: Sorting slices alphabetically results in 500 - Internal Server Error

[git]

SeanPreusse commented on issue #3673: Sorting slices alphabetically results in 
500 - Internal Server Error
URL: 
https://github.com/apache/incubator-superset/issues/3673#issuecomment-336692755
 
 
   version **20.4.** 
   
   **Stacktrace**
  Traceback (most recent call last):
 File 
"/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask/app.py",
 line 1982, in wsgi_app
   response = self.full_dispatch_request()
 File 
"/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask/app.py",
 line 1614, in full_dispatch_request
   rv = self.handle_user_exception(e)
 File 
"/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask/app.py",
 line 1517, in handle_user_exception
   reraise(exc_type, exc_value, tb)
 File 
"/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask/app.py",
 line 1612, in full_dispatch_request
   rv = self.dispatch_request()
 File 
"/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask/app.py",
 line 1598, in dispatch_request
   return self.view_functions[rule.endpoint](**req.view_args)
 File 
"/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask_appbuilder/security/decorators.py",
 line 26, in wraps
   return f(self, *args, **kwargs)
 File 
"/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask_appbuilder/views.py",
 line 475, in list
   widgets = self._list()
 File 
"/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask_appbuilder/baseviews.py",
 line 877, in _list
   page_size=page_size)
 File 
"/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask_appbuilder/baseviews.py",
 line 791, in _get_list_widget
   count, lst = self.datamodel.query(joined_filters, order_column, 
order_direction, page=page, page_size=page_size)
 File 
"/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask_appbuilder/models/sqla/interface.py",
 line 109, in query
   order_direction=order_direction)
 File 
"/home/ubuntu/virtualenvs/superset/local/lib/python2.7/site-packages/flask_appbuilder/models/sqla/interface.py",
 line 71, in _get_base_query
   query = query.order_by(self._get_attr(order_column).asc())
   AttributeError: 'property' object has no attribute 'asc'
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on issue #3672: URL link to parent or blank does not work within Markup or Separator widget

[git]

xrmx commented on issue #3672: URL link to parent or blank does not work within 
Markup or Separator widget
URL: 
https://github.com/apache/incubator-superset/issues/3672#issuecomment-336692651
 
 
   What version is latest version? steps to reproduce should contain the 
procedure to replicate the issue, i don't think clicking a link to google is a 
superset issue.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on issue #3673: Sorting slices alphabetically results in 500 - Internal Server Error

[git]

xrmx commented on issue #3673: Sorting slices alphabetically results in 500 - 
Internal Server Error
URL: 
https://github.com/apache/incubator-superset/issues/3673#issuecomment-336692517
 
 
   What version is latest version? Also post the stacktrace you had in the logs.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on issue #3673: Sorting slices alphabetically results in 500 - Internal Server Error

[git]

xrmx commented on issue #3673: Sorting slices alphabetically results in 500 - 
Internal Server Error
URL: 
https://github.com/apache/incubator-superset/issues/3673#issuecomment-336692517
 
 
   What version is latest version?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] alvinthai opened a new issue #3674: Minor feature request: additional Histogram display options

[git]

alvinthai opened a new issue #3674: Minor feature request: additional Histogram 
display options
URL: https://github.com/apache/incubator-superset/issues/3674
 
 
   Is it possible to include more display options for the histogram plots? It 
is currently not possible to:
   
   - label the x-axis
   - hide the bar values
   - offset the value axis (currently the x-axis values are displayed in the 
middle of the vertical bar, most histogram plots have the x-axis at the edge of 
the bars, like in this image: 
https://upload.wikimedia.org/wikipedia/commons/thumb/c/c3/Histogram_of_arrivals_per_minute.svg/1200px-Histogram_of_arrivals_per_minute.svg.png)
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SeanPreusse opened a new issue #3673: Sorting slices alphabetically results in 500 - Internal Server Error

[git]

SeanPreusse opened a new issue #3673: Sorting slices alphabetically results in 
500 - Internal Server Error
URL: https://github.com/apache/incubator-superset/issues/3673
 
 
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [X] I have checked the superset logs for python stacktraces and included 
it here as text if any
   - [X] I have reproduced the issue with at least the latest released version 
of superset
   - [X] I have checked the issue tracker for the same issue and I haven't 
found one similar
   
   
   ### Superset version
   Latest Version
   
   ### Expected results
   Sorting slice alphabetically
   
   ### Actual results
   500 - Internal Server Error
   
   ### Steps to reproduce
   Click on 'Slices', next to the slice title, click on the up/down arrow to 
sort.
   
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] SeanPreusse opened a new issue #3672: URL link to parent or blank does not work within Markup or Separator widget

[git]

SeanPreusse opened a new issue #3672: URL link to parent or blank does not work 
within Markup or Separator widget
URL: https://github.com/apache/incubator-superset/issues/3672
 
 
   Make sure these boxes are checked before submitting your issue - thank you!
   
   - [X ] I have checked the superset logs for python stacktraces and included 
it here as text if any
   - [X ] I have reproduced the issue with at least the latest released version 
of superset
   - [X ] I have checked the issue tracker for the same issue and I haven't 
found one similar
   
   ### Superset version
   Latest version
   
   ### Expected results
   Link opens new window or within existing
   
   ### Actual results
   Link does not execute
   These widgets are helpful in creating an additional context for dashboards 
and natural flow through.
   
   ### Steps to reproduce
   Code: http://www.google.com"; target="_Parent">Link Text
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on issue #3671: Adding new countries to Map view

[git]

xrmx commented on issue #3671: Adding new countries to Map view
URL: 
https://github.com/apache/incubator-superset/issues/3671#issuecomment-336648148
 
 
   You shouldn't change the installed package, you have to add the changes to 
the source code, rebuild the package and then install it again to check if it 
works.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] polprog opened a new issue #3671: Adding new countries to Map view

[git]

polprog opened a new issue #3671: Adding new countries to Map view
URL: https://github.com/apache/incubator-superset/issues/3671
 
 
   I'm having problems with adding new countries to the map view in Superset.
   
   I am running superset version 0.19.1 (rather fresh install, never upgraded 
from an existing older version),  python 3.5.3 and debian 9.2
   
   Following the instructions in the 
[documentation](https://superset.incubator.apache.org/visualization.html), I:
   - Took the shapefiles for Poland from the website specified in step 1
   - Have converted the shapefile to `poland.geojson` and placed it in 
`superset/static/assets/visualizations/countries/`
   
   To verify, it contains polygons that are defined as:
   
   ```
   
{"type":"FeatureCollection","crs":{"type":"name","properties":{"name":"urn:ogc:def:crs:OGC:1.3:CRS84"}},"features":[
   
{"type":"Feature","geometry":{"type":"Polygon","coordinates":[[[20.432125091552734,51.289997100830135],
  and so on and so on 
,[20.432125091552734,51.289997100830135]]]},"properties":{"ID_0":79,"ISO":"PL-01","NAME_0":"Poland","ID_1":1,"NAME_1":"somevoivodeship","ID_2":1,"NAME_2":"Bas-Rhin","TYPE_2":"wojewodztwo","ENGTYPE_2":"Department","NL_NAME_2":null,"VARNAME_2":"Unterelsa?"}},
   }}
   ```
   
   I have verified this syntax with geojson syntax from `france.geojson`, and 
it works perfectly when uploaded to mapshaper.org, so I'm sure that it is not a 
problem with the syntax of the geojson file.
   
   Then, I found the `controls.jsx` file (it was located in another directory, 
`/usr/local/lib/python3.5/dist-packages/superset/static/assets/javascripts/explore/stores/controls.jsx`
 instead - found it with `find` shell command and it's the only `controls.jsx` 
in the whole install) and added a correpsonding entry there (as specified in 
step 7). 
   
   Still, I cannot see the new country in the dropdown list.
   
   What am I doing wrong?
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] graceguo-supercat commented on issue #3498: Add check_ownership call in save_or_overwrite_slice

[git]

graceguo-supercat commented on issue #3498: Add check_ownership call in 
save_or_overwrite_slice
URL: 
https://github.com/apache/incubator-superset/issues/3498#issuecomment-336612331
 
 
   @jaylindquist check these lines
   `slice_add_perm = self.can_access('can_add', 'SliceModelView')`
   `slice_overwrite_perm = is_owner(slc, g.user)`
   `slice_download_perm = self.can_access('can_download', 'SliceModelView')`
   ...
   `if action == 'overwrite' and not slice_overwrite_perm:`
   `return json_error_response("You don't have the rights to alter 
this slice", status=400)`
   
   
   we checked all permissions and passing down to 
`self.save_or_overwrite_slice`. is it a good permission check?
 
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] vnnw commented on issue #3516: How to make Table View/ Pivot Table order by time?

[git]

vnnw commented on issue #3516: How to make Table View/ Pivot Table order by 
time?
URL: 
https://github.com/apache/incubator-superset/issues/3516#issuecomment-336609634
 
 
   @Jemteddy Good idea. Why I haven't thought of that? But I do hope there will 
be a option instead of working around.
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3670: Fix the epoch_s & epoch_ms calculations

[git]

coveralls commented on issue #3670: Fix the epoch_s & epoch_ms calculations
URL: 
https://github.com/apache/incubator-superset/pull/3670#issuecomment-336609539
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13714584/badge)](https://coveralls.io/builds/13714584)
   
   Coverage remained the same at 70.384% when pulling 
**63d532f5919ad280312c72bffb1bd35258f75561 on lcx412:master** into 
**bad6938d1a65453b94f7bfe4e9936e6e066b0775 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] lcx412 opened a new pull request #3670: Fix the epoch_s & epoch_ms calculations

[git]

lcx412 opened a new pull request #3670: Fix the epoch_s & epoch_ms calculations
URL: https://github.com/apache/incubator-superset/pull/3670
 
 
   datetime(1970, 1, 1) doesn't correspond to unix timestamp 0 for non UTC
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3652: Authentication: Enable user impersonation for Superset to HiveServer2 using hive.server2.proxy.user (a.fernandez)

[git]

coveralls commented on issue #3652: Authentication: Enable user impersonation 
for Superset to HiveServer2 using hive.server2.proxy.user (a.fernandez)
URL: 
https://github.com/apache/incubator-superset/pull/3652#issuecomment-336588790
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13712801/badge)](https://coveralls.io/builds/13712801)
   
   Coverage decreased (-0.02%) to 70.364% when pulling 
**f310817ab4e5abe2913d39356fe4ddaad5255dfb on 
afernandez:afernandez_impersonate** into 
**bad6938d1a65453b94f7bfe4e9936e6e066b0775 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] afernandez commented on a change in pull request #3652: Authentication: Enable user impersonation for Superset to HiveServer2 using hive.server2.proxy.user (a.fernandez)

[git]

afernandez commented on a change in pull request #3652: Authentication: Enable 
user impersonation for Superset to HiveServer2 using hive.server2.proxy.user 
(a.fernandez)
URL: 
https://github.com/apache/incubator-superset/pull/3652#discussion_r144673331
 
 

 ##
 File path: superset/db_engine_specs.py
 ##
 @@ -830,6 +854,34 @@ def _partition_query(
 cls, table_name, limit=0, order_by=None, filters=None):
 return "SHOW PARTITIONS {table_name}".format(**locals())
 
+@classmethod
+def modify_url_for_impersonation(cls, url, impersonate_user, username):
+"""
+Modify the SQL Alchemy URL object with the user to impersonate if 
applicable.
+:param url: SQLAlchemy URL object
+:param impersonate_user: Bool indicating if impersonation is enabled
+:param username: Effective username
+"""
+if impersonate_user is True and "auth" in url.query.keys() and 
username is not None:
+url.query["hive_server2_proxy_user"] = username
+
+@classmethod
+def get_uri_for_impersonation(cls, uri, impersonate_user, username):
+"""
+Return a new URI string that allows for user impersonation.
+:param uri: URI string
+:param impersonate_user:  Bool indicating if impersonation is enabled
+:param username: Effective username
+:return: New URI string
+"""
+new_uri = uri
+url = make_url(uri)
+backend_name = url.get_backend_name()
+
+# Must be Hive connection, enable impersonation, and set param 
auth=LDAP|KERBEROS
+if backend_name == "hive" and "auth" in url.query.keys() and 
impersonate_user is True and username is not None:
 
 Review comment:
   Fixed
 
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] afernandez commented on a change in pull request #3652: Authentication: Enable user impersonation for Superset to HiveServer2 using hive.server2.proxy.user (a.fernandez)

[git]

afernandez commented on a change in pull request #3652: Authentication: Enable 
user impersonation for Superset to HiveServer2 using hive.server2.proxy.user 
(a.fernandez)
URL: 
https://github.com/apache/incubator-superset/pull/3652#discussion_r144673310
 
 

 ##
 File path: superset/db_engine_specs.py
 ##
 @@ -830,6 +854,34 @@ def _partition_query(
 cls, table_name, limit=0, order_by=None, filters=None):
 return "SHOW PARTITIONS {table_name}".format(**locals())
 
+@classmethod
+def modify_url_for_impersonation(cls, url, impersonate_user, username):
+"""
+Modify the SQL Alchemy URL object with the user to impersonate if 
applicable.
+:param url: SQLAlchemy URL object
+:param impersonate_user: Bool indicating if impersonation is enabled
+:param username: Effective username
+"""
+if impersonate_user is True and "auth" in url.query.keys() and 
username is not None:
 
 Review comment:
   Fixed
 
----
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] afernandez commented on a change in pull request #3652: Authentication: Enable user impersonation for Superset to HiveServer2 using hive.server2.proxy.user (a.fernandez)

[git]

afernandez commented on a change in pull request #3652: Authentication: Enable 
user impersonation for Superset to HiveServer2 using hive.server2.proxy.user 
(a.fernandez)
URL: 
https://github.com/apache/incubator-superset/pull/3652#discussion_r144673294
 
 

 ##
 File path: superset/db_engine_specs.py
 ##
 @@ -184,6 +186,28 @@ def select_star(cls, my_db, table_name, schema=None, 
limit=100,
 sql = sqlparse.format(sql, reindent=True)
 return sql
 
+@classmethod
+def modify_url_for_impersonation(cls, url, impersonate_user, username):
+"""
+Modify the SQL Alchemy URL object with the user to impersonate if 
applicable.
+:param url: SQLAlchemy URL object
+:param impersonate_user: Bool indicating if impersonation is enabled
+:param username: Effective username
+"""
+if impersonate_user and username is not None:
 
 Review comment:
   Fixed
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] timifasubaa closed pull request #3533: Latest import csv

[git]

timifasubaa closed pull request #3533: Latest import csv
URL: https://github.com/apache/incubator-superset/pull/3533
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3643: Import CSV

[git]

coveralls commented on issue #3643: Import CSV
URL: 
https://github.com/apache/incubator-superset/pull/3643#issuecomment-336583119
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13712367/badge)](https://coveralls.io/builds/13712367)
   
   Coverage increased (+0.2%) to 70.584% when pulling 
**91a0e1d1c37ca9d267110c4579d3926cfcedd874 on timifasubaa:import_csv** into 
**bad6938d1a65453b94f7bfe4e9936e6e066b0775 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3643: Import CSV

[git]

coveralls commented on issue #3643: Import CSV
URL: 
https://github.com/apache/incubator-superset/pull/3643#issuecomment-336582592
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13712363/badge)](https://coveralls.io/builds/13712363)
   
   Coverage increased (+0.2%) to 70.584% when pulling 
**91a0e1d1c37ca9d267110c4579d3926cfcedd874 on timifasubaa:import_csv** into 
**bad6938d1a65453b94f7bfe4e9936e6e066b0775 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3643: Import CSV

[git]

coveralls commented on issue #3643: Import CSV
URL: 
https://github.com/apache/incubator-superset/pull/3643#issuecomment-336582591
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13712363/badge)](https://coveralls.io/builds/13712363)
   
   Coverage increased (+0.2%) to 70.584% when pulling 
**91a0e1d1c37ca9d267110c4579d3926cfcedd874 on timifasubaa:import_csv** into 
**bad6938d1a65453b94f7bfe4e9936e6e066b0775 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3643: Import CSV

[git]

coveralls commented on issue #3643: Import CSV
URL: 
https://github.com/apache/incubator-superset/pull/3643#issuecomment-336582589
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13712363/badge)](https://coveralls.io/builds/13712363)
   
   Coverage increased (+0.2%) to 70.584% when pulling 
**91a0e1d1c37ca9d267110c4579d3926cfcedd874 on timifasubaa:import_csv** into 
**bad6938d1a65453b94f7bfe4e9936e6e066b0775 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3643: Import CSV

[git]

coveralls commented on issue #3643: Import CSV
URL: 
https://github.com/apache/incubator-superset/pull/3643#issuecomment-336582590
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13712363/badge)](https://coveralls.io/builds/13712363)
   
   Coverage increased (+0.2%) to 70.584% when pulling 
**91a0e1d1c37ca9d267110c4579d3926cfcedd874 on timifasubaa:import_csv** into 
**bad6938d1a65453b94f7bfe4e9936e6e066b0775 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3643: Import CSV

[git]

coveralls commented on issue #3643: Import CSV
URL: 
https://github.com/apache/incubator-superset/pull/3643#issuecomment-336582382
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13712303/badge)](https://coveralls.io/builds/13712303)
   
   Coverage increased (+0.2%) to 70.584% when pulling 
**91a0e1d1c37ca9d267110c4579d3926cfcedd874 on timifasubaa:import_csv** into 
**bad6938d1a65453b94f7bfe4e9936e6e066b0775 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3643: Import CSV

[git]

coveralls commented on issue #3643: Import CSV
URL: 
https://github.com/apache/incubator-superset/pull/3643#issuecomment-336582381
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13712303/badge)](https://coveralls.io/builds/13712303)
   
   Coverage increased (+0.2%) to 70.584% when pulling 
**91a0e1d1c37ca9d267110c4579d3926cfcedd874 on timifasubaa:import_csv** into 
**bad6938d1a65453b94f7bfe4e9936e6e066b0775 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3643: Import CSV

[git]

coveralls commented on issue #3643: Import CSV
URL: 
https://github.com/apache/incubator-superset/pull/3643#issuecomment-336582383
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13712303/badge)](https://coveralls.io/builds/13712303)
   
   Coverage increased (+0.2%) to 70.584% when pulling 
**91a0e1d1c37ca9d267110c4579d3926cfcedd874 on timifasubaa:import_csv** into 
**bad6938d1a65453b94f7bfe4e9936e6e066b0775 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] timifasubaa commented on issue #3643: Import CSV

[git]

timifasubaa commented on issue #3643: Import CSV
URL: 
https://github.com/apache/incubator-superset/pull/3643#issuecomment-336579863
 
 
   @mistercrunch resolved!
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] coveralls commented on issue #3643: Import CSV

[git]

coveralls commented on issue #3643: Import CSV
URL: 
https://github.com/apache/incubator-superset/pull/3643#issuecomment-336579486
 
 
   
   [![Coverage 
Status](https://coveralls.io/builds/13712078/badge)](https://coveralls.io/builds/13712078)
   
   Coverage increased (+0.2%) to 70.584% when pulling 
**8b68fb01f74381285c6c98ab6c4e19a66147cfed on timifasubaa:import_csv** into 
**bad6938d1a65453b94f7bfe4e9936e6e066b0775 on apache:master**.
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services