[GitHub] codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart
codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart URL: https://github.com/apache/incubator-superset/pull/4772#issuecomment-379125594 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=h1) Report > Merging [#4772](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr=desc) will **increase** coverage by `0.08%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4772 +/- ## == + Coverage 72.59% 72.67% +0.08% == Files 205 205 Lines 1540115402 +1 Branches 1183 1183 == + Hits1118011194 +14 + Misses 4218 4205 -13 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.45% <ø> (+0.97%)` | :arrow_up: | | [superset/assets/javascripts/dashboard/reducers.js](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9yZWR1Y2Vycy5qcw==) | `50% <100%> (ø)` | :arrow_up: | | [...ssets/javascripts/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `93.82% <100%> (+0.07%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=footer). Last update [92230b8...cd11186](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart
codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart URL: https://github.com/apache/incubator-superset/pull/4772#issuecomment-379125594 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=h1) Report > Merging [#4772](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr=desc) will **increase** coverage by `0.08%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4772 +/- ## == + Coverage 72.59% 72.67% +0.08% == Files 205 205 Lines 1540115402 +1 Branches 1183 1183 == + Hits1118011194 +14 + Misses 4218 4205 -13 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.45% <ø> (+0.97%)` | :arrow_up: | | [superset/assets/javascripts/dashboard/reducers.js](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9yZWR1Y2Vycy5qcw==) | `50% <100%> (ø)` | :arrow_up: | | [...ssets/javascripts/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `93.82% <100%> (+0.07%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=footer). Last update [92230b8...cd11186](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart
codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart URL: https://github.com/apache/incubator-superset/pull/4772#issuecomment-379125594 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=h1) Report > Merging [#4772](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr=desc) will **increase** coverage by `0.08%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4772 +/- ## == + Coverage 72.59% 72.67% +0.08% == Files 205 205 Lines 1540115401 Branches 1183 1183 == + Hits1118011193 +13 + Misses 4218 4205 -13 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.45% <ø> (+0.97%)` | :arrow_up: | | [...ssets/javascripts/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `93.75% <100%> (ø)` | :arrow_up: | | [superset/assets/javascripts/dashboard/reducers.js](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9yZWR1Y2Vycy5qcw==) | `50% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=footer). Last update [92230b8...b8a396f](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart
codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart URL: https://github.com/apache/incubator-superset/pull/4772#issuecomment-379125594 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=h1) Report > Merging [#4772](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr=desc) will **increase** coverage by `0.08%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4772 +/- ## == + Coverage 72.59% 72.67% +0.08% == Files 205 205 Lines 1540115401 Branches 1183 1183 == + Hits1118011193 +13 + Misses 4218 4205 -13 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.45% <ø> (+0.97%)` | :arrow_up: | | [...ssets/javascripts/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `93.75% <100%> (ø)` | :arrow_up: | | [superset/assets/javascripts/dashboard/reducers.js](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9yZWR1Y2Vycy5qcw==) | `50% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=footer). Last update [92230b8...b8a396f](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart
codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart URL: https://github.com/apache/incubator-superset/pull/4772#issuecomment-379125594 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=h1) Report > Merging [#4772](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr=desc) will **increase** coverage by `0.08%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4772 +/- ## == + Coverage 72.59% 72.67% +0.08% == Files 205 205 Lines 1540115401 Branches 1183 1183 == + Hits1118011193 +13 + Misses 4218 4205 -13 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=tree) | Coverage Δ | | |---|---|---| | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.45% <ø> (+0.97%)` | :arrow_up: | | [...ssets/javascripts/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `93.75% <100%> (ø)` | :arrow_up: | | [superset/assets/javascripts/dashboard/reducers.js](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9yZWR1Y2Vycy5qcw==) | `50% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=footer). Last update [92230b8...b8a396f](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart
codecov-io commented on issue #4772: [dashboard] open in edit mode when adding a chart URL: https://github.com/apache/incubator-superset/pull/4772#issuecomment-379125594 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=h1) Report > Merging [#4772](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/92230b853566de2ee55c55c49a2b1b41e10a6d10?src=pr=desc) will **increase** coverage by `<.01%`. > The diff coverage is `100%`. [](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=tree) ```diff @@Coverage Diff @@ ## master#4772 +/- ## == + Coverage 72.59% 72.59% +<.01% == Files 205 205 Lines 1540115402 +1 Branches 1183 1183 == + Hits1118011181 +1 Misses 4218 4218 Partials33 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=tree) | Coverage Δ | | |---|---|---| | [...cripts/dashboard/components/DashboardContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZENvbnRhaW5lci5qc3g=) | `0% <ø> (ø)` | :arrow_up: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `73.5% <100%> (+0.01%)` | :arrow_up: | | [...ssets/javascripts/explore/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4772/diff?src=pr=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2V4cGxvcmUvY29tcG9uZW50cy9TYXZlTW9kYWwuanN4) | `93.75% <100%> (ø)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=footer). Last update [92230b8...b248744](https://codecov.io/gh/apache/incubator-superset/pull/4772?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
