[GitHub] hughhhh commented on issue #4643: Added option to add fill to area line charts
hug commented on issue #4643: Added option to add fill to area line charts URL: https://github.com/apache/incubator-superset/pull/4643#issuecomment-379035275 deprioritizing due to work needing to be done on nvd3 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hughhhh commented on issue #4643: Added option to add fill to area line charts
hug commented on issue #4643: Added option to add fill to area line charts URL: https://github.com/apache/incubator-superset/pull/4643#issuecomment-375553809 Setting the `fillOpacity` chart doesn't effect the color. Its weird because the api allows it to set this value but it doesn't change it in the view. I'll keep debugging might be a good op to contribute back to nvd3 :p ![line_area_opacity](https://user-images.githubusercontent.com/27827808/37814127-9b40c404-2e25-11e8-89d6-505f8e0375b2.gif) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hughhhh commented on issue #4643: Added option to add fill to area line charts
hug commented on issue #4643: Added option to add fill to area line charts URL: https://github.com/apache/incubator-superset/pull/4643#issuecomment-375553809 Setting the `fillOpacity` chart doesn't effect the color. Its weird because the api allows it to set this value but it doesn't change it in the view. ![line_area_opacity](https://user-images.githubusercontent.com/27827808/37814127-9b40c404-2e25-11e8-89d6-505f8e0375b2.gif) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hughhhh commented on issue #4643: Added option to add fill to area line charts
hug commented on issue #4643: Added option to add fill to area line charts URL: https://github.com/apache/incubator-superset/pull/4643#issuecomment-375553809 Setting the `fillOpacity` chart doesn't effect the color. Its weird because the api allows it to set this value but it doesn't change it in the view. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hughhhh commented on issue #4643: Added option to add fill to area line charts
hug commented on issue #4643: Added option to add fill to area line charts URL: https://github.com/apache/incubator-superset/pull/4643#issuecomment-375553809 Setting the `fillOpacity` chart doesn't effect the color. Its weird because the api allows it to set this value but it doesn't change it in the view. ![line_area](https://user-images.githubusercontent.com/27827808/37813941-c59681ae-2e24-11e8-8333-859cacc99e1f.gif) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hughhhh commented on issue #4643: Added option to add fill to area line charts
hug commented on issue #4643: Added option to add fill to area line charts URL: https://github.com/apache/incubator-superset/pull/4643#issuecomment-374841266 Made the changes but have weird bug with nvd3 when messing around with the legend. It resets all the path css to have 100% opacity, but then when click another legend item it resets itself. I've been messing around with the css and no luck. any advice? ![line_area](https://user-images.githubusercontent.com/27827808/37696362-3fc86016-2c93-11e8-8242-fe9f91dd383e.gif) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hughhhh commented on issue #4643: Added option to add fill to area line charts
hug commented on issue #4643: Added option to add fill to area line charts URL: https://github.com/apache/incubator-superset/pull/4643#issuecomment-374841266 Made the changes but have weird bug with nvd3 when messing around with the legend. It reset all the path css to have 100% opacity, but then when click another legend item it resets itself. I've been messing around with the css and no luck. any advice? ![line_area](https://user-images.githubusercontent.com/27827808/37696362-3fc86016-2c93-11e8-8242-fe9f91dd383e.gif) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] hughhhh commented on issue #4643: Added option to add fill to area line charts
hug commented on issue #4643: Added option to add fill to area line charts URL: https://github.com/apache/incubator-superset/pull/4643#issuecomment-374841266 Made the changes but have weird bug with nvd3 when messing around with the legend. I've been messing around with the css and no luck. any advice? ![line_area](https://user-images.githubusercontent.com/27827808/37696362-3fc86016-2c93-11e8-8242-fe9f91dd383e.gif) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services