[GitHub] mistercrunch commented on a change in pull request #4890: [bugfix] temporal columns with expression fail
mistercrunch commented on a change in pull request #4890: [bugfix] temporal
columns with expression fail
URL:
https://github.com/apache/incubator-superset/pull/4890#discussion_r184558306
##
File path: superset/connectors/sqla/models.py
##
@@ -130,8 +131,9 @@ def get_timestamp_expression(self, time_grain):
elif pdf == 'epoch_ms':
expr = db_spec.epoch_ms_to_dttm().format(col=expr)
grain = self.table.database.grains_dict().get(time_grain)
-literal = grain.function if grain else '{col}'
-literal = expr.format(col=expr)
+if grain:
+literal = grain.function
+literal = expr.format(col=expr)
Review comment:
Yeah I think we're both wrong on this one :( , I'm going to clean this up a
bit more and write many tests covering the whole function.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] mistercrunch commented on a change in pull request #4890: [bugfix] temporal columns with expression fail
mistercrunch commented on a change in pull request #4890: [bugfix] temporal
columns with expression fail
URL:
https://github.com/apache/incubator-superset/pull/4890#discussion_r184538061
##
File path: tests/model_tests.py
##
@@ -105,3 +105,9 @@ def test_grains_dict(self):
self.assertEquals(d.get('day').function, 'DATE({col})')
self.assertEquals(d.get('P1D').function, 'DATE({col})')
self.assertEquals(d.get('Time Column').function, '{col}')
+
+def test_get_timestamp_expression(self):
+tbl = self.get_table_by_name('birth_names')
+ds_col = tbl.get_column('ds')
+sqla_literal = ds_col.get_timestamp_expression(None)
Review comment:
The problem is the test will fail depending on the database it's working on.
I guess I can figure out which engine it's on (postgres/mysql) and do the
proper assertion depending on that
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
