[GitHub] mistercrunch commented on issue #4552: [travis/tox] Restructuring configuration and testing
mistercrunch commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-378826189 So if I want to add a python dep where do I do it? In setup.py AND in requirements.txt? I was thinking this process would involve a [documented] pip-compile step and the whole dep tree. I remember we spoke about this but forgot the details on why no pip-compile + pinning the whole tree. If the goal is to get as close as possible to an fully reproducible build, it seems like we need the whole dep tree. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4552: [travis/tox] Restructuring configuration and testing
mistercrunch commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-378973490 Also I'm not clear on how Pypi operates, but my guess is that it only looks at what's in `setup.py` and disregards the `requirements.txt` file, meaning a simple `pip install superset` would be less predictable following this PR since much version-range specs was removed from `setup.py` in this PR. At Lyft our build process for all Python apps generates both a `requirements.txt` and a `requirements3.txt` out of a `requirements.in` file, not sure how it's accomplished, maybe it has pip-compile while 2 different venv are used alternatively. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mistercrunch commented on issue #4552: [travis/tox] Restructuring configuration and testing
mistercrunch commented on issue #4552: [travis/tox] Restructuring configuration and testing URL: https://github.com/apache/incubator-superset/pull/4552#issuecomment-379980121 LGTM! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
