[GitHub] timifasubaa commented on issue #4552: [travis/tox] Restructuring configuration and testing

2018-04-05 Thread GitBox
timifasubaa commented on issue #4552: [travis/tox] Restructuring configuration 
and testing
URL: 
https://github.com/apache/incubator-superset/pull/4552#issuecomment-378840175
 
 
   @mistercrunch @john-bodley Would (pipenv)[https://docs.pipenv.org/] solve 
our problems here? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] timifasubaa commented on issue #4552: [travis/tox] Restructuring configuration and testing

2018-04-05 Thread GitBox
timifasubaa commented on issue #4552: [travis/tox] Restructuring configuration 
and testing
URL: 
https://github.com/apache/incubator-superset/pull/4552#issuecomment-378840175
 
 
   @mistercrunch @john-bodley Would pipenv[https://docs.pipenv.org/] solve our 
problems here? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] timifasubaa commented on issue #4552: [travis/tox] Restructuring configuration and testing

2018-03-22 Thread GitBox
timifasubaa commented on issue #4552: [travis/tox] Restructuring configuration 
and testing
URL: 
https://github.com/apache/incubator-superset/pull/4552#issuecomment-375517723
 
 
   +1 Because having a requirements.txt file can improve the speed of our 
Docker builds. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] timifasubaa commented on issue #4552: [travis/tox] Restructuring configuration and testing

2018-03-22 Thread GitBox
timifasubaa commented on issue #4552: [travis/tox] Restructuring configuration 
and testing
URL: 
https://github.com/apache/incubator-superset/pull/4552#issuecomment-375515748
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services