[GitHub] xrmx commented on issue #4333: Add hour grain to SQLite

2018-02-03 Thread GitBox 
xrmx commented on issue #4333: Add hour grain to SQLite
URL: 
https://github.com/apache/incubator-superset/pull/4333#issuecomment-362829108
 
 
   No objection from me, just that I haven't seen a mention in the commit :)
   
   Il 02 feb 2018 11:09 PM, "Beto Dealmeida"  ha
   scritto:
   
   > @xrmx , I thought it made sense to update the
   > sample data to have higher than daily resolution, but I can remove that.
   >
   > ?
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on issue #4333: Add hour grain to SQLite

2018-02-02 Thread GitBox 
xrmx commented on issue #4333: Add hour grain to SQLite
URL: 
https://github.com/apache/incubator-superset/pull/4333#issuecomment-362686251
 
 
   Is the `data/__init__.py` hunk supposed to be here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] xrmx commented on issue #4333: Add hour grain to SQLite

2018-02-02 Thread GitBox 
xrmx commented on issue #4333: Add hour grain to SQLite
URL: 
https://github.com/apache/incubator-superset/pull/4333#issuecomment-362686251
 
 
   Is the __init__.py hunk supposed to be here?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services