[GitHub] xrmx commented on issue #4412: Comment row at end of query in SQL Lab fails to render in Explore window
xrmx commented on issue #4412: Comment row at end of query in SQL Lab fails to render in Explore window URL: https://github.com/apache/incubator-superset/issues/4412#issuecomment-365217960 @villebro please open a PR so it can be reviewed and merged. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #4412: Comment row at end of query in SQL Lab fails to render in Explore window
xrmx commented on issue #4412: Comment row at end of query in SQL Lab fails to render in Explore window URL: https://github.com/apache/incubator-superset/issues/4412#issuecomment-365207900 Looking again at the code we may want to clean the sql *after* poking with the template processor. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #4412: Comment row at end of query in SQL Lab fails to render in Explore window
xrmx commented on issue #4412: Comment row at end of query in SQL Lab fails to render in Explore window URL: https://github.com/apache/incubator-superset/issues/4412#issuecomment-365207248 Looks good to me, bonus points for adding a test :) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #4412: Comment row at end of query in SQL Lab fails to render in Explore window
xrmx commented on issue #4412: Comment row at end of query in SQL Lab fails to render in Explore window URL: https://github.com/apache/incubator-superset/issues/4412#issuecomment-365200288 sqlparse.format has an option for removing comments http://sqlparse.readthedocs.io/en/latest/api/#formatting-of-sql-statements This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] xrmx commented on issue #4412: Comment row at end of query in SQL Lab fails to render in Explore window
xrmx commented on issue #4412: Comment row at end of query in SQL Lab fails to render in Explore window URL: https://github.com/apache/incubator-superset/issues/4412#issuecomment-365200288 sqlparse.format has an option for striping comments http://sqlparse.readthedocs.io/en/latest/api/#formatting-of-sql-statements This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
