[GitHub] xrmx commented on issue #4886: remove hard code http scheme of short url #4656

2018-04-26 Thread GitBox
xrmx commented on issue #4886: remove hard code http scheme of short url #4656
URL: 
https://github.com/apache/incubator-superset/pull/4886#issuecomment-384564829
 
 
   @ripoul you fix what hey report:
   ./superset/views/core.py:754:13: E122 continuation line missing indentation 
or outdented
   
   that means that you have to readd the 4 spaces indentation you removed :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] xrmx commented on issue #4886: remove hard code http scheme of short url #4656

2018-04-26 Thread GitBox
xrmx commented on issue #4886: remove hard code http scheme of short url #4656
URL: 
https://github.com/apache/incubator-superset/pull/4886#issuecomment-384564829
 
 
   @ripoul you fix what hey report:
   ./superset/views/core.py:754:13: E122 continuation line missing indentation 
or outdented
   
   that means that you have to readd the 4 spaces indentation you removed )


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] xrmx commented on issue #4886: remove hard code http scheme of short url #4656

2018-04-26 Thread GitBox
xrmx commented on issue #4886: remove hard code http scheme of short url #4656
URL: 
https://github.com/apache/incubator-superset/pull/4886#issuecomment-384552150
 
 
   @ripoul i think it would be more complicated than that to have the full url 
with scheme and host. Don't mind that, we can cleanup that later.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services