Re: Issue 5791 - Need feedback

2019-05-21 Thread John Bodley
I’ve added some comments to your PR. It’s probably best to
discuss/iterate on the memoized issue in the PR.

> On May 21, 2019, at 12:58 AM, Gianluca Ciccarelli 
>  wrote:
>
> Hi all,
>
> I’d appreciate feedback on my PR (at 
> https://github.com/apache/incubator-superset/pull/7403/).
>
> I’m almost done addressing the 5 errors found by lgtm.com 
> (https://lgtm.com/projects/g/apache/incubator-superset/alerts/?mode=list&severity=error).
>  I’m only having problems understanding how to fix the alert about memoized 
> (called "Mutation of descriptor in __get__ or __set__ method.”).
>
> Any suggestion is more than welcome!
>
> Gianluca Ciccarelli
> Data Engineer @ Bolt


Issue 5791 - Need feedback

2019-05-21 Thread Gianluca Ciccarelli
Hi all,

I’d appreciate feedback on my PR (at 
https://github.com/apache/incubator-superset/pull/7403/).

I’m almost done addressing the 5 errors found by lgtm.com 
(https://lgtm.com/projects/g/apache/incubator-superset/alerts/?mode=list&severity=error).
 I’m only having problems understanding how to fix the alert about memoized 
(called "Mutation of descriptor in __get__ or __set__ method.”).

Any suggestion is more than welcome!

Gianluca Ciccarelli
Data Engineer @ Bolt