date:20170627

[GitHub] syncope pull request #47: Fixes [SYNCOPE-1110], [SYNCOPE-1123]

2017-06-27 Thread mat-ale

GitHub user mat-ale opened a pull request:

https://github.com/apache/syncope/pull/47

Fixes [SYNCOPE-1110], [SYNCOPE-1123]

Hi,

this fixes 
[[SYNCOPE-1110]](https://issues.apache.org/jira/browse/SYNCOPE-1110) and 
[[SYNCOPE-1123]](https://issues.apache.org/jira/browse/SYNCOPE-1123).

Regards,
Matteo

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mat-ale/syncope SYNCOPE-1110

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/syncope/pull/47.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #47


commit abbed772c8f2723ffc002a480f3f20600650128d
Author: Matteo Alessandroni 
Date:   2017-06-23T12:27:17Z

Fixes [SYNCOPE-1110], [SYNCOPE-1123]




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (SYNCOPE-1110) Error replacing group/auxclass/resource during self-management operation

2017-06-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SYNCOPE-1110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064408#comment-16064408
 ] 

ASF GitHub Bot commented on SYNCOPE-1110:
-

GitHub user mat-ale opened a pull request:

https://github.com/apache/syncope/pull/47

Fixes [SYNCOPE-1110], [SYNCOPE-1123]

Hi,

this fixes 
[[SYNCOPE-1110]](https://issues.apache.org/jira/browse/SYNCOPE-1110) and 
[[SYNCOPE-1123]](https://issues.apache.org/jira/browse/SYNCOPE-1123).

Regards,
Matteo

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mat-ale/syncope SYNCOPE-1110

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/syncope/pull/47.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #47


commit abbed772c8f2723ffc002a480f3f20600650128d
Author: Matteo Alessandroni 
Date:   2017-06-23T12:27:17Z

Fixes [SYNCOPE-1110], [SYNCOPE-1123]




> Error replacing group/auxclass/resource during self-management operation
> 
>
> Key: SYNCOPE-1110
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1110
> Project: Syncope
>  Issue Type: Bug
>  Components: enduser
>Affects Versions: 2.0.3
>Reporter: fabio martelli
> Fix For: 2.0.4, 2.1.0
>
>
> Steps to reproduce:
> # perform a self registration by specifying 2 groups, 2 aux classes and 2 
> resources
> # submit and perform an approval with admin user
> # perform a self management by replacing one group/auxclass/resource with 
> another one
> # submbit and perform an approval with admin user
> # check the expected result into the administration console 
> Groups, auxclasses and resources assigned to the approved user will be three 
> instead of two.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] syncope pull request #47: Fixes [SYNCOPE-1110], [SYNCOPE-1123]

2017-06-27 Thread ilgrosso

Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/47#discussion_r124199671
  
--- Diff: 
client/enduser/src/main/java/org/apache/syncope/client/enduser/model/CustomAttribute.java
 ---
@@ -26,18 +26,18 @@
 
 private static final long serialVersionUID = 4910266842123376686L;
 
-private Boolean readonly;
+private boolean readonly;
 
 private List defaultValues = new ArrayList<>();
 
 public CustomAttribute() {
 }
 
-public Boolean getReadonly() {
+public boolean getReadonly() {
--- End diff --

This should be `isReadonly()`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (SYNCOPE-1110) Error replacing group/auxclass/resource during self-management operation

2017-06-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SYNCOPE-1110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064411#comment-16064411
 ] 

ASF GitHub Bot commented on SYNCOPE-1110:
-

Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/47#discussion_r124199671
  
--- Diff: 
client/enduser/src/main/java/org/apache/syncope/client/enduser/model/CustomAttribute.java
 ---
@@ -26,18 +26,18 @@
 
 private static final long serialVersionUID = 4910266842123376686L;
 
-private Boolean readonly;
+private boolean readonly;
 
 private List defaultValues = new ArrayList<>();
 
 public CustomAttribute() {
 }
 
-public Boolean getReadonly() {
+public boolean getReadonly() {
--- End diff --

This should be `isReadonly()`


> Error replacing group/auxclass/resource during self-management operation
> 
>
> Key: SYNCOPE-1110
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1110
> Project: Syncope
>  Issue Type: Bug
>  Components: enduser
>Affects Versions: 2.0.3
>Reporter: fabio martelli
> Fix For: 2.0.4, 2.1.0
>
>
> Steps to reproduce:
> # perform a self registration by specifying 2 groups, 2 aux classes and 2 
> resources
> # submit and perform an approval with admin user
> # perform a self management by replacing one group/auxclass/resource with 
> another one
> # submbit and perform an approval with admin user
> # check the expected result into the administration console 
> Groups, auxclasses and resources assigned to the approved user will be three 
> instead of two.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] syncope pull request #47: Fixes [SYNCOPE-1110], [SYNCOPE-1123]

2017-06-27 Thread ilgrosso

Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/47#discussion_r124199801
  
--- Diff: 
client/enduser/src/main/java/org/apache/syncope/client/enduser/resources/UserSelfReadResource.java
 ---
@@ -137,12 +137,13 @@ public void writeData(final Attributes attributes) 
throws IOException {
 private void customizeAttrs(final Set attrs,
 final Map customForm) {
 
-CollectionUtils.filter(attrs, new Predicate() {
-
-@Override
-public boolean evaluate(final AttrTO attr) {
-return customForm.containsKey(attr.getSchema());
+Set attrsToAdd = new HashSet<>();
--- End diff --

You could use `CollectionUtils.collect()` here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (SYNCOPE-1110) Error replacing group/auxclass/resource during self-management operation

2017-06-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SYNCOPE-1110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064412#comment-16064412
 ] 

ASF GitHub Bot commented on SYNCOPE-1110:
-

Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/47#discussion_r124199801
  
--- Diff: 
client/enduser/src/main/java/org/apache/syncope/client/enduser/resources/UserSelfReadResource.java
 ---
@@ -137,12 +137,13 @@ public void writeData(final Attributes attributes) 
throws IOException {
 private void customizeAttrs(final Set attrs,
 final Map customForm) {
 
-CollectionUtils.filter(attrs, new Predicate() {
-
-@Override
-public boolean evaluate(final AttrTO attr) {
-return customForm.containsKey(attr.getSchema());
+Set attrsToAdd = new HashSet<>();
--- End diff --

You could use `CollectionUtils.collect()` here.


> Error replacing group/auxclass/resource during self-management operation
> 
>
> Key: SYNCOPE-1110
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1110
> Project: Syncope
>  Issue Type: Bug
>  Components: enduser
>Affects Versions: 2.0.3
>Reporter: fabio martelli
> Fix For: 2.0.4, 2.1.0
>
>
> Steps to reproduce:
> # perform a self registration by specifying 2 groups, 2 aux classes and 2 
> resources
> # submit and perform an approval with admin user
> # perform a self management by replacing one group/auxclass/resource with 
> another one
> # submbit and perform an approval with admin user
> # check the expected result into the administration console 
> Groups, auxclasses and resources assigned to the approved user will be three 
> instead of two.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] syncope pull request #47: Fixes [SYNCOPE-1110], [SYNCOPE-1123]

2017-06-27 Thread ilgrosso

Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/47#discussion_r124200072
  
--- Diff: fit/enduser-reference/src/test/resources/protractor-conf.js ---
@@ -19,17 +19,17 @@
 exports.config = {
   directConnect: false,
   capabilities: {
-'browserName': 'phantomjs',
+'browserName': 'chrome',
--- End diff --

Bad: restore `phantomjs` here!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (SYNCOPE-1110) Error replacing group/auxclass/resource during self-management operation

2017-06-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/SYNCOPE-1110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064414#comment-16064414
 ] 

ASF GitHub Bot commented on SYNCOPE-1110:
-

Github user ilgrosso commented on a diff in the pull request:

https://github.com/apache/syncope/pull/47#discussion_r124200072
  
--- Diff: fit/enduser-reference/src/test/resources/protractor-conf.js ---
@@ -19,17 +19,17 @@
 exports.config = {
   directConnect: false,
   capabilities: {
-'browserName': 'phantomjs',
+'browserName': 'chrome',
--- End diff --

Bad: restore `phantomjs` here!


> Error replacing group/auxclass/resource during self-management operation
> 
>
> Key: SYNCOPE-1110
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1110
> Project: Syncope
>  Issue Type: Bug
>  Components: enduser
>Affects Versions: 2.0.3
>Reporter: fabio martelli
> Fix For: 2.0.4, 2.1.0
>
>
> Steps to reproduce:
> # perform a self registration by specifying 2 groups, 2 aux classes and 2 
> resources
> # submit and perform an approval with admin user
> # perform a self management by replacing one group/auxclass/resource with 
> another one
> # submbit and perform an approval with admin user
> # check the expected result into the administration console 
> Groups, auxclasses and resources assigned to the approved user will be three 
> instead of two.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (SYNCOPE-1122) Enduser must show all attributes when customForm.json has empty section with show=true

2017-06-27 Thread Andrea Patricelli (JIRA)


 [ 
https://issues.apache.org/jira/browse/SYNCOPE-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrea Patricelli updated SYNCOPE-1122:
---
Description: 
If customForm.json is like this:
{code}
{
 
  "PLAIN":
  {
"show": true
  }
}
{code}
I see all plain attributes, but they haven't values.

  was:
If customForm.json is like this:
{code}
{
 
  "PLAIN":
  {
"show": true
  }
}
{code}
I should see all plain attributes, I see instead none.


> Enduser must show all attributes when customForm.json has empty section with 
> show=true
> --
>
> Key: SYNCOPE-1122
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1122
> Project: Syncope
>  Issue Type: Bug
>  Components: enduser
>Affects Versions: 2.0.3
>Reporter: Andrea Patricelli
>Assignee: Andrea Patricelli
> Fix For: 2.0.4, 2.1.0
>
>
> If customForm.json is like this:
> {code}
> {
>  
>   "PLAIN":
>   {
> "show": true
>   }
> }
> {code}
> I see all plain attributes, but they haven't values.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: [DISCUSS] - Third party JWT SSO integration?

2017-06-27 Thread Francesco Chicchiriccò

On 26/06/2017 18:07, Colm O hEigeartaigh wrote:

Hi all,

It occurred to me that we can easily support SSO using third party JWT
tokens. Instead of (or as well as) having a single "jwsSignatureVerifier"
in securityContext.xml, we could have a map of issuer ->
jwsSignatureVerifier Objects.

We could get the verifier to use to verify the signature by querying the
map using the issuer of the token. If this succeeds, and if the subject is
a known user, we could allow the call to proceed.

Alternatively, we could have a separate service which translates third
party JWT tokens into local SSO tokens.

Hi Colm,
your idea seems interesting.

Instead of providing a map in securityContext.xml, I would rather enable
[1] to dynamically discover JwsSignatureVerifier implementations (or
maybe a new interface of ours extending that, adding a getIssuer() method).
Moreover, the new interface extending JwsSignatureVerifier could also
provide a method to resolve the JWT subject into Syncope username (known
user).

If you like, I can take care of this.

Please also note that such SSO would work only at REST level; in order
to enable Admin Console or Enduser UI to that, something like the SAML
2.0 SP Agent [2] will need to be provided.

As people started asking for 2.0.4 [3][4] and CXF 3.1.12 is under vote,
I think we should start finalizing, e.g. postponing new features and
improvements to 2.0.5. But maybe this one can still fit.

Regards.

[1]
https://github.com/apache/syncope/blob/2_0_X/core/logic/src/main/java/org/apache/syncope/core/logic/init/ClassPathScanImplementationLookup.java
[2]
https://github.com/apache/syncope/blob/2_0_X/ext/saml2sp/agent/src/main/java/org/apache/syncope/ext/saml2lsp/agent/AssertionConsumer.java#L47
[3]
https://lists.apache.org/thread.html/d8a6f8fe3629d1d00165e2461458511d8ace983af6006a5d304fa6a9@%3Cuser.syncope.apache.org%3E
[4]
https://lists.apache.org/thread.html/7d9072146f01994c8fb7f02c8af1f88e031345e391c06970a8fcf1ff@%3Cuser.syncope.apache.org%3E

--
Francesco Chicchiriccò

Tirasa - Open Source Excellence
http://www.tirasa.net/

Member at The Apache Software Foundation
Syncope, Cocoon, Olingo, CXF, OpenJPA, PonyMail
http://home.apache.org/~ilgrosso/

[jira] [Assigned] (SYNCOPE-1113) Report files are downloaded with same extension

2017-06-27 Thread fabio martelli (JIRA)


 [ 
https://issues.apache.org/jira/browse/SYNCOPE-1113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

fabio martelli reassigned SYNCOPE-1113:
---

Assignee: fabio martelli

> Report files are downloaded with same extension
> ---
>
> Key: SYNCOPE-1113
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1113
> Project: Syncope
>  Issue Type: Bug
>  Components: console
>Affects Versions: 2.0.3, 2.0.4
> Environment: Firefox browser
>Reporter: Matteo Alessandroni
>Assignee: fabio martelli
>Priority: Minor
> Fix For: 2.0.4, 2.1.0
>
>
> Steps to reproduce:
> #  go to Reports;
> #  execute a report and go to "view" section;
> #  click on the just executed report and export it in one of the available 
> formats;
> #  try to export the same report in the other formats
> *problem*: the exported files will always have the same format as in the 
> first export (step 3).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SYNCOPE-1120) Use the standard Bearer Authorization header for JWT tokens

2017-06-27 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/SYNCOPE-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064485#comment-16064485
 ] 

ASF subversion and git services commented on SYNCOPE-1120:
--

Commit ee802ac1503a51b734a91448770fe05da193e138 in syncope's branch 
refs/heads/master from [~ilgrosso]
[ https://git-wip-us.apache.org/repos/asf?p=syncope.git;h=ee802ac ]

[SYNCOPE-1120] Updating docs


> Use the standard Bearer Authorization header for JWT tokens
> ---
>
> Key: SYNCOPE-1120
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1120
> Project: Syncope
>  Issue Type: Improvement
>Reporter: Colm O hEigeartaigh
>Assignee: Colm O hEigeartaigh
> Fix For: 2.0.4, 2.1.0
>
>
> As discussed on the mailing list, this task is to switch to use the standard 
> Bearer Authorization header instead of X-Syncope-Token when invoking on REST 
> services:
> https://t.co/QwLRejSgJL



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (SYNCOPE-1120) Use the standard Bearer Authorization header for JWT tokens

2017-06-27 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/SYNCOPE-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064484#comment-16064484
 ] 

ASF subversion and git services commented on SYNCOPE-1120:
--

Commit 047ef966f3ef9af40f4c258efedaf8d42a8e843c in syncope's branch 
refs/heads/2_0_X from [~ilgrosso]
[ https://git-wip-us.apache.org/repos/asf?p=syncope.git;h=047ef96 ]

[SYNCOPE-1120] Updating docs


> Use the standard Bearer Authorization header for JWT tokens
> ---
>
> Key: SYNCOPE-1120
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1120
> Project: Syncope
>  Issue Type: Improvement
>Reporter: Colm O hEigeartaigh
>Assignee: Colm O hEigeartaigh
> Fix For: 2.0.4, 2.1.0
>
>
> As discussed on the mailing list, this task is to switch to use the standard 
> Bearer Authorization header instead of X-Syncope-Token when invoking on REST 
> services:
> https://t.co/QwLRejSgJL



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

66 matches

Mail list logo