[GitHub] [syncope] ilgrosso closed pull request #206: [SYNCOPE-1578] Adding auth support to SRA, with OIDC / OAUTH2 implementations, reviewing several details on WA and Core to make all functional
ilgrosso closed pull request #206: URL: https://github.com/apache/syncope/pull/206 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [syncope] ilgrosso closed pull request #205: [SYNCOPE-1578] Adding auth support to SRA, with OIDC / OAUTH2 implementations, revie…
ilgrosso closed pull request #205: URL: https://github.com/apache/syncope/pull/205 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [syncope] ilgrosso commented on pull request #205: [SYNCOPE-1578] Adding auth support to SRA, with OIDC / OAUTH2 implementations, revie…
ilgrosso commented on pull request #205: URL: https://github.com/apache/syncope/pull/205#issuecomment-658884051 This looks somewhat stuck, closing and creating new one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [syncope] ilgrosso opened a new pull request #206: [SYNCOPE-1578] Adding auth support to SRA, with OIDC / OAUTH2 implementations, reviewing several details on WA and Core to make all function
ilgrosso opened a new pull request #206: URL: https://github.com/apache/syncope/pull/206 Re-creating after #205 seemed to got stuck. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Broken: apache/syncope#6688 (master - 9b4db28)
Build Update for apache/syncope - Build: #6688 Status: Broken Duration: 59 mins and 14 secs Commit: 9b4db28 (master) Author: Francesco Chicchiriccò Message: Upgrading Wicket and Wicket-jQueryUI View the changeset: https://github.com/apache/syncope/compare/34898008ed89...9b4db284a40c View the full build log and details: https://travis-ci.org/github/apache/syncope/builds/708320511?utm_medium=notification_source=email -- You can unsubscribe from build emails from the apache/syncope repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=3236582_medium=notification_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.
Still Failing: apache/syncope#6685 (master - 3489800)
Build Update for apache/syncope - Build: #6685 Status: Still Failing Duration: 1 hr, 10 mins, and 9 secs Commit: 3489800 (master) Author: Misagh Moayyed Message: SYNCOPE-1545: Enable Swagger support for WA (#204) View the changeset: https://github.com/apache/syncope/compare/94daac48b247...34898008ed89 View the full build log and details: https://travis-ci.org/github/apache/syncope/builds/708295107?utm_medium=notification_source=email -- You can unsubscribe from build emails from the apache/syncope repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=3236582_medium=notification_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.
[GitHub] [syncope] ilgrosso opened a new pull request #205: [SYNCOPE-1578] Adding auth support to SRA, with OIDC / OAUTH2 implementations, revie…
ilgrosso opened a new pull request #205: URL: https://github.com/apache/syncope/pull/205 …wing several details on WA and Core to make all functional This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Fixed: apache/syncope#6680 (master - 94daac4)
Build Update for apache/syncope - Build: #6680 Status: Fixed Duration: 40 mins and 7 secs Commit: 94daac4 (master) Author: Francesco Chicchiriccò Message: Upgrading BVal and maven-war-plugin View the changeset: https://github.com/apache/syncope/compare/4774ee8c4b9e...94daac48b247 View the full build log and details: https://travis-ci.org/github/apache/syncope/builds/708266155?utm_medium=notification_source=email -- You can unsubscribe from build emails from the apache/syncope repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=3236582_medium=notification_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.
[jira] [Commented] (SYNCOPE-1545) Web Access
[ https://issues.apache.org/jira/browse/SYNCOPE-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17158072#comment-17158072 ] ASF subversion and git services commented on SYNCOPE-1545: -- Commit 34898008ed897ee54cce87cd01303109cf8c209c in syncope's branch refs/heads/master from Misagh Moayyed [ https://gitbox.apache.org/repos/asf?p=syncope.git;h=3489800 ] SYNCOPE-1545: Enable Swagger support for WA (#204) > Web Access > -- > > Key: SYNCOPE-1545 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1545 > Project: Syncope > Issue Type: New Feature > Components: wa >Reporter: Francesco Chicchiriccò >Assignee: Francesco Chicchiriccò >Priority: Major > Fix For: 3.0.0 > > > Web application acting as a central hub for authentication: > * dynamically adapting for the configured authentication features (modules, > chains, levels, ...) from SYNCOPE-160 > * highly customizable, either graphically and processing > Good candidate for building upon appears to be [Apereo > CAS|https://apereo.github.io/cas/]. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [syncope] mmoayyed merged pull request #204: SYNCOPE-1545: Enable Swagger support for WA
mmoayyed merged pull request #204: URL: https://github.com/apache/syncope/pull/204 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Still Failing: apache/syncope#6680 (master - 94daac4)
Build Update for apache/syncope - Build: #6680 Status: Still Failing Duration: 41 mins and 36 secs Commit: 94daac4 (master) Author: Francesco Chicchiriccò Message: Upgrading BVal and maven-war-plugin View the changeset: https://github.com/apache/syncope/compare/4774ee8c4b9e...94daac48b247 View the full build log and details: https://travis-ci.org/github/apache/syncope/builds/708266155?utm_medium=notification_source=email -- You can unsubscribe from build emails from the apache/syncope repository going to https://travis-ci.org/account/preferences/unsubscribe?repository=3236582_medium=notification_source=email. Or unsubscribe from *all* email updating your settings at https://travis-ci.org/account/preferences/unsubscribe?utm_medium=notification_source=email. Or configure specific recipients for build notifications in your .travis.yml file. See https://docs.travis-ci.com/user/notifications.
[jira] [Created] (SYNCOPE-1580) Design WA REST APIs to configure configuration properties
Misagh Moayyed created SYNCOPE-1580: --- Summary: Design WA REST APIs to configure configuration properties Key: SYNCOPE-1580 URL: https://issues.apache.org/jira/browse/SYNCOPE-1580 Project: Syncope Issue Type: Sub-task Components: wa Affects Versions: 3.0.0 Reporter: Misagh Moayyed Assignee: Misagh Moayyed Fix For: 3.0.0 Define REST endpoints and relevant data structures allowing WA to set and configure properties such as the OIDC issuer, etc. The endpoints should be sufficiently protected so they can be called from the command-line or the admin-UI once UI support is built. Once a property value is stored, WA should be asked to refresh its context to fetch the setting and resume without having to rebuild or restart the container, etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [syncope] mmoayyed closed pull request #204: Enable Swagger support for WA
mmoayyed closed pull request #204: URL: https://github.com/apache/syncope/pull/204 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [syncope] mmoayyed commented on pull request #204: Enable Swagger support for WA
mmoayyed commented on pull request #204: URL: https://github.com/apache/syncope/pull/204#issuecomment-658649673 Certainly! Will do. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [syncope] ilgrosso commented on pull request #204: Enable Swagger support for WA
ilgrosso commented on pull request #204: URL: https://github.com/apache/syncope/pull/204#issuecomment-658649020 @mmoayyed looks very nice, thanks! Besides the small things noted above, would you mind, when merging, to add `SYNCOPE-1545` in the commit message? Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [syncope] ilgrosso commented on a change in pull request #204: Enable Swagger support for WA
ilgrosso commented on a change in pull request #204:
URL: https://github.com/apache/syncope/pull/204#discussion_r454906836
##
File path: wa/starter/src/main/resources/application.properties
##
@@ -45,3 +45,6 @@ spring.main.allow-bean-definition-overriding=true
spring.main.lazy-initialization=false
service.discovery.address=http://localhost:8080/syncope-wa/
+
+version=${syncope.version}
+buildNumber=${buildNumber}
Review comment:
see above
##
File path:
wa/starter/src/main/java/org/apache/syncope/wa/starter/config/SyncopeWAConfiguration.java
##
@@ -221,4 +237,14 @@ public KeymasterStart keymasterStart() {
public KeymasterStop keymasterStop() {
return new KeymasterStop(NetworkService.Type.WA);
}
+
+@Bean
+public String version() {
+return applicationContext.getEnvironment().getProperty("version");
+}
+
+@Bean
+public String buildNumber() {
Review comment:
This should not be needed.
Please also consider that it would require the `buildnumber-maven-plugin` to
run.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [syncope] mmoayyed opened a new pull request #204: Enable Swagger support for WA
mmoayyed opened a new pull request #204: URL: https://github.com/apache/syncope/pull/204 This pull request adjusts WA to turn on Swagger support via the `cas-server-support-swagger` dependency. In doing so, 1. The [CAS module is upgraded](https://apereo.github.io/cas/development/integration/Swagger-Integration.html) to base its swagger support on top of Swagger v2.1.x 2. The WA configuration does a simple bean override to present Syncope information to the Docklet, such as version, title, etc. 3. Default configuration is adjusted to consider actuators, controllers etc as part of Swagger UI.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
