[GitHub] [syncope] ilgrosso commented on a change in pull request #258: Switch to CAS 6.4

[GitBox]

ilgrosso commented on a change in pull request #258:
URL: https://github.com/apache/syncope/pull/258#discussion_r610533237



##
File path: 
fit/wa-reference/src/test/java/org/apache/syncope/fit/ui/SAML2SP4UIITCase.java
##
@@ -156,6 +158,20 @@ public static void idpSetup() {
 saml2sp4UIIdPService.update(cas);
 }
 
+@Test
+public void fetchSpMetadata() throws Exception {
+try (CloseableHttpClient httpclient = HttpClients.createDefault()) {
+HttpClientContext context = HttpClientContext.create();
+context.setCookieStore(new BasicCookieStore());
+
+HttpGet get = new HttpGet(WA_ADDRESS + "/sp/metadata");
+CloseableHttpResponse response = httpclient.execute(get, context);
+assertEquals(HttpStatus.SC_OK, 
response.getStatusLine().getStatusCode());
+String responseBody = EntityUtils.toString(response.getEntity());
+assertNotNull(responseBody);

Review comment:
   I'd rather change this with
   
   ```
   assertFalse(responseBody.isEmpty());
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Broken: apache/syncope#7310 (master - 88db9c4)

[Travis CI]

Build Update for apache/syncope
-

Build: #7310
Status: Broken

Duration: 14 mins and 16 secs
Commit: 88db9c4 (master)
Author: Francesco Chicchiriccò
Message: [SYNCOPE-1545] WA > OIDC 1.0 (#260)

View the changeset: 
https://github.com/apache/syncope/compare/fae5dbc91d72...88db9c46dc99

View the full build log and details: 
https://travis-ci.com/github/apache/syncope/builds/222596728?utm_medium=notification_source=email


--

You can unsubscribe from build emails from the apache/syncope repository going 
to 
https://travis-ci.com/account/preferences/unsubscribe?repository=16807214_medium=notification_source=email.
Or unsubscribe from *all* email updating your settings at 
https://travis-ci.com/account/preferences/unsubscribe?utm_medium=notification_source=email.
Or configure specific recipients for build notifications in your .travis.yml 
file. See https://docs.travis-ci.com/user/notifications.

[jira] [Commented] (SYNCOPE-1545) Web Access

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/SYNCOPE-1545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317710#comment-17317710
 ] 

ASF subversion and git services commented on SYNCOPE-1545:
--

Commit 88db9c46dc99dd214f9cac7adae708345178263f in syncope's branch 
refs/heads/master from Francesco Chicchiriccò
[ https://gitbox.apache.org/repos/asf?p=syncope.git;h=88db9c4 ]

[SYNCOPE-1545] WA > OIDC 1.0 (#260)



> Web Access
> --
>
> Key: SYNCOPE-1545
> URL: https://issues.apache.org/jira/browse/SYNCOPE-1545
> Project: Syncope
>  Issue Type: New Feature
>  Components: wa
>Reporter: Francesco Chicchiriccò
>Assignee: Francesco Chicchiriccò
>Priority: Major
> Fix For: 3.0.0
>
>
> Web application acting as a central hub for authentication:
>  * dynamically adapting for the configured authentication features (modules, 
> chains, levels, ...) from SYNCOPE-160
>  * highly customizable, either graphically and processing
> Good candidate for building upon appears to be [Apereo 
> CAS|https://apereo.github.io/cas/].



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [syncope] ilgrosso merged pull request #260: [SYNCOPE-1545] WA > OIDC 1.0

[GitBox]

ilgrosso merged pull request #260:
URL: https://github.com/apache/syncope/pull/260


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org