[jira] [Resolved] (SYNCOPE-1689) Consolidate Provision, Mapping and Items into single JSON column
[ https://issues.apache.org/jira/browse/SYNCOPE-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Chicchiriccò resolved SYNCOPE-1689. - Resolution: Fixed > Consolidate Provision, Mapping and Items into single JSON column > > > Key: SYNCOPE-1689 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1689 > Project: Syncope > Issue Type: Improvement > Components: core, extensions >Reporter: Francesco Chicchiriccò >Assignee: Francesco Chicchiriccò >Priority: Major > Fix For: 3.0.0 > > > Consolidate a set of JPA entities from their own tables into single JSON > column. > The idea is that such strategy will improve the general provisioning > performance, especially during propagation, as no joins will be needed to > fetch the required information. > It could be an idea to do the same with Connector and Resource capabilities. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SYNCOPE-1689) Consolidate Provision, Mapping and Items into single JSON column
[ https://issues.apache.org/jira/browse/SYNCOPE-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566844#comment-17566844 ] ASF subversion and git services commented on SYNCOPE-1689: -- Commit e702a667035b32585f45ed72cee5dc68a515219d in syncope's branch refs/heads/master from Francesco Chicchiriccò [ https://gitbox.apache.org/repos/asf?p=syncope.git;h=e702a66703 ] [SYNCOPE-1689] Consolidate Provision, Mapping and Items into single JSON column (#360) > Consolidate Provision, Mapping and Items into single JSON column > > > Key: SYNCOPE-1689 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1689 > Project: Syncope > Issue Type: Improvement > Components: core, extensions >Reporter: Francesco Chicchiriccò >Assignee: Francesco Chicchiriccò >Priority: Major > Fix For: 3.0.0 > > > Consolidate a set of JPA entities from their own tables into single JSON > column. > The idea is that such strategy will improve the general provisioning > performance, especially during propagation, as no joins will be needed to > fetch the required information. > It could be an idea to do the same with Connector and Resource capabilities. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [syncope] ilgrosso merged pull request #360: [SYNCOPE-1689] Consolidate Provision, Mapping and Items into single JSON column
ilgrosso merged PR #360: URL: https://github.com/apache/syncope/pull/360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [syncope] github-code-scanning[bot] commented on a diff in pull request #360: [SYNCOPE-1689] Consolidate Provision, Mapping and Items into single JSON column
github-code-scanning[bot] commented on code in PR #360:
URL: https://github.com/apache/syncope/pull/360#discussion_r921045612
##
client/idrepo/console/src/main/java/org/apache/syncope/client/console/commons/StatusProvider.java:
##
@@ -28,14 +28,14 @@
import org.apache.syncope.client.console.wicket.markup.html.form.ActionLink;
import org.apache.syncope.client.ui.commons.status.ConnObjectWrapper;
import org.apache.syncope.common.lib.to.AnyTO;
-import org.apache.syncope.common.lib.to.ConnObjectTO;
+import org.apache.syncope.common.lib.to.ConnObject;
public interface StatusProvider extends Serializable {
-Optional> get(
+Optional> get(
String anyTypeKey, String connObjectKeyValue, String resource);
-List> get(AnyTO any,
Collection resources);
+List> get(AnyTO any,
Collection resources);
Review Comment:
## Useless parameter
The parameter resources is unused.
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1106)
##
common/idm/lib/src/main/java/org/apache/syncope/common/lib/to/PagedConnObjectResult.java:
##
@@ -109,7 +109,7 @@
@JacksonXmlElementWrapper(localName = "result")
@JacksonXmlProperty(localName = "item")
-public List getResult() {
+public List getResult() {
Review Comment:
## Exposing internal representation
getResult exposes the internal representation stored in field result. The
value may be modified [after this call to getResult](1).
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1115)
##
common/am/lib/src/main/java/org/apache/syncope/common/lib/to/AttrRepoTO.java:
##
@@ -77,7 +77,7 @@
this.order = order;
}
-public List getItems() {
+public List getItems() {
Review Comment:
## Exposing internal representation
getItems exposes the internal representation stored in field items. The
value may be modified [after this call to getItems](1).
getItems exposes the internal representation stored in field items. The
value may be modified [after this call to getItems](2).
getItems exposes the internal representation stored in field items. The
value may be modified [after this call to getItems](3).
[Show more
details](https://github.com/apache/syncope/security/code-scanning/1107)
##
common/idm/lib/src/main/java/org/apache/syncope/common/lib/to/ResourceTO.java:
##
@@ -229,21 +229,21 @@
}
@JsonIgnore
-public Optional getProvision(final String anyType) {
+public Optional getProvision(final String anyType) {
return provisions.stream().filter(
provision -> anyType != null &&
anyType.equals(provision.getAnyType())).
findFirst();
}
-public List getProvisions() {
+public List getProvisions() {
Review Comment:
## Exposing internal representation
getProvisions exposes the internal representation stored in field
provisions. The value may be modified [after this call to getProvisions](1).
getProvisions exposes the internal representation stored in field
provisions. The value may be modified [after this call to getProvisions](2).
getProvisions exposes the internal representation stored in field
provisions. The value may be modified [after this call to getProvisions](3).
getProvisions exposes the internal representation stored in field
provisions. The value may be modified [after this call to getProvisions](4).
getProvisions exposes the internal representation stored in field
provisions. The value may be modified [after this call to getProvisions](5).
getProvisions exposes the internal representation stored in field
provisions. The value may be modified [after this call to getProvisions](6).
getProvisions exposes the internal representation stored in field
provisions. The value may be modified [after this call to getProvisions](7).
getProvisions exposes the internal representation stored in field
provisions. The value may be modified [after this call to getProvisions](8).
getProvisions exposes the internal representation stored in field
provisions. The value may be modified [after this call to getProvisions](9).
getProvisions exposes the internal representation stored in field
provisions. The value may be modified [after this call to getProvisions](10).
getProvisions exposes the internal representation stored in field
provisions. The value may be modified [after this call to getProvisions](11).
getProvisions exposes the internal representation stored in field
provisions. The value may be modified [after this call to getProvisions](12).
getProvisions exposes the internal representation stored in field
provisions. The value may be modified [after this call to getProvisions](13).
getProvisions exposes the internal representation stored in field
provisions. The value may be modified [after this call to
[jira] [Commented] (SYNCOPE-1690) NPE when add search condition in topology explore resource
[ https://issues.apache.org/jira/browse/SYNCOPE-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17566758#comment-17566758 ] ASF subversion and git services commented on SYNCOPE-1690: -- Commit 703803cc8ed2fc721a5e6c080ed231b9d1bce2d9 in syncope's branch refs/heads/master from SamuelGaro [ https://gitbox.apache.org/repos/asf?p=syncope.git;h=703803cc8e ] [SYNCOPE-1690] Avoid NPE with null key in getOrDefault method (#361) > NPE when add search condition in topology explore resource > -- > > Key: SYNCOPE-1690 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1690 > Project: Syncope > Issue Type: Bug > Components: console >Affects Versions: 3.0.0 >Reporter: Samuel Garofalo >Priority: Major > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (SYNCOPE-1690) NPE when add search condition in topology explore resource
[ https://issues.apache.org/jira/browse/SYNCOPE-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Chicchiriccò reassigned SYNCOPE-1690: --- Assignee: Francesco Chicchiriccò > NPE when add search condition in topology explore resource > -- > > Key: SYNCOPE-1690 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1690 > Project: Syncope > Issue Type: Bug > Components: console >Affects Versions: 3.0.0 >Reporter: Samuel Garofalo >Assignee: Francesco Chicchiriccò >Priority: Major > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SYNCOPE-1690) NPE when add search condition in topology explore resource
[ https://issues.apache.org/jira/browse/SYNCOPE-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Chicchiriccò resolved SYNCOPE-1690. - Resolution: Fixed > NPE when add search condition in topology explore resource > -- > > Key: SYNCOPE-1690 > URL: https://issues.apache.org/jira/browse/SYNCOPE-1690 > Project: Syncope > Issue Type: Bug > Components: console >Affects Versions: 3.0.0 >Reporter: Samuel Garofalo >Assignee: Francesco Chicchiriccò >Priority: Major > Fix For: 3.0.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [syncope] ilgrosso merged pull request #361: [SYNCOPE-1690] NPE when add search condition in topology explore resource
ilgrosso merged PR #361: URL: https://github.com/apache/syncope/pull/361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SYNCOPE-1690) NPE when add search condition in topology explore resource
Samuel Garofalo created SYNCOPE-1690: Summary: NPE when add search condition in topology explore resource Key: SYNCOPE-1690 URL: https://issues.apache.org/jira/browse/SYNCOPE-1690 Project: Syncope Issue Type: Bug Components: console Affects Versions: 3.0.0 Reporter: Samuel Garofalo Fix For: 3.0.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (SYNCOPE-1689) Consolidate Provision, Mapping and Items into single JSON column
Francesco Chicchiriccò created SYNCOPE-1689: --- Summary: Consolidate Provision, Mapping and Items into single JSON column Key: SYNCOPE-1689 URL: https://issues.apache.org/jira/browse/SYNCOPE-1689 Project: Syncope Issue Type: Improvement Components: core, extensions Reporter: Francesco Chicchiriccò Assignee: Francesco Chicchiriccò Fix For: 3.0.0 Consolidate a set of JPA entities from their own tables into single JSON column. The idea is that such strategy will improve the general provisioning performance, especially during propagation, as no joins will be needed to fetch the required information. It could be an idea to do the same with Connector and Resource capabilities. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [syncope] ilgrosso commented on pull request #360: Consolidating Provision, Mapping and Items into single JSON column
ilgrosso commented on PR #360: URL: https://github.com/apache/syncope/pull/360#issuecomment-1184116165 Very interesting results from some smoke performance tests. I've been using [ilgrosso/syncopeRestClient](https://github.com/ilgrosso/syncopeRestClient) to create users with propagation against Syncope instances started via `mvn -Pdebug,all` under `fit/core-reference` directory. | | `master` | this PR | |--|---|| | 1000 users | 1145426 ms (~19 minutes) | 189939 ms (~3 minutes) | -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
