[GitHub] [syncope] DmitriyBrashevets commented on pull request #289: [SYNCOPE-1643] Chaning of user realm doesn't trigger provisioning
DmitriyBrashevets commented on pull request #289: URL: https://github.com/apache/syncope/pull/289#issuecomment-921733929 > @DmitriyBrashevets I understand that: > > 1. only moving the `setRealm()` invocation, with no further changes, fixes `UserDataBinderImpl`'s behavior > 2. no issues with `GroupDataBInderImpl` > > If these are correct, then please just apply the same change as (1) into `AnyObjectDataBinderImpl` and we should be all set, thanks. The `AnyObjectDataBinderImpl` doesn't require any changes the `setRealm()` is executed after the creation of the projection -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [syncope] DmitriyBrashevets commented on pull request #289: [SYNCOPE-1643] Chaning of user realm doesn't trigger provisioning
DmitriyBrashevets commented on pull request #289: URL: https://github.com/apache/syncope/pull/289#issuecomment-921725709 > @DmitriyBrashevets please apply similar changes to `GroupDataBinderImpl` and `AnyObjectDataBinderImpl` For groups the provisioning works well when the realm is changed. If the org.apache.syncope.core.provisioning.java.data.AbstractAnyDataBinder#setRealm is executed after the before-projection is created then `org.apache.syncope.core.provisioning.java.data.AbstractAnyDataBinder#propByRes` calculates resources correctly as there may be changes in the `org.apache.syncope.common.lib.to.AttrTO` with schema "__NAME__" because of connObjectLink. This leads to a consistent behavior for UserDataBinder and GroupDataBinder. So, I'd say that moving of the execution of `org.apache.syncope.core.provisioning.java.data.AbstractAnyDataBinder#setRealm` below the creation of projections solves the issue. Please, look at: https://github.com/apache/syncope/blob/ad2523680b68e843cba35261c350521875f81945/core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/GroupDataBinderImpl.java#L203 Please, tell: 1. if `org.apache.syncope.core.provisioning.java.data.AbstractAnyDataBinder.setRealm(Any, AnyPatch)` still needs to be modfied 2. if you're fine with moving of `org.apache.syncope.core.provisioning.java.data.AbstractAnyDataBinder#setRealm` below -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
