ilgrosso commented on a change in pull request #244:
URL: https://github.com/apache/syncope/pull/244#discussion_r592944710
##
File path:
ext/saml2sp4ui/logic/src/main/java/org/apache/syncope/core/logic/SAML2SP4UILogic.java
##
@@ -252,10 +254,10 @@ public SAML2Request createLoginRequest(
RequestedAuthnContext requestedAuthnContext =
requestedAuthnContextProvider.get();
SAML2Configuration cfg = saml2Client.getConfiguration();
Review comment:
It seems this line is not needed anymore (see CodeQL scannin)
##
File path: wa/starter/src/main/resources/application.properties
##
@@ -40,9 +40,14 @@ management.endpoint.loggers.enabled=true
management.endpoint.refresh.enabled=true
management.endpoint.registeredServices.enabled=true
-cas.events.core.enabled=false
+# Cache service definitions for 5 minutes
+cas.service-registry.cache.duration=PT5M
+
+# Reload services and hydrate the cache every 5 minutes
+cas.service-registry.schedule.repeat-interval=PT5M
+cas.service-registry.schedule.start-delay=PT30S
-server.servlet.session.tracking-modes=cookie
Review comment:
Any reason to remove `server.servlet.session.tracking-modes=cookie` ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
