[GitHub] syncope issue #26: Identity Recertification

[ilgrosso]

Github user ilgrosso commented on the issue:

https://github.com/apache/syncope/pull/26
  
Hi @nscendoni, thanks for taking this initiative!

Could you please fill an issue on JIRA (as "new feature") where you also 
provide functional high-level description?
Once you got the issue number (`SYNCOPE-XXX`), please reference it in your 
commit messages so that this PR gets automatically linked.

About the proposed changes:
 1. I made some comments, please address
 1. It is not immediately evident to me the kind of change you made to the 
Activiti user workflow definition: I suppose you have added a "request-certify" 
task, could you please elaborate?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] syncope issue #26: Identity Recertification

[nscendoni]

Github user nscendoni commented on the issue:

https://github.com/apache/syncope/pull/26
  
Hi Francesco,

Thanks for your review. I will create a new JIRA issue with a functional
description of my proposal.
I will address the comments and complete the feature implementation until
an "usable" state. The goal of this push request was to validate the design
with you.

Regarding the change to Activiti workflow I paste here the part of diagram
that I modified:

[image: Immagine incorporata 1]

2016-06-25 15:36 GMT+02:00 Francesco Chicchiriccò 

:

> Hi @nscendoni , thanks for taking this
> initiative!
>
> Could you please fill an issue on JIRA (as "new feature") where you also
> provide functional high-level description?
> Once you got the issue number (SYNCOPE-XXX), please reference it in your
> commit messages so that this PR gets automatically linked.
>
> About the proposed changes:
>
>1. I made some comments, please address
>2. It is not immediately evident to me the kind of change you made to
>the Activiti user workflow definition: I suppose you have added a
>"request-certify" task, could you please elaborate?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] syncope issue #26: Identity Recertification

[ilgrosso]

Github user ilgrosso commented on the issue:

https://github.com/apache/syncope/pull/26
  
Thanks for opening 
[SYNCOPE-880|https://issues.apache.org/jira/browse/SYNCOPE-880], I have 
commented there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---