[GitHub] syncope issue #50: Connector and Resource configuration versioning in Admin ...

2017-07-13 Thread mat-ale 
Github user mat-ale commented on the issue:

https://github.com/apache/syncope/pull/50
  
Good to hear that!
You're welcome.
Matteo


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] syncope issue #50: Connector and Resource configuration versioning in Admin ...

2017-07-13 Thread ilgrosso 
Github user ilgrosso commented on the issue:

https://github.com/apache/syncope/pull/50
  
Merged, thanks @mat-ale!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] syncope issue #50: Connector and Resource configuration versioning in Admin ...

2017-07-12 Thread ilgrosso 
Github user ilgrosso commented on the issue:

https://github.com/apache/syncope/pull/50
  
Miscellaneous questions:

1. Why `ConnHistoryDirectoryPanel`, `ConnHistoryConfDirectoryPanel` and 
`ConnHistoryConfMainDirectoryPanel` are separated and not a single class?
1. Same applies to `ResHistoryDirectoryPanel`, 
`ResHistoryConfDirectoryPanel` and `ResHistoryConfMainDirectoryPanel`
1. The `Cancel` button is missing in the two history modal windows
1. There is no option to show the diff with the current configuration
1. Rather than "reload", the menu item should be "restore" instead
1. When clicking 'reload', the confirmation message states "Do you really 
want to delete the selected item(s)?"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] syncope issue #50: Connector and Resource configuration versioning in Admin ...

2017-07-11 Thread ilgrosso 
Github user ilgrosso commented on the issue:

https://github.com/apache/syncope/pull/50
  
Also, please:

1. move the `DataProvider` classes into their respective `DirectoryPanel` 
(this is the general approach followed by most of existing `DirectoryPanel` 
classes, with exception of the most complex ones)
1. align the class names with their respective Core's counterparts, e.g. 
use prefixes:
   * `ConnInstanceHistoryConf`
   * `ResourceHistoryConf`

   not `ConnHistoryConf` or `ResHistoryConf`

Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] syncope issue #50: Connector and Resource configuration versioning in Admin ...

2017-07-11 Thread ilgrosso 
Github user ilgrosso commented on the issue:

https://github.com/apache/syncope/pull/50
  
When building via Maven, I get the following warnings, please fix:

```
[WARNING] bootstrap class path not set in conjunction with -source 1.7
[WARNING] 
/home/ilgrosso/work/syncope/syncope2/client/console/src/main/java/org/apache/syncope/client/console/topology/TopologyTogglePanel.java:[338,45]
 unchecked call to 
HistoryConfList(org.apache.syncope.client.console.wicket.markup.html.bootstrap.dialog.BaseModal,java.lang.String,org.apache.wicket.PageReference,org.apache.syncope.common.lib.AbstractBaseBean)
 as a member of the raw type 
org.apache.syncope.client.console.panels.HistoryConfList
[WARNING] 
/home/ilgrosso/work/syncope/syncope2/client/console/src/main/java/org/apache/syncope/client/console/topology/TopologyTogglePanel.java:[561,45]
 unchecked call to 
HistoryConfList(org.apache.syncope.client.console.wicket.markup.html.bootstrap.dialog.BaseModal,java.lang.String,org.apache.wicket.PageReference,org.apache.syncope.common.lib.AbstractBaseBean)
 as a member of the raw type 
org.apache.syncope.client.console.panels.HistoryConfList
[WARNING] 
/home/ilgrosso/work/syncope/syncope2/client/console/src/main/java/org/apache/syncope/client/console/panels/ResHistoryConfDirectoryPanel.java:[154,42]
 dataProvider() in 
org.apache.syncope.client.console.panels.ResHistoryConfDirectoryPanel overrides 
dataProvider() in org.apache.syncope.client.console.panels.DirectoryPanel
  return type requires unchecked conversion from 
org.apache.syncope.client.console.commons.ResHistoryConfDataProvider to 
org.apache.syncope.client.console.commons.ResHistoryConfDataProvider
[WARNING] 
/home/ilgrosso/work/syncope/syncope2/client/console/src/main/java/org/apache/syncope/client/console/panels/HistoryConfDetails.java:[193,23]
 unchecked call to CompoundPropertyModel(T) as a member of the raw type 
org.apache.wicket.model.CompoundPropertyModel
[WARNING] 
/home/ilgrosso/work/syncope/syncope2/client/console/src/main/java/org/apache/syncope/client/console/panels/HistoryConfDetails.java:[193,22]
 unchecked call to setModel(org.apache.wicket.model.IModel) as a member of 
the raw type org.apache.wicket.markup.html.form.Form
[WARNING] 
/home/ilgrosso/work/syncope/syncope2/client/console/src/main/java/org/apache/syncope/client/console/panels/HistoryConfDetails.java:[203,32]
 unchecked call to setChoices(java.util.List) as a member of the raw type 
org.apache.syncope.client.console.wicket.markup.html.form.AjaxDropDownChoicePanel
[WARNING] 
/home/ilgrosso/work/syncope/syncope2/client/console/src/main/java/org/apache/syncope/client/console/panels/HistoryConfDetails.java:[204,39]
 unchecked call to 
setChoiceRenderer(org.apache.wicket.markup.html.form.IChoiceRenderer) as a 
member of the raw type 
org.apache.syncope.client.console.wicket.markup.html.form.AjaxDropDownChoicePanel
[WARNING] 
/home/ilgrosso/work/syncope/syncope2/client/console/src/main/java/org/apache/syncope/client/console/panels/HistoryConfDetails.java:[225,36]
 unchecked call to setModelObject(T) as a member of the raw type 
org.apache.syncope.client.console.wicket.markup.html.form.FieldPanel
[WARNING] 
/home/ilgrosso/work/syncope/syncope2/client/console/src/main/java/org/apache/syncope/client/console/panels/ConnHistoryConfDirectoryPanel.java:[154,43]
 dataProvider() in 
org.apache.syncope.client.console.panels.ConnHistoryConfDirectoryPanel 
overrides dataProvider() in 
org.apache.syncope.client.console.panels.DirectoryPanel
  return type requires unchecked conversion from 
org.apache.syncope.client.console.commons.ConnHistoryConfDataProvider to 
org.apache.syncope.client.console.commons.ConnHistoryConfDataProvider
[WARNING] 
/home/ilgrosso/work/syncope/syncope2/client/console/src/main/java/org/apache/syncope/client/console/panels/HistoryConfList.java:[62,29]
 unchecked call to 
HistoryConfDetails(org.apache.syncope.client.console.wicket.markup.html.bootstrap.dialog.BaseModal,T,org.apache.wicket.PageReference,java.util.List)
 as a member of the raw type 
org.apache.syncope.client.console.panels.HistoryConfDetails
[WARNING] 
/home/ilgrosso/work/syncope/syncope2/client/console/src/main/java/org/apache/syncope/client/console/panels/HistoryConfList.java:[78,29]
 unchecked call to 
HistoryConfDetails(org.apache.syncope.client.console.wicket.markup.html.bootstrap.dialog.BaseModal,T,org.apache.wicket.PageReference,java.util.List)
 as a member of the raw type 
org.apache.syncope.client.console.panels.HistoryConfDetails
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---