[PR] [SYNCOPE-1809] Remove uidOnCreate attribute on delete propagation [syncope]
andrea-patricelli opened a new pull request, #640: URL: https://github.com/apache/syncope/pull/640 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SYNCOPE-1809] Remove uidOnCreate attribute on delete propagation [syncope]
ilgrosso commented on code in PR #640: URL: https://github.com/apache/syncope/pull/640#discussion_r1514685072 ## fit/core-reference/src/test/java/org/apache/syncope/fit/core/UserIssuesITCase.java: ## @@ -1634,4 +1640,72 @@ public void issueSYNCOPE1793() { resource(RESOURCE_NAME_NOPROPAGATION).action(ResourceAssociationAction.ASSIGN).build()); assertEquals(Response.Status.OK.getStatusCode(), response.getStatus()); } + +@Test +public void issue1809() throws IOException { Review Comment: this should be named `issueSYNCOPE1809` (see others) ## core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/propagation/AbstractPropagationTaskExecutor.java: ## @@ -383,6 +383,20 @@ protected Uid delete( connector.delete(objectClass, uid, null, propagationAttempted); result = uid; +// SYNCOPE-1809 remove uidOnCreate attribute, if any Review Comment: are such comments really needed? We've got `git blame` ## core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/propagation/AbstractPropagationTaskExecutor.java: ## @@ -383,6 +383,20 @@ protected Uid delete( connector.delete(objectClass, uid, null, propagationAttempted); result = uid; +// SYNCOPE-1809 remove uidOnCreate attribute, if any +taskInfo.getResource() +.getProvisionByAnyType(taskInfo.getAnyType()) +.filter(provision -> provision.getUidOnCreate() != null) +.ifPresent(provision -> { +LOG.debug("Removing uidOnCreate [{}] attribute from [{}] on delete", Review Comment: either remove this logging statement or add it for the other case when `getUidOnCreate()` is used in this class -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SYNCOPE-1809] Remove uidOnCreate attribute on delete propagation [syncope]
andrea-patricelli commented on code in PR #640: URL: https://github.com/apache/syncope/pull/640#discussion_r1514722405 ## core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/propagation/AbstractPropagationTaskExecutor.java: ## @@ -383,6 +383,20 @@ protected Uid delete( connector.delete(objectClass, uid, null, propagationAttempted); result = uid; +// SYNCOPE-1809 remove uidOnCreate attribute, if any Review Comment: No, going to remove. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SYNCOPE-1809] Remove uidOnCreate attribute on delete propagation [syncope]
andrea-patricelli commented on code in PR #640: URL: https://github.com/apache/syncope/pull/640#discussion_r1514744013 ## core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/propagation/AbstractPropagationTaskExecutor.java: ## @@ -383,6 +383,20 @@ protected Uid delete( connector.delete(objectClass, uid, null, propagationAttempted); result = uid; +// SYNCOPE-1809 remove uidOnCreate attribute, if any +taskInfo.getResource() +.getProvisionByAnyType(taskInfo.getAnyType()) +.filter(provision -> provision.getUidOnCreate() != null) +.ifPresent(provision -> { +LOG.debug("Removing uidOnCreate [{}] attribute from [{}] on delete", Review Comment: Added logging also in the other section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SYNCOPE-1809] Remove uidOnCreate attribute on delete propagation [syncope]
andrea-patricelli merged PR #640: URL: https://github.com/apache/syncope/pull/640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@syncope.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org