[jira] [Commented] (SYNCOPE-245) Improve UserTestITCase and RoleTestITCase
[ https://issues.apache.org/jira/browse/SYNCOPE-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527762#comment-13527762 ] Francesco Chicchiriccò commented on SYNCOPE-245: Sorry, my bad: I was applying your patch to the 1_0_X branch instead of trunk; there it works like a charm. > Improve UserTestITCase and RoleTestITCase > - > > Key: SYNCOPE-245 > URL: https://issues.apache.org/jira/browse/SYNCOPE-245 > Project: Syncope > Issue Type: Improvement >Affects Versions: 1.0.3-incubating, 1.1.0 >Reporter: Christian Schneider >Assignee: Christian Schneider > Fix For: 1.1.0 > > Attachments: syncope_tests.patch, syncope_usertest.patch > > > The test org.apache.syncope.core.rest.UserTestITCase has some highly > repetitive code where AttributeTOs and AttributeMods are created. I created > two small helper methods and was able to make the test about 150 lines > smaller. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SYNCOPE-245) Improve UserTestITCase and RoleTestITCase
[ https://issues.apache.org/jira/browse/SYNCOPE-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527761#comment-13527761 ] Francesco Chicchiriccò commented on SYNCOPE-245: Applying your patch causes different hunks: could you please check? ilgrosso@mogano ~/work/syncope/1_0_X $ patch -p0 < ~/Downloads/syncope_tests.patch patching file core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java patching file core/src/test/java/org/apache/syncope/core/rest/UserTestITCase.java Hunk #1 succeeded at 78 (offset -1 lines). Hunk #2 succeeded at 130 (offset -1 lines). Hunk #3 succeeded at 182 (offset -1 lines). Hunk #4 succeeded at 201 (offset -1 lines). Hunk #5 FAILED at 307. Hunk #6 succeeded at 318 (offset -32 lines). Hunk #7 succeeded at 379 (offset -32 lines). Hunk #8 succeeded at 420 (offset -32 lines). Hunk #9 succeeded at 525 (offset -32 lines). Hunk #10 succeeded at 1003 (offset -31 lines). Hunk #11 FAILED at 1042. Hunk #12 succeeded at 1077 (offset -31 lines). Hunk #13 succeeded at 1160 (offset -31 lines). Hunk #14 succeeded at 1479 (offset -31 lines). Hunk #15 succeeded at 1490 (offset -31 lines). Hunk #16 succeeded at 1566 (offset -31 lines). Hunk #17 succeeded at 1584 (offset -31 lines). Hunk #18 succeeded at 1614 (offset -31 lines). Hunk #19 succeeded at 1628 (offset -31 lines). Hunk #20 succeeded at 1665 (offset -31 lines). Hunk #21 succeeded at 1685 (offset -31 lines). Hunk #22 succeeded at 1785 (offset -31 lines). Hunk #23 succeeded at 1810 (offset -31 lines). Hunk #24 succeeded at 1873 (offset -31 lines). 2 out of 24 hunks FAILED -- saving rejects to file core/src/test/java/org/apache/syncope/core/rest/UserTestITCase.java.rej patching file core/src/test/java/org/apache/syncope/core/rest/TaskTestITCase.java Hunk #1 FAILED at 18. Hunk #2 succeeded at 207 (offset -2 lines). Hunk #3 succeeded at 230 (offset -2 lines). Hunk #4 succeeded at 326 (offset -2 lines). Hunk #5 succeeded at 529 (offset -2 lines). 1 out of 5 hunks FAILED -- saving rejects to file core/src/test/java/org/apache/syncope/core/rest/TaskTestITCase.java.rej patching file core/src/test/java/org/apache/syncope/core/rest/SchemaTestITCase.java patching file core/src/test/java/org/apache/syncope/core/rest/RoleTestITCase.java Hunk #1 FAILED at 18. Hunk #7 succeeded at 311 (offset -34 lines). 1 out of 7 hunks FAILED -- saving rejects to file core/src/test/java/org/apache/syncope/core/rest/RoleTestITCase.java.rej ilgrosso@mogano ~/work/syncope/1_0_X $ svn status ? core/src/test/java/org/apache/syncope/core/rest/UserTestITCase.java.orig M core/src/test/java/org/apache/syncope/core/rest/SchemaTestITCase.java ? core/src/test/java/org/apache/syncope/core/rest/TaskTestITCase.java.orig M core/src/test/java/org/apache/syncope/core/rest/AbstractTest.java M core/src/test/java/org/apache/syncope/core/rest/UserTestITCase.java ? core/src/test/java/org/apache/syncope/core/rest/RoleTestITCase.java.orig M core/src/test/java/org/apache/syncope/core/rest/RoleTestITCase.java M core/src/test/java/org/apache/syncope/core/rest/TaskTestITCase.java > Improve UserTestITCase and RoleTestITCase > - > > Key: SYNCOPE-245 > URL: https://issues.apache.org/jira/browse/SYNCOPE-245 > Project: Syncope > Issue Type: Improvement >Affects Versions: 1.0.3-incubating, 1.1.0 >Reporter: Christian Schneider >Assignee: Christian Schneider > Fix For: 1.1.0 > > Attachments: syncope_tests.patch, syncope_usertest.patch > > > The test org.apache.syncope.core.rest.UserTestITCase has some highly > repetitive code where AttributeTOs and AttributeMods are created. I created > two small helper methods and was able to make the test about 150 lines > smaller. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SYNCOPE-245) Improve UserTestITCase and RoleTestITCase
[ https://issues.apache.org/jira/browse/SYNCOPE-245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526537#comment-13526537 ] Christian Schneider commented on SYNCOPE-245: - Ok .. will do the changes. I also found the methods are a good match for AbstractTest as I found some more similar code in TaskTest. > Improve UserTestITCase and RoleTestITCase > - > > Key: SYNCOPE-245 > URL: https://issues.apache.org/jira/browse/SYNCOPE-245 > Project: Syncope > Issue Type: Improvement >Affects Versions: 1.0.3-incubating, 1.1.0 >Reporter: Christian Schneider >Assignee: Christian Schneider > Fix For: 1.1.0 > > Attachments: syncope_usertest.patch > > > The test org.apache.syncope.core.rest.UserTestITCase has some highly > repetitive code where AttributeTOs and AttributeMods are created. I created > two small helper methods and was able to make the test about 150 lines > smaller. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
