[jira] [Commented] (SYNCOPE-426) UserService#update and RoleService#update require entity id to be specified twice
[ https://issues.apache.org/jira/browse/SYNCOPE-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805339#comment-13805339 ] Francesco Chicchiriccò commented on SYNCOPE-426: Fixed in trunk with no code modifications: https://builds.apache.org/job/Syncope-trunk/477/ > UserService#update and RoleService#update require entity id to be specified > twice > - > > Key: SYNCOPE-426 > URL: https://issues.apache.org/jira/browse/SYNCOPE-426 > Project: Syncope > Issue Type: Bug >Affects Versions: 1.1.4 >Reporter: Francesco Chicchiriccò >Assignee: Francesco Chicchiriccò >Priority: Minor > Labels: rest > Fix For: 1.1.5, 1.2.0 > > > As recently reported in mailing list [1], updating an user requires to pass > its id both as path parameter and embedded in the provided UserMod. > While having both parameters (id and UserMod) seems to be unavoidable to > adhere to REST best practices, it would be quite easy to allow an empty id in > UserMod. > Same applies to role update and RoleMod. > [1] http://markmail.org/message/zgh27isscw3hvwfx -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (SYNCOPE-426) UserService#update and RoleService#update require entity id to be specified twice
[ https://issues.apache.org/jira/browse/SYNCOPE-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805211#comment-13805211 ] Hudson commented on SYNCOPE-426: FAILURE: Integrated in Syncope-trunk #476 (See [https://builds.apache.org/job/Syncope-trunk/476/]) [SYNCOPE-426] Merge from 1_1_X (ilgrosso: rev 1535657) * /syncope/trunk * /syncope/trunk/common/src/main/java/org/apache/syncope/common/services/UserService.java * /syncope/trunk/core/src/main/java/org/apache/syncope/core/services/RoleServiceImpl.java * /syncope/trunk/core/src/main/java/org/apache/syncope/core/services/UserServiceImpl.java * /syncope/trunk/core/src/test/java/org/apache/syncope/core/rest/UserTestITCase.java > UserService#update and RoleService#update require entity id to be specified > twice > - > > Key: SYNCOPE-426 > URL: https://issues.apache.org/jira/browse/SYNCOPE-426 > Project: Syncope > Issue Type: Bug >Affects Versions: 1.1.4 >Reporter: Francesco Chicchiriccò >Assignee: Francesco Chicchiriccò >Priority: Minor > Labels: rest > Fix For: 1.1.5, 1.2.0 > > > As recently reported in mailing list [1], updating an user requires to pass > its id both as path parameter and embedded in the provided UserMod. > While having both parameters (id and UserMod) seems to be unavoidable to > adhere to REST best practices, it would be quite easy to allow an empty id in > UserMod. > Same applies to role update and RoleMod. > [1] http://markmail.org/message/zgh27isscw3hvwfx -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (SYNCOPE-426) UserService#update and RoleService#update require entity id to be specified twice
[ https://issues.apache.org/jira/browse/SYNCOPE-426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805209#comment-13805209 ] Hudson commented on SYNCOPE-426: SUCCESS: Integrated in Syncope-1_1_X #125 (See [https://builds.apache.org/job/Syncope-1_1_X/125/]) [SYNCOPE-426] Setting UserMod#id and RoleMod#id in service implementations, prior to call to controllers (ilgrosso: rev 1535655) * /syncope/branches/1_1_X/client/src/main/java/org/apache/syncope/client/services/proxy/RoleServiceProxy.java * /syncope/branches/1_1_X/client/src/main/java/org/apache/syncope/client/services/proxy/UserServiceProxy.java * /syncope/branches/1_1_X/core/src/main/java/org/apache/syncope/core/services/RoleServiceImpl.java * /syncope/branches/1_1_X/core/src/main/java/org/apache/syncope/core/services/UserServiceImpl.java * /syncope/branches/1_1_X/core/src/test/java/org/apache/syncope/core/rest/UserTestITCase.java > UserService#update and RoleService#update require entity id to be specified > twice > - > > Key: SYNCOPE-426 > URL: https://issues.apache.org/jira/browse/SYNCOPE-426 > Project: Syncope > Issue Type: Bug >Affects Versions: 1.1.4 >Reporter: Francesco Chicchiriccò >Assignee: Francesco Chicchiriccò >Priority: Minor > Labels: rest > Fix For: 1.1.5, 1.2.0 > > > As recently reported in mailing list [1], updating an user requires to pass > its id both as path parameter and embedded in the provided UserMod. > While having both parameters (id and UserMod) seems to be unavoidable to > adhere to REST best practices, it would be quite easy to allow an empty id in > UserMod. > Same applies to role update and RoleMod. > [1] http://markmail.org/message/zgh27isscw3hvwfx -- This message was sent by Atlassian JIRA (v6.1#6144)
