[GitHub] incubator-taverna-mobile pull request #87: Added WorkflowPresenter Test

2018-06-17 Thread sagar15795
Github user sagar15795 commented on a diff in the pull request:


https://github.com/apache/incubator-taverna-mobile/pull/87#discussion_r195927973
  
--- Diff: app/src/main/res/values/strings.xml ---
@@ -166,6 +166,7 @@ limitations under the License.
 Enter valid email
 Enter valid password
 Failed to fetch 
Workflow
+No workflows avialable
--- End diff --

check it by page no if `pageNumber==0` then show this otherwise show what 
have I suggested to you.


---


[GitHub] incubator-taverna-mobile pull request #87: Added WorkflowPresenter Test

2018-06-17 Thread Hiteshgautam01
Github user Hiteshgautam01 commented on a diff in the pull request:


https://github.com/apache/incubator-taverna-mobile/pull/87#discussion_r195927632
  
--- Diff: app/src/main/res/values/strings.xml ---
@@ -166,6 +166,7 @@ limitations under the License.
 Enter valid email
 Enter valid password
 Failed to fetch 
Workflow
+No workflows avialable
--- End diff --

I am using this when there is no workflow is created by any user on 
myExperiment. Then this is for empty workflows.


---


[GitHub] incubator-taverna-mobile pull request #87: Added WorkflowPresenter Test

2018-06-17 Thread sagar15795
Github user sagar15795 commented on a diff in the pull request:


https://github.com/apache/incubator-taverna-mobile/pull/87#discussion_r195927188
  
--- Diff: app/src/main/res/values/strings.xml ---
@@ -166,6 +166,7 @@ limitations under the License.
 Enter valid email
 Enter valid password
 Failed to fetch 
Workflow
+No workflows avialable
--- End diff --

make it `More workflows not available`


---


[GitHub] incubator-taverna-mobile pull request #87: Added WorkflowPresenter Test

2018-06-17 Thread Hiteshgautam01
GitHub user Hiteshgautam01 opened a pull request:

https://github.com/apache/incubator-taverna-mobile/pull/87

Added WorkflowPresenter Test

Please make sure these boxes are checked before submitting your pull 
request - thanks!

- [ ] Apply the `AndroidStyle.xml` style template to your code in Android 
Studio.

- [ ] Run the checks with `./gradlew check` to make sure you didn't break 
anything

- [ ] If you have multiple commits please combine them into one commit by 
squashing them.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Hiteshgautam01/incubator-taverna-mobile Test_1

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-taverna-mobile/pull/87.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #87


commit deff7b1f84f43bb99dd51658f15f8660f32a7000
Author: Hitesh Gautam 
Date:   2018-06-17T11:47:14Z

Added WorkflowPresenter Test




---