[GitHub] incubator-taverna-mobile pull request #54: Adds password visibility toggle f...

2018-02-15 Thread saketkumar95
GitHub user saketkumar95 opened a pull request:

https://github.com/apache/incubator-taverna-mobile/pull/54

Adds password visibility toggle feature to login screen password editText

Just started with some UI improvements. 
Added toggle Password on login screen for password field.

@sagar15795 Please Review. :) 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/saketkumar95/incubator-taverna-mobile toggle

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-taverna-mobile/pull/54.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #54


commit 1c0094d0ff1c447e2d5c9fb8680d8813dc897594
Author: saketkumar95 
Date:   2018-02-15T22:52:45Z

Adds password visibility toggle feature to login screen password editText




---


[GitHub] incubator-taverna-mobile pull request #64: Improved LoginScreen UI

2018-02-28 Thread saketkumar95
GitHub user saketkumar95 opened a pull request:

https://github.com/apache/incubator-taverna-mobile/pull/64

Improved LoginScreen UI

Please make sure these boxes are checked before submitting your pull 
request - thanks!

- [x] Apply the `AndroidStyle.xml` style template to your code in Android 
Studio.

- [x] Run the checks with `./gradlew check` to make sure you didn't break 
anything

- [x] If you have multiple commits please combine them into one commit by 
squashing them.
https://user-images.githubusercontent.com/21558765/36791900-fec439e8-1cbe-11e8-845e-54f9c08a84d5.png";>
@sagar15795 Please review this. :) 

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/saketkumar95/incubator-taverna-mobile UI

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-taverna-mobile/pull/64.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #64


commit 0c768655edb9e1b44dca6cd7680ab8ddc8ecb9c4
Author: saketkumar95 
Date:   2018-02-28T14:25:56Z

Improved LoginScreen UI




---


[GitHub] incubator-taverna-mobile pull request #65: Fix: Replace usage dialogue box w...

2018-03-01 Thread saketkumar95
Github user saketkumar95 commented on a diff in the pull request:


https://github.com/apache/incubator-taverna-mobile/pull/65#discussion_r171493890
  
--- Diff: 
app/src/main/java/org/apache/taverna/mobile/ui/usage/UsageActivity.java ---
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.taverna.mobile.ui.usage;
+
+import android.support.v7.app.ActionBar;
+import android.support.v7.app.AppCompatActivity;
+import android.os.Bundle;
+import android.support.v7.widget.Toolbar;
+import android.view.MenuItem;
+
+import org.apache.taverna.mobile.R;
+
+import butterknife.BindView;
+import butterknife.ButterKnife;
+
+public class UsageActivity extends AppCompatActivity {
+
+@BindView(R.id.toolbar)
+Toolbar mToolbar;
+
+@Override
+protected void onCreate(Bundle savedInstanceState) {
+super.onCreate(savedInstanceState);
+setContentView(R.layout.activity_usage2);
--- End diff --

@Hiteshgautam01 layout name should be `activity_usage` only. Why usage2? 


---


[GitHub] incubator-taverna-mobile pull request #65: Fix: Replace usage dialogue box w...

2018-03-01 Thread saketkumar95
Github user saketkumar95 commented on a diff in the pull request:


https://github.com/apache/incubator-taverna-mobile/pull/65#discussion_r171501140
  
--- Diff: 
app/src/main/java/org/apache/taverna/mobile/ui/DashboardActivity.java ---
@@ -163,10 +163,8 @@ public boolean onNavigationItemSelected(MenuItem 
menuItem) {
 
 case R.id.nav_usage:
 
-dialog.setCanceledOnTouchOutside(true);
-
dialog.setTitle(getString(R.string.title_nav_usage));
-
dialog.setContentView(R.layout.usage_layout);
-dialog.show();
+Intent i = new 
Intent(DashboardActivity.this, UsageActivity.class);
--- End diff --

use `intent` instead of `i`


---


[GitHub] incubator-taverna-mobile pull request #65: Fix: Replace usage dialogue box w...

2018-03-01 Thread saketkumar95
Github user saketkumar95 commented on a diff in the pull request:


https://github.com/apache/incubator-taverna-mobile/pull/65#discussion_r171501902
  
--- Diff: app/src/main/res/layout/activity_usage.xml ---
@@ -0,0 +1,179 @@
+
+
+http://schemas.android.com/apk/res/android";
+android:layout_width="match_parent"
+android:layout_height="match_parent"
+android:orientation="vertical">
+
+

[GitHub] incubator-taverna-mobile pull request #66: Adds tutorial screens on first st...

2018-03-01 Thread saketkumar95
GitHub user saketkumar95 opened a pull request:

https://github.com/apache/incubator-taverna-mobile/pull/66

Adds tutorial screens on first start of the app

This PR adds tutorial screens on first start of the app.

- [x] Apply the `AndroidStyle.xml` style template to your code in Android 
Studio.

- [x] Run the checks with `./gradlew check` to make sure you didn't break 
anything

- [x] If you have multiple commits please combine them into one commit by 
squashing them.

Here is the screenshots of all the slides.
https://user-images.githubusercontent.com/21558765/36878077-5433d300-1de3-11e8-80ae-0ae7e379a483.png";>
https://user-images.githubusercontent.com/21558765/36878079-54b405a2-1de3-11e8-9a0f-7501ba45da7f.png";>
https://user-images.githubusercontent.com/21558765/36878080-54e790c0-1de3-11e8-926c-9eff65f92432.png";>
https://user-images.githubusercontent.com/21558765/36878081-551c676e-1de3-11e8-960a-12beaa19001c.png";>


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/saketkumar95/incubator-taverna-mobile 
tutorials

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-taverna-mobile/pull/66.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #66


commit e8e62cd9ccbcef29efff8597db551a23f4cfddd0
Author: saketkumar95 
Date:   2018-03-01T08:28:10Z

Adds tutorial screens on first start of the app




---


[GitHub] incubator-taverna-mobile pull request #65: Fix: Replace usage dialogue box w...

2018-03-01 Thread saketkumar95
Github user saketkumar95 commented on a diff in the pull request:


https://github.com/apache/incubator-taverna-mobile/pull/65#discussion_r171752317
  
--- Diff: 
app/src/main/java/org/apache/taverna/mobile/ui/DashboardActivity.java ---
@@ -163,10 +163,8 @@ public boolean onNavigationItemSelected(MenuItem 
menuItem) {
 
 case R.id.nav_usage:
 
-dialog.setCanceledOnTouchOutside(true);
-
dialog.setTitle(getString(R.string.title_nav_usage));
-
dialog.setContentView(R.layout.usage_layout);
-dialog.show();
+Intent intent = new 
Intent(DashboardActivity.this, UsageActivity.class);
--- End diff --

@Hiteshgautam01 Checkstyle rule is failing here.


---


[GitHub] incubator-taverna-mobile pull request #68: Improved ImageZoom screen

2018-03-02 Thread saketkumar95
GitHub user saketkumar95 opened a pull request:

https://github.com/apache/incubator-taverna-mobile/pull/68

Improved ImageZoom screen

This PR improves the ImageZoom Screen. 

- [x] Apply the `AndroidStyle.xml` style template to your code in Android 
Studio.

- [x] Run the checks with `./gradlew check` to make sure you didn't break 
anything

- [x] If you have multiple commits please combine them into one commit by 
squashing them.

Here is the screenshot after changes : 

![screenshot_1520060327](https://user-images.githubusercontent.com/21558765/36931563-7bf9d28a-1ede-11e8-9529-32d6a778af22.png)

@sagar15795 Please review! :)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/saketkumar95/incubator-taverna-mobile 
imageZoom

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-taverna-mobile/pull/68.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #68


commit d8a6a1d0aa5ba5cbe8430f0b8e373529186a6504
Author: saketkumar95 
Date:   2018-03-03T06:56:36Z

Improved ImageZoom screen




---


[GitHub] incubator-taverna-mobile pull request #69: Improvements in Login Screen UI

2018-03-09 Thread saketkumar95
Github user saketkumar95 commented on a diff in the pull request:


https://github.com/apache/incubator-taverna-mobile/pull/69#discussion_r173614607
  
--- Diff: app/src/main/res/layout/fragment_login.xml ---
@@ -32,8 +32,8 @@
 
 

[GitHub] incubator-taverna-mobile pull request #66: Adds tutorial screens on first st...

2018-03-10 Thread saketkumar95
Github user saketkumar95 commented on a diff in the pull request:


https://github.com/apache/incubator-taverna-mobile/pull/66#discussion_r173622525
  
--- Diff: 
app/src/main/java/org/apache/taverna/mobile/ui/tutorial/TutorialActivity.java 
---
@@ -0,0 +1,204 @@
+package org.apache.taverna.mobile.ui.tutorial;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import android.content.Context;
+import android.content.Intent;
+import android.os.Build;
+import android.os.Bundle;
+import android.support.v4.view.PagerAdapter;
+import android.support.v4.view.ViewPager;
+import android.support.v7.app.AppCompatActivity;
+import android.text.Html;
+import android.view.LayoutInflater;
+import android.view.View;
+import android.view.ViewGroup;
+import android.widget.Button;
+import android.widget.LinearLayout;
+import android.widget.TextView;
+
+import org.apache.taverna.mobile.R;
+import org.apache.taverna.mobile.data.local.PreferencesHelper;
+import org.apache.taverna.mobile.ui.FlashScreenActivity;
+
+import butterknife.BindView;
+import butterknife.ButterKnife;
+import butterknife.OnClick;
+
+
+public class TutorialActivity extends AppCompatActivity {
+
+@BindView(R.id.view_pager)
+ViewPager viewPager;
+
+@BindView(R.id.layoutDots)
+LinearLayout dotsLayout;
+
+@BindView(R.id.btn_skip)
+Button bSkip;
+
+@BindView(R.id.btn_next)
+Button bNext;
+
+
+ViewPagerAdapter viewPagerAdapter;
+TextView[] dots;
+int[] layouts;
+PreferencesHelper preferencesHelper;
+
+@Override
+protected void onCreate(Bundle savedInstanceState) {
+super.onCreate(savedInstanceState);
+preferencesHelper = new PreferencesHelper(this);
+if (!preferencesHelper.isFirstTimeLaunch()) {
+launchFlashScreen();
+finish();
+}
+
+setContentView(R.layout.activity_tutorial);
+
+ButterKnife.bind(this);
+
+
+if (Build.VERSION.SDK_INT >= 21) {
+getWindow().getDecorView()
+
.setSystemUiVisibility(View.SYSTEM_UI_FLAG_LAYOUT_STABLE
+| View.SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN);
+}
+
+layouts = new int[]{
+R.layout.tutorial_slide1,
+R.layout.tutorial_slide2,
+R.layout.tutorial_slide3,
+R.layout.tutorial_slide4};
+
+addBottomDots(0);
+
+viewPagerAdapter = new ViewPagerAdapter();
+viewPager.setAdapter(viewPagerAdapter);
+viewPager.addOnPageChangeListener(viewPagerPageChangeListener);
+
+}
+
+@OnClick(R.id.btn_skip)
+public void skipClick(View v) {
+launchFlashScreen();
+}
+
+@OnClick(R.id.btn_next)
+public void nextClick(View v) {
+int current = getItem(+1);
+if (current < layouts.length) {
+viewPager.setCurrentItem(current);
+} else {
+launchFlashScreen();
+}
+}
+
+public void addBottomDots(int currentPage) {
+dots = new TextView[layouts.length];
+
+int[] colorsActive = 
getResources().getIntArray(R.array.array_dot_active);
+int[] colorsInactive = 
getResources().getIntArray(R.array.array_dot_inactive);
+
+dotsLayout.removeAllViews();
+for (int i = 0; i < dots.length; i++) {
+dots[i] = new TextView(this);
+dots[i].setText(Html.fromHtml("•"));
+dots[i].setTextSize(35);
+dots[i].setTextColor(colorsInactive[currentPage]);
+dotsLayout.addView(dots[i]);
+}
+
+if (dots.length > 0)
+dots[currentP

[GitHub] incubator-taverna-mobile pull request #66: Adds tutorial screens on first st...

2018-03-10 Thread saketkumar95
Github user saketkumar95 commented on a diff in the pull request:


https://github.com/apache/incubator-taverna-mobile/pull/66#discussion_r173622568
  
--- Diff: 
app/src/main/java/org/apache/taverna/mobile/ui/tutorial/TutorialActivity.java 
---
@@ -0,0 +1,204 @@
+package org.apache.taverna.mobile.ui.tutorial;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import android.content.Context;
+import android.content.Intent;
+import android.os.Build;
+import android.os.Bundle;
+import android.support.v4.view.PagerAdapter;
+import android.support.v4.view.ViewPager;
+import android.support.v7.app.AppCompatActivity;
+import android.text.Html;
+import android.view.LayoutInflater;
+import android.view.View;
+import android.view.ViewGroup;
+import android.widget.Button;
+import android.widget.LinearLayout;
+import android.widget.TextView;
+
+import org.apache.taverna.mobile.R;
+import org.apache.taverna.mobile.data.local.PreferencesHelper;
+import org.apache.taverna.mobile.ui.FlashScreenActivity;
+
+import butterknife.BindView;
+import butterknife.ButterKnife;
+import butterknife.OnClick;
+
+
+public class TutorialActivity extends AppCompatActivity {
+
+@BindView(R.id.view_pager)
+ViewPager viewPager;
+
+@BindView(R.id.layoutDots)
+LinearLayout dotsLayout;
+
+@BindView(R.id.btn_skip)
+Button bSkip;
+
+@BindView(R.id.btn_next)
+Button bNext;
+
+
+ViewPagerAdapter viewPagerAdapter;
+TextView[] dots;
+int[] layouts;
+PreferencesHelper preferencesHelper;
+
+@Override
+protected void onCreate(Bundle savedInstanceState) {
+super.onCreate(savedInstanceState);
+preferencesHelper = new PreferencesHelper(this);
+if (!preferencesHelper.isFirstTimeLaunch()) {
+launchFlashScreen();
+finish();
+}
+
+setContentView(R.layout.activity_tutorial);
+
+ButterKnife.bind(this);
+
+
+if (Build.VERSION.SDK_INT >= 21) {
+getWindow().getDecorView()
+
.setSystemUiVisibility(View.SYSTEM_UI_FLAG_LAYOUT_STABLE
+| View.SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN);
+}
+
+layouts = new int[]{
+R.layout.tutorial_slide1,
+R.layout.tutorial_slide2,
+R.layout.tutorial_slide3,
+R.layout.tutorial_slide4};
+
+addBottomDots(0);
+
+viewPagerAdapter = new ViewPagerAdapter();
+viewPager.setAdapter(viewPagerAdapter);
+viewPager.addOnPageChangeListener(viewPagerPageChangeListener);
+
+}
+
+@OnClick(R.id.btn_skip)
+public void skipClick(View v) {
+launchFlashScreen();
+}
+
+@OnClick(R.id.btn_next)
+public void nextClick(View v) {
+int current = getItem(+1);
+if (current < layouts.length) {
+viewPager.setCurrentItem(current);
+} else {
+launchFlashScreen();
+}
+}
+
+public void addBottomDots(int currentPage) {
+dots = new TextView[layouts.length];
+
+int[] colorsActive = 
getResources().getIntArray(R.array.array_dot_active);
+int[] colorsInactive = 
getResources().getIntArray(R.array.array_dot_inactive);
+
+dotsLayout.removeAllViews();
+for (int i = 0; i < dots.length; i++) {
+dots[i] = new TextView(this);
+dots[i].setText(Html.fromHtml("•"));
+dots[i].setTextSize(35);
+dots[i].setTextColor(colorsInactive[currentPage]);
+dotsLayout.addView(dots[i]);
+}
+
+if (dots.length > 0)
+dots[currentP

[GitHub] incubator-taverna-mobile pull request #66: Adds tutorial screens on first st...

2018-03-11 Thread saketkumar95
Github user saketkumar95 commented on a diff in the pull request:


https://github.com/apache/incubator-taverna-mobile/pull/66#discussion_r173668552
  
--- Diff: 
app/src/main/java/org/apache/taverna/mobile/ui/tutorial/TutorialActivity.java 
---
@@ -0,0 +1,200 @@
+package org.apache.taverna.mobile.ui.tutorial;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import android.content.Context;
+import android.content.Intent;
+import android.os.Build;
+import android.os.Bundle;
+import android.support.annotation.NonNull;
+import android.support.v4.view.PagerAdapter;
+import android.support.v4.view.ViewPager;
+import android.support.v7.app.AppCompatActivity;
+import android.text.Html;
+import android.view.LayoutInflater;
+import android.view.View;
+import android.view.ViewGroup;
+import android.widget.Button;
+import android.widget.LinearLayout;
+import android.widget.TextView;
+
+import org.apache.taverna.mobile.R;
+import org.apache.taverna.mobile.data.local.PreferencesHelper;
+import org.apache.taverna.mobile.ui.FlashScreenActivity;
+
+import butterknife.BindView;
+import butterknife.ButterKnife;
+import butterknife.OnClick;
+
+
+public class TutorialActivity extends AppCompatActivity implements 
ViewPager.OnPageChangeListener {
+
+@BindView(R.id.slide_pager)
+ViewPager slidePager;
+
+@BindView(R.id.layoutDots)
+LinearLayout dotsLayout;
+
+@BindView(R.id.btn_skip)
+Button bSkip;
+
+@BindView(R.id.btn_next)
+Button bNext;
+
+int[] layouts;
+private PreferencesHelper preferencesHelper;
+
+@Override
+protected void onCreate(Bundle savedInstanceState) {
+super.onCreate(savedInstanceState);
+preferencesHelper = new PreferencesHelper(this);
+if (!preferencesHelper.isFirstTimeLaunch()) {
+launchFlashScreen();
+finish();
+}
+
+setContentView(R.layout.activity_tutorial);
+
+ButterKnife.bind(this);
+
+
+if (Build.VERSION.SDK_INT >= 21) {
+getWindow().getDecorView()
+
.setSystemUiVisibility(View.SYSTEM_UI_FLAG_LAYOUT_STABLE
+| View.SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN);
+}
+
+layouts = new int[]{
+R.layout.tutorial_slide1,
+R.layout.tutorial_slide2,
+R.layout.tutorial_slide3,
+R.layout.tutorial_slide4};
+
+addBottomDots(0);
+
+TutorialSliderAdapter tutorialSliderAdapter = new 
TutorialSliderAdapter();
+slidePager.setAdapter(tutorialSliderAdapter);
+slidePager.addOnPageChangeListener(this);
+
+}
+
+@OnClick(R.id.btn_skip)
+public void skipClick(View v) {
+launchFlashScreen();
+}
+
+@OnClick(R.id.btn_next)
+public void nextClick(View v) {
+int current = getItem(+1);
+if (current < layouts.length) {
+slidePager.setCurrentItem(current);
+} else {
+launchFlashScreen();
+}
+}
+
+public void addBottomDots(int currentPage) {
+TextView[] dots = new TextView[layouts.length];
+
+int[] colorsActive = 
getResources().getIntArray(R.array.array_dot_active);
+int[] colorsInactive = 
getResources().getIntArray(R.array.array_dot_inactive);
+
+dotsLayout.removeAllViews();
+for (int i = 0; i < dots.length; i++) {
+dots[i] = new TextView(this);
+dots[i].setText(Html.fromHtml("•"));
+dots[i].setTextSize(35);
+dots[i].setTextColor(colorsInactive[currentPage]);
+dotsLayout.addView(dots[i]);
+}
+
+if (dots.length > 0)
+

[GitHub] incubator-taverna-mobile pull request #66: Adds tutorial screens on first st...

2018-03-11 Thread saketkumar95
Github user saketkumar95 commented on a diff in the pull request:


https://github.com/apache/incubator-taverna-mobile/pull/66#discussion_r173668561
  
--- Diff: app/src/main/AndroidManifest.xml ---
@@ -19,63 +19,67 @@ See the License for the specific language governing 
permissions and
 limitations under the License.
 -->
 http://schemas.android.com/apk/res/android";
-  package="org.apache.taverna.mobile">
--- End diff --

Done! 👍 


---


[GitHub] incubator-taverna-mobile pull request #66: Adds tutorial screens on first st...

2018-03-12 Thread saketkumar95
Github user saketkumar95 commented on a diff in the pull request:


https://github.com/apache/incubator-taverna-mobile/pull/66#discussion_r173773226
  
--- Diff: app/src/main/AndroidManifest.xml ---
@@ -37,14 +37,18 @@ limitations under the License.
 android:label="@string/app_name">
 
 
+android:name=".ui.tutorial.TutorialActivity"
--- End diff --

I have used the preference which checks if the app is first time launched 
or not.  


---


[GitHub] incubator-taverna-mobile pull request #66: Adds tutorial screens on first st...

2018-03-12 Thread saketkumar95
Github user saketkumar95 commented on a diff in the pull request:


https://github.com/apache/incubator-taverna-mobile/pull/66#discussion_r173773188
  
--- Diff: 
app/src/main/java/org/apache/taverna/mobile/ui/tutorial/TutorialActivity.java 
---
@@ -0,0 +1,161 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.taverna.mobile.ui.tutorial;
+
+import android.content.Intent;
+import android.os.Build;
+import android.os.Bundle;
+import android.support.v4.view.ViewPager;
+import android.support.v7.app.AppCompatActivity;
+import android.text.Html;
+import android.view.View;
+import android.widget.Button;
+import android.widget.LinearLayout;
+import android.widget.TextView;
+
+import org.apache.taverna.mobile.R;
+import org.apache.taverna.mobile.data.local.PreferencesHelper;
+import org.apache.taverna.mobile.ui.FlashScreenActivity;
+import org.apache.taverna.mobile.ui.adapter.TutorialSliderAdapter;
+
+import butterknife.BindView;
+import butterknife.ButterKnife;
+import butterknife.OnClick;
+
+
+public class TutorialActivity extends AppCompatActivity implements 
ViewPager.OnPageChangeListener {
+
+@BindView(R.id.slide_pager)
+ViewPager slidePager;
+
+@BindView(R.id.layoutDots)
+LinearLayout dotsLayout;
+
+@BindView(R.id.btn_skip)
+Button bSkip;
+
+@BindView(R.id.btn_next)
+Button bNext;
+
+int[] layouts;
+private PreferencesHelper preferencesHelper;
+
+@Override
+protected void onCreate(Bundle savedInstanceState) {
+super.onCreate(savedInstanceState);
+preferencesHelper = new PreferencesHelper(this);
+if (!preferencesHelper.isFirstTimeLaunch()) {
+launchFlashScreen();
--- End diff --

@sagar15795 Check this! 


---


[GitHub] incubator-taverna-mobile pull request #66: Adds tutorial screens on first st...

2018-03-12 Thread saketkumar95
Github user saketkumar95 commented on a diff in the pull request:


https://github.com/apache/incubator-taverna-mobile/pull/66#discussion_r173773510
  
--- Diff: app/src/main/AndroidManifest.xml ---
@@ -37,14 +37,18 @@ limitations under the License.
 android:label="@string/app_name">
 
 
+android:name=".ui.tutorial.TutorialActivity"
--- End diff --

I have used the preference which checks if the app is first time launched 
or not.


---


[GitHub] incubator-taverna-mobile pull request #71: Adding myExperiment logo on login...

2018-03-24 Thread saketkumar95
Github user saketkumar95 commented on a diff in the pull request:


https://github.com/apache/incubator-taverna-mobile/pull/71#discussion_r176906647
  
--- Diff: app/src/main/res/layout/fragment_login.xml ---
@@ -60,16 +60,13 @@
 android:orientation="vertical"
 android:padding="@dimen/login_layout_padding">
 
-
+android:src="@drawable/myexlogo"
--- End diff --

@Hiteshgautam01 I wonder that this image might be small on large devices 
like android tablet. Can you please do a quick check that this looks good at 
the too large or too small devices? 


---